From nobody Sat Feb 7 08:41:24 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1588757307; cv=pass; d=zohomail.com; s=zohoarc; b=Lvv7xAnjsb6c+V+p1KIuCVJNZUuMdfO9V7NSVgM1PHYXJtoopjg4eNZJcy1B6e9RLm6PRmkR4MihDGyHkbLAEqtj56yBO01y5gH7w+ZmY/lSg8BAhkmxnuI/X1noZ/xT2m+AaMvyOgGCNCATprBqMKqaKm4ZrIJ9AX86iC2IV6A= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588757307; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4stp/YPQb+H23VtW46Eqog8ZHEO8flueBqrIOysmr9c=; b=VB8ck1M4Co/0j6jFWDNm9bGXtrpp01/ah3THYyMeTdmvJMK9JoWbJCiwngbxwO5ZWuFK1OI5WJS94FdOH/AYdx1vUPXUnVeUBGm4yqI2AF5E/xGz/iBotyqhGhKcpZXBnpmD4rYjqR2a6n3ds56tY9oRjMy33hcWasBGYwh8N20= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588757307072542.5041251301974; Wed, 6 May 2020 02:28:27 -0700 (PDT) Received: from localhost ([::1]:54736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWGLp-0003Nm-RF for importer@patchew.org; Wed, 06 May 2020 05:28:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48884) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWGJP-0007hs-K1; Wed, 06 May 2020 05:25:55 -0400 Received: from mail-eopbgr20115.outbound.protection.outlook.com ([40.107.2.115]:7399 helo=EUR02-VE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWGJO-0006M8-8f; Wed, 06 May 2020 05:25:55 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AM7PR08MB5382.eurprd08.prod.outlook.com (2603:10a6:20b:108::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Wed, 6 May 2020 09:25:48 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::acfa:5:88c8:b7b9]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::acfa:5:88c8:b7b9%3]) with mapi id 15.20.2958.030; Wed, 6 May 2020 09:25:47 +0000 Received: from localhost.localdomain (185.215.60.178) by FRYP281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.26 via Frontend Transport; Wed, 6 May 2020 09:25:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RzDGZqXrZgRF+9qzALbw4x+xGDg1RQI4uIP5Vv0HCTOGDQBcL9uWDKJMr9UGC94Z8xV6YDJjKI1RfavBEp2UGEBtO+TfHWlbjY5MRoVjjkEo6R4qMKk4kQaLoXY5OwB4KyLbakqMO9cXnK6wyGsUunrOQGOgiN0s0VdurHE2YtnBq/oTujBQDft8A/KTM6vJ0Mg+aD7Aeow4+EdY+ffTRS+qIPEK2knpw7ylh0sPFVBnm724xkXsz8WU6FegXUCllcvSffwnB3E6ddjvi93LcIpGsZGg16LFrGf+vbEm+Llhw5aW4e0hVSeddbuHdBEynJ1GwNZylt6eg3F2v744mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4stp/YPQb+H23VtW46Eqog8ZHEO8flueBqrIOysmr9c=; b=NnLs+RNr4+TEPjOQxXRUqGyjB+9EBF7zC05Zz3uwwJ3Zzo7y/BpvIPgC/jmhAhD1ZwqA3yEj6uQhjTQm/WVk8C2dRCezFksYySvbNBEWd//H/QhZ52gzC4VdUJugCJHwtiq4Ucqyw6ZYSl3Nd4q1aBDcYZ2N6ugcdM3RMhNViCoO1zOLsuB2W02eraVe/V44OiO0A6JKduiqwYeQl5kovzn7Sby38zSxrXrJNfPffVFwifPhc6EOYsPlM3bVOHNfW7yWgIVOG/bumLGbxxPDBVMopTK4qZvXX0Y/uIsDKWWTT6/HCJ+nRwCoajayVkScoTTajLpgFVYJ/daZSca5tA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4stp/YPQb+H23VtW46Eqog8ZHEO8flueBqrIOysmr9c=; b=dyN2R4WVHj7YSZIgKJ4VzYftKwwiTfrLGas1UNhrVUktY0ZWbYHnzlRjUaH4mzcUSzUOnfrekWpIRcexNhS9UVYMzNIPY9LN6j2UJ5KAWcBqHVIVSNuGGPLAfoUgOaSXs8jryQ+T6F/v5XGbhk/693O9Gz6E/szHwKFvSP4m1hk= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Subject: [PATCH 1/8] block/vdi: return ZERO block-status when appropriate Date: Wed, 6 May 2020 12:25:06 +0300 Message-Id: <20200506092513.20904-2-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20200506092513.20904-1-vsementsov@virtuozzo.com> References: <20200506092513.20904-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FRYP281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::27) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Mailer: git-send-email 2.21.0 X-Originating-IP: [185.215.60.178] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4af39444-98eb-4dce-ae35-08d7f19f75e0 X-MS-TrafficTypeDiagnostic: AM7PR08MB5382: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:117; X-Forefront-PRVS: 03950F25EC X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2PByJXHvid5NjG7bA6XhLYpTe1XAJkduEFLeS5Cf3bOMfpv1Otmv/UEtRSkQADvCu3yZtU2ppQpyEmFeqDscDvW02v0GSKeur9ouTIv6FORuprVDwFGjAlIq9mc307FM2l50ydWyLonG8FDgfq8p2Xvfio3RMXu61DPay6KcQIqIC34caIgvs23rsyfe2e4U9ImLvaV7NizBYjC11b8eKLt467jjFZS8evf7rzN6r/LkZEBIG9BMyIBXsoS6yJkjQcNze4ZDvxzmkPpEmFuMOblJOJl+FpRZGm/P/kROOISvnvmqWuGfqPB+q0IQeSOz9UaC1nbw+dC0Q9Qd8BuaDwgRIltuIv7AKixMRuwQLhX4scKcUt8As1aSgQQkUBp9g73/DlZZNcKjjXocA273iEMx/Mf3ShozJwLoiQ34jS0yyKxMgAGIg+tnR7j1wmKH96BX93ih13Ho4mdGJ25tzRj7Ngof5yxnIyN6EW0N8HwUJzRqOuYjsWorenK+b8C9bk57ScOVya+uo068SSukjCRSVRbFW3fGxuWrS5z9NgkPIQaw1sJF7vCIv9f+XUGc X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(366004)(136003)(396003)(39840400004)(346002)(33430700001)(6486002)(6916009)(52116002)(956004)(2616005)(6666004)(8936002)(86362001)(26005)(107886003)(2906002)(6506007)(5660300002)(36756003)(478600001)(16526019)(7416002)(69590400007)(186003)(66946007)(66476007)(33440700001)(66556008)(4326008)(316002)(1076003)(8676002)(6512007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: fqGiKrwSbYuOItnwIhGTBTr/Fz6sc/bFq9h5I68nkqgzvrsakVEOFaz7uBNUDg2fahwSOc9ns92S8zyS7JPSFFz2R4B37Kd0Twu0NrfDG54rjKWfa+5rEIi8ynz7NPzlnRr9nNuv6Ar+V5D/gkoZuzF5Wiflu2BZOo/VwvUQlMvx5Gzp55vFrMVW7DPCrA0WrA/WoOYEeErzRzFHeYKWfa161F16AWC/u0ZPX4H/T95ntEP5RxLDEoXfF4XnjLiULFEe4crLXSln9E0aXOjACGJQ0kbFPUaUSp1JqQ7OdVLQBiBWoc8BjJJz/bK4vE6UzffHfKdcyOVJ2hNA2PQ2G7awDX/7/lnbgHZl0ndhLQ/o22CJCfR+a8YbTIV8kRVCFcSbxE9soHew88i43Kl2mJYLnPXodtJ9YeTypym3qmZ04jEkko38fiLQS5sqjSHjds4EBAOuMQSI77wXbfdBI1F/LArelLbxP/tEAYl9kM7Pb3T8B/0nF57h3yw9MNCqX08VTF0EtIYHLfECSVzH+ojaSvKY/WExDEzKaYXmKafTNgqA/OI4cWuxU5VvZTf5HlTejiZYYF8F7+RioUlS9uPNGZaZ4pHXtYhP7yPd1YdjjFkpsmw4C7xxsS+QaJmvGKMi9dSxai7h422VyReEXHZOL3wgbRq1ovxQUhXeyeNcnRZZXD2EqN0H2yQGh2GgMCKBqrJl4sjyzzDQL4Qz24lLB7B+3WqbjQVeQnTp2xVGLk3+uiplSQSaPssxBX8LLtmsx5kdPmg4BYjhtvqwmGxHvzUSDhnhSO5bqS/5teA= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4af39444-98eb-4dce-ae35-08d7f19f75e0 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2020 09:25:47.7042 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wncI5Bxz98fKwiVmIgUk1zW/SL33UoJsx5iil+ADlccwneW1wlVqGj06muIQhKg0D++FE6WGFESwJGUzTwkVWABoIaH0WgiEXBJt3q6NZJw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5382 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.2.115; envelope-from=vsementsov@virtuozzo.com; helo=EUR02-VE1-obe.outbound.protection.outlook.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/06 05:25:49 X-ACL-Warn: Detected OS = Windows NT kernel [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, kwolf@redhat.com, vsementsov@virtuozzo.com, stefanha@redhat.com, codyprime@gmail.com, sw@weilnetz.de, pl@kamp.de, qemu-devel@nongnu.org, mreitz@redhat.com, ronniesahlberg@gmail.com, den@openvz.org, pbonzini@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) Content-Type: text/plain; charset="utf-8" In case of !VDI_IS_ALLOCATED[], we do zero out the corresponding chunk of qiov. So, this should be reported as ZERO. After block-status update, it never reports 0, so setting unallocated_blocks_are_zero doesn't make sense. Drop it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/vdi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/vdi.c b/block/vdi.c index 0c7835ae70..83471528d2 100644 --- a/block/vdi.c +++ b/block/vdi.c @@ -334,7 +334,6 @@ static int vdi_get_info(BlockDriverState *bs, BlockDriv= erInfo *bdi) logout("\n"); bdi->cluster_size =3D s->block_size; bdi->vm_state_offset =3D 0; - bdi->unallocated_blocks_are_zero =3D true; return 0; } =20 @@ -536,7 +535,7 @@ static int coroutine_fn vdi_co_block_status(BlockDriver= State *bs, *pnum =3D MIN(s->block_size - index_in_block, bytes); result =3D VDI_IS_ALLOCATED(bmap_entry); if (!result) { - return 0; + return BDRV_BLOCK_ZERO; } =20 *map =3D s->header.offset_data + (uint64_t)bmap_entry * s->block_size + --=20 2.21.0 From nobody Sat Feb 7 08:41:24 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1588757226; cv=pass; d=zohomail.com; s=zohoarc; b=h5QgEHJ4/MdPP+dIMxKePNS7Xmp+zWqEGcqFDX8tvMQZHrwWGjcOfck5NBLhYcqqSZKNJltKQ0aTMgm3hc3YIgktmoqR+PBOY1dYh3IiDnfwpKtgvGsX9N8U00I4JSkSmu3ImhXbkFTFePARzZt35R6BweBEUv3FnpHw0ZlGWGo= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588757226; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3EpN70uMkgp/rhYbPjxKOA+xhVvYDR7cUp0ikthvy/0=; b=WeQGbOz5oDoD3PQWJV9lfJpqyppwqKrYEFta08Q9QHeLSdseW54C11KyAY3ov36QUioI4zc2gb/xBAX1jsk1hvgWZIJr/2i0iU4BJjsQg49a51y4LUKxwxDawU9+cOSR7sjsU+QBHcxnOCZwOKpWSe93nkIFXdSRVJLUMGuH4tw= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588757226556332.00534056216; Wed, 6 May 2020 02:27:06 -0700 (PDT) Received: from localhost ([::1]:49128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWGKX-00017L-7Q for importer@patchew.org; Wed, 06 May 2020 05:27:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48904) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWGJR-0007kX-5L; Wed, 06 May 2020 05:25:57 -0400 Received: from mail-eopbgr20115.outbound.protection.outlook.com ([40.107.2.115]:7399 helo=EUR02-VE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWGJQ-0006M8-7K; Wed, 06 May 2020 05:25:56 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AM7PR08MB5382.eurprd08.prod.outlook.com (2603:10a6:20b:108::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Wed, 6 May 2020 09:25:49 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::acfa:5:88c8:b7b9]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::acfa:5:88c8:b7b9%3]) with mapi id 15.20.2958.030; Wed, 6 May 2020 09:25:49 +0000 Received: from localhost.localdomain (185.215.60.178) by FRYP281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.26 via Frontend Transport; Wed, 6 May 2020 09:25:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ECIvf7GR3UqA+XpMTN/cLis7GDTmC44g3mp1z3CpImOYxrIKWzxLBU84JExCaz8FYwV9+PqeuqoAC9uNn0acWi/qzX3Pbz0Ri7P4v5Q3nj1mETPsgVf1fT67rkC6o493nHAFHGj66XNNltVKe0e0PITbF7JbnBxlC2JELsF+jEG7FF00U8j4tEZgRkz/wocp/iAHISPIGALmnnI/ZH7WFMvq6paG053xHCn42Zna10LELM0RRlYv9xjfMXL2NIobn4TdcAvSi6PXLnyWFE2QcaOjitpov/Z9HsG/OV8gDHDtDVv3cSbQDuhrybp9rRl6w5cwbLsCVqK7XoNqtPWqMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3EpN70uMkgp/rhYbPjxKOA+xhVvYDR7cUp0ikthvy/0=; b=S0WE0RF4uNOX4MBlQQYqmi2fcTYo4q5JjdVFNPOP0bkHlJ3Jmjy04SLQAEXB8dgn9mI400tItFFqnir8zrlbQy2Lwd57HUxSy3AvJ7tgx/8Th+fORxakg6CCXqi+klP4RJNjq1FCNVB0dGpFUoM7H7ehxW7eGweJe2ULKnqq+kqCW3fek+dC5+l2SpcdJGbBvnHGVPlJyZNK+5qR2DB8DGUc1+8CjVT8LJTezYNCo74P9KmsoR5CtZt7R5xgMa3oAmC0RqrvKI31qJI2ZVTm2DqZNanWeA1M3AfZpxFK5D8cnb3Kc6RsQ3k3+gDecO7F71Gpr8ox0sUVF2Br4B8Ztg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3EpN70uMkgp/rhYbPjxKOA+xhVvYDR7cUp0ikthvy/0=; b=Bqw/q8OZSUjVOubeeEiwDGO4V6fzx98REFCbL+HtPOHdKoqj4drlwV36+EofabRzGdaQJGEJLE2uHIBIKa9Yq0YqLAt4dXNVRwbbVLrnQcbpnBCqaqpj2xP+jv0ux3mEkfGRmT5behCz+6/MZnur5VmVgLrl9JI4Xz5WbQcG75g= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Subject: [PATCH 2/8] block/vpc: return ZERO block-status when appropriate Date: Wed, 6 May 2020 12:25:07 +0300 Message-Id: <20200506092513.20904-3-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20200506092513.20904-1-vsementsov@virtuozzo.com> References: <20200506092513.20904-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FRYP281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::27) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Mailer: git-send-email 2.21.0 X-Originating-IP: [185.215.60.178] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2428ceca-b341-46dc-890c-08d7f19f766b X-MS-TrafficTypeDiagnostic: AM7PR08MB5382: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3968; X-Forefront-PRVS: 03950F25EC X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Fc6nJm9agt8tDwe2lLHZru7oBUkOdyVBWhI6bwbSRkTy+LpoNvAY2J8AL6eqkHyO2ALDBmZZ0tNMMLxFHKPnHbxbWFz4S61xe0Ap1Zp9hDYQJJ4wPzap9JaGnl8L4DPYQwyVNHJU5owMgLO5V+e/3Ohmr8lDPmf6G+ZoJcjdpccClIT5GUVkWIh789S6vrkytq20w323HUnffq5IOtSdwVMTGrrCfGoSjczL+6TUpH4JNo9X2FF27yhF6oTxs75sZ2FEgpRIVL0ZfJKl17ilY35NqYZYKBE/J8Ol0Af/oJRxam5ELXAyjfqqHe091X6xb2afM5fzNrD4O4KhMhsOYmXfXVqUFXgx9gAzH5VxH8l73O7kRV7OmGxQhs69P8xRvsqw9WHErEpgYJQl9h9A1pNXVB3VV3Gyg5f2XIxfng5OGKlsNQwgjGxy9iyvWyC6RL+2oxfJJ1Wr6F3J3ZAO6zSJRT9x0epmVyElAHikOA5qvzrIDRiXtrf0UihvuJt65Nz8ZrpcCuL+pqpGVi8/UFxgdXHrZkFyVwii0dN5FMzxboKqjDdlicW3lT0Ve+S4 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(366004)(136003)(396003)(39840400004)(346002)(33430700001)(6486002)(6916009)(52116002)(956004)(2616005)(6666004)(8936002)(86362001)(26005)(107886003)(2906002)(6506007)(5660300002)(36756003)(478600001)(16526019)(7416002)(69590400007)(186003)(66946007)(66476007)(33440700001)(66556008)(4326008)(4744005)(316002)(1076003)(8676002)(6512007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: ZDF+M/GSjfP3C6PLf4CYDNMOPWaeIpelYr+jP2gSmjSq5KfifYOE+7N/mH3LpVj+tkAb0zLpwKNBaNIzY1iYCT9ZhYw5fQQKuzPazqwwL2t0BOM7WdGo4NhrGY2GYuOcrL/DhaS8+w9dLzhM4loUxnBYCuBaJOWtISKKTdyyu80K1sIA+CdIF71a2hO/D//ScKcc+AsvuSc/79PVo2b2Q8uHcfwy2qEMd5O3D4tpXuW9EmVJT11qiMghLoVswuLlJjCvgZ+PrRmqHuM6MiaMKNKwU3wahOQPLburpffSvITjeBeux8zt2JXBq2rqZER7R59gFh/Hf1qhPn+WdlwlvjUK9dpKGfyLUB2TsGqY0XPVsW0gD9DWDZBY3z5oTacCWiTf1G2EyuxDKBOjA+8FvGSqTin3p7n3LIBFWnZFHljIaRv1cKB/9f+KyvkstqcQ5l9GPJ6jVJ4aOARdHexi18aIMrlWIMSV697vwVsEGgkTpzF/UNvXodL2ld5opTyiDimEn9HpaP04GF6+9uAe0s1CKccpNmCJvbIBFkiA/6ZrCP8lF+W7aiA2avQJw6KyPhs2r4nCNiKpa5G6EcR269eecXoywhgOP7GPT8q189l4WlyNk/0EeaZLhnFDLMJOE/LBAUbFoanQAlqTJJAd4+LHbqRgBi0wzfrmKihv46lZR4Rjp1GHE3HKrBjMEpDOnyrqHzSJSmOwRfnzO52vQyAQkhBohBN6SWyTJProU+P3dSMtDF06ps1xbBvmirlLurMyYEfqJsWV/bhzu2ZZ1NIZTUlvEOnCp55b1X3LgNo= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2428ceca-b341-46dc-890c-08d7f19f766b X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2020 09:25:48.6132 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: o7YfbiYLjMKOdlGkS0OesNHJpjIb3tZy4toNUkYUZnLwKLhPM4E4QIgSB4E6moquCU1EmDHiUAObaWcP5SqU8EumB3iFgmqqsP/lXJIqRck= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5382 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.2.115; envelope-from=vsementsov@virtuozzo.com; helo=EUR02-VE1-obe.outbound.protection.outlook.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/06 05:25:49 X-ACL-Warn: Detected OS = Windows NT kernel [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, kwolf@redhat.com, vsementsov@virtuozzo.com, stefanha@redhat.com, codyprime@gmail.com, sw@weilnetz.de, pl@kamp.de, qemu-devel@nongnu.org, mreitz@redhat.com, ronniesahlberg@gmail.com, den@openvz.org, pbonzini@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) Content-Type: text/plain; charset="utf-8" In case when get_image_offset() returns -1, we do zero out the corresponding chunk of qiov. So, this should be reported as ZERO. After block-status update, it never reports 0, so setting unallocated_blocks_are_zero doesn't make sense. Drop it. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- block/vpc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index 2d1eade146..555f9d8587 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -606,7 +606,6 @@ static int vpc_get_info(BlockDriverState *bs, BlockDriv= erInfo *bdi) bdi->cluster_size =3D s->block_size; } =20 - bdi->unallocated_blocks_are_zero =3D true; return 0; } =20 @@ -745,7 +744,7 @@ static int coroutine_fn vpc_co_block_status(BlockDriver= State *bs, image_offset =3D get_image_offset(bs, offset, false, NULL); allocated =3D (image_offset !=3D -1); *pnum =3D 0; - ret =3D 0; + ret =3D BDRV_BLOCK_ZERO; =20 do { /* All sectors in a block are contiguous (without using the bitmap= ) */ --=20 2.21.0 From nobody Sat Feb 7 08:41:24 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1588757404; cv=pass; d=zohomail.com; s=zohoarc; b=gh0OTizGZ+RKQGkSRslQumkoI/1gVd8uojuZXwdBxhs6KwP2/h8rZd5UcLd3dTQggjBWAeFNXEaFr3fn2VWy60BPSqXcLf5VZH1hzQe2ENbD+aE6ihZc1oH1hDJccApaPt8ZnpZDIqmtO5j25DWx8vXeCoaDtjJJglPZm/nhe9Q= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588757404; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=SyMhc+tlp9KJH7/4pnAro/zM2Gj0iiVvsKyD1K0GLlU=; b=kXyxeOijMvRF9ST9XBR+2ub2QfJ/FMpeUWvaSBFcCJCP6Mgek4mricY1GI1zoFsAagU03HpRHIvfaENBe+gxcOm55hEbXmhQU9lefBtCN4Z3TPR4Rc9EF5HoVTxEupzJ3bqaQAqulCCiwKlwa2hkyYeHT9n2Qp0GiCjzK0fVITo= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158875740407292.90880842204399; Wed, 6 May 2020 02:30:04 -0700 (PDT) Received: from localhost ([::1]:60296 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWGNO-0005hQ-QR for importer@patchew.org; Wed, 06 May 2020 05:30:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWGJS-0007nr-Hf; Wed, 06 May 2020 05:25:58 -0400 Received: from mail-eopbgr20115.outbound.protection.outlook.com ([40.107.2.115]:7399 helo=EUR02-VE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWGJR-0006M8-NR; Wed, 06 May 2020 05:25:58 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AM7PR08MB5382.eurprd08.prod.outlook.com (2603:10a6:20b:108::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Wed, 6 May 2020 09:25:50 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::acfa:5:88c8:b7b9]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::acfa:5:88c8:b7b9%3]) with mapi id 15.20.2958.030; Wed, 6 May 2020 09:25:50 +0000 Received: from localhost.localdomain (185.215.60.178) by FRYP281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.26 via Frontend Transport; Wed, 6 May 2020 09:25:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XdTeAEn9euWBgsVBCSBeNPhFsDKfUB+LGgN4oftOSJRAb/+eqBlQSybMr321ajm0pGn1AqFV+ouhl7Bfp+01bM/iGSXMFUiIqyMnv5ANtUr/kLMPyOamgr1uelAzhLxICu/1s0GfLiPJfWZEyzIChzVdYxzZLaYN3GoxIevbWUnw8teATPLfJtUhh3j5gJdPiZm8xNpgqywjCEAkFvg0BQr5s9LUzUPNt0fuTFTLTamnWF4xpSY70lM9cNtMhhX/i4CmeBDQV6BjA4XdvE9ieGRbFCzNPKnZN5QRnHYY1AHYMU5RpTYE6AFWK9wfcVPkVOJbFEhrsZ8MbHfO3kMtyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SyMhc+tlp9KJH7/4pnAro/zM2Gj0iiVvsKyD1K0GLlU=; b=h9YeJ4nJoRV9kgpj7/4Os37Y7FboNdmy1e03nvWtfjERwGWN9MtOxd9dXMdbKW4DbhNipYVwb2oKQhHYKsFr8wtvA2EvP4FN1+62lugQlPeq3iGTbzEeNRcEcO+jSP8AqFa0j/PSo4isO97TZ/kdKTLggw32tqk7cg3l7j0s7pdqlPKAFfa2sqZ9RViekmTDQqlP0Hb1Z2q+2M5GV7d+eyzo8xUcM77PmrXGEI16uLYpZ0TbTo+FuNkmYmosqFcwKUfp8sMcOJjWpMXo8DxG5mkQUT2Ikpckm0EjnI/BH9BqGQ4Ep1muUPKxcjxbT7f7WLPQQT8RnHhffivX5id7oQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SyMhc+tlp9KJH7/4pnAro/zM2Gj0iiVvsKyD1K0GLlU=; b=E+TdlsAGCNRYPpv/duKFzs1ontm+L9tx/rMrF/pFIc66Fv12EA3VOA3MeAucx5rjrQPuTBFIiQ37t25/baV1kxQz4H0T5ItaUWz51/zJG4W1pEXUjCP4f9Xo1CBGcZt6DwB9OR13wGFx2d4qA+hy7jptOJBjEDbPMRVP1kCLGwo= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Subject: [PATCH 3/8] block/crypto: drop unallocated_blocks_are_zero Date: Wed, 6 May 2020 12:25:08 +0300 Message-Id: <20200506092513.20904-4-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20200506092513.20904-1-vsementsov@virtuozzo.com> References: <20200506092513.20904-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FRYP281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::27) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Mailer: git-send-email 2.21.0 X-Originating-IP: [185.215.60.178] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: da912479-72e3-433d-b81a-08d7f19f76f4 X-MS-TrafficTypeDiagnostic: AM7PR08MB5382: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:632; X-Forefront-PRVS: 03950F25EC X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fMCJlo7AgEfrOPenwG3v0tcb2oBw/bq4akmKaBTV1oNjUQncPEEFmLypD++QiXCG+N2iGZGq16sHPWMfbvJLkKYyd9KSbvX6QdbTesXp53g7xMA9o3y1Yxa3DXPZ1H0YAqSED+GJbk8IDcYJEAEw0qBe/DjGDHIKulfVSwVd11x6XruP+K0y2dAUZ1/y/TqKcvUEPjrBFa4TMj2t5Q/jcLx0va75GNirfD9H0YKZ4oo+Y58z1AjfFSnLe4GoxLsVlB6B1UQUjCmBt/j1QrZLlH7o59bVlXsokbMmboQf7D5nSyM48Orv+h8JE2FFNujVDtzm/YUN6kbks35tHCxpVo+Gw6h6Iy+vYQw1nl/NT0d4AcsiSvKPk9hQj4AFJRGyWLo6HeGG7VvtHr9QgMjTQXiZzXjM5JhblAnSx98eu7prTwKSOC+Z/ajNKhD/lFd8fOncZ6pa0nwn4kjGfNnnqpoSYtfYA3Z96+7WZOmmOW03SQe9wnwhsMze3MUi444bVlYu6Ox9Aad7tK24sOmWqDIl2s7GZnon/HqNEuXW479bU3VR1HSkiTwqDkeDaBjb X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(366004)(136003)(396003)(39840400004)(346002)(33430700001)(6486002)(6916009)(52116002)(956004)(2616005)(6666004)(8936002)(86362001)(26005)(107886003)(2906002)(6506007)(5660300002)(36756003)(478600001)(16526019)(7416002)(69590400007)(186003)(66946007)(66476007)(33440700001)(66556008)(4326008)(4744005)(316002)(1076003)(8676002)(6512007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: 3KIQ34l7lBXZ/Mr3n8JwO0gxpPZhK4O0KM5jKIp1uzXmaKipr0RVEIHd6Re55o4KMvX4tV0rdskiVVpn5nlnLt1jQbyrW5po0qXND4S6AoaWxQPKA1dIq1g1wxNZqu3yFTLJrjcBJrfLczmy1EQqn6CRXpYvbVUaeAf8FpTM4YtGyu7IiGuGX2nyrlSoxmXaFGle+ktBVXfzxHwJooayB8pQAvvBXc7TAkznILsAy0CvJ9SzMQqgeRBivc8F4GzmML8Uxw7nzixFn0L49/v6LArWsbkKB+xke/J6qQkd9AQgnjweYw9NyvVrzEkOSVsOFyUE2pDFtL548wH8+xCkXvD65KPp9efBsMuIv4OUqr/545PUYVBBqMGuB8qfIEyG9qVOuUaQF7njOkp5S5YJpNdyGcsnOnWyCCXTE7sBgQ+Vt4q9AyCDJk/3G6aWgsNi6RgAXSHu6fdmubWnbfyxFMDn9qGeLFGn1rND6fQqRQsDqgef4HcYpV0nvde9+ZzFx5HcJw8Fl//eZXypIRrYbQXIImAVVLT/TO63Jx5YI/ykiMvnAX5ohpFgoqYavvEmsqELMt2W1JgEoG1E3giHRj/Qj/WFQwLDH7qzaeMEptuYj+IQAMc0zCmMlEHmTe21j9lQufNRwmo55r+OWls2yMqeQnK3vFoKT8RSGj2nEeae/PgDqT9f244wO/w+vbqyuh6bBS8qqlkNSuwxEc3bVOGtA2kNyU4BNwM7BGzRTYdFAlPYcjiIVCKPu/1RxCrvViF+875U43SFPC/uSojv/SYS52xz/KA5fH8keZg43Io= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: da912479-72e3-433d-b81a-08d7f19f76f4 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2020 09:25:50.0270 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ouat+iKPF+bmTQYaRj2OMBzcbfmo+QL3JI39wHaE2ajCIthvDkL1l2oRVk+qSf3hUoyOV9g9l1z3qdcEGmslG5iVH1s4O7use6icfICnQ4Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5382 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.2.115; envelope-from=vsementsov@virtuozzo.com; helo=EUR02-VE1-obe.outbound.protection.outlook.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/06 05:25:49 X-ACL-Warn: Detected OS = Windows NT kernel [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, kwolf@redhat.com, vsementsov@virtuozzo.com, stefanha@redhat.com, codyprime@gmail.com, sw@weilnetz.de, pl@kamp.de, qemu-devel@nongnu.org, mreitz@redhat.com, ronniesahlberg@gmail.com, den@openvz.org, pbonzini@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) Content-Type: text/plain; charset="utf-8" It's false by default, no needs to set it. We are going to drop this variable at all, so drop it now here, it doesn't hurt. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- block/crypto.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/crypto.c b/block/crypto.c index e02f343590..7685e61844 100644 --- a/block/crypto.c +++ b/block/crypto.c @@ -694,7 +694,6 @@ static int block_crypto_get_info_luks(BlockDriverState = *bs, return ret; } =20 - bdi->unallocated_blocks_are_zero =3D false; bdi->cluster_size =3D subbdi.cluster_size; =20 return 0; --=20 2.21.0 From nobody Sat Feb 7 08:41:24 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1588757321; cv=pass; d=zohomail.com; s=zohoarc; b=bdTcUchqe41yQv4YXoJ90VgL+WNruCK+6jJpy3oQqy/VHbHAo31jHkmAqYuYmceKBBFHU3Wov6EYOtuFwMmkEwyXHL1CvqxB0QqFmXhGGX6ogkg1awh0BAA+GuEjns4o7DR/nBJwT7siDgdKTxCkkBZrEHigT1RalZqeEWqxUx8= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588757321; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=UhwpC8Q4GWHznTsW8gfNCsFiPmsjmwh67BhMgluksDA=; b=hvOTRjN5zWOq3oByvholh0QkiOuQ2a0wiHmhH9Iqz7M01sJUsXep+/y6OYTacFSDlFFtr5lVT5lk+0i+PTWvlZUKcy4dvByKH7wF3JOQmv3pliH6asnWNIcwvfaHFdUv6JfBKG7kW2ylqA2mrxps9HgPPn++NGLXTDf50Ts2zH8= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588757321336728.7175974491571; Wed, 6 May 2020 02:28:41 -0700 (PDT) Received: from localhost ([::1]:55644 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWGM4-0003kX-3y for importer@patchew.org; Wed, 06 May 2020 05:28:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48942) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWGJU-0007sJ-2U; Wed, 06 May 2020 05:26:00 -0400 Received: from mail-eopbgr20115.outbound.protection.outlook.com ([40.107.2.115]:7399 helo=EUR02-VE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWGJT-0006M8-52; Wed, 06 May 2020 05:25:59 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AM7PR08MB5382.eurprd08.prod.outlook.com (2603:10a6:20b:108::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Wed, 6 May 2020 09:25:51 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::acfa:5:88c8:b7b9]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::acfa:5:88c8:b7b9%3]) with mapi id 15.20.2958.030; Wed, 6 May 2020 09:25:51 +0000 Received: from localhost.localdomain (185.215.60.178) by FRYP281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.26 via Frontend Transport; Wed, 6 May 2020 09:25:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TS34xdh6r98S+zWpYwym2m8QrI3uJKxysaE320IJA40R72sOfiQ5kw5TPIch+bExJ2pCfkSfeEB3yxTYn6HjYSYz1wcItvjMwOOmDJesTdrNeJXKKq5RT3jZRIbCXAdTTqERUI/aPOiZX8ENE0JBkwUQn1uZBc3qLRjZ6KdoJfXHFPD6qhHxSdbqoncU0spemZ3C4nKiZ2Aacq1zDDND5k3jPq6/Kn9VBQaMvaOFe8meu1JOYM6rpkvq+UzKsZZQGGfVyUGjU84nmiRrlxIMMCer8NfLQ3SsCewz2LL604Q8fmP++KjAgMN4gQ0JnI6jBkMeEgCuezlRG6i4a8fmHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UhwpC8Q4GWHznTsW8gfNCsFiPmsjmwh67BhMgluksDA=; b=ZTFD+gxP/ycTK/Sg1s9g+hGZTV5JxAJaXFZYdM96AIz2p35MhUHp6BbMptYJQpPn9bb1NTnUe/XytZHChNRUUCAbAbj2rm9BgKUZIsuUunKabiwgVrrF6+oeTQOGuvh+IbnPLB3Z9ZKtgaXKBQSPZVCJe5NHo+nTR7FUr0apbOJwHb1Mq2DCoh+YFwC5zznKpFW+B1w6Y4/qzkiVvPfpo1k6vjgaCkhFnHtbAk1fdomyajlKhjyvb+B//f0BzQ69YzsquWHyUudTt+ae0niorFawaoCmw+6nBHylCBSuU57W/ee8v8upwEdm87u3y232DCwEWcqtThSkmoY+Olql8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UhwpC8Q4GWHznTsW8gfNCsFiPmsjmwh67BhMgluksDA=; b=uNBsaVeH77s4OoB2NwvNuRj6NEDoMXxk2NoxR4GACLw8jQ5ykeeZfrGMemyVYqpqrQcgy7245q9rKH8NBX9/WxMa9BjMKFcAgakrcbQ9gY3l8Dom7r4o2Uxd+/QsjdnJx5Z1Qkk610q+LTSplr/yp7pgMqMIefoRyYo9AJUSqCM= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Subject: [PATCH 4/8] block/iscsi: drop unallocated_blocks_are_zero Date: Wed, 6 May 2020 12:25:09 +0300 Message-Id: <20200506092513.20904-5-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20200506092513.20904-1-vsementsov@virtuozzo.com> References: <20200506092513.20904-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FRYP281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::27) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Mailer: git-send-email 2.21.0 X-Originating-IP: [185.215.60.178] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 34b7a7be-9f14-49ff-f0fd-08d7f19f77db X-MS-TrafficTypeDiagnostic: AM7PR08MB5382: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:262; X-Forefront-PRVS: 03950F25EC X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M9uv+C/hxoBjoOWDk0Aqn/I/mJ8UtYyTk3eXJNowbAKb6tOzVPETJTxSlAt9xUQc2bG0Dnk8zcHR/hNKfr1j1ODt2tjS9DfeqvzwCsBipAqQrlCwL/p+ax1nU2VzgNS1Mx9sqik6UOgXnfQn64Q11xCbAIGiqZw2lscdZOz/I5v9/BZ4oGxF7jFKaYJ7hnZ385CAP19BOzil6w4tEPgkgFDqp/Lvw2umVOooi6+1QBKiRglq+oviXqiPzIqbWE/OZzKhuv4iDbk4Nc3jV3k1/fYPx4gaxHTylfzA4EM9cqhejBSNeS6u3DOX1MzwtcSCIRJwBx87rRQkujgjGWzvPsh2NAAzH8dHhFuKKBm9de8IvxhLBXczqGNp+Lmy2B9cZfnvtkk0Qy3H6FxytFcC4hoInJiM8onCjTgEkCJ/8AON+Ir4nwGnKEfpghTuRpNzUUHbFPZe1rUXyPs1deqr1Jj6DMxFUBZDW0UmH+0I/Nt+HhIYTCsIGUSbHI2wA8V2hsQXtuXUUzO4pND0WE0zSdOEsxJQPxpGpwINF2FsgJfrgRpntIXFIMxWpAFbByKn X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(366004)(136003)(396003)(39840400004)(346002)(33430700001)(6486002)(6916009)(52116002)(956004)(2616005)(6666004)(8936002)(86362001)(26005)(107886003)(2906002)(6506007)(5660300002)(36756003)(478600001)(16526019)(7416002)(69590400007)(186003)(66946007)(66476007)(33440700001)(66556008)(4326008)(4744005)(316002)(1076003)(8676002)(6512007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: KDGJiKbHyjYm5y/LRTaASqVeKv31jKMxfzPBolVdwyCJc42wFeNBiR0E8MdnMIBdQ0N4jKeMB4/iwzdzmVX80fa65paz1guwuJ77PMTY3QmaeoOOE7Vgu73gPpsEDijnldahXmfiRJyUbsO8HAo/cHF8DCrZT0LC49/oLZ6UVT1jPKQ0Xx/Tg8ASrDgvslLluOaZpha/f+ymptiJn3XCXj4CaphIP6JPFNtM8+/FY9GewFt0Um4EKlvCskSE8ci6NXM73U8EHmKxGoRQInbNgBkLoZjyB7iWgGaItP828Z0RsQG9mTEpP99R3SIs7DwdNyJgvmwCc240A4R1GQ9D19Fq0MQOX/qXhJrb9iLdXCckaYrXR40HsHKkRMYdLmANAsxD7JYlyhFPXNwPgTrVOP+9MVL7Y3sKwR+/5VNQXnrRqjPDSJ9MNapyY7E98sZODz86tI6N7e4Opas0DaZqcj8YCOxKoZ27mE+ECT4YHYrmDwLHy54f2IuK+SxCfk57f/CUevEz5rVHlRD9XIZlSoItgwDmZeVMvz2cjPFErlP52U2CswbP3Ozl78emmsamCUp8Q4OHoVHOLlhCdREhvNGASAzhl07bb6K2Zwlyfj0MBdMREDd+/zi0sorXOM9gmfNtRjLoHwsyzoWybawiicOq0pPnHMiNu3WT9CYIl64CjnMQApTt+1k/2W6fIz5MaCYG+Cc1lO/pjTJuJLtp2aM3DIfDE8R3j1/EMUOYWXF/wV0RxlRcw32u37kpg/+MJLwz0EBHLKlFDW/FFGCRsN4Jn1ACZkCcMI+0iDPK08Y= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34b7a7be-9f14-49ff-f0fd-08d7f19f77db X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2020 09:25:51.0336 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SqGzsvmsTI6heQdCtyC1FIC5aQQEz5hjns2G7UwpUBiBav0PXQe1I5PpvjKXedXW+j4Bp8Sg6Uz/33J9zRSkOYG62W5Tm7CLy3dXzx6s65A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5382 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.2.115; envelope-from=vsementsov@virtuozzo.com; helo=EUR02-VE1-obe.outbound.protection.outlook.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/06 05:25:49 X-ACL-Warn: Detected OS = Windows NT kernel [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, kwolf@redhat.com, vsementsov@virtuozzo.com, stefanha@redhat.com, codyprime@gmail.com, sw@weilnetz.de, pl@kamp.de, qemu-devel@nongnu.org, mreitz@redhat.com, ronniesahlberg@gmail.com, den@openvz.org, pbonzini@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) Content-Type: text/plain; charset="utf-8" We set bdi->unallocated_blocks_are_zero =3D iscsilun->lbprz, but iscsi_co_block_status doesn't return 0 in case of iscsilun->lbprz, it returns ZERO when appropriate. So actually unallocated_blocks_are_zero is useless. Drop it now. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- block/iscsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index a8b76979d8..767e3e75fd 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -2163,7 +2163,6 @@ static int coroutine_fn iscsi_co_truncate(BlockDriver= State *bs, int64_t offset, static int iscsi_get_info(BlockDriverState *bs, BlockDriverInfo *bdi) { IscsiLun *iscsilun =3D bs->opaque; - bdi->unallocated_blocks_are_zero =3D iscsilun->lbprz; bdi->cluster_size =3D iscsilun->cluster_size; return 0; } --=20 2.21.0 From nobody Sat Feb 7 08:41:24 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1588757254; cv=pass; d=zohomail.com; s=zohoarc; b=WrMo4mfHXZmx9zMMt+LTrnsKz1E93AEPQBpsCX1iPmThmIWDJ5e3ilxM02mgKmqTLJxK2g585D2qkHgVD1ouSHfJ8wQMzKTkIm8/8FzrKAMkpNU4RDCJu65Nxl8wO8MkISvdI9HFPq4UZKxDuumIUApl4k+CHt/YK8fKaUl1M+8= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588757254; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Qd8IHOGIPLUQSjIyBtnjHX/hsBMDt6lUuP3Mm3kWzt4=; b=h71pj3SGPxWUHbzhxF7Wrbt+ndlJQ8d6QvJjKRcs4wLdWiDaBxYYhEt+X6AxO9Hl0kyngMGJzVxUhzMqRoLkLsSTd1EK3b/mRol/6rga46SmV2dSGQjaQc91bbyskPaSF0oQF8iRl1qv8QEil7UesvElTGnrV27YWhd97dmTDbE= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588757254154701.1213548908211; Wed, 6 May 2020 02:27:34 -0700 (PDT) Received: from localhost ([::1]:51164 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWGKy-0001vt-S7 for importer@patchew.org; Wed, 06 May 2020 05:27:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48964) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWGJV-0007wJ-Di; Wed, 06 May 2020 05:26:01 -0400 Received: from mail-eopbgr20115.outbound.protection.outlook.com ([40.107.2.115]:7399 helo=EUR02-VE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWGJU-0006M8-KH; Wed, 06 May 2020 05:26:01 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AM7PR08MB5382.eurprd08.prod.outlook.com (2603:10a6:20b:108::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Wed, 6 May 2020 09:25:52 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::acfa:5:88c8:b7b9]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::acfa:5:88c8:b7b9%3]) with mapi id 15.20.2958.030; Wed, 6 May 2020 09:25:52 +0000 Received: from localhost.localdomain (185.215.60.178) by FRYP281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.26 via Frontend Transport; Wed, 6 May 2020 09:25:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kmkq3XLD5iZCUVTi/8h8HG7BF5mbR7lmtJPq137K5xvUYvBXheCabOJd2cHqaB++THVUu99F92D06HLafk2sGyZ8Jaua/7ApJQaLEOfB2Bk3rkt9H0Ag4WmZLreuehc2Vab9j/cuuwsvyUZdxEGS0R4RzLgyIZUkc3Z3qnl8mbbLNWEXFM7EfL4Z24j/Pti6Zai7vu5WCFLEMh3gw8IOI2HlF0XRmU81G6hpzlDwBHKksqMZ5w3VadJVPsNJ+r3u+M+6tRKvIBmDqZbpPbwrKcGSM85jypxKgWjeHCpC72PPb6mAWcsXubIzNNJeDahBg4qJxnZ5WN70HefF7oHSbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qd8IHOGIPLUQSjIyBtnjHX/hsBMDt6lUuP3Mm3kWzt4=; b=IEWGVcdDIesr7SlmGzdZ7N0uqXOs7W7l7nEOECDztma4FlNy/kp5MSs7tbOQZ9BMNW4cUoueRh8VofpKLDlSB2xL1HYBWQ1OzPuFhXUjP4la+ySzrUD7/RCaNmDS5nIlvytTzDchKC/DivOa+s4aGflcQ8+VGuCZnxBCkai1G3DpZwGih4O0SCIusNy/YqhTO9JTYC2+OXciskfzUPOE2fIGbEy9xXzv7lAcpuhkSEZhlgKbXqmIQAVjWbcyZu/wFgegyoxzF9JcHKnlKwFV+Zy9h8/kqS0jpGvDMDfQeMTLos8ycnrByzHk81J7El53zPCMI6CSuYr1K0w2PGgwyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qd8IHOGIPLUQSjIyBtnjHX/hsBMDt6lUuP3Mm3kWzt4=; b=vel/Kzk6YJWchVWIoT3Ku5OKrk4UsMG5brcuvmQX2GKtWBi81EgwgodVASQHpcbX1B5PhYEQPrLfo7nl10woBUb1JKw5zpuOpNQ8Ew9v8oEjXd4saDan8XybNMXAI/2rIgcsSI3zHigM81o6IL/6XtFJzUPO0H4nSAt77sffxoY= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Subject: [PATCH 5/8] block/file-posix: drop unallocated_blocks_are_zero Date: Wed, 6 May 2020 12:25:10 +0300 Message-Id: <20200506092513.20904-6-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20200506092513.20904-1-vsementsov@virtuozzo.com> References: <20200506092513.20904-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FRYP281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::27) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Mailer: git-send-email 2.21.0 X-Originating-IP: [185.215.60.178] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2f04c9ee-09c2-4e53-e5e7-08d7f19f786a X-MS-TrafficTypeDiagnostic: AM7PR08MB5382: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:40; X-Forefront-PRVS: 03950F25EC X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hHlc8O7JMFZsjsgWEHihyMxpAQVocmZq49pH+MCw46KejgDdFZftRZr6CK15frV/FDJTQDg/peSh8ZyTmlk/FnZoI/MnnLWE8NzWi4/rlW2y6t6C0GB9Xs7W6mcLOFrlQINj4IqDuCFe5xkNROc7TQSUjbvAn/WGDDLQac4D2m6iQQrMOlUHds1bK6B0gKabhNzt47hhFuhmVHQWv8MVfAC5hkVPR9T6uKb3yfC2mhOZRgqCNnMqVUWEYZcBfo7v6DFaqjWc8DqLyd+fBZPbZDjgghNdjqKTyUvH+ymvn4k4g09p58CMIvirALo0T5qdOOXsoxKqr6hMCYzpLg20PeAjTHxln42NrW0VFM1QbVkox8EGZI/uRzIYGEJsq97RLXT/e4MV/7b8laObyCMD9/OKEYL9dHqXTO/i1CNeq/K4Ot8iVyNCWTS1E1hJYeg0nKcjRy4cdHkOwb+SI2j4KntBfpkYlSmgUQFwN7XLRltYfHnM9khA8Rq0qHExACsqMeDk3NqBIIekX0rjjDYIZjYHiv0p5tsqDsw+yx0U3Qlm+9PcvqQ9UuWaEVvpGjsl X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(366004)(136003)(396003)(39840400004)(346002)(33430700001)(6486002)(6916009)(52116002)(956004)(2616005)(6666004)(8936002)(86362001)(26005)(107886003)(2906002)(6506007)(5660300002)(36756003)(478600001)(16526019)(7416002)(69590400007)(186003)(66946007)(66476007)(33440700001)(66556008)(4326008)(4744005)(316002)(1076003)(8676002)(6512007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: aYJumq/lTqh3G6Z1bw2hN7ONYkfRHXNfvNpqrxTssW5rra19ksCmLWTgsgNE5oWNaCf5JPDlxofjMzIlEcNNj17OR/AL5lARNp2+K9rdhf4oUEf2gn/QmP2CAHuEsdjcCgKSsIaEverefcqIm86qrb0UNLEnQUTEXWAA9htb70ttPUJ+Q2XA7puS/BO2WiWxCYK3+2ZNxRaO+kR2b1aCfgI6VtzrU4PAVVvOxoxsLyxa0Ene/X1VkoWW09lSD83dOIQ0LBWR2MDDZg0cNl9ps/Igk7mtB3KFGxQdEYT6QQ/LBN4Ag8CONxsQVTi3LczuSK299uN7bvqnbKQ34Xcn3z1mtAia6XAzl2IGQgbij4JmdVSR/PR7W9pI6iuyVzuhaSERDrsqS5AmdzRm76hQBbqXPNxB9vuZadURHU4tNltgLWXda1vB9cF65JVqUIsIwQNfTfVCERGS5vu1d7giCX6ZEZ00CyYAeQzZfrxYJ1DBssG9BuGrjsvxoUmUa8yV1Aa3WSebu77edVQTnlu4SX7ndYsJ4/XoqBOJ2+oCEadI7dugt0vjr6GkMZ4Qwgeg3LUnlCah2/meXBFNng0DXAcA8p9TAAVJa4WfjOrbUo/MIAh9n1cOat4XO4hGJNyzPABqTo9MdnhHANHWrc1h/MKfFhD8T6BD+1c0/E8vmUuBtYtWAZT1rbOuZxLtx9wNTJo+IoxYcEij6ZVXFhFfUJoeuvRYhIL0bE07FAimxiuVXJ7HsQREhzK4n0cgrmmf6VUYPXzdiJIwI60/1DlRWfUftqBhaB87ObfTbljxRV8= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f04c9ee-09c2-4e53-e5e7-08d7f19f786a X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2020 09:25:52.2960 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PXyYuuj5/kYuJ3CSulUPm6oX2QGLto8Ag4U2kDL1eZmZrCkI4FJ/VkzoL92MVzTsavAuP12O2R60X22RMe1j4pBumyDOhMAZOJ10e03GFl8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5382 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.2.115; envelope-from=vsementsov@virtuozzo.com; helo=EUR02-VE1-obe.outbound.protection.outlook.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/06 05:25:49 X-ACL-Warn: Detected OS = Windows NT kernel [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, kwolf@redhat.com, vsementsov@virtuozzo.com, stefanha@redhat.com, codyprime@gmail.com, sw@weilnetz.de, pl@kamp.de, qemu-devel@nongnu.org, mreitz@redhat.com, ronniesahlberg@gmail.com, den@openvz.org, pbonzini@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) Content-Type: text/plain; charset="utf-8" raw_co_block_status() in block/file-posix.c never returns 0, so unallocated_blocks_are_zero is useless. Drop it. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- block/file-posix.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/block/file-posix.c b/block/file-posix.c index 05e094be29..5c01735108 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -2878,9 +2878,6 @@ static int coroutine_fn raw_co_pwrite_zeroes( =20 static int raw_get_info(BlockDriverState *bs, BlockDriverInfo *bdi) { - BDRVRawState *s =3D bs->opaque; - - bdi->unallocated_blocks_are_zero =3D s->discard_zeroes; return 0; } =20 --=20 2.21.0 From nobody Sat Feb 7 08:41:24 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1588757500; cv=pass; d=zohomail.com; s=zohoarc; b=RZOrWkXyKlJISknHfClc2L4v1uv4HIlc8vxvGAfOUaeNOLv75QaZMUCegrzBkI+UlAG+3RtQZxPdUA2XgeRFsKHWj4w/TS4OM8BeCtY4aS59M9QriWpDehe9OXsdYtZ63IsjBg8YVoUfeeOEWdyaATE5OOsi6loMu/OzkBv36VM= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588757500; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=FSXnq5YEH64tq5COWIKr4xJUGg7k87XezzJ1KazDrUU=; b=ZfEyQvmZE08BBKoptP0e8T2oFG6POG/q8R3K6bGthBs6gQyO+fHtAr/g0zRKjE8c8U9Cv2675FonbGGJ3iLZ9LNaAflXYmENkZif0swpB/LdnNtEnVCRLET4F+Sw4NtF7/Vtu59QmAESfnVLDzsYoOjNA4AIKrfZxsUnRSQih0Y= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588757500373273.62197602547405; Wed, 6 May 2020 02:31:40 -0700 (PDT) Received: from localhost ([::1]:36470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWGOx-0007ax-3m for importer@patchew.org; Wed, 06 May 2020 05:31:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48986) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWGJW-00080F-UR; Wed, 06 May 2020 05:26:02 -0400 Received: from mail-eopbgr20115.outbound.protection.outlook.com ([40.107.2.115]:7399 helo=EUR02-VE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWGJW-0006M8-11; Wed, 06 May 2020 05:26:02 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AM7PR08MB5382.eurprd08.prod.outlook.com (2603:10a6:20b:108::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Wed, 6 May 2020 09:25:53 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::acfa:5:88c8:b7b9]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::acfa:5:88c8:b7b9%3]) with mapi id 15.20.2958.030; Wed, 6 May 2020 09:25:53 +0000 Received: from localhost.localdomain (185.215.60.178) by FRYP281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.26 via Frontend Transport; Wed, 6 May 2020 09:25:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ULpASXb7FQTgwEdHUdW2IjunVgH3e2CP4u8qwEtJ/Xbs3/liasCaja6wyfnEeQG08WWlp93nEfL5Kou4G5/dNwSBhbHL8YH8ye7BrDVsXFj4vjcvBpiplXGCN/jlDKMwgGtnN+cWC0mmS2GZeKvi/y3jaI8HjrbQeahvkyYB5F7DeVNUvT7/vuD6dH/Cj4zFBfomRAZL+uiD1CAEyTq+Pm9UIeVrcAYUgSbrhOScElgIJb+hJeP4jSC4oncuNU3XlqJFvcP31MWwmJQzLgdYiyttX8WkOGA1J6+ftsX5HNOP5E2e3wPOQjAhyBUtDMuqdsQVc6YdVxLgr8bCU9KKeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FSXnq5YEH64tq5COWIKr4xJUGg7k87XezzJ1KazDrUU=; b=Bgl+5oClLqerNFO/2BKAtVFFsTYHpaKpgpwAoYbyiPqBng1FXXl4fu0W3r7MYZDsiwycAl3fQAWVb6Id1b66UlejaDUwl8TooZOCEPRirhSavsRIdV5vrhkQAAY+SFyuHJpzaV4BZ/5xW1ObKD87SFPmhlKfCsEKiDQ92GtM0i27S+LoIP0mc/qIBaKS/7dEibE4rsEdAzJ/ExkX6ttMxhQbT38pJdRKjQb0Vo8x5Au3KlYHeIjOPsUjnLBDE7cvcZZ8f//tECW4IhLkSOnCmyX74NZDp2QW0Wd+gtP5PBEnXMxc2gqKev8P8xnwo10hamx04amk11UmXd9Xck5NLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FSXnq5YEH64tq5COWIKr4xJUGg7k87XezzJ1KazDrUU=; b=oLGG3S3X6ei7Qioj1/ZbWv9r4gkwDVuL9l+FHRljATfY0CySeKIzYdOGPkVffmMxQ4B/l8XzVsqTHjUEk7JZ7PVu7Zh0ucz9OnZSGQlBtxGpUMBoHVexT4yrHQJWGH703mUkDT+M/1XtdhFc/xN2OrA2OHGqor5xs4t1FsJOaW0= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Subject: [PATCH 6/8] block/vhdx: drop unallocated_blocks_are_zero Date: Wed, 6 May 2020 12:25:11 +0300 Message-Id: <20200506092513.20904-7-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20200506092513.20904-1-vsementsov@virtuozzo.com> References: <20200506092513.20904-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FRYP281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::27) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Mailer: git-send-email 2.21.0 X-Originating-IP: [185.215.60.178] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 473f1a49-1d98-4505-4466-08d7f19f792e X-MS-TrafficTypeDiagnostic: AM7PR08MB5382: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:47; X-Forefront-PRVS: 03950F25EC X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ssURfNn61NawZ3UpHafDnDWto4ShKQsWF1iSR3Uincf8hSJeSTvAbJuE6uKjCq1AZEr/XM/v2HfgoDsXVViiUv4lNweaaI2Wj4vb3ScEF2isIUP1MrARaULZNbcm70EWWvkfkISDqYGInUTRdTZ222UFnrUanEAAbI9nvQPrDlVkqqx4PtBMkVOiXyT/VNI0CyVoTNqltFi8AjNowMoZRF4Q1XsS0XpHn/5c/Rhi4U4S/cgbl83s1V8EFSBhyJNKwYi6dCc5OwksaH5g+g0yUm8KjLZsqD8NQh9UaEkDsKHTPlQt4uhOd6KsC8J0lGX5NzMwJ9M+b/i00rpMvQjQEJ+xQX6y3ZYzEdB8tlqjasgMv9SyGo+nqPqxwIFCDFK5tvogSg/oe98R9zo1+ObvsdRamaxUJtdWW6yf0E2GRblw/kHr7+UI7Ob7qZtdoAMTRMddraMmMa6OxyByGrLnCzdUYlgGbrT4+DWrCCnjflr3yjRYKoqqOLx1b2bxt8+QWrtBz7YJlVkuhT7KGBBrZMGaYCJF20CHZDUePDZXMpTXcJM1zuFNo5m9Lt0Q+tHl X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(366004)(136003)(396003)(39840400004)(346002)(33430700001)(6486002)(6916009)(52116002)(956004)(2616005)(6666004)(8936002)(86362001)(26005)(107886003)(2906002)(6506007)(5660300002)(36756003)(478600001)(16526019)(7416002)(69590400007)(186003)(66946007)(66476007)(33440700001)(66556008)(4326008)(4744005)(316002)(1076003)(8676002)(6512007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: UCdlRn8ED1bwklAa99lhcqLId33jJPQ27DSo/HR8HjV/G8CqWuAy3Qx5cnk8u1zJ2wcAI6Mlovbyhjvq/M8nlR5GQPyBtdGYjUc6lontGnj9eNtxus8uitQLZke9gZXAX0lMB+ZwfXswVWckrfKShWeQI3o58GLlGfVvqA5FnszKFl3y3dDKFmJ8LPcOc8gSwnX9jSBnKssyFZvKrhWFJBC5bA8tFjemfDtnVLw8RUy44n70etWni1NTsTau/7rHtlValxHHCWth4/U4S2qgGlrcP2l0y9yjDP18wxXfoRtq5Emuxs0jcboC1/w1B0k4DlQHNQMkkdlM9TyDqjGb1NEFBmbW8dNz3IjnoJsavEoAHrd9tww9/pwyovTwc9qKQUFmO4wJuxcggFtqrMYzJZBKgNwJcks5Pr88Jk1+5u3g0ku/C4EbOuUeGFg+MwiyEheqBY2vx0tbTRTkAKrda5Cti/Lc6AsjEyfSkV3b1yTS3lJwqZmBztkFfCGPcxK4Nutoz+0KKTrpI13qwatAe7i0bB5CbsTM/hK6FmsK+Iy8cDtdBEMPJKPGOjgzfi3kf+IBjDXf+7aOSFi9TidEk//+ec+NzNpPozeYpz/6di9fZNfTJ91nEkPsUB6hXoElGTJMd5d3QC4D5LXNG7lXNA7+uDtySzyerjtR43yikeQuaCDTIA86P0BpoUqnbVkrxiREeqIkTlboKjrx1nmwDDMyCT3SUZLxDx4TPukSprSc48vtGQa0s9CbggpL3CDYOR0gLImmtTqJ6wp8wfEk7WzXDoLlSIJD5cXmN7dXCYE= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 473f1a49-1d98-4505-4466-08d7f19f792e X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2020 09:25:53.4510 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XmiAZpQDu5Iv6y+4xwD859u8BIFUtpb9/L6NeMNEWH7p3k2oikRd1hptxfArO/URg/cQRXzvztm3nNewrJAFe/l9u7ao95YiDqb/RYDRiEc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5382 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.2.115; envelope-from=vsementsov@virtuozzo.com; helo=EUR02-VE1-obe.outbound.protection.outlook.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/06 05:25:49 X-ACL-Warn: Detected OS = Windows NT kernel [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, kwolf@redhat.com, vsementsov@virtuozzo.com, stefanha@redhat.com, codyprime@gmail.com, sw@weilnetz.de, pl@kamp.de, qemu-devel@nongnu.org, mreitz@redhat.com, ronniesahlberg@gmail.com, den@openvz.org, pbonzini@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) Content-Type: text/plain; charset="utf-8" vhdx doesn't have .bdrv_co_block_status handler, so DATA|ALLOCATED is always assumed for it. unallocated_blocks_are_zero is useless, drop it. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- block/vhdx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/block/vhdx.c b/block/vhdx.c index aedd782604..45963a3166 100644 --- a/block/vhdx.c +++ b/block/vhdx.c @@ -1164,9 +1164,6 @@ static int vhdx_get_info(BlockDriverState *bs, BlockD= riverInfo *bdi) =20 bdi->cluster_size =3D s->block_size; =20 - bdi->unallocated_blocks_are_zero =3D - (s->params.data_bits & VHDX_PARAMS_HAS_PARENT) =3D=3D 0; - return 0; } =20 --=20 2.21.0 From nobody Sat Feb 7 08:41:24 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1588757560; cv=pass; d=zohomail.com; s=zohoarc; b=mOWSAEGIcKDN/ryfooilZsVVS4sG7ZtZBvvsndkaVCEoeEF81JTsHteg5/9zSw2AwB9BYYTZkK6fx+d24CfMjbV2mC27HDOI50lZJydbOOLYgEgpQKm48X4PDS+ezpoPwtFL/+hEA2hxSPl7JZOsRmFDqcvsld/5L2nOEEW8d5o= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588757560; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=j/tYIj7mrdIsX4tg3tsG17MNhFv9OGlRKqf7KQyYDUo=; b=DYTUbrlRilRSgxPcvZPyMfOnxbeoaZ5HsY4rJgIGmILEjVV4Oy64397pwY7ozMA+blk6YZhfGcBd8aauDONLlmSyAjzt5/JchIh/hNFnOIQ0OC7EzPVDjFJBcvw09lW+JFWbVPZrOO3Gt6tUnwawjR7pdv04Uc6Fp2lECO8Z1y4= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158875756006137.00198085792408; Wed, 6 May 2020 02:32:40 -0700 (PDT) Received: from localhost ([::1]:39100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWGPu-0000Gn-ME for importer@patchew.org; Wed, 06 May 2020 05:32:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWGJY-00084I-By; Wed, 06 May 2020 05:26:04 -0400 Received: from mail-eopbgr20115.outbound.protection.outlook.com ([40.107.2.115]:7399 helo=EUR02-VE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWGJX-0006M8-FW; Wed, 06 May 2020 05:26:04 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AM7PR08MB5382.eurprd08.prod.outlook.com (2603:10a6:20b:108::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Wed, 6 May 2020 09:25:54 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::acfa:5:88c8:b7b9]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::acfa:5:88c8:b7b9%3]) with mapi id 15.20.2958.030; Wed, 6 May 2020 09:25:54 +0000 Received: from localhost.localdomain (185.215.60.178) by FRYP281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.26 via Frontend Transport; Wed, 6 May 2020 09:25:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jT6WRngp3eneJ6gGGPwJGOBzwXorQG5TpHibf4qAGLZ1v2CmJgZDvmD4MgCXPAEOAErxsaSofIi6ENOdiRZw/45/bsHdgAWBNNa5+gwdwIIGsR6Y5SOn0d51rvoYTWiVU3PNzRXNqIXfJrXZ+sIvaCTMocHaue83BERQD2M8d5eMjGX9S+FE2g2OX5k2e2+koltYiLKlvU4XWkmg+q0ftxPruhZKLbXlEH2YHI5d990ObFqYbfo8fu1jyU8eks5CzJOPVAE5qwx4sXUN/TPUCf0VchprC8w1V3Mu3BDVuWEtWLCwFWEbVy11CRn2/0C3DRNCQM7+VEvRCCWAwJ2bdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j/tYIj7mrdIsX4tg3tsG17MNhFv9OGlRKqf7KQyYDUo=; b=JDFtQFbxMtzWebWTpa8ziJEUE3PupLWo0vX1gI5+L6iyzK2DU0MEloPDRPJC9eC46eE+f1POk0DoZrlsJk3z5veUmTNpHhemOcJLyjSZakMhs8J9BsqinO0ottC2hjQerE/SnQcZZlWAD+SwrKQAmFkxQ44JihYU0mKnPYLFJ0ThcJ0YA01IiyMNEpJO4gW7mHePXgUZOMe56U5fuujTR/6TW7Bm4SR41YkB+9+J5BxIdr3DiW9UTJ45xGw8xszIHhkLJ1rhbwTdJCibyCP44kqjOX1IDHjQXykkjKvJFBf1kZCs4Ae3oC2HoqEGeOF7lz14WzZyQb771ucnAGw4wQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j/tYIj7mrdIsX4tg3tsG17MNhFv9OGlRKqf7KQyYDUo=; b=XeFYZ+I7bcYSpf27/cHDtq9IGNmM61U9yAs9EVqhwXqypGf841JmaaVaaxYrkmZX5JOfYAlkEIXn+Bei7ieJb7lUROrneg8i05JfD21zzC0i4a1oHrMX51fqjj8SL+3ropmCuWRfVAGf+rzwr44PXinuaEo7QdAKm7XZmD1RWMs= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Subject: [PATCH 7/8] qemu-img: convert: don't use unallocated_blocks_are_zero Date: Wed, 6 May 2020 12:25:12 +0300 Message-Id: <20200506092513.20904-8-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20200506092513.20904-1-vsementsov@virtuozzo.com> References: <20200506092513.20904-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FRYP281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::27) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Mailer: git-send-email 2.21.0 X-Originating-IP: [185.215.60.178] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d6ccb276-d45b-4dc8-208c-08d7f19f79dd X-MS-TrafficTypeDiagnostic: AM7PR08MB5382: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:262; X-Forefront-PRVS: 03950F25EC X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mTczkqlTnRO/3aFehiYkkHg1oc8zx+sZ5OhwcxJ5bXJpvwbSMj+HP33jXzuiKopAaEhwKVQM/NzPHk8DM0zfKH9/2eOV8E7EqHb6SUmiIG/frMLznDrrNHQmwhcdeqgsbveiYogjvQM7AzCv74JFlhtvgp7AO2H2R5qg/6VR7nRTy3t5/sKn8GMPD7M0acxyb1Z9DcvS/kLRl4behIoTSvCQG0EqRI4KTuOxJXW8GEarAY1qfp/aqHj6RR7EE9MIyh0mSM3XFfj9QQMV84Vrztr/BbAYdJeocruScR782w+ll68knpCrkOjWtuKtU6dk3zQ+2w/O+kW00GMg9LtwaizpqdUOztUzQVYamX1C7GMV/Nox/BXTLEWnhlVy95AF/ufOtfjYCd0xTjRz0bX9f65Q3Qds8VpoCcqw69RE6cxG3pC+bUYZE+E+USXHvpufKWIoZWyyI5W7xvFFAu7CFk8PS+zNVUWmZcvfm/xNh4gCm+RRofb6aL4qFS7Dle4qrEKD3NqDU/2zkw9Lkp/f/BrOhD1jDV6WqPw+0QUWxDZRF2ljK5a5mrh6sWlaATWE X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(366004)(136003)(396003)(39840400004)(346002)(33430700001)(6486002)(6916009)(52116002)(956004)(2616005)(6666004)(8936002)(86362001)(26005)(107886003)(2906002)(6506007)(5660300002)(36756003)(478600001)(16526019)(7416002)(69590400007)(186003)(66946007)(66476007)(33440700001)(66556008)(4326008)(316002)(1076003)(8676002)(6512007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: CLzkhb8/W01Atsp5/gsS8hnXRvvDGa5kHCYO/jYkRIvTCapJn+2qxZRcby4yo+a0k2ysZrZZxvDR+QC+eYu0RljHpO6UII0us9rU87G6NEmf/T2vGCIGaYHnhNjxqD/6bOMITo4XRQutp3OaVT2ovRfGS+kJyIrwzC8ssXLybbJHtCzHhTLT1BaAHmUQ5TWyAGX8Qay61rHrrK+vG9nsDSyHzvAYUsQ1K/O2TnTAku/DDb+WHHjWb2oO06Xy9wNa2qB0zne1xcAzdXLFMV5cI8NIWu2993TIPZaBz7sXVPy3j7GqXtf+IGZYOYhtE8jQrln2sibd2ta7g8doqzjtpFH82hcR+R69vynb4UvTyL+fSiEqWMyC8mgxHRyJxAbYwv/qzwl5o/LUp0tcH0AnvXduFE5jkdTXPMt1GNyTRDAiRiDuIHLK01nP4vL8s87VrWZ5Z8CDcA2P7rU9Up55pL20oG3f0OR+mtEa26+gEnZvKDLzhauIGoXYQhLcO5oPi12HNGYU4B72mntM5h/nFslHCilb4Yk/h8kjN1AL8Y/aXZ54ZSqsLP0ZZ5SD3rTjg9sbfVTb31PfsRXM/3P2h5PuuzGLOzhU+vWK/FyZaVb+QXnjeKFt7ItLeo+MzJuwA5YtnLRNvMaGrK1NfkXfWOMRJ8RT+4nQ9/rP+fg1rYHH9IhKgvWZ0sOkJAnmkplkqfr/XYmKvnEVcCPueudxbbtu4xRJF15K/Wlz9G2WCGas7GO0bJzkh4Zn/VY5G/uybziKmjgk8UJwmW8J9OWtYVXw21wUfw7II9JMA8p8V1I= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6ccb276-d45b-4dc8-208c-08d7f19f79dd X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2020 09:25:54.4884 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pYqVYoTQCH+1YRr9kkvmzs5cJqM0zo0O/ku8mj9cS34NpnOLvTb2yf24nbQQdswAya9sbwdNrEfdZoN1LdsL7CN1/x8Bsa25ZRzy1CBnK9E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5382 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.2.115; envelope-from=vsementsov@virtuozzo.com; helo=EUR02-VE1-obe.outbound.protection.outlook.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/06 05:25:49 X-ACL-Warn: Detected OS = Windows NT kernel [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, kwolf@redhat.com, vsementsov@virtuozzo.com, stefanha@redhat.com, codyprime@gmail.com, sw@weilnetz.de, pl@kamp.de, qemu-devel@nongnu.org, mreitz@redhat.com, ronniesahlberg@gmail.com, den@openvz.org, pbonzini@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) Content-Type: text/plain; charset="utf-8" qemu-img convert wants to distinguish ZERO which comes from short backing files. unallocated_blocks_are_zero field of bdi is unrelated: space after EOF is always considered to be zero anyway. So, just make post_backing_zero true in case of short backing file. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- qemu-img.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 6a4327aaba..4fe751878b 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1632,7 +1632,6 @@ typedef struct ImgConvertState { BlockBackend *target; bool has_zero_init; bool compressed; - bool unallocated_blocks_are_zero; bool target_is_new; bool target_has_backing; int64_t target_backing_sectors; /* negative if unknown */ @@ -1677,7 +1676,7 @@ static int convert_iteration_sectors(ImgConvertState = *s, int64_t sector_num) =20 if (s->target_backing_sectors >=3D 0) { if (sector_num >=3D s->target_backing_sectors) { - post_backing_zero =3D s->unallocated_blocks_are_zero; + post_backing_zero =3D true; } else if (sector_num + n > s->target_backing_sectors) { /* Split requests around target_backing_sectors (because * starting from there, zeros are handled differently) */ @@ -2580,7 +2579,6 @@ static int img_convert(int argc, char **argv) } else { s.compressed =3D s.compressed || bdi.needs_compressed_writes; s.cluster_sectors =3D bdi.cluster_size / BDRV_SECTOR_SIZE; - s.unallocated_blocks_are_zero =3D bdi.unallocated_blocks_are_zero; } =20 ret =3D convert_do_copy(&s); --=20 2.21.0 From nobody Sat Feb 7 08:41:24 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1588757421; cv=pass; d=zohomail.com; s=zohoarc; b=fegw1vYYNW3iolgck/F5wU9lLRYGR0D4ITjyV9cAHCp+qBpKxoR+rH6vyC4Z2i8u3lj85DPGgM6D01VdVJWKLBdYj/mc4YRhQc9+9JcvBcOXlAlPUS3Ez5k/nWu0DFBu55BoOCQ3zhYysKJX79mTnqWNPKxbj+VBqHwt42jVwbg= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588757421; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2CJ/zA8nPmGcJLhw0yj8M9+rqqBa0WbBpGW0h7FaeTk=; b=YJCi98aP9euBdRdZf0iAN4LQ7lcShIHh/k5ZDbTgIWXfk7U0xxFr+Ogec9YLXIZcPCUcEi1BRBM247/edLs7MC7UoIQfiMMhvseK9kKKOXsvtnOlkpjHUZl/Q5QtysuiAahgRNrXGjTcDngt6OW7ADBv7CpAKxKWO1UjkwctWW8= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158875742193583.98605694835828; Wed, 6 May 2020 02:30:21 -0700 (PDT) Received: from localhost ([::1]:33140 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWGNg-000691-GQ for importer@patchew.org; Wed, 06 May 2020 05:30:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWGJa-000892-8u; Wed, 06 May 2020 05:26:06 -0400 Received: from mail-eopbgr20115.outbound.protection.outlook.com ([40.107.2.115]:7399 helo=EUR02-VE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWGJZ-0006M8-0b; Wed, 06 May 2020 05:26:05 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AM7PR08MB5382.eurprd08.prod.outlook.com (2603:10a6:20b:108::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Wed, 6 May 2020 09:25:55 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::acfa:5:88c8:b7b9]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::acfa:5:88c8:b7b9%3]) with mapi id 15.20.2958.030; Wed, 6 May 2020 09:25:55 +0000 Received: from localhost.localdomain (185.215.60.178) by FRYP281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.26 via Frontend Transport; Wed, 6 May 2020 09:25:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=de93ioL1iD7MtlIfJ7z0GBIfhXObPHEcimW5qh5MvUG9h0mTkJ6ciJ9rAG5KV1eExlGQhwqIxUN//mL7ZFi8ZgSPT34tapkfTtzaypb3luWWNhbhdXUy3KDfFNjoRUT+PaqnSVzQws2rJif/SWuLyevYJgWqCdokaF8cKehZ66S2gkOAVOko3gxxUNhg9valVpDQwSmZYGdYXKPHdE9QRM6e1ZV11FIanlfB+3lhaiY+MRZED1oosD1M5nOqA9cc/Mx+mg78hkegsOYknSctKN6Po5ScVsTJS1SBWWZ7tyGj1+ryTaqQIITl3ug2WhyduycOpO/2/SoCvBBGgGne8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2CJ/zA8nPmGcJLhw0yj8M9+rqqBa0WbBpGW0h7FaeTk=; b=AryYtzo840xFzWrZgmH6f9NSHw84RbvShkyhGqDMLHf+lLke3FUcT7vva6msFvbjoJ12kbEA/3hVmGCju6oBBYCqxt2S+OhR4e/ECUCg3w9m40ODV0biQGyWjeC2TJM2xHaJq2qX36OZuf8QmAVkelSnp2z+28De9o1MUEMKLyeIjXwratg3z2GVGJOwQfiWeIMuE7L+U1Z4RJQLWvVxl86YYitLAeWGGdiRLFgGEHw6Pox3/oYFEurWFqiIkWYgcV/W/Rd1h1bGcE9ulelfjgsdbEMuVDDywwGv7/OvEFkzTWj1EYTMMT1uv7Y5aHJhmDYpr3DAemMaCEJKUOF+DQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2CJ/zA8nPmGcJLhw0yj8M9+rqqBa0WbBpGW0h7FaeTk=; b=IUOTh1QU1soPPjqIaHsaRvSBJdQaBkjdcYxEyKcWPgSilpVsm0DhLkmMRfPjqodK0jOUrzOnDFFO0z+xVFQsTiOdYqC/HTzUzTNc8fSKcOY+l5nerJYUE9CqmNSNdYHyLsoTM64k6pYCZmW6msHgaNWBMTK5ZIPpatoXTHSExEs= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Subject: [PATCH 8/8] block: drop unallocated_blocks_are_zero Date: Wed, 6 May 2020 12:25:13 +0300 Message-Id: <20200506092513.20904-9-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20200506092513.20904-1-vsementsov@virtuozzo.com> References: <20200506092513.20904-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FRYP281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::27) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Mailer: git-send-email 2.21.0 X-Originating-IP: [185.215.60.178] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 375643b8-3fa7-4da2-bb4b-08d7f19f7a7b X-MS-TrafficTypeDiagnostic: AM7PR08MB5382: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1227; X-Forefront-PRVS: 03950F25EC X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EHawf3pCvv8ui+5n0JWH9kXHeb6E3fLv68K2Iyf4bmRryqBKyCaNwECOsY/mU1wFIb1fssKNpU9dUisgFZOKladUq6vd10LnHac/o3Z9lzK0+MKpVRBWxqwBfGmlgSJzNjRGx9NwQSLmctcLeqomDbt+vRKof9NBrnEjBthAwaLj8u9uYhLYLAJn+QIWlqhqYeS/kAE26OHz7miZcAunzYd+M7iy6Hopx3Ifo2q7yDGyO0uS+jPJy7sxI1zZRJtlISJa1hWF7pLqDq1peKH5K90o6xBpk8tdqS+piP0egPQl1G/yJDjZc7FyzlxDQbEVg1eeCy04duKS2/I5ZgSwrht7oRtVoZl6HHD1zvajiWOae3XrAlz9c28WPuueyBZbMfbPnhDsoDKk51S9fd+4CHb+Q1DalcZ3WAeGgsREiuM6RM841MEbG1bWqhOdTbX5HgiKO1BsUP5tNzRkbA5VuNIXaPzz6cmTZqD4wJkIEzKwmqmEmZEZSO3tsQVtXiWsYizmrXPO5+S/zQw1OaEJvUjaNo4C4vpC3NNg3XDRS3NavnQxleCqi2tNuntzwjsI X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(366004)(136003)(396003)(39840400004)(346002)(33430700001)(6486002)(6916009)(52116002)(956004)(2616005)(6666004)(8936002)(86362001)(26005)(107886003)(2906002)(6506007)(5660300002)(36756003)(478600001)(16526019)(7416002)(69590400007)(186003)(66946007)(66476007)(33440700001)(66556008)(4326008)(316002)(1076003)(8676002)(6512007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: yD3H28PmdEGsg8UmJmHNcsUSJ/vSvCBTxhD5oecqTws4MQrN7K0Ylp696XaTuYQ+Wc6gFJpJk3Z899H6UiJvvy5xGwFLYXfCsbctVhRThrnsHMNm3d0wzWPZrrsWvnG5rV7MkLUCBGy8ifaJhHxyHuECMyrjJYSbeq2uSlzmHfjQntiLSxxbk5MKTV+gGuJEi9h0eE90XuOK7797SEyQL6JcL1GaLrNxFcNsIA3XU3EMycAm46AL1xa963vp1IVKAybajbfQFkzUC6sSt8SOB+yVXy1V9WmMfXLPxrut22sdJH6EHNEjp7L8wh72r7n2Bdo3Ai0BGsO+TUz/LWdDJP6s0+Bz7V0W9PVlBa4LnMnbsQjQJ1dWJdHo7p5D5wKxL8ubEABxlXkfUX/Z1Isp8FKAJcZK0wObPWoPqNArH0JEGFb1lMmubyUYcVyBa2l4opB1xtOORjlNKnrh8xetD73QCTCHOUZdzofuUQWgk1TwHyGm0XV32oTUVkF/umVwjIqsilUAVqAkIHGF/qdH1G/vV0zHwjeaiGmAfR6+/K+FQSDPaTveK1rtssXZso72LELBKMjZRX72f0WtOAybwYbv4M/JU9uOFjErpzcdLCt55/M8AhwADf1+L2oWOsNjDpR2SF0+1L/Phc00lxZ7tFnga2gMPSyA4EV6ppHWZzRMqA58HsYNbGehR+xfmr+3U/PlG+DT6vCODNFpGi/A50bt3mQEu6/S5d7rGeGB6IuOfGJY+XMTxNZs8bYlnbE8qlb3iD14bOoeW13a2TIUX94XKYTGMEMYaVdNyW1wAi8= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 375643b8-3fa7-4da2-bb4b-08d7f19f7a7b X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2020 09:25:55.4293 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7erHHS9DVNUZnOrIb162gkF0LLE4XkDdwFDjQfBYLJetXYbrxY4nI/9gIjM04+ybPrmpIsIQEBwCsMwxdJbB8QjwBhq3iSXQHr3fsXAmbAI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5382 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.2.115; envelope-from=vsementsov@virtuozzo.com; helo=EUR02-VE1-obe.outbound.protection.outlook.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/06 05:25:49 X-ACL-Warn: Detected OS = Windows NT kernel [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, kwolf@redhat.com, vsementsov@virtuozzo.com, stefanha@redhat.com, codyprime@gmail.com, sw@weilnetz.de, pl@kamp.de, qemu-devel@nongnu.org, mreitz@redhat.com, ronniesahlberg@gmail.com, den@openvz.org, pbonzini@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) Content-Type: text/plain; charset="utf-8" Currently this field only set by qed and qcow2. But in fact, all backing-supporting formats (parallels, qcow, qcow2, qed, vmdk) share this semantics: on unallocated blocks, if there is no backing file they just memset the buffer with zeroes. So, document this behavior for .supports_backing and drop .unallocated_blocks_are_zero Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block.h | 6 ------ include/block/block_int.h | 13 ++++++++++++- block.c | 15 --------------- block/io.c | 8 ++++---- block/qcow2.c | 1 - block/qed.c | 1 - 6 files changed, 16 insertions(+), 28 deletions(-) diff --git a/include/block/block.h b/include/block/block.h index 8b62429aa4..db1cb503ec 100644 --- a/include/block/block.h +++ b/include/block/block.h @@ -21,11 +21,6 @@ typedef struct BlockDriverInfo { /* offset at which the VM state can be saved (0 if not possible) */ int64_t vm_state_offset; bool is_dirty; - /* - * True if unallocated blocks read back as zeroes. This is equivalent - * to the LBPRZ flag in the SCSI logical block provisioning page. - */ - bool unallocated_blocks_are_zero; /* * True if this block driver only supports compressed writes */ @@ -431,7 +426,6 @@ int bdrv_co_pdiscard(BdrvChild *child, int64_t offset, = int64_t bytes); int bdrv_has_zero_init_1(BlockDriverState *bs); int bdrv_has_zero_init(BlockDriverState *bs); int bdrv_has_zero_init_truncate(BlockDriverState *bs); -bool bdrv_unallocated_blocks_are_zero(BlockDriverState *bs); bool bdrv_can_write_zeroes_with_unmap(BlockDriverState *bs); int bdrv_block_status(BlockDriverState *bs, int64_t offset, int64_t bytes, int64_t *pnum, int64_t *map, diff --git a/include/block/block_int.h b/include/block/block_int.h index 92335f33c7..c156b22c6b 100644 --- a/include/block/block_int.h +++ b/include/block/block_int.h @@ -115,7 +115,18 @@ struct BlockDriver { */ bool bdrv_needs_filename; =20 - /* Set if a driver can support backing files */ + /* + * Set if a driver can support backing files. This also implies the + * following semantics: + * + * - Return status 0 of .bdrv_co_block_status means that corresponding + * blocks are not allocated in this layer of backing-chain + * - For such (unallocated) blocks, read will: + * - read from backing file if there is one and big enough + * - fill buffer with zeroes if there is no backing file + * - space after EOF of the backing file considered as zero + * (corresponding part of read-buffer must be zeroed by driver) + */ bool supports_backing; =20 /* For handling image reopen for split or non-split files */ diff --git a/block.c b/block.c index cf5c19b1db..0283fdecbc 100644 --- a/block.c +++ b/block.c @@ -5305,21 +5305,6 @@ int bdrv_has_zero_init_truncate(BlockDriverState *bs) return 0; } =20 -bool bdrv_unallocated_blocks_are_zero(BlockDriverState *bs) -{ - BlockDriverInfo bdi; - - if (bs->backing) { - return false; - } - - if (bdrv_get_info(bs, &bdi) =3D=3D 0) { - return bdi.unallocated_blocks_are_zero; - } - - return false; -} - bool bdrv_can_write_zeroes_with_unmap(BlockDriverState *bs) { if (!(bs->open_flags & BDRV_O_UNMAP)) { diff --git a/block/io.c b/block/io.c index a4f9714230..484adec5a1 100644 --- a/block/io.c +++ b/block/io.c @@ -2385,16 +2385,16 @@ static int coroutine_fn bdrv_co_block_status(BlockD= riverState *bs, =20 if (ret & (BDRV_BLOCK_DATA | BDRV_BLOCK_ZERO)) { ret |=3D BDRV_BLOCK_ALLOCATED; - } else if (want_zero) { - if (bdrv_unallocated_blocks_are_zero(bs)) { - ret |=3D BDRV_BLOCK_ZERO; - } else if (bs->backing) { + } else if (want_zero && bs->drv->supports_backing) { + if (bs->backing) { BlockDriverState *bs2 =3D bs->backing->bs; int64_t size2 =3D bdrv_getlength(bs2); =20 if (size2 >=3D 0 && offset >=3D size2) { ret |=3D BDRV_BLOCK_ZERO; } + } else { + ret |=3D BDRV_BLOCK_ZERO; } } =20 diff --git a/block/qcow2.c b/block/qcow2.c index 2ba0b17c39..dc3c0aac2b 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -4858,7 +4858,6 @@ err: static int qcow2_get_info(BlockDriverState *bs, BlockDriverInfo *bdi) { BDRVQcow2State *s =3D bs->opaque; - bdi->unallocated_blocks_are_zero =3D true; bdi->cluster_size =3D s->cluster_size; bdi->vm_state_offset =3D qcow2_vm_state_offset(s); return 0; diff --git a/block/qed.c b/block/qed.c index b0fdb8f565..fb7833dc8b 100644 --- a/block/qed.c +++ b/block/qed.c @@ -1514,7 +1514,6 @@ static int bdrv_qed_get_info(BlockDriverState *bs, Bl= ockDriverInfo *bdi) memset(bdi, 0, sizeof(*bdi)); bdi->cluster_size =3D s->header.cluster_size; bdi->is_dirty =3D s->header.features & QED_F_NEED_CHECK; - bdi->unallocated_blocks_are_zero =3D true; return 0; } =20 --=20 2.21.0