From nobody Fri Nov 14 16:58:11 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1588711061; cv=none; d=zohomail.com; s=zohoarc; b=hEdyWAbgpr7/12jw7fO7yqPP+nQzBZ/0vuiuCeYx3JeCj5P2JBulMZL7nLm8IP2W729G/yRFMGFg+kl9fdgbuO4LoGFRN6FoG5BuaeDbND1Nvmn5MKL1NnaPSr9d6VvvAGxexguYDFk07Lw308l6iJBhUo0dYpLCH9Q5tS+sq+A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588711061; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=RxNggGBv0tQrTZufmX6jygLyOCLwPEbrD6z+20MWo+Q=; b=etZzQ5fvD+Tnq0QrksUVM0Ar9ptfdEWpPvvJu4cCCdNxV9OJxRQDrK0qqiP8PeyHjyRzgFxaH6sIP4ocZpPWmQJuY6XGigcc8h76n8lBekfb6AegO9f8bG53aw6Hl45E/sYJ0DLMcIIQiKlrWgthmRUPlywJoT8GBT1EFnM3qNs= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588711061513797.1985388225038; Tue, 5 May 2020 13:37:41 -0700 (PDT) Received: from localhost ([::1]:42414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jW4Jv-0006AF-Qy for importer@patchew.org; Tue, 05 May 2020 16:37:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47396) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jW4Iu-0004hV-1s; Tue, 05 May 2020 16:36:36 -0400 Received: from charlie.dont.surf ([128.199.63.193]:57580) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jW4Ir-0007q0-4r; Tue, 05 May 2020 16:36:34 -0400 Received: from apples.local (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by charlie.dont.surf (Postfix) with ESMTPSA id AD282BF9A4; Tue, 5 May 2020 20:36:30 +0000 (UTC) From: Klaus Jensen To: qemu-block@nongnu.org Subject: [PATCH 2/2] hw/block/nvme: allow use of any valid msix vector Date: Tue, 5 May 2020 22:36:03 +0200 Message-Id: <20200505203603.278339-3-its@irrelevant.dk> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200505203603.278339-1-its@irrelevant.dk> References: <20200505203603.278339-1-its@irrelevant.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=128.199.63.193; envelope-from=its@irrelevant.dk; helo=charlie.dont.surf X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/05 16:36:30 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Klaus Jensen , qemu-devel@nongnu.org, Max Reitz , Klaus Jensen , Keith Busch , Javier Gonzalez Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Klaus Jensen If the device uses MSI-X, any of the 2048 MSI-X interrupt vectors are valid. If the device is not using MSI-X, vector will and can only be zero at this point. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 2b072bbb21e7..755ced8b03fb 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -646,7 +646,7 @@ static uint16_t nvme_create_cq(NvmeCtrl *n, NvmeCmd *cm= d) trace_nvme_err_invalid_create_cq_vector(vector); return NVME_INVALID_IRQ_VECTOR | NVME_DNR; } - if (unlikely(vector > n->num_queues)) { + if (unlikely(vector > PCI_MSIX_FLAGS_QSIZE)) { trace_nvme_err_invalid_create_cq_vector(vector); return NVME_INVALID_IRQ_VECTOR | NVME_DNR; } --=20 2.26.2