From nobody Fri Nov 14 15:20:12 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1588672838; cv=none; d=zohomail.com; s=zohoarc; b=Cp962Ttb9fCNAFQIN5wS55SGhIrO1HrF2dw81+VdaSNlWAoVHKvH9cfzIQQnvwpd5iXZUcT0OrKrIeb1cpdywEYIs9d37d+fHwIAcom/Hry4AKTwAy9YWQmCFoTk/FwZYkWc3INUdzsxLBFca/AUdQlI8e36CDUKZVdOCn77LmE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588672838; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=EkplecsBlPPnRuZXHE6e7jrbnG0gHvt4a5C9/IO/Jn4=; b=XhgzPGn/y+i7uWPDoS5S/5mfU/JUpTixRCywdHvDGUAQOnpybxH2SJejMiAFozHZbYPn44WuLLSlNETHPOhgNsy2cEctsI1bUEV+I+wuU4hKgWzs9syhKh3T5rsO4XZIZ140icwIkQ7fDgeYFZPZxXZp7qrRwtRsnWT6nzMd71c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588672838886747.871795635784; Tue, 5 May 2020 03:00:38 -0700 (PDT) Received: from localhost ([::1]:59638 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVuNQ-0007jX-NM for importer@patchew.org; Tue, 05 May 2020 06:00:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54534) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVuMh-00078N-0n; Tue, 05 May 2020 05:59:51 -0400 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]:33422) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVuMg-0004OJ-0s; Tue, 05 May 2020 05:59:50 -0400 Received: by mail-wm1-x343.google.com with SMTP id v8so2083411wma.0; Tue, 05 May 2020 02:59:49 -0700 (PDT) Received: from localhost.localdomain (26.red-88-21-207.staticip.rima-tde.net. [88.21.207.26]) by smtp.gmail.com with ESMTPSA id s17sm2894725wmc.48.2020.05.05.02.59.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2020 02:59:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=EkplecsBlPPnRuZXHE6e7jrbnG0gHvt4a5C9/IO/Jn4=; b=qxeUGu7zd/oq5+AkjIqIIv4AbwIjrr2CS1GlsoHs/2IwErU9jL5p8nTg/rnrOi0+Hs era/vVIFq2Fn0c+N/zEgg8RtcjI3rErFOkAiEBhcbRViM9pY9PQoKrr8JtFXnBrPxB8U dYAAM/9nOBmwrEvFbBQyFoM4nLYG7/1VTx9juSHRWqUMdHdZ/gMA6KgZiDTjjg1tvx2t XzKHmX9ffT/usEqxPNpKfM4MAWSch2o6dp0PgoTGgPQELt66edWS0/Qfzf2nxNiebBy1 Yjp7ogELJL5Z/wVnCRA6LGvBJPmzzqLHzEk65i4hoi/ziakFo1nSYTjN1ShlVhYApYUp Ln9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=EkplecsBlPPnRuZXHE6e7jrbnG0gHvt4a5C9/IO/Jn4=; b=MILe16i+DptK7/+FLWuEuzAURVc35F6mFWjonFBt9qoWDZywJx5erJt8HrsiPXdahF b5FDpj23jNw4BYkjShFQA9/DPCUXqZbKMV51r+Ck6N2UCiaSLlA1UNUoP5iRHjAZ7Q2N DjxmW4zid7nw6648fsAlatkiMc4tax7mEGTDQq4P5Q6wAkGFd7WJcIZRuOOKCsjmF/kF UN/lw98uA43UK5vc6vqhNEYFc0ayPwn/k6TJ0YQxYTWmwIGt/cKBQIorkNK3sjDJk4JZ 3tI3QgwR/mPBVhMDp4aoNWoFpBXuMaXKY27oSog3xBq38jNA0OONbZAb0zGlc4kciuRb VK3A== X-Gm-Message-State: AGi0PubMkZcoPFcJUY2Pj3e5aB8jYlnCijV3gxBvXU+GyqY3I99c3WSE CTWFKtc8Ch3aAZJSL9V/FzONryv9 X-Google-Smtp-Source: APiQypKyFJ5xMsui8MoA133za5FCya/SqUJWChQoP18iHA4UA3DilmOORgWEXBb7+n5FKKU0PIWMQQ== X-Received: by 2002:a05:600c:1008:: with SMTP id c8mr2340956wmc.14.1588672787793; Tue, 05 May 2020 02:59:47 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH] hw/arm/musicpal: Map the UART devices unconditionally Date: Tue, 5 May 2020 11:59:45 +0200 Message-Id: <20200505095945.23146-1-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::343; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x343.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-arm@nongnu.org, Jan Kiszka , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) I can't find proper documentation or datasheet, but it is likely a MMIO mapped serial device mapped in the 0x80000000..0x8000ffff range belongs to the SoC address space, thus is always mapped in the memory bus. Map the devices on the bus regardless a chardev is attached to it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jan Kiszka --- from 2019... found while doing housekeeping --- hw/arm/musicpal.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c index b2d0cfdac8..92f33ed87e 100644 --- a/hw/arm/musicpal.c +++ b/hw/arm/musicpal.c @@ -1619,14 +1619,10 @@ static void musicpal_init(MachineState *machine) pic[MP_TIMER2_IRQ], pic[MP_TIMER3_IRQ], pic[MP_TIMER4_IRQ], NULL); =20 - if (serial_hd(0)) { - serial_mm_init(address_space_mem, MP_UART1_BASE, 2, pic[MP_UART1_I= RQ], - 1825000, serial_hd(0), DEVICE_NATIVE_ENDIAN); - } - if (serial_hd(1)) { - serial_mm_init(address_space_mem, MP_UART2_BASE, 2, pic[MP_UART2_I= RQ], - 1825000, serial_hd(1), DEVICE_NATIVE_ENDIAN); - } + serial_mm_init(address_space_mem, MP_UART1_BASE, 2, pic[MP_UART1_IRQ], + 1825000, serial_hd(0), DEVICE_NATIVE_ENDIAN); + serial_mm_init(address_space_mem, MP_UART2_BASE, 2, pic[MP_UART2_IRQ], + 1825000, serial_hd(1), DEVICE_NATIVE_ENDIAN); =20 /* Register flash */ dinfo =3D drive_get(IF_PFLASH, 0, 0); --=20 2.21.3