From nobody Sat May 18 09:48:37 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1588602468; cv=none; d=zohomail.com; s=zohoarc; b=dLqt9u5Kl6B0XPp0N1ddjHjviI4eX4LfxPpHttTX9Q743yMXEY67UwsDjtHhHpoV/EFNHltj2jbW9oxvDAy90/vWJj6hCNnK++9HTjNSi54bgdXibVETzLD8UV/SAO+dMLp1w0jtRHrtBlXzi9h3/UYLqckIfoxfxsfxXMLEJqA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588602468; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=6KssWYDWKmX2bACLCXDvYL5R7uQ9ktgUSddYGO3LWEc=; b=W/l8WAIzEo85TSQln5bNyJXrvQFB7FDTl8fCMLPb2UvbDIsOOym4SxYLlSBiz5xm6TRRLhgcY7Na9SPN1N6AULeoDa/gPMGl8JhnsI7t0aeDKVhIid5hmAAbMTgU1H35JUxgg9CgWAwNVyVh0698U6u/tgb/nSVEFnYYlqCOwLk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158860246821851.33294425182169; Mon, 4 May 2020 07:27:48 -0700 (PDT) Received: from localhost ([::1]:42950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVc4Q-00025s-Tf for importer@patchew.org; Mon, 04 May 2020 10:27:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVc3P-0000sV-Va for qemu-devel@nongnu.org; Mon, 04 May 2020 10:26:44 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:33933 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jVc3M-0005Ei-Es for qemu-devel@nongnu.org; Mon, 04 May 2020 10:26:42 -0400 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-353-fTbOWmVPNkGaWeOGmNxZ1Q-1; Mon, 04 May 2020 10:26:34 -0400 Received: by mail-wr1-f72.google.com with SMTP id g10so2082822wrr.10 for ; Mon, 04 May 2020 07:26:34 -0700 (PDT) Received: from x1w.redhat.com (26.red-88-21-207.staticip.rima-tde.net. [88.21.207.26]) by smtp.gmail.com with ESMTPSA id s18sm20559545wra.94.2020.05.04.07.26.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2020 07:26:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588602398; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6KssWYDWKmX2bACLCXDvYL5R7uQ9ktgUSddYGO3LWEc=; b=Y+qowDjs1g+uX24UWLWMrguxiTU7atOcGFLwsPRxcE4pC47l7YxTi3LJPCFq3GD3x30r1B +pHQ29wGFIaVasf9j6tKx3S/JcRpZVyFN3VTnl9GL4eP9CG8FU1gPDUD7KnK9H30EmOxbd oigt90dbyPY3ouYawuvUXafp+Yn+znE= X-MC-Unique: fTbOWmVPNkGaWeOGmNxZ1Q-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=xuMjaNYxipgB8albhPc6Ph80ZynRbvJlRqsT2hfDicc=; b=a2WCnTEkr3qdV1WmZ93KO6oBD9CQC/gEYj1bOJis7UaMMT46kO2wX15w/WwIz6SRzC l4EEP4ZbJAkL1+BKJdZF8jv0gWojFjEnh1IswEyUqLS3ES03aMhdhL2KbE6zPTFfSlOM RSUGF6d+u392cEy7JkvpxiwTR1KRYlDzN5rW9zB8wXcgp+KSRin6rZTIjkLeAbgZqXhb x7dnkjIpfGGxkLzM3Zv7Z1MsvpAs5RFfyfW5ydHtmAGT81v3t37osbhXK3QNC+BQQViu 5UcO/T/wDr939wIKOuAbMp8JZdrg04mUDknzN+fUocM7PKLAqgxHnLH39HhTmoRExCtj rmFg== X-Gm-Message-State: AGi0PuYscR1v/H5BsBZH1E+Syq9ciVMfENyim28ERVvCBYXiGgB7aOfM ajZY7GkprPVYzPa63uCX00MOcYUdtqUn0EYajWFS+HwTNnXOqmeesVnD5Jg1fj2E1pZMCfvhssa d3KZrR9ncjad5dTw= X-Received: by 2002:a5d:650b:: with SMTP id x11mr19094441wru.405.1588602393117; Mon, 04 May 2020 07:26:33 -0700 (PDT) X-Google-Smtp-Source: APiQypJVO+8+jDCxGemtvWiUST40IreBT7h+uUr5YMU2tz1NUVpt2k0Ua08mhJG5n6zjqJbnEvUJKg== X-Received: by 2002:a5d:650b:: with SMTP id x11mr19094362wru.405.1588602392066; Mon, 04 May 2020 07:26:32 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH] tests/qht-bench: Fix Clang 'int-conversion' warning Date: Mon, 4 May 2020 16:26:30 +0200 Message-Id: <20200504142630.12842-1-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.120; envelope-from=philmd@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 05:09:11 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson , "Emilio G . Cota" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alexander Bulekov Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" When building with Clang 10 on Fedora 32, we get: tests/qht-bench.c:287:29: error: implicit conversion from 'unsigned long'= to 'double' changes value from 18446744073709551615 to 1844674407370955161= 6 [-Werror,-Wimplicit-int-float-conversion] *threshold =3D rate * UINT64_MAX; ~ ^~~~~~~~~~ /usr/include/stdint.h:130:23: note: expanded from macro 'UINT64_MAX' # define UINT64_MAX (__UINT64_C(18446744073709551615)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/stdint.h:107:25: note: expanded from macro '__UINT64_C' # define __UINT64_C(c) c ## UL ^~~~~~~ :14:1: note: expanded from here 18446744073709551615UL ^~~~~~~~~~~~~~~~~~~~~~ Fix by using nextafter() from : float nextafterf( float from, float to ); Returns the next representable value of 'from' in the direction of 'to'. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- Cc: Emilio G. Cota Cc: Alex Benn=C3=A9e Cc: Richard Henderson Cc: Alexander Bulekov --- tests/qht-bench.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qht-bench.c b/tests/qht-bench.c index e3b512f26f..f93f8e0fe2 100644 --- a/tests/qht-bench.c +++ b/tests/qht-bench.c @@ -10,6 +10,7 @@ #include "qemu/qht.h" #include "qemu/rcu.h" #include "qemu/xxhash.h" +#include =20 struct thread_stats { size_t rd; @@ -284,7 +285,7 @@ static void do_threshold(double rate, uint64_t *thresho= ld) if (rate =3D=3D 1.0) { *threshold =3D UINT64_MAX; } else { - *threshold =3D rate * UINT64_MAX; + *threshold =3D rate * nextafterf(0x1p64, 0.0); } } =20 --=20 2.21.3