From nobody Sat May 18 07:09:01 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1588594056; cv=none; d=zohomail.com; s=zohoarc; b=DYJP52OqfLVoPFhehhbfPrtfvUOf5V0GcY+X84kK7Oa31fyKhNEsjoUoMGiIFysozWz8NjWXy4YLDqnuhG/Nq1lyAqlzYymY4wZXTh+razK3Yzenf5XTx9VjIAptodAyCRBv+zKC+UmYHZt8IDxZC29xOA11uRaoO2b2xdq+RKA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588594056; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lAASt12YOl1wkWqImD28x1i+dIyD7UnpB9bA99aP4zI=; b=W3Dj7d2Sx8LCP/SqKd7sQHLPXPSlkzoItbWd7ialPNz60Ala04RQJv6JV0wOqKiBDRmlDhHUdL6R8EGUA9xaNz1PSmOQz3azs8gcVHQSS6vwUq/NqdUvsErfue+XXHMbgRxC4vilmNmG2GphogTVZlfJLEIWU/UHudv9Iv1DWvE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588594056572613.4477679078192; Mon, 4 May 2020 05:07:36 -0700 (PDT) Received: from localhost ([::1]:58374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVZsl-00079Z-AQ for importer@patchew.org; Mon, 04 May 2020 08:07:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVZjp-0002y5-BK; Mon, 04 May 2020 07:58:21 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:60137) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVZjl-0001x0-Bu; Mon, 04 May 2020 07:58:20 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MKbwg-1jqYUg2RnI-00KuhC; Mon, 04 May 2020 13:58:02 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 01/20] scsi/esp-pci: add g_assert() for fix clang analyzer warning in esp_pci_io_write() Date: Mon, 4 May 2020 13:57:39 +0200 Message-Id: <20200504115758.283914-2-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200504115758.283914-1-laurent@vivier.eu> References: <20200504115758.283914-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:IAjXWeOvZowTWwwghDSTfo/cqLp7D2O1nyg8K9rIrOLAVnCLpvo j2Sku7G5E6RbBln9ywr7h8BqE2eB/ynmo/HQwFOJ3gwyMFD2o2B28T38QjpeB4HRf3wFPoY v2WZD366mLi+ymb8gvRFXjYwcKl5qNbD4Z1YZyfL2nue4EOEvRbd9YLRfjFGmPpgXBUmK11 k9IVzjxMfaQ3O0JN5iv4A== X-UI-Out-Filterresults: notjunk:1;V03:K0:3MG0TqZ99jE=:f1bJ+HcIvfmH8ujY6XD+eD D4aNqis9rNUNUt4Oy2X9JVMFSpUPlcj3gvymKH5EEL2HNRnRfONQioOpyXJSJ6u1jWDQkjzK0 oVTBKH3qjGtG7oF2/zn4xHanCvVrIkdQ5WEVUJYgekSOT6UsStF2YCfNm6eBWra/WtdqPVvV0 57xlwPidxLeo1iL3h0XcYvXo7igQrI22vxAOTFBx22pmrtIsB0nhrYYK8Y64HHGozd52DucV7 xrfNvfeRUnI8W2Ednbd+MkydvNguMUfxb8m+Tp68ocKWmWlBU56YzLlzzhVT8Q4R6QXLILhV3 WpjW/+e8qinypO3UosYMGQmJO3mCOL+F6NS4CiUTPK1E9J7fcJQj6xpKFMp5Rm1Xyj8DmTfGK K6M7GA4Yi0HoH1G5hTdvraOZ7OKXZxZyRUmz0uZBBW+9jkRaMADXL4u31MbPBcjexfs/v6oK4 ekTymBhzD5iRNugFNFWqi50HqjN3f/VAXxRGGrQpwYi9qRb7dp9TpLVAUlgexT7RhrbhAJgZo t8/QlauZ5c/xZphvj8r1A4DikD/K5WrbIz4zzz9t+4pG5h2PPS1T9b5uRkEndEHCilpMeSzqB 3JxMKwcDPv4Q2E0OZyCu33LGCZ7qWo0ngPB/L7BoOLkXJQvj0PMSKAbNnfGXZhcASYmCdxJ7f GxjJQO7EzFelGAN5GPsz+3rI2YwrxmCT7m7PQkWRwCTD9s1AnyavMopZUs4URh3LCEwVKuSUJ yJ1Zc/m512g4u+NTfTO3rOL3bMPvyCi6TYlmNT64dfrzwOSlDUq93HkYYPqVGfAM1YdgdYB5/ dznbKFzK1ic7RVn7ZAuzLPiKubQJYERG0UIvrQjL30MGwk5pvirFbEQcApupwq5cATzi1Rc Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=217.72.192.75; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 07:58:02 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Chen Qun , Michael Tokarev , Laurent Vivier , Euler Robot Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Chen Qun Clang static code analyzer show warning: hw/scsi/esp-pci.c:198:9: warning: Value stored to 'size' is never read size =3D 4; ^ ~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Laurent Vivier Message-Id: <20200325025919.21316-2-kuhn.chenqun@huawei.com> Signed-off-by: Laurent Vivier --- hw/scsi/esp-pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c index d5a1f9e01748..497a8d590190 100644 --- a/hw/scsi/esp-pci.c +++ b/hw/scsi/esp-pci.c @@ -197,6 +197,7 @@ static void esp_pci_io_write(void *opaque, hwaddr addr, addr &=3D ~3; size =3D 4; } + g_assert(size >=3D 4); =20 if (addr < 0x40) { /* SCSI core reg */ --=20 2.26.2 From nobody Sat May 18 07:09:01 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1588593599; cv=none; d=zohomail.com; s=zohoarc; b=j/q1f6CDFy3vOHh4v32FSe+/nyr6loK6GDIejRG2mbKKUlc+UgAWbmGxuQVp6vblzml9YHXPNbqmR1DMIp4uQjRdNXyxqyCOmf3Z1Pm/TXwuVL17eoBcGJ6t2YC02EL5i/iiTARgYHFwfgGk2f+FuEMMTBOgYk0RCM30LmQ0y0w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588593599; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/JPy0aeXgrzTxtQFRWp40FItJiX14Gj3j7z0rs8w/do=; b=n5hhe2WcqGjIKi2ZpJqlPzYntXhqgWfhYhLgR73lAurTwfT6v8sb4mV4G9+jwA1bL3T+ZnogDMk/plclysromyiRXFbTSkKxzPeiDlOwxT8inDVgq7kjXsQFzPWrL7zCyf8zK1f2iIIgE0yLXeikGmyXBGlV3ZWh01LsKm/pxYM= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588593599889329.84040634375515; Mon, 4 May 2020 04:59:59 -0700 (PDT) Received: from localhost ([::1]:33390 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVZlO-00051o-IP for importer@patchew.org; Mon, 04 May 2020 07:59:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51978) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVZje-0002oU-QJ; Mon, 04 May 2020 07:58:10 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:51679) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVZjd-0001mg-Pa; Mon, 04 May 2020 07:58:10 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MUog3-1jekfK0kJF-00Qi79; Mon, 04 May 2020 13:58:03 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 02/20] display/blizzard: use extract16() for fix clang analyzer warning in blizzard_draw_line16_32() Date: Mon, 4 May 2020 13:57:40 +0200 Message-Id: <20200504115758.283914-3-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200504115758.283914-1-laurent@vivier.eu> References: <20200504115758.283914-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:foyPSr7xsSevWh/8RpltGSGoNnpQUkoxfNoJfKzpLy2pDhFRZuw 9i6AvXlNwaFpIy1fjQxKlCdAVkUL26S6pnRB71Nk2rgbTGocd8DGvBKV7RkCEiE4ECIJIr4 x4wiNs3C8Qom709dEcQIQzv9kgoVSfbAGAyddGEn4qI0XZq9Hos2fHqxAzwml1FyMiKa54g mX/4fC/PsP9hUovG9ACfg== X-UI-Out-Filterresults: notjunk:1;V03:K0:IlICTlhBH4Y=:bw3P7mCJcpuQH/5fL1qitb gbDpr8+IgvYTMmc8TsQc6EFp04kmgnpCXb7DR1sMti7TNQETDgM6UtY8DhNZTVN04vF5goCjk 7+Yve4GOo45Q/JdoMvI9YRUBDX+8IFbYeDBuMZLlv9NeXkDUJa7nXundwO1EGt6VaPNVjOzlk bEVCIlLHGyoW+X9lrBnk/Q3CBqJJSGHk2mExGX49zrdHxuKd46z5bkJXWuTyLzFviFwrBhb8W mKn4wg+wbF06sppNavdLetoiNoMFUl30WxOTHQ93wEJvdqUxPcZsQvsD9i8nUrNN5CSGn2Yf/ qg+3qt38Amm7KVyN20A1n5Vi5lmIQlJIvmt7qQIXyWEJqbNoMOWWRK2f5GYEgRGCe8IWBTT/g VZC7keXet0s/shpKNpwk1toe+SDEH2Rn3982PXxABBNiuKM4aCa8SNzb2yyEnenVXOv/1NlV7 0s6JCndZ1RsdOteKV+Q5dISgaO0bcU14B9qRwIBxeHSV4YZvCkqYdhmPuo3Nl+gxbif9oFmKl 3SC80hahz9LL4rr2HnDQfVCtw1YyPqMUa4LTrWI26/IbRYkWlIhc6oFPxtNfUskvANHLgMDED HeAyEWBbmUC76VtT2pTGvQ2+0pUMxvtYZqcq9o7KE3gR849WIys+NAcX9Ux/isGPx8A3rGxkW G+K6s/8/r0e7wMzT3bv4xOMrSK9O+DbQvbs0qlQCyhXaFvvkKOgimP7xSd1u7xX+M9fqcV6EP THPe30z4+g84vuBZZw5GCzwoN0FrLFVoKtc0mFceeFauIvFILApA6yvEF/zb5ck1Wjb0sk0vR TPFJL7Py31FxvlqB+pPq6Ya3ehpg2XP1JA24qUzCnXkOudEgU7AB2eeGT0w8c7gQPIP3IOi Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.17.24; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 07:58:08 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Chen Qun , Michael Tokarev , Laurent Vivier , Euler Robot Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Chen Qun Clang static code analyzer show warning: hw/display/blizzard.c:940:9: warning: Value stored to 'data' is never read data >>=3D 5; ^ ~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Laurent Vivier Message-Id: <20200325025919.21316-3-kuhn.chenqun@huawei.com> Signed-off-by: Laurent Vivier --- hw/display/blizzard.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/display/blizzard.c b/hw/display/blizzard.c index 359e399c2a0b..105241577de1 100644 --- a/hw/display/blizzard.c +++ b/hw/display/blizzard.c @@ -19,6 +19,7 @@ */ =20 #include "qemu/osdep.h" +#include "qemu/bitops.h" #include "ui/console.h" #include "hw/display/blizzard.h" #include "ui/pixel_ops.h" @@ -932,12 +933,9 @@ static void blizzard_draw_line16_32(uint32_t *dest, const uint16_t *end =3D (const void *) src + width; while (src < end) { data =3D *src ++; - b =3D (data & 0x1f) << 3; - data >>=3D 5; - g =3D (data & 0x3f) << 2; - data >>=3D 6; - r =3D (data & 0x1f) << 3; - data >>=3D 5; + b =3D extract16(data, 0, 5) << 3; + g =3D extract16(data, 5, 6) << 2; + r =3D extract16(data, 11, 5) << 3; *dest++ =3D rgb_to_pixel32(r, g, b); } } --=20 2.26.2 From nobody Sat May 18 07:09:01 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1588594061; cv=none; d=zohomail.com; s=zohoarc; b=B28PAMJ6HMKhdx8fDupld7DIWs34MVb+wmbKyFvL2r6haEo3nSrZJWwcxBdYbYWHxIIjqp6gLLRPt9cgdL8miJmdJPG2VOPmnLc1uqLLOx2XMS4MtpIiFBQNRpgmvqjapaWp4uVxI81KwZlwFYzhnilLCGpqn1Y6R9ClpyygYM8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588594061; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=m5LYuVAqaUNDbjv2LlrAgNacgPd1itHZQrCOo9c3gqU=; b=n2zIBUFbGIayrRHLJa0+3W91KLtNhcGIC3dRl/ibbodwHSgLp1CjANCn0P9mF+gxLtx6fOy35y16qelSzpsfs2ebQZ7OTo4pJQ7Vl0ljiOHdDE1bQ5lmtzOMR79YgGdh0ovALg4JezBLuDDuKBdyxBg7pKXvHZFIpR5wHSmtmJ4= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588594061813519.4510094461085; Mon, 4 May 2020 05:07:41 -0700 (PDT) Received: from localhost ([::1]:58784 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVZsq-0007Jc-DJ for importer@patchew.org; Mon, 04 May 2020 08:07:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52040) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVZjr-00033m-9p; Mon, 04 May 2020 07:58:23 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:41055) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVZjo-0001zK-VS; Mon, 04 May 2020 07:58:22 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MLyzP-1jnW5l0VaD-00HsQV; Mon, 04 May 2020 13:58:04 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 03/20] timer/exynos4210_mct: Remove redundant statement in exynos4210_mct_write() Date: Mon, 4 May 2020 13:57:41 +0200 Message-Id: <20200504115758.283914-4-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200504115758.283914-1-laurent@vivier.eu> References: <20200504115758.283914-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:rGPmTbt3LS78KZblEyLnOBFOGWdEOJIuW7LeCx9f7iNzdLmp2Lj MzlPvWoRUqDr4hftXRpUfCkZ+eu/L8o1FwdUoZIscg4UsGuLngTWEI8luCNcA9ULd8RyMpI ESycGUHZjkaBLlzuN0t6tG8TJKAdmFY0yhVhk/K4zwt6GCDOHxVNMdpiJD2JppGFgCN/1hC jZjpWN1myU3sPr5drXerg== X-UI-Out-Filterresults: notjunk:1;V03:K0:oIhUnmCaHA8=:i1Umx/M5mqCude2CXClJ6q zhUjfRd7IHXVe4z3jLXwNQ1jk6UOfz/6jpQRFqr8ejnISHO3sODrX4ZQO8qlTrRMJ4hpOQqhw KpeLbs4SORsLKtma75BuEt4yU+CXbaDY2UFeDyb+75IFKLobS6bP+PfmqnmlG3yfTCGA9pWXk 5HTzy+zLin6r1klIhXL5u4XacdP8O/yhLl41lEIl/4SWsh2XefzTWJdjAb1oVIhWlxroSxF98 Qz34YvvF4qpvHXPnAYBcWqGt8umAT91rNwPxMvej+xcfgopk6mGzhA7IS8FNS/aUHZA4n8ohV ViCVTT0u43oMiUXHdnRgBchq9JYtBRC0RgnL+y9swFACaTM1T7KdxNKMj6SJ3h6cGnG/hGwtH 0OyHBSGRzcbRIv+HhgIBXmpdibogFJz5MfkCiXK/aOgWAkM50xBtssSZ9nBcCaO9Wa8jXTrWn 7Eeq9ZtfTGPjKXiK1htdyuGt6+VOQ/kgK+09NGctibO6ZULGT5dCdNi4fD7d3y0wXAqA1hKv9 Sucaz4tDGof8Wd9a5x9OEYtUCq2OQpw6uJor8ogruV2ecoMeWOvbHK0wJeKKZxMYXZOeSSduj lGbUYYjxAkuSdRArSZSJgyEOZjRjVRTXc0zmQgEdYaC7UrO3QreSTfh5onc/o6Xe55lLHp3OR OlCJvV2uHtyphJGABHMlZwliok04mDBDMAnhD2D0YzXKGUfQHjDotIM1hmXwMZ221DwVCxzbx Zt817jB+p/i09Uv2Rtx1hXn9JUJsarLsFItHghBqq+2pJ5ehERtG4F+9yynucmQnQvYLT4t6K 7X3K7ayZ9xoI+k5v6B8T0zirQ8GBUi3qYQIErnLV3RS3sWAbNp091P4ZGvMf/VZdJwY9Y8j Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=217.72.192.73; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 07:58:12 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , Alistair Francis , Euler Robot , Chen Qun , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Chen Qun Clang static code analyzer show warning: hw/timer/exynos4210_mct.c:1370:9: warning: Value stored to 'index' is never= read index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/timer/exynos4210_mct.c:1399:9: warning: Value stored to 'index' is never= read index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/timer/exynos4210_mct.c:1441:9: warning: Value stored to 'index' is never= read index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Laurent Vivier Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20200325025919.21316-4-kuhn.chenqun@huawei.com> Signed-off-by: Laurent Vivier --- hw/timer/exynos4210_mct.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hw/timer/exynos4210_mct.c b/hw/timer/exynos4210_mct.c index 944120aea59c..570cf7075bc5 100644 --- a/hw/timer/exynos4210_mct.c +++ b/hw/timer/exynos4210_mct.c @@ -1367,7 +1367,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr= offset, =20 case L0_TCNTB: case L1_TCNTB: lt_i =3D GET_L_TIMER_IDX(offset); - index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); =20 /* * TCNTB is updated to internal register only after CNT expired. @@ -1396,7 +1395,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr= offset, =20 case L0_ICNTB: case L1_ICNTB: lt_i =3D GET_L_TIMER_IDX(offset); - index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); =20 s->l_timer[lt_i].reg.wstat |=3D L_WSTAT_ICNTB_WRITE; s->l_timer[lt_i].reg.cnt[L_REG_CNT_ICNTB] =3D value & @@ -1438,8 +1436,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr= offset, =20 case L0_FRCNTB: case L1_FRCNTB: lt_i =3D GET_L_TIMER_IDX(offset); - index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); - DPRINTF("local timer[%d] FRCNTB write %llx\n", lt_i, value); =20 s->l_timer[lt_i].reg.wstat |=3D L_WSTAT_FRCCNTB_WRITE; --=20 2.26.2 From nobody Sat May 18 07:09:01 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1588593739; cv=none; d=zohomail.com; s=zohoarc; b=KM2HXOC0VKNdAG0Upeq15V3O8yqhK4Hon+QbpJBsBlAkHrTPB7c4FH2arTSWWGdwouqsg2LodZf2wVwGQQhnIeThTpKd4uMdQb1hUiRllSH9EjfaezXWcad4sjsd262PMaEg4WLUag4fbjPgWu5Y4XmzweNyTgbfko+IZ5BMFuk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588593739; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Djehs5dEd0RlWXdDnDxmJYo+t/gqD4KlSt3ZjpyazMo=; b=F9as3Dkng55R5lsppfg7DKNrbS4SlHTRn3UilcB1C4yqNsdWHeLYzPSkBTE/eriqs77e4XZRv2t+41VT/o/mhp0jX9CMpG8M2CcuDXouVVnKVjwTcVgBGMNxASMa2TDWTklF77jG1LwD4xtFaSHwar17H4iS1yau0PIvUSyWS3U= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158859373919971.31246616222654; Mon, 4 May 2020 05:02:19 -0700 (PDT) Received: from localhost ([::1]:40476 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVZnd-00087f-S7 for importer@patchew.org; Mon, 04 May 2020 08:02:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52028) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVZjq-00031r-L2; Mon, 04 May 2020 07:58:22 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:60045) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVZjo-0001yc-Rt; Mon, 04 May 2020 07:58:22 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1Mg6qO-1ivzfO3x3G-00hgP6; Mon, 04 May 2020 13:58:05 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 04/20] crypto: Redundant type conversion for AES_KEY pointer Date: Mon, 4 May 2020 13:57:42 +0200 Message-Id: <20200504115758.283914-5-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200504115758.283914-1-laurent@vivier.eu> References: <20200504115758.283914-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:ij71dasd6aUUvAuk8Gmh4BUmqjgTzMBaXMzWHHUi5ztnC+Py9+5 BsP46QK/FpKMNIeA9KHKsKPJ/Wn3cZXiqgntgON/NaLqeR+XqSweKl8egrzQbHvPJ/ONnSH zyxoeiyVMxPuFEsMS6F8eXF5PMO7jU3ooAdMQ96HasjhJ9aOtx9XIr+p4zzfRKAW7BnYoGr ugXPmJfBmTOpIfWBCMazg== X-UI-Out-Filterresults: notjunk:1;V03:K0:z8Cj/S1lsNk=:OSal1EPwiLQ1ysdDI0m4Fy bdPOi134lpFET8LIMJ7Q4K/9tB5la0AfyEJLstH2F4w+0TW2Rq8OHzuA5Qoyp3W94/1QZH2T/ RMrLaOsFurnVSFWawXtMY7o0j4H7FasP2ocOx5pZC4nCnoeQ+d0Jy4bXVN5IjWMSubuiFOSwb ZMB+ma4+0tVchG1/Hn6/O2RByqB8qy5sJLfxN851gASBV8dh7nVqgqBwy1+YmniIGc/kBvRVM FopFBauITjurxGXVTc3OzoKfrFo8WN3ehjy9aVK3C2z47+WRWIsxUFx7x4WqNBtbtKGaiTXBl YDbqIu0K81XKRTLkdVFgi4Mk2rCXa9Ry1ElhzW6Wm8lQ2sx+zAiN2kG6i6OxzPUn750vxy0+N MMPMWUcXEUOPrsurnV0v+w19AvEtQ+AxX8ziWOwwNrL9AFEywLYywEtygWpc2nrQWgBWvxNNe lyk6f2fJE60Zlf9UkNeWhcdsTwetj0F3eZxwTgYHITIdX8HeyTUWrdzoJ+lC30hJ0McYBlB88 qdLQNL5ryIRl+B7ZSMdFFY0uDL1xMy8U9PBlpYracMzDcEz68Jw6fnZ+nFx+1Aon7FaoHE7LD oiD+iuE0DOzxOAPrOSNzfZEuaILSl1pF4EEJHf6kPQywBTDwYg7f5ds3PFHWXCr13M/giso+Z tjVjLla3mK34GbTLMJMaRS4Az+r7KE0QlktC+1HoInQzaP2YbWyCpdHaLxJAV9zErNI/DNLax t1kvxe+h+g7esON7H+GCHVFLQZ+HzsYP8Afa/DJhAlqIp7RGlT+frvoC5INmPz1q1PO5bBbA5 ASJ7BvA0mCOcgbB81xmHBfHEfnpCp8+uStOImgK9YhgkItEdeB9jfjPDm0wcTsfSz6/5nji Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=217.72.192.73; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 07:58:12 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Chen Qun Fix: eaec903c5b8 Reported-by: Euler Robot Signed-off-by: Chen Qun Acked-by: Daniel P. Berrang=C3=A9 Reviewed-by: Laurent Vivier Message-Id: <20200325092137.24020-4-kuhn.chenqun@huawei.com> Signed-off-by: Laurent Vivier --- crypto/cipher-builtin.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/crypto/cipher-builtin.c b/crypto/cipher-builtin.c index bf8413e71a6e..99d6280a1669 100644 --- a/crypto/cipher-builtin.c +++ b/crypto/cipher-builtin.c @@ -133,8 +133,7 @@ static void qcrypto_cipher_aes_xts_encrypt(const void *= ctx, { const QCryptoCipherBuiltinAESContext *aesctx =3D ctx; =20 - qcrypto_cipher_aes_ecb_encrypt((AES_KEY *)&aesctx->enc, - src, dst, length); + qcrypto_cipher_aes_ecb_encrypt(&aesctx->enc, src, dst, length); } =20 =20 @@ -145,8 +144,7 @@ static void qcrypto_cipher_aes_xts_decrypt(const void *= ctx, { const QCryptoCipherBuiltinAESContext *aesctx =3D ctx; =20 - qcrypto_cipher_aes_ecb_decrypt((AES_KEY *)&aesctx->dec, - src, dst, length); + qcrypto_cipher_aes_ecb_decrypt(&aesctx->dec, src, dst, length); } =20 =20 --=20 2.26.2 From nobody Sat May 18 07:09:01 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1588594160; cv=none; d=zohomail.com; s=zohoarc; b=J9w2AyLJIJ18B27U8Dc9kGTB/P7RJcS2eLysR4LVGsyE9hzadQc8edc8Bw5QTqGMrc6DvWFSe8hp3wDFoURwHHJwQ9Ez+WoDAnmZS7rwatAJhqFLSm/OVsV41L2GweQrAJ0ul8RP7DYtXF2P+OzCkPZLz5h66z48xrt+qu2Irbk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588594160; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=641zgSsX+p83/6SRB8wjxYRec5gdUxPzJxFXzcDQYIQ=; b=nidaurmIUAn7EYj/BAUTfshzHjKLpPNxRm3gAeTjmXVaUU//7Kyg2zwo+6+jorRlSRoHe7r9EWcIs59Ms9EDwIHFAP8UhJLqS+JzqcX/UrIEpUEAH9O4a9JBC06TxBnFOWtomlblgkKHwn5v92Z4BjXdxVIsFi5YXwzXi4vYkPA= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588594160811304.13988543037397; Mon, 4 May 2020 05:09:20 -0700 (PDT) Received: from localhost ([::1]:36976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVZuR-0001Yk-HG for importer@patchew.org; Mon, 04 May 2020 08:09:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52044) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVZjr-00034M-H8; Mon, 04 May 2020 07:58:23 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:57893) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVZjo-0001ye-Mx; Mon, 04 May 2020 07:58:23 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MwPjf-1jFYr103BF-00sJdn; Mon, 04 May 2020 13:58:10 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 05/20] MAINTAINERS: Mark the LatticeMico32 target as orphan Date: Mon, 4 May 2020 13:57:43 +0200 Message-Id: <20200504115758.283914-6-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200504115758.283914-1-laurent@vivier.eu> References: <20200504115758.283914-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:hi4ZlP8k5hKSLyW93PzeAzjqJe7XRZDKE3QUbZJxRddbZ0QtWkK bVT5faEL9/nfqe6W5s0oAEPHhkS7yQLTIWeqaeOpNp1Nabf4FtufvCxcnIFsGk2jczIYj3s eGuH1PWZ6ATYKIss8VmC5lU0zquPKHNhIWMfqQ3XmMiK3ZZDxSPjkKvYXPAoSzFN70AjxKZ 5D/GMNs6xYaoMV7eADNFQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:xchtK2hLMPU=:mTpDgH15Fmum6Aeypk48KQ cbP9u2PgvmOPCBawOU7I0CitFqGORSTF9fJautdXkhq0IMHXTApODc8h1v9rIpN/uXzHj2Pb1 D4SgxcwwNrLsv28aHYHmKgb8Xcf0qJPzgbLYyeSFj0hVEIm80vgnCrRDPxOVjxt4vHhRZvwVN aTOIAWxB6MO2yQ+5wpOU3mQu7yV6vJMFUUgLj/66E7gSJzuU+uBV66AyyFzuXZ3oPS7rGR0FW mICwAZ1w8DDhu/HyCVX5MByeRAhZ44yE7oxBMz55NOREKfJo2szXFNokg9/7xdAhjbyX7n7r0 war8ie8OZhojCgMDU42Eo1SUuN5gDXoo0s4/8wbqgD/a9EnOgrsDTylgOftCcdNg4LvS62zzM Z9smX4/ii7XltmU2BqWALIL1xI0GD4dZI+bQM3AdHFN3jEaqoxRtmLTY4PzfQL02fyq+m5KYv SNW7XEvQ3pMU4Oi+3ZVRsDXl+Hcykv728JgY/rlqTS/g8Xo2nrpWWSVzC45T+4+zNZUc13A+K PvK7mgVuyCfbv6tvcT8My1mXJoCfLQKYRsLeF/t7zvEs7d1O3vGUbIYIaV2MPTWKJeq37aiUW d9Ws/X0IzHotkdJ7sMQUsQLwZTbDmXLVNvlTCzTolxBVQzh+xmjA2Rejas+h/DppqPtT5XvEc P3j8+VXX4IofbVqJQ87vgyw8OGf84mOlrE68qpEdk3YEhnzMw21McXfDVMfx/jZ9nEsXar7+a DStnPN12FWw48aq1TTqDjOtRB2GdEh+grrwmgBm4w1u7rMfwoV8R7LS8kYRfq+hV/0y9/B3wd jlnWWUhOh4sXbG+AmKld2q//rWZ2rNNhqIftUu2EfJFvM7rdD8UTK3WAkg3JH365NEf1YGd Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=217.72.192.74; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 07:58:13 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Michael Tokarev , Richard Henderson , Laurent Vivier , Michael Walle , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 Michael Walle expressed his desire to orphan the lm32 target [*]: I guess it is time to pull the plug. Mainly, because I have no time for this anymore. I've always worked on this on my spare time and life changed. And secondly, I guess RISC-V is taking over ;) It has a far better ecosystem. Also, to my knowledge the only (public) user of LM32 is milkymist and this project is dead for years now.. So time to say goodbye. It was fun and I've learned a lot - technically and also how a huge open source project works. Thank you everyone for that :) Basically everything still works and there are even TCG test cases which covers all instructions the processor has. Many thanks to Michael for his substantial contributions to QEMU, and for maintaining the LM32 target for various years! [*] https://www.mail-archive.com/qemu-devel@nongnu.org/msg605024.html Acked-by: Michael Walle Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20200316142827.20867-1-philmd@redhat.com> Signed-off-by: Laurent Vivier --- MAINTAINERS | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8aa8efaf1d7f..d6886be13159 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -184,8 +184,8 @@ F: hw/net/*i82596* F: include/hw/net/lasi_82596.h =20 LM32 TCG CPUs -M: Michael Walle -S: Maintained +R: Michael Walle +S: Orphan F: target/lm32/ F: disas/lm32.c F: hw/lm32/ @@ -977,13 +977,13 @@ F: pc-bios/hppa-firmware.img LM32 Machines ------------- EVR32 and uclinux BSP -M: Michael Walle -S: Maintained +R: Michael Walle +S: Orphan F: hw/lm32/lm32_boards.c =20 milkymist -M: Michael Walle -S: Maintained +R: Michael Walle +S: Orphan F: hw/lm32/milkymist.c =20 M68K Machines --=20 2.26.2 From nobody Sat May 18 07:09:01 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1588593787; cv=none; d=zohomail.com; s=zohoarc; b=V4Tx3szmHCfp2C8Q/istQ3ujSqpTi3Ebhp2wDikXgtW8SO9Az2vRfaszasYPfHZMl7OfhBcgIToUu99jPMTV/q7rPCRUK8YyrJlEOwJCt8MrUF0eomTw3BOJZq9HkMjnNaQFFeoCBl3KXGIP6HJdDD0ZXIwniIz+kKmAOP5bOrw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588593787; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=n9ggtfwvm/yRP5Z2mFvmiwsXJw5s5oEIw/Qij3Mv264=; b=aC0H2hbWAJt11lcO4395X7SRePc2yYxqkDkdgxTbMFo1X2LGsbkm0pQ52WVnLgCoGFux18/PINjhrN0b6LLtK3saCZtt9e9xndfaLba16OhtqOBUcVh9UbuFtgybCuyhuxvLolvfWEqszPhl2AHJBVasciBPobMokAzAHzHpEac= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588593787842559.6565671230132; Mon, 4 May 2020 05:03:07 -0700 (PDT) Received: from localhost ([::1]:41904 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVZoQ-0000Gs-JL for importer@patchew.org; Mon, 04 May 2020 08:03:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVZjp-0002zg-Sf; Mon, 04 May 2020 07:58:21 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:42191) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVZjo-0001yg-Om; Mon, 04 May 2020 07:58:21 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MOzfO-1jmAmM2VKO-00PKXW; Mon, 04 May 2020 13:58:10 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 06/20] hw/mem/pc-dimm: Print slot number on error at pc_dimm_pre_plug() Date: Mon, 4 May 2020 13:57:44 +0200 Message-Id: <20200504115758.283914-7-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200504115758.283914-1-laurent@vivier.eu> References: <20200504115758.283914-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:nMIjpqcyfeagiB2tomuREloaNkW9VnRkFmvDSw6OsS7MG4ZWEii 4KXMpA6rphhNRiAmq5w26xpimy2x9RyUt1nWl1050+tx5soX9Y9ErNKzM3GkZEhwNJRD3NR /TuI4KSaaKe2wa5fhFrNcuB8TJ013OSrCQeKlQuECnzyvaeKK9j74xftsZc7ugV+9CH+9qk Vy1PKXICu3pjuZ/ADCYnA== X-UI-Out-Filterresults: notjunk:1;V03:K0:mTVN/XyWfEY=:W16uyu/pJhNvkGvWiPgjvA 2FWi/MiH2OyqHoIKaAEFr02+vgsbblDvDWSVhkbwGHKBGdZCLG5P30o86Xir5E7FdC2FifVsR h4MQhI7bC4IfLArOSalR9WxYlEB2Y9/TVQ4Q9Q/4iun+O+f6sHYs23ZAUxqMQ6LV0UNuCLtpe 4Z3040p1xG0mvpUCfys22cVjxtsCR6e1JpQPgd8EYGcUJf/4s8G06rBG5+0xpd/4eGu3c4EKH bY0DnYZVJHzySeqRbKTGZ6Kiu5zNZpqFrij7ziboOX+po+ivuIcP93NKzQBzhvTIAyPaB8i6N Mz5TcRB3EXm5kNl9mPl/FiIvv/nCSUwkD1prNjI+b1494bJtaHa/HRLRadbEumg3m+6qHd33D imJa1PMWBnNHOql+9teP+kFBQJMtbaMTRaEz1k71l/uNMky/morF4jQfY7hulWSEBoK1oiFiG YslBiV6EkrPphmZ0MNQcuXdhaaN8lS5KgB+GLwZCPtYf6eLjGRxbBGwu9Fc35r49tZ3eu6aUO 5zDhpuBPFgjuxBK/j2IycSlxk5xQw2KJsDIKnxnmfJD9jHu2ex/sRVH/MjIfrAcJkL49bTz9k GrUtrclUpqc2+WXgO1WGMsEwMhFaoWHO2j9a6EIroO6HTKL8Zfma1AgvIfbNSxZK5wBG05Gs1 0ha1HlasfB3mgQRQUkI+wivgNE9rJYaBL8Kd1DvSe/mdn+MfgoXm/TkuSIIlkN19h7PCNYikH rAdYXRFw0ji90cBFO0ERL2tVcRdKDRi9sOOoP05U3xMgvdJUQuYwMjVA7VTJRztUsVJGZ9+jx vRzKidr6n/kn5EapysUJ+ZxZyjQtteYpQ+NrKqLtpeqkGn3w1rlz0UlQqLZoq0Ze8QsIusr Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.17.24; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 07:58:08 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , Wainer dos Santos Moschetta Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Wainer dos Santos Moschetta The error report in pc_dimm_pre_plug() now has the slot number printed. Signed-off-by: Wainer dos Santos Moschetta Message-Id: <20200310180510.19489-2-wainersm@redhat.com> Signed-off-by: Laurent Vivier --- hw/mem/pc-dimm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c index 8f50b8afea3c..36edfcf46799 100644 --- a/hw/mem/pc-dimm.c +++ b/hw/mem/pc-dimm.c @@ -44,8 +44,8 @@ void pc_dimm_pre_plug(PCDIMMDevice *dimm, MachineState *m= achine, &error_abort); if ((slot < 0 || slot >=3D machine->ram_slots) && slot !=3D PC_DIMM_UNASSIGNED_SLOT) { - error_setg(&local_err, "invalid slot number, valid range is [0-%" - PRIu64 "]", machine->ram_slots - 1); + error_setg(&local_err, "invalid slot number %d, valid range is [0-= %" + PRIu64 "]", slot, machine->ram_slots - 1); goto out; } =20 --=20 2.26.2 From nobody Sat May 18 07:09:01 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1588593962; cv=none; d=zohomail.com; s=zohoarc; b=e6CBNUuMBkge1pHetB+e6DYlx9ayvsqA/yd8RH1z5sE05zgENiPVGITLeKG0KbNaSM+0N+HqCGeNT1gfq6HSh9Fft0t9LSELpzHvEx0gjB/st5MvnKM4PsBohOHc2teooBFMnNSBmNVFFb1Qk8oi9698xvYXD5Ly1+baitTXyHc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588593962; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jSRpoFyvyBB8v6VEUukqRVIwU/ijN+t0EAfd8IqQE8o=; b=Mw/IOUIlgjDeVZliyDg7JPNlf+a9twUtgyetbdK6fCTsb2vGt4vnEpsTT+BYtSgnIuF4L7ftdr9P8XgZMbkOnyth/H2fkxXztLgf5pr0lJD+VWMqeTKGnq3l1LauSP1YnM6BoH+TX/rhw76Nj83KsTql6holjrXglu7AMtkyOQE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588593962765681.9620364023998; Mon, 4 May 2020 05:06:02 -0700 (PDT) Received: from localhost ([::1]:51540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVZrF-0004FU-Dw for importer@patchew.org; Mon, 04 May 2020 08:06:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52034) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVZjr-00032t-0j; Mon, 04 May 2020 07:58:23 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:51577) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVZjo-000224-TI; Mon, 04 May 2020 07:58:22 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MVubb-1jfr8A0guj-00RoZr; Mon, 04 May 2020 13:58:11 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 07/20] hw/mem/pc-dimm: Fix line over 80 characters warning Date: Mon, 4 May 2020 13:57:45 +0200 Message-Id: <20200504115758.283914-8-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200504115758.283914-1-laurent@vivier.eu> References: <20200504115758.283914-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:uoOCv6SWCIzT4rAEh7LAxYnD9eqhHUN9UdFbneX2A8S7JYa3EQt nlWJ+zqUlSEhHLroSD3BCNjdwhg5KHsmShG/KornRceMx1B0k/I9k9iAvjZMKV6EZS3abth 04lCc8AN0n1Aw8h+HTanmiXiEIU7sra5qNS6uNOt7e1zF8sKj7TRGL2l2ct/oIGyBC2k+pB w65YW6NRLBz9755Lmfr0w== X-UI-Out-Filterresults: notjunk:1;V03:K0:C4xhP5OJBIY=:YID2BNSHBArahqvD0vXEcA UecVbj8vK7q4VOn+xj4MJCrGCpCQz9qqF4tG4PZcPkislLyJBL0S2o4njAwNkicEhxuXd2HYs KJFIWrsozEnRnMHzZznv4P1Ahcm/SKTRPymbML9pc/C/v6uavfiR8A4gig+rfttLa4asHIzsG b74IrlnDC+g4q4WrnrPp1VZiLJuqPS6V1KODWIzWnCDI+DpvrSUBBsgUdUmqBSx9JDDci0e9g ogqhleLGrppfxLvcGux3ht2Ff1xO6afR6cYYTEKGIKMFzl8H5yqqFPVZjqNxmHcs6q58UIzpa LwVeoQ8q7rHY5QZaxgHYaSqPR+wCcuSdAObNHpt02LNIMH+JFIhTEixcN/2+s6kAT/NF6aHx9 CjFzSuR+zKoMpfA7wuk5XkDoa+ad5dkx0DJzmdNW9tvars8FtUk3IrAIA4yo819KZr9nwy35G 1pcvPT5ichydgyuikg8hOpcQM26a/0R7FKCdj5HeTH8ItCV9BnCP75Qo+NAipqbEyqxOx2jFG I66Sn7FFa5dvjYs64K0817NxFiZ10tAeMPsEh/YR1KfWqSP9wIEBGW1zcxtIOxtOLycCbaAXb IRNhI2N29L7WD6LO8sqcYOQ7ZHROh+F23c6tc4ahii3auweQfH1EbpkEvdaESxvvhGR3BruKv wxnJbMLwjhp1EW9mzlNwXLYDf2TAFxzTQUqZOIUeiDOlYNH7+dhcVCX5N2B5C1ahhSEbcTfRI 7aVwKzIpF7saryP+89kzi+CT7v/QRP81GdUPBINFRcXcSwZZ7M9twGB/LIy7v6L0bpa4l/ZEX 315QqLxBeEA/StubPGKiADwwv5nl9HSspHVxtXGpKfwrJ6dlxlYzEqVGgecJvXx7Gpd1wzu Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.17.13; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 07:58:14 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , Wainer dos Santos Moschetta Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Wainer dos Santos Moschetta Signed-off-by: Wainer dos Santos Moschetta Message-Id: <20200310180510.19489-3-wainersm@redhat.com> Signed-off-by: Laurent Vivier --- hw/mem/pc-dimm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c index 36edfcf46799..6d62588fea8c 100644 --- a/hw/mem/pc-dimm.c +++ b/hw/mem/pc-dimm.c @@ -218,7 +218,8 @@ static MemoryRegion *pc_dimm_get_memory_region(PCDIMMDe= vice *dimm, Error **errp) =20 static uint64_t pc_dimm_md_get_addr(const MemoryDeviceState *md) { - return object_property_get_uint(OBJECT(md), PC_DIMM_ADDR_PROP, &error_= abort); + return object_property_get_uint(OBJECT(md), PC_DIMM_ADDR_PROP, + &error_abort); } =20 static void pc_dimm_md_set_addr(MemoryDeviceState *md, uint64_t addr, --=20 2.26.2 From nobody Sat May 18 07:09:01 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1588594209; cv=none; d=zohomail.com; s=zohoarc; b=QYdF3k3reD6tQfPn8vI+xuFml+Y4Y6XZApIBaQSmKugdzzKDYMNugCMIKnnfNAsIpTS95BPlAKU+WxfyTsDxuL+IWLgfjmRB7w5QR2Mp9J5jCqIP2PY2wTVYscEBBhNZ0eNsMjAXDMdEP2rCEX8iVPlHAxFXj79OQv5PCx/uiEc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588594209; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=i4PZBQWT1lWk1owaBXRR7ha4wIQxrw3n7urbluKvKBM=; b=F2oI8cj8lLkvsgtWWqSpVQgFFlPapA798IAQSBPph4QNuz67GiGjRoixieerg86ZjbB9Mq6yXvBWDD+QKOvEc/nIvJdZaqRyHfRuk48YjpB0bOi/gSNJFRR18jSKAIXKouHan6QcIKCSe4VgR4CHMeDX5pyySQ/RgA4l1OBIV5c= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588594209706985.8423425911391; Mon, 4 May 2020 05:10:09 -0700 (PDT) Received: from localhost ([::1]:39380 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVZvE-0002Xu-Em for importer@patchew.org; Mon, 04 May 2020 08:10:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52062) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVZjt-000393-37; Mon, 04 May 2020 07:58:25 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:38807) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVZjp-00027i-02; Mon, 04 May 2020 07:58:24 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1Mn1mb-1ipg1502hr-00kARR; Mon, 04 May 2020 13:58:12 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 08/20] elf_ops: Don't try to g_mapped_file_unref(NULL) Date: Mon, 4 May 2020 13:57:46 +0200 Message-Id: <20200504115758.283914-9-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200504115758.283914-1-laurent@vivier.eu> References: <20200504115758.283914-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:BQ5r9yph8+G/Az6IX8fW6EIIjsM+kUd3mF51aPquBfwZdBe78HQ eJny12BmQEzKP8RuUE9iCi84G9lQkzH84XG1tI0BSjC4quvIP1FWMvd5pHl8s1dMCMQcmMq HQ/ZxSNvlyXyh1WBdViEbgdbjsSe4iTbQPZQC/nZ0qrsH/WQ5FI3bVxbct72uEReOO+FK2o 8PG5uPIteltoGpTuG3VQQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:XJXUFm27smw=:7Iahaa0JmqSlE5YatvC0bp 6dutlD/QcvXKvsQesDZwrOqnOx2bgnQgs2kE2tjaUEt4pqrUr4hhvfv39aviY2DJIIe9CAJ4W 4dLdNRocSko0IUkiOFLyNLZ+f7EmktNNPRAoAlaoMIQ4vXqRWpuY2bgyW7C0qIkffQvK8r4HF Sz5f1OP1QfMbrnoiLprwcRt1bnbr4E+uTJMYxTKDkRMn0FFgLIaN5PQzMmYxfoLmZuvxEoX+L vEhOHJiJMZOZ/rbzEMZN++Nz03/jO8Xvhre069TkTwfOCAPI3+YKpKiAitq0ict5J3+jYHqJE YoH1O78NYE6fBnw98wvxqpDgmEJ2tRrqrMZCYeCueOw5CZu82fhPBZctFOb16ajAGfwqsHqq/ RXF5HOF9c8OuZuTbzeYZeZTBSsFPdzQFHe2roUdntS30VfNcRxEVfKBCFlH1/pAhtUNtRnR9/ JqSSzlEHhYYS3A/mKOXqibmtBvjWdvs72zdgVDClXvDizo5nCnZ3x8b37wTWUSGnfyyHXZKkt 02mF77bMEosg/WCYQfxqB2P+VF3dSktHaWPNvo1qxqTICMevNLvo0wiuwS9yZhB7hDeDh1apY Q9HY/6dKQZyAGC0kNRm4Qfh/H57BxpKXm97/0gPFLqhf0/ODnTxQiEv4uibzfd4WcZaszuPV4 AAFFoWLzyHdQlLrC6oheP5UU7AwyBWQYZHkhQOS3ZLnoHkV59Rf1/f3IFn6c1Cew+9sOuZOch kLc9mRWuqphz92qXxtNVPe7uFKs4K16kkCjR+pOQojIVp1RqaZlAirT3gBMEJ9bXvijOxagSP lBRiOWlL2GF4INTR0VwQJjJAA0JU0c+GxMxvJS/N+pLw4C45JMpac3WpyjunCJTPIuvCMUF Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.17.13; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 07:58:14 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , Randy Yates , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Stefano Garzarella Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell Calling g_mapped_file_unref() on a NULL pointer is not valid, and glib will assert if you try it. $ qemu-system-arm -M virt -display none -device loader,file=3D/tmp/bad.elf qemu-system-arm: -device loader,file=3D/tmp/bad.elf: GLib: g_mapped_file_un= ref: assertion 'file !=3D NULL' failed (One way to produce an ELF file that fails like this is to copy just the first 16 bytes of a valid ELF file; this is sufficient to fool the code in load_elf_ram_sym() into thinking it's an ELF file and calling load_elf32() or load_elf64().) The failure-exit path in load_elf can be reached from various points in execution, and for some of those we haven't yet called g_mapped_file_new_from_fd(). Add a condition to the unref call so we only call it if we successfully created the GMappedFile to start with. This will fix the assertion; for the specific case of the generic loader it will then fall back from "guess this is an ELF file" to "maybe it's a uImage or a hex file" and eventually to "just load as a raw data file". Reported-by: Randy Yates Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Stefano Garzarella Message-Id: <20200423202011.32686-1-peter.maydell@linaro.org> Signed-off-by: Laurent Vivier --- include/hw/elf_ops.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/hw/elf_ops.h b/include/hw/elf_ops.h index e0bb47bb678d..398a4a2c85bb 100644 --- a/include/hw/elf_ops.h +++ b/include/hw/elf_ops.h @@ -606,7 +606,9 @@ static int glue(load_elf, SZ)(const char *name, int fd, *highaddr =3D (uint64_t)(elf_sword)high; ret =3D total_size; fail: - g_mapped_file_unref(mapped_file); + if (mapped_file) { + g_mapped_file_unref(mapped_file); + } g_free(phdr); return ret; } --=20 2.26.2 From nobody Sat May 18 07:09:01 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1588594204; cv=none; d=zohomail.com; s=zohoarc; b=G5i6oTzW1z7NeAQR2AHObLhohcyUmPrYD/gnmXVztpOvgk+0jE7PX9zd0zS2GUjtciO+X642RR3BGt2FuD9RuaXUmPp29Lx6czS2COo0shRz7ec1uOL5dzNO/eHpwSdCevEjKC2cFByGZ9TXA05DrtIoRM7IWxTdV9qrRSri2GA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588594204; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=EVSIChbQJivhP5jlnEzv63VISPYgYZRKQJDYqNNBuAs=; b=GmPE05nzPSGxUyaJmWp6mQiWx/D6yQQ+PshDQGHBWMPS/1+rTF0/mACvTYu7hrZfxsFhh7z5vrGsLuUQOK0E0jX5V3rn/MrMQKV8Ioq05tnLl5V7Zx1y7IaqZicHDCstxCS2sDxKS6F0Fv16qXF6eoAf/ykejB06zfqGw2PG3RE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588594204109932.2757767261025; Mon, 4 May 2020 05:10:04 -0700 (PDT) Received: from localhost ([::1]:38948 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVZv8-0002Mk-LP for importer@patchew.org; Mon, 04 May 2020 08:10:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52026) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVZjq-00031X-I8; Mon, 04 May 2020 07:58:22 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:43835) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVZjo-0001zs-RL; Mon, 04 May 2020 07:58:22 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MUGRh-1jfIdL30tf-00RG4v; Mon, 04 May 2020 13:58:12 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 09/20] MAINTAINERS: Update Keith Busch's email address Date: Mon, 4 May 2020 13:57:47 +0200 Message-Id: <20200504115758.283914-10-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200504115758.283914-1-laurent@vivier.eu> References: <20200504115758.283914-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:Kw1W33UiramJN05FkDK+uqteuGHK9DNSy0wNvsi6LhGV1x1aGnK LUzQcOejjGsZP8hegmDlZtxy/WJHzFVeplRBnfiE+may1hT1i3TYmt0DKw8pDd790Upp4g0 bagpdJbyQyUtgn5S3bbhZGIEaaqDQcJtg+A4gdbB+e9Z8ccpAu0J3xcpw2jPMRpx7l9i2+u LaVXz/fZoJj+ZcA6HV2lw== X-UI-Out-Filterresults: notjunk:1;V03:K0:6r08Tl0UI+g=:Le3/aX/SokAIznQ7lezQ2c GOdJTRwsZnAmcF9EGHEHa7vPmwImBhsgpBwSo0sY4n8xqtetbj0eZBV0i9RNrhHCp0C3twkHb fxJuAo28jyZLf7NEejuQoDyJ1W6RKdtD9kXXLmy2/Ru02EKxnfsOZ8wrWylzqT7sIs4dRTM+r HAXHiovfQvoiGV6RmG6vhxKtD4Qod2NtunWsLnrOsxflfx2TzX+MJGKH8dKzFA5dH9t2MZUA7 YQfJjtWYBIeY1HiR3POJ9Q5I+XL9bJJYzCwoOFf/CM1qthCRNvg5wA8ikYBw5JaGwbKi6iF/s im/a+O7vaFI9/2Ctx9wRVH0Lw/Fb6OfBVlJcX3dwFWFMFPnvv+bxILY2s4J7ns/8m7R9Wcg80 PouONWzD21nN2LKgLWLv0d51EnkgUTi6aMrc+5Rz+pHZA+ycbFax5ymM8BVk7KMryqNpJNb8r J5wuVsDthUt0oXlk27skkpn4wv3eB8w7kzGtMEpboM9X4GzzyTqZ0wIi7/xgjT8JJkgu+jAYg S8uq2M8XAx6yRP+GSbK/02+/PleHseG+CTjQDOSSwF4GF9BTpcG6fWWG/On8Lo6RuqBhDEjqS bbXKGdQpjigzps4QjwvsPlOmpiY50c48jAWJwW+NvhMMcWEq+o3lIQ4CfxEycCmj+FqxX43st whFid3Wd/WPFgyrmGmPgmo2+suxxtX3m20r4QP1oJfAlvzv2BfLlgdDtyrOtuY3HM4xJ4f5fb tG7jib9kg89fQY2cay/kmhLyQknrKOZsi3V20DWo+Jg2xjTQMAj13URMSm8OpxHdFWnpr90xz Y0YJ6iEWxnEwdXbqkBFV1JSH2imIBC052Gz0ddsa+bksEsQtNsmT9ZPk8msxoi0yP7AFqNc Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.17.13; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 07:58:14 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Keith Busch , Michael Tokarev , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 keith.busch@intel.com address is being rejected. Replace by the email address Keith is actively using. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Keith Busch Message-Id: <20200421122236.24867-1-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index d6886be13159..1f84e3ae2c6a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1735,7 +1735,7 @@ F: hw/virtio/virtio-crypto-pci.c F: include/hw/virtio/virtio-crypto.h =20 nvme -M: Keith Busch +M: Keith Busch L: qemu-block@nongnu.org S: Supported F: hw/block/nvme* --=20 2.26.2 From nobody Sat May 18 07:09:01 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1588593926; cv=none; d=zohomail.com; s=zohoarc; b=IqS2H4n4+Eq6SOOF1OSoBqsTroOp96n1q67o4dGo+xVmPkRRK9+Kb7TDRuCOx7r+QJrxdF/Wuf1ShVvfUsrMitSz7BqD2TrSvO2k/7bqfLBqKMSxkx43uPgSiGdhe+j19tG73WprAhCvVgUGxVCtPx1zSybPncpH/h7LD7+iyB4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588593926; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=mlteo4pCMLntgWdXEkpA1e2SAT9pUIMaoUshK9Z/r4g=; b=KLJoyIyW/VbOj6IxTY9jJqxNtPos1jJ7w0Tc1AxMycy8tw55790ht3v2Pb2IL3LJ/wIj31DvR+MsPkpPFrL4xTOlhLBzpmQu5fRC52tljZ3XHV1e6gOAaqysqeoz0Hq5cJh2QUveT2lsrgORP/YHf6M+41aDVi9imqw89L/WQ2Y= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588593926235544.8547051727669; Mon, 4 May 2020 05:05:26 -0700 (PDT) Received: from localhost ([::1]:50346 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVZqe-0003j9-QC for importer@patchew.org; Mon, 04 May 2020 08:05:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52030) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVZjq-00031y-Mu; Mon, 04 May 2020 07:58:22 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:60549) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVZjo-0002Cm-Qr; Mon, 04 May 2020 07:58:22 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MVubb-1jfr841YKD-00RoZr; Mon, 04 May 2020 13:58:13 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 10/20] chardev: Add macOS to list of OSes that support -chardev serial Date: Mon, 4 May 2020 13:57:48 +0200 Message-Id: <20200504115758.283914-11-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200504115758.283914-1-laurent@vivier.eu> References: <20200504115758.283914-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:4ey3ye1NpyUXtC8bi3qhu9jeGu/krl8+monyixcJO2ry/Ndqd2E m4yRyCEDsPorj2bPBO6Xp5bTFUo59KbQtgykPkXYbfUPY8R7hDJw30A7mJC3uEgiG/3yelI 8RwkWjsWEKQDRVHghxFMMwdkMSY8u/DNadnmGxklTZArBDLnxbXNiWom7ImNyLnrFtX0H9W HutkynkGyp2ZzazcWEJyQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:9LBGXjpzMRM=:GtTGsuEAuj+gKcq5BcaEC7 ciiX7FV+ZUZhlwT0HBMxGmAuXG0IZgWbRXVmAODfVrkPwIKrLBZdWPcqgHiUb+5UkX2ouXn8H Ine8hbTfo+4y5VURJT3Bj/sXuGDsnp45iHZwSxf4uLyo0ANsxLmCLjaJS0fHROa0KD86+z1G2 Vzh+KiztRNqvgA8FIjht4aFXt0bDxIafyHbKEtsiIdCe19cQXlwmxOApPf7OtGByYDyTj8Nrh ZcQx+jzK0SEQsd5ZTDzu8OQIJeYkcMakruidID3YQTaNrphnQC+F5/QfHWMiS47zfOOpQn5XX kIdidjxtMsYCEBOyee3moWoriUsA++deY21x9R76+OjSw+50B74/HtpFhSlLv5fbUuy80QzuO 71eErKyV8woJuvaqdmW9NlhVymOiGdrJmJ/grGDzt4gdtIhUeDemKlhd2DY6DdmTwKRLCgiT4 ktpK2zElFapAZlUupzLv1D1p+CU+LTJ+/tOy3E5y229OEl1YUkCsdSjmRi9WF9zD73ORJftdY pQxp7liKsgf1KH6+aBRNqaXKUcvSRGVJXP/u4/cgdTGK4RbVaAv2793DJlf1AWxPqo9wPUX3K nNSv9ln1XFpzP0xzWI32ozXwmcpap/JF6V9XmWD1hpyNBhsQZw9M+6jyuB61SJEcmi+jIArVx Hex1eZlaHE/IQU5ep5pNiy9hUBHBh2Z5celIKUjs9LTL3wXhG1JROxPr9o8w21pN0sYJjcZPR WTvYPfZZoQk6Q+xREvgIQSc73seblIJYryLQyawOH/6eXHGKIChxdJlhsZMknXocuF4zflh4E bfAKUvjjOXlzpTtzwK62rGUJx0cDbawZz5LGUZSaLUqNX/xznpV47ATCGBGM7ixzup6Kopy Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=217.72.192.74; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 07:58:13 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Mikhail Gusarov , Michael Tokarev , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Mikhail Gusarov macOS API for dealing with serial ports/ttys is identical to BSDs. Signed-off-by: Mikhail Gusarov Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20200426210956.17324-1-dottedmag@dottedmag.net> Signed-off-by: Laurent Vivier --- chardev/char-serial.c | 2 +- include/qemu/osdep.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/chardev/char-serial.c b/chardev/char-serial.c index 5b833ea0773b..7c3d84ae243e 100644 --- a/chardev/char-serial.c +++ b/chardev/char-serial.c @@ -53,7 +53,7 @@ static void qmp_chardev_open_serial(Chardev *chr, =20 #elif defined(__linux__) || defined(__sun__) || defined(__FreeBSD__) \ || defined(__NetBSD__) || defined(__OpenBSD__) || defined(__DragonFly_= _) \ - || defined(__GLIBC__) + || defined(__GLIBC__) || defined(__APPLE__) =20 static void tty_serial_init(int fd, int speed, int parity, int data_bits, int stop_bits) diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 20f5c5f197d0..ff7c17b85735 100644 --- a/include/qemu/osdep.h +++ b/include/qemu/osdep.h @@ -379,7 +379,7 @@ void qemu_anon_ram_free(void *ptr, size_t size); #define HAVE_CHARDEV_SERIAL 1 #elif defined(__linux__) || defined(__sun__) || defined(__FreeBSD__) \ || defined(__NetBSD__) || defined(__OpenBSD__) || defined(__DragonFly_= _) \ - || defined(__GLIBC__) + || defined(__GLIBC__) || defined(__APPLE__) #define HAVE_CHARDEV_SERIAL 1 #endif =20 --=20 2.26.2 From nobody Sat May 18 07:09:01 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1588594350; cv=none; d=zohomail.com; s=zohoarc; b=UPJ4nivyUwERhRbhIhalr1gwDV1Ootqr7IbkTbcCRnQUV510pcs/uuwsMc9oXykQqSALuvD4s1wbH3Grm3lIT1Gftp0NWlW39EJMk2wg+Hj/gdkMS9hhZKUHUMEqEalwlP8nxyOOtPXNN36uD+adtSEG1VYeDPCHLhZFf17Fcec= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588594350; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ohbIPQordbPoDqVDOhJocD8dKa8es2UCGCm7LtBLYjY=; b=E4kipq/X4Lh5+lEy8h6T6LaqDfsQlV0l8VjVmCAVX0GmsyFk8Doc9ADNWejkdp5xfygxoDzDn3Kjyh8GWUoencRs4x2xiMdHsAdj5BAq7cRcm33TWAQNIqoVhWyxTD9ilPV7qPoDxoKZhrzzbUbESAXMfWiQ6jB9DTFjS3mBa+M= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588594350662963.6761331305524; Mon, 4 May 2020 05:12:30 -0700 (PDT) Received: from localhost ([::1]:45362 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVZxV-0005L6-70 for importer@patchew.org; Mon, 04 May 2020 08:12:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52050) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVZjr-00035e-UQ; Mon, 04 May 2020 07:58:23 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:46785) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVZjo-00028z-TH; Mon, 04 May 2020 07:58:23 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1N8XDT-1j1JFE44Kf-014Si3; Mon, 04 May 2020 13:58:14 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 11/20] Compress lines for immediate return Date: Mon, 4 May 2020 13:57:49 +0200 Message-Id: <20200504115758.283914-12-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200504115758.283914-1-laurent@vivier.eu> References: <20200504115758.283914-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:wYnk4vWOlgTtlHnIFo0rRCQ8QcF1UrGGnMVNrzZXwL2/Q4XJ14P v3QnL+h1N9163JYXJdFWgin7dPF9X6BQYgkLRA8KQCNZIs3HkgQM8e1caBI2hs9pzbyHAAP w17ghkS/+7oPHI1m2WnbwZAHccuUVMvXigMmgxnotFicqfdRQizJSeYh0JYfxgyA6xjOvX6 LY3Vs8WGWiIm5Hg0eZ6Dw== X-UI-Out-Filterresults: notjunk:1;V03:K0:t/7b+5QkGpg=:EDaEgGyQI8ThhafOVj5yiQ pkzUWbPCVHIbIKXXReH8yH/YuxK2dGkAH6gKnk1rdITyHb/tSED++QIY9igYA4LGxS8PTn1JO gvTePLgAhUlod+l7q/TT9I//y+pPf0PtTFvubQBY1O3IjgbSlW65/vSIvAB6GEG0WZqILuCRW Ud/xIN+6smb1Q97Hqj2OlE3uA4nvTbdymxHPe5Lju8Gzc/dkyCmvtOfZKyAsN8eA80Oysmm8Z IkPPFcFIaNhoAq4SdOE2X0aPh/2gpAB+jihhmTXSlIduWRE4NMnUMRrKoYqjNXVmAMSFIM6N5 r1PU/m89fbM3UnXgkexpj+Oo7ocPLfoAvf1s+bEVLUEHdDM0HSIgadGQ9YoAEqYUQ0qkScDgf RSh7Q7oy8EJ6zWTYNetxElpvkqmFaLMX/ePsuBglDq6DqFn7CiBbVOsQDR77bKWCECBWsF3Ew W+0cCail8Ai+Ils4kc2PkeJxXUTWelmP/7dBBG4iMwA70sieUaQf1ayexpjsN5cYT5+AUr1m7 x4A4H4mpjsiJd2c+PG9GH279XeRNZ1JVZxiZdjSEJwEONaBJgXrTHFxG2LtVJTM3NxjcNU3OB EiiVmlRw7DsabczrXKs2unfzlvFclxl5CQvd8bCwCHmWR2fi4zRqe8MYXDZCCEZK344UqLbXJ YMSlP8JzocE97vbTEgub+Rs0G4dI6Sn9y3jpiG+/OIzk+HRiqcs7EvRMC2Y5ry/5XxmsFOZ5C ne96HEwdL4OCzxlA7fv61gguT2dsCjHSm3tJdczyVilTgQSUi2Y4y2DldwcnOrfI7cJ8n3m8h ryXeLHikwcCyLCxuGSHPXi8Lu8vuD7G76vjU3sO6PofldkGSp4G18rPB4mdAZMfdDJuOUrV Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.17.24; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 07:58:08 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Simran Singhal , Michael Tokarev , Laurent Vivier , Stefan Hajnoczi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Simran Singhal Compress two lines into a single line if immediate return statement is foun= d. It also remove variables progress, val, data, ret and sock as they are no longer needed. Remove space between function "mixer_load" and '(' to fix the checkpatch.pl error:- ERROR: space prohibited between function name and open parenthesis '(' Done using following coccinelle script: @@ local idexpression ret; expression e; @@ -ret =3D +return e; -return ret; Signed-off-by: Simran Singhal Reviewed-by: Stefan Hajnoczi Message-Id: <20200401165314.GA3213@simran-Inspiron-5558> Signed-off-by: Laurent Vivier --- block/file-posix.c | 3 +-- block/nfs.c | 3 +-- block/nvme.c | 4 +--- block/vhdx.c | 3 +-- hw/audio/ac97.c | 4 +--- hw/audio/adlib.c | 5 +---- hw/display/cirrus_vga.c | 4 +--- migration/ram.c | 4 +--- ui/gtk.c | 3 +-- util/qemu-sockets.c | 5 +---- 10 files changed, 10 insertions(+), 28 deletions(-) diff --git a/block/file-posix.c b/block/file-posix.c index bf09ad8bc0d0..8fd8c27305cc 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -1631,8 +1631,7 @@ static int handle_aiocb_write_zeroes_unmap(void *opaq= ue) =20 /* If we couldn't manage to unmap while guaranteed that the area reads= as * all-zero afterwards, just write zeroes without unmapping */ - ret =3D handle_aiocb_write_zeroes(aiocb); - return ret; + return handle_aiocb_write_zeroes(aiocb); } =20 #ifndef HAVE_COPY_FILE_RANGE diff --git a/block/nfs.c b/block/nfs.c index 2393fbfe6bcc..18c0a7369454 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -623,8 +623,7 @@ static int nfs_file_open(BlockDriverState *bs, QDict *o= ptions, int flags, } =20 bs->total_sectors =3D ret; - ret =3D 0; - return ret; + return 0; } =20 static QemuOptsList nfs_create_opts =3D { diff --git a/block/nvme.c b/block/nvme.c index 7b7c0cc5d673..eb2f54dd9dc9 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -575,11 +575,9 @@ static bool nvme_poll_cb(void *opaque) { EventNotifier *e =3D opaque; BDRVNVMeState *s =3D container_of(e, BDRVNVMeState, irq_notifier); - bool progress =3D false; =20 trace_nvme_poll_cb(s); - progress =3D nvme_poll_queues(s); - return progress; + return nvme_poll_queues(s); } =20 static int nvme_init(BlockDriverState *bs, const char *device, int namespa= ce, diff --git a/block/vhdx.c b/block/vhdx.c index 45be0a43218c..aedd78260455 100644 --- a/block/vhdx.c +++ b/block/vhdx.c @@ -411,8 +411,7 @@ int vhdx_update_headers(BlockDriverState *bs, BDRVVHDXS= tate *s, if (ret < 0) { return ret; } - ret =3D vhdx_update_header(bs, s, generate_data_write_guid, log_guid); - return ret; + return vhdx_update_header(bs, s, generate_data_write_guid, log_guid); } =20 /* opens the specified header block from the VHDX file header section */ diff --git a/hw/audio/ac97.c b/hw/audio/ac97.c index 1ec87feec0cb..8a9b9924c495 100644 --- a/hw/audio/ac97.c +++ b/hw/audio/ac97.c @@ -573,11 +573,9 @@ static uint32_t nam_readb (void *opaque, uint32_t addr) static uint32_t nam_readw (void *opaque, uint32_t addr) { AC97LinkState *s =3D opaque; - uint32_t val =3D ~0U; uint32_t index =3D addr; s->cas =3D 0; - val =3D mixer_load (s, index); - return val; + return mixer_load(s, index); } =20 static uint32_t nam_readl (void *opaque, uint32_t addr) diff --git a/hw/audio/adlib.c b/hw/audio/adlib.c index d6c1fb0586c6..7c3b67dcfb8c 100644 --- a/hw/audio/adlib.c +++ b/hw/audio/adlib.c @@ -120,13 +120,10 @@ static void adlib_write(void *opaque, uint32_t nport,= uint32_t val) static uint32_t adlib_read(void *opaque, uint32_t nport) { AdlibState *s =3D opaque; - uint8_t data; int a =3D nport & 3; =20 adlib_kill_timers (s); - data =3D OPLRead (s->opl, a); - - return data; + return OPLRead (s->opl, a); } =20 static void timer_handler (void *opaque, int c, double interval_Sec) diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c index 0d391e1300aa..1f29731ffe11 100644 --- a/hw/display/cirrus_vga.c +++ b/hw/display/cirrus_vga.c @@ -2411,12 +2411,10 @@ static uint64_t cirrus_linear_bitblt_read(void *opa= que, unsigned size) { CirrusVGAState *s =3D opaque; - uint32_t ret; =20 /* XXX handle bitblt */ (void)s; - ret =3D 0xff; - return ret; + return 0xff; } =20 static void cirrus_linear_bitblt_write(void *opaque, diff --git a/migration/ram.c b/migration/ram.c index 04f13feb2e77..06cba8863280 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -2135,9 +2135,7 @@ int ram_postcopy_send_discard_bitmap(MigrationState *= ms) } trace_ram_postcopy_send_discard_bitmap(); =20 - ret =3D postcopy_each_ram_send_discard(ms); - - return ret; + return postcopy_each_ram_send_discard(ms); } =20 /** diff --git a/ui/gtk.c b/ui/gtk.c index 030b251c6109..83f2f5d49b2a 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -1650,8 +1650,7 @@ static GSList *gd_vc_menu_init(GtkDisplayState *s, Vi= rtualConsole *vc, G_CALLBACK(gd_menu_switch_vc), s); gtk_menu_shell_append(GTK_MENU_SHELL(view_menu), vc->menu_item); =20 - group =3D gtk_radio_menu_item_get_group(GTK_RADIO_MENU_ITEM(vc->menu_i= tem)); - return group; + return gtk_radio_menu_item_get_group(GTK_RADIO_MENU_ITEM(vc->menu_item= )); } =20 #if defined(CONFIG_VTE) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index bcc06d0e01c7..86c48b9fa5de 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -765,15 +765,12 @@ static int vsock_connect_addr(const struct sockaddr_v= m *svm, Error **errp) static int vsock_connect_saddr(VsockSocketAddress *vaddr, Error **errp) { struct sockaddr_vm svm; - int sock =3D -1; =20 if (!vsock_parse_vaddr_to_sockaddr(vaddr, &svm, errp)) { return -1; } =20 - sock =3D vsock_connect_addr(&svm, errp); - - return sock; + return vsock_connect_addr(&svm, errp); } =20 static int vsock_listen_saddr(VsockSocketAddress *vaddr, --=20 2.26.2 From nobody Sat May 18 07:09:01 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1588594494; cv=none; d=zohomail.com; s=zohoarc; b=Q7WAB05yjm+VNUCMGpGv3mddM6roxzRklpOrqE1nR1uhzdyhSsqShWPk0IAmeWcTFNF/TAqHzqcZMD5zpVUFtN4JnNL8Yx0oeqpZe+XEtfe9VT7WBZuHsTH5JtEcrYrj2XHo7b2rCIgrthkF4CWNgQvdYkab9aaBOB8jZS8+DOc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588594494; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ljGUBXmtFJTFh8iET2P4+kNF1J1dnoutD9QHOmV9HV0=; b=CeQb0iMaVv0AnXu+Y3qqt/9kPsg8JNL4ZBqH4HQ02hYVkE+yMmTuLETQYxc02dMgzwHeQyTcpSwQ1EUtnakDX2UxCg/Zp+tRTv6OIGW2uustuEcQ8jMPpr6B86NXtw32B9WVmEq5Jo8HvAoHdhbdibd3eJoHsKsyHy8F9bnhh+U= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588594494240896.1274678657486; Mon, 4 May 2020 05:14:54 -0700 (PDT) Received: from localhost ([::1]:52480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVZzp-00008A-0G for importer@patchew.org; Mon, 04 May 2020 08:14:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52070) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVZjt-0003BS-Vg; Mon, 04 May 2020 07:58:26 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:53973) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVZjq-0002Ia-L3; Mon, 04 May 2020 07:58:25 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MsZif-1jHDHZ2zWd-00ty41; Mon, 04 May 2020 13:58:14 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 12/20] block: Avoid dead assignment Date: Mon, 4 May 2020 13:57:50 +0200 Message-Id: <20200504115758.283914-13-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200504115758.283914-1-laurent@vivier.eu> References: <20200504115758.283914-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:03Ne1koK0HaDqr7XUYO5Az/zXyQGSOVXkNfUdTSsTFAQaOqrJ/C 0CQUOCkrCLo+5MUw1MsCdEGaPwJmxgVO1i4LZy9hgBkMSnNzCTC6XHEFhI6N3L22Xd7Z3Uc eavPtNqExSvODzxEqrcynmQyOtrQIZbl7jY3QFCxR8NWsaWVGyLYuHX3KkbDVyLPJ433jIk Us/qW/oi/4QQyyStn8zlw== X-UI-Out-Filterresults: notjunk:1;V03:K0:OSJn6/64oNE=:7gJq+oN4AFSNitIRtBwkJm oFMAsPOA/DRbPjrdgqWVWw2cuc1T82ViK6wa+ZvYFgCWgn9DhHpD0IJ9WaWAyxiFI8wqEFJsM wjFccASv9E4KP/yHUpedREy2oKkHzQP5+YRV7nc1ErA0b81UOA2zRISyNwUNn1GFGhrGtZzEp Ob8EDptQSdLl1wlWyfq0AY/uC91lingK+4r/0xm2oIRCnhFvxOZyAYFlLQdVu1bq1INRzboWd pNySifc7V4Xsilc8pBJPbkaZ5jK5C5/rUDuABZODGsGfNbiEjbqMurMxT4C+ZLI5zKfY/4F2O +bScd0TZnHl/8q67SzNnHJYrDasqyW2XTzUbPtuEiub2JQVDObCgEjamc26leRC6tHnL6EYva pXRC6AMKs2Dxeb/Fg/EggvdvDDlpaukSdX+rxRTynYVXc++gcnXQe87zSZ2M5EGxEXrSz4YeK VVhIrLwbM+/82hu1akVvivibeJLqZCEUTv2r63ac5MtkymOoXgG0tSCkBhEjTsFKprj8Qdo4M wWXv4k4/RS/osJqTE+FTO5gpSr3e6v9a94ZZfcHs10ZensCwQzulWRm4eCrLbFyTs5EtUyTRn 0VVwvBW9ptNpVFBBBhENBDyXh6V5jVzp8dGW34+jvyI9KToapdMzUcxyHH+Rqk5rbgjoIe/0u F2vY8uc605aW/LwPBbwP/Nec71fKISzbAx7JjscvxbnSaHDqwee8NwIV8zm7fAQfzxD9QSM93 xgvGWxYyD7uDbd5BnKAtyBiOroQLms9UbdEBJ6QZ/UQwA1OqyIsJvWt8MXe6otuaJs4rGUCu3 o3/2/yKUDBRtbwLWZ6RRJlHsUQhI/roAjZ8gBgmNmI6SzMExa5SdDzHWMYtjv8QCLfx3Fk5 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.17.10; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 06:04:59 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , Markus Armbruster , Alistair Francis , Max Reitz , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 Fix warning reported by Clang static code analyzer: block.c:3167:5: warning: Value stored to 'ret' is never read ret =3D bdrv_fill_options(&options, filename, &flags, &local_err); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Fixes: 462f5bcf6 Reported-by: Clang Static Analyzer Suggested-by: Markus Armbruster Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Max Reitz Message-Id: <20200422133152.16770-2-philmd@redhat.com> Signed-off-by: Laurent Vivier --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index 301ec588bda2..cf5c19b1db49 100644 --- a/block.c +++ b/block.c @@ -3165,7 +3165,7 @@ static BlockDriverState *bdrv_open_inherit(const char= *filename, } =20 ret =3D bdrv_fill_options(&options, filename, &flags, &local_err); - if (local_err) { + if (ret < 0) { goto fail; } =20 --=20 2.26.2 From nobody Sat May 18 07:09:01 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1588593731; cv=none; d=zohomail.com; s=zohoarc; b=FZz9jRrfSKz44vR7p0HDeGTNhAHoR514ly264PbO7ghaiBAToievIUw61gAdXxpCvZGJn7Fp2J759d5pPZqir+/PEqx5tdCxnAIbc2y9Wb0kecnjzZjOhbu6wXShEmAm4UResaIee3jXm9c/tNOkgy+i6MLpTNlsg/FJnYbGdnw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588593731; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Gw8ga+HBpzgcPhkQvm0s4/ETgPZQpzdto6xZDUzqx38=; b=d9C/+lHirwINWQoC20N5s/YcS1uTODNnuPfHS4bbPzCl911YX8toyz/PzwqfVMSBtpxc6Wh+iykq3DUJy0SgEv1isM6EXVvGodGLbhn/5NVwUCKwEglTxgGK6reAcQ6K61Y+AMDnE+0kEl1odXXBh4gzjFyVd8OUOuMvIS2/5HU= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588593731747105.49515877820318; Mon, 4 May 2020 05:02:11 -0700 (PDT) Received: from localhost ([::1]:39778 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVZnW-0007qd-E6 for importer@patchew.org; Mon, 04 May 2020 08:02:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52022) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVZjq-00030D-3B; Mon, 04 May 2020 07:58:22 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:33173) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVZjo-0002Cl-RB; Mon, 04 May 2020 07:58:21 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MCJvA-1jNMH71Nv0-009S6y; Mon, 04 May 2020 13:58:15 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 13/20] blockdev: Remove dead assignment Date: Mon, 4 May 2020 13:57:51 +0200 Message-Id: <20200504115758.283914-14-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200504115758.283914-1-laurent@vivier.eu> References: <20200504115758.283914-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:IrQCQUvJnCBMuzwPerB6rAw1jQmYN+bT1Cvx+93KqSD86XtX9sQ O5tJv1kjfJE1EIvQLnqXJR4MeUnxKk7fuFM8qhXnZJ9I43ZqkMf70Wh2GI4ECjxtJxpI49H VBCfemjnhy0G9v1VPjRA3b+yClFsawGAizCZXY10edquG5mJB0uYHxrWUuipNDPz3gdCJ1n z3F9cUQh3S2RtXsMRAvGQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:Y2mFQFLM/B0=:lwMeXtxT+sVjvIhZR3sI3D 7dy3wEAM/yRCtRw3vAjQZldLC4OQ4Og4qiR7201APxQoPyfd50e5qPD3iyp81E9OxpRG2cdpx I1fAGYBRQWU1aieUdWJBLrBeE6wEMe8D/CHJWPhhxEHWyA2ijyqrin20ZazdHbgH8youlignk xP+G/s/3D82tE9EsNWH15oIgmHmYiivIISYzvNDe0cEWIs9SFhWrqKJAj5KYDA2CxXgaPHdoF oHUFQYNQdUw56M5XSSkrb+h24qXZb7j3gYp9OIkcBQJ7N+U3Ky5TnNZ9fr3nYKw8IOoH9Wjs0 eVD+EQm6UdFsP6U7mY8DYHpp40JgOpb+a+sqxbGtk3XMXMRX0sjSGIbdnvhLtOd8zme8h8nuk +ybK0sNdOvpXYvGTvP128vL8t2CXNLoMLFwzJnOaFTBLVG6Ry77MZjXlzbfpOAhkbvoOJu406 SAp7hMyTk4YwV9cxKXPCQxmYsEhm6nO9Czxith1U7vE2uXXrse4X8K3mmGxwPcN4B9kFpRGaq OLSlFM4tQWP8pjX+nEc5DKOPeK7VTKJZLJ0K5jgcIqf/fryVIoNlg3U7AOg3Yk8YrBgSYg7oB wBmL4+Bc3NvKFgHu1G0LhGr3xfZM0iesCG0rRyQseussc3GDIF/MrKC0QmXGd1Sr+TMdsvqob 1dCoHCwmDZzi+rNwjD4ovhhUVSWEKCsuNlpe9npLWBKkOpVzyEn96E8qUN0alxjuOpBi9KtTA oXmx2oCCkaym/dQNgocSTTr4jbCyLrOpF4teIUX8uUybUsdfPlEPsA5zCNUxBuSgMXFwffKxZ O3S9BUWG/G+Kc8zStUgj3rIzGcuanmb18jbbGbAbu7mcPbVX0erLCedxreDSM+gVBLJPMEc Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=217.72.192.73; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 07:58:12 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Michael Tokarev , Laurent Vivier , Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 Fix warning reported by Clang static code analyzer: CC blockdev.o blockdev.c:2744:5: warning: Value stored to 'ret' is never read ret =3D blk_truncate(blk, size, false, PREALLOC_MODE_OFF, errp); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Max Reitz Message-Id: <20200422133152.16770-3-philmd@redhat.com> [lv: fix conflict because of "Add flags to blk_truncate()"] Signed-off-by: Laurent Vivier --- blockdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index dc1a0c7c2fd4..708d0c323fd2 100644 --- a/blockdev.c +++ b/blockdev.c @@ -2741,7 +2741,7 @@ void qmp_block_resize(bool has_device, const char *de= vice, } =20 bdrv_drained_begin(bs); - ret =3D blk_truncate(blk, size, false, PREALLOC_MODE_OFF, 0, errp); + blk_truncate(blk, size, false, PREALLOC_MODE_OFF, 0, errp); bdrv_drained_end(bs); =20 out: --=20 2.26.2 From nobody Sat May 18 07:09:01 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1588594105; cv=none; d=zohomail.com; s=zohoarc; b=K9dDbyxzHciM3uqVaGgIutdleXX6i/aokz6y3klufM5QmDDDZwqHkppY1OLDlySEASq4mbfpQdFVQKtuB1a+gnikAXXDA0NNiqL6zorG8C2WJRapMzFrvo45ASi/XLof4yNVHHn0oFfuhkw6zK/IBsNO5743t+asju9ThWU28Hs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588594105; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4RLS+D/dgpyNrM7qs3n9PgchuawyF62j3KUqzaUBWtM=; b=KkfJ2/Ng5W2QWDmFaTxHxCTnpk4sUaqBRnumIilDwYt60JEWkSvSLjCm4DhLS6xM6jVbb05Aa6/Hm1N+gPzGE543/VfEEnh77Z/2tdkfdE+zVQUmRfRjkntm5ObJ6IUTy/jtF2jrRQumkvPVo+jeNMQo+cLpMCKzyiFdVPKzzW0= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588594105104596.5807854118146; Mon, 4 May 2020 05:08:25 -0700 (PDT) Received: from localhost ([::1]:32872 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVZtX-0008Fn-VD for importer@patchew.org; Mon, 04 May 2020 08:08:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52058) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVZjs-00038T-SD; Mon, 04 May 2020 07:58:24 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:58235) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVZjq-0002ID-EY; Mon, 04 May 2020 07:58:24 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1Mna0x-1ip83G3zJl-00jcTf; Mon, 04 May 2020 13:58:16 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 14/20] hw/i2c/pm_smbus: Remove dead assignment Date: Mon, 4 May 2020 13:57:52 +0200 Message-Id: <20200504115758.283914-15-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200504115758.283914-1-laurent@vivier.eu> References: <20200504115758.283914-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:lAdcSX0kajxnl05WjULUUsCSNLGK9FItQz984ooxQyMQ3F2VPXe tP2kTCLf1i7xGJL6rHvLRWjRV0vrBeoYerXrvt+t0jxSbV05ACXHngJrc9qQRkXtiHw4o6d nFW4ITSXkFBpj7hBZqJBRz31vumaMsKWJhm6VqXRQxT/7DQ/V6laMHNRbun9f4+JHcEb849 M7D2l/ulhZwt0yjCVoxrg== X-UI-Out-Filterresults: notjunk:1;V03:K0:GbPX6t2rIxs=:a6/vmlwAKH50bZFZYh7e8+ UCnVb5hrzq9WKE1jsF3wEgP/pZv0hruh9jX33wgSKGxDO6sb145St1c0DCejA3Wq61IKiyuoz BvBxlK5/ItUi6NcGirc0wv891RKFRgkIr4gMWyOEP+1XxeObA0mnUdwq4qGvIBFRz3bfsVg8Y prFvK0F08fZVti82dQ+M/YpRCo5Gk0q2HvM2PKMkUE2AQz2aPrx69Jy1ph8c9va3grWtAjC+V eOkwuM3nxt7t4udiqBIG0u5nzM1EGJZGfznDVXgJgUx2DfpOSRM2srpUMRMRu9rc+2NO3sGry L5ffMB0Cv2fg4505aE7kWu/Uze+fWyL43TRMf8lUFYLwaqjYq100J/wIfDL/kfDVvOvDsnA2H xSRMcAzQ5iEarkruRlxYup3/Pf+WkdLy2faTsxBcy12CutEDkqVJxwfpsEwT0PWA+zd72GShe +tvCzn5yPL7EzlbF8/nowJYiJy6ShQXj8BitXgX8xWBwXBbBrB4wBlEKpS6zOHOeiKvanc7Qv Uc499rhCPlD59wNlqqnhR2pSwYrTi+X8xJh5kJGEeVbPMNkydKB6m3tAB1qC0ehsvHQQs6N9x ohDhNtxUQUDLvn0eHa3UCuX2L6b+n5ldGN/PG8I1fBm8HP8RnSdw5CDBrz7Npaz9tsvG7Qpi5 CHFXxUvVMSPzOu0AhUM7x9CuFo+WnKpCBP3D/gClbhKC8RmGcY6SGpyXsU3LBmDf9Zt/ADcnG Q++cGg35BeERxm73PP+YtgvUaNSYcugQPNANAV31720DAmO1S2FJ4clQCgn9ELEIOr4mS9YfM srNMe0BkFPfqsgsL7mK/ymhagRPQUXRZB0ATXvwxs0zfFgH9kjkxMbGgcHxJcuBiHlPEa+i Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=217.72.192.73; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 07:58:12 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , Michael Tokarev , Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 Fix warning reported by Clang static code analyzer: CC hw/i2c/pm_smbus.o hw/i2c/pm_smbus.c:187:17: warning: Value stored to 'ret' is never read ret =3D 0; ^ ~ Reported-by: Clang Static Analyzer Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20200422133152.16770-4-philmd@redhat.com> Signed-off-by: Laurent Vivier --- hw/i2c/pm_smbus.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/i2c/pm_smbus.c b/hw/i2c/pm_smbus.c index 36994ff5857c..4728540c37e6 100644 --- a/hw/i2c/pm_smbus.c +++ b/hw/i2c/pm_smbus.c @@ -184,7 +184,6 @@ static void smb_transaction(PMSMBus *s) s->smb_stat |=3D STS_HOST_BUSY | STS_BYTE_DONE; s->smb_data[0] =3D s->smb_blkdata; s->smb_index =3D 0; - ret =3D 0; } goto out; } --=20 2.26.2 From nobody Sat May 18 07:09:01 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1588594957; cv=none; d=zohomail.com; s=zohoarc; b=avvRVXuwVBCqktjwxiGhzxoQvQAPZcNVS2buOXvDitSkpKP/+S2STsKrwKnAK+5yOH8TZK8NQVDFb/M6L0s5TivuFVBEolbIamggUbBo6At2YfZVKU96J1D72hwE7Lfqiudfk4VKKRNQT0GqoGCzY6ohEkLtSel5PMI2PYRIE3Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588594957; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6vJhrttUsAzQWjjSEsvY61qOkyolZr6K31D3JXA0msg=; b=KHAE4lTVP+Z/1UDZp8WhIXifNGC9tq/Q3KFKnqOXBMNe2EgKLPSO+oYZ2mD8cmwuVtZ1tI+FsRtViITTLbXosMuxhS+vcSy97bB3RL9gOaySmFwSDd42bXGY1ZjRBDABog7e4YiHpOG8YqFGiFnIIMYPdnk0xsNS1wdcFTSOGIQ= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588594957640376.63798276858574; Mon, 4 May 2020 05:22:37 -0700 (PDT) Received: from localhost ([::1]:42802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVa7I-0008BY-Dt for importer@patchew.org; Mon, 04 May 2020 08:22:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52102) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVZk3-0003Lt-Kr; Mon, 04 May 2020 07:58:35 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:34201) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVZk2-0002Lm-EZ; Mon, 04 May 2020 07:58:35 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MNtjq-1jl4JV2sAa-00OE4o; Mon, 04 May 2020 13:58:17 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 15/20] hw/input/adb-kbd: Remove dead assignment Date: Mon, 4 May 2020 13:57:53 +0200 Message-Id: <20200504115758.283914-16-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200504115758.283914-1-laurent@vivier.eu> References: <20200504115758.283914-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:hsInISMjZejKFc62NlpU9zM5vQXucwUAa8UscLt3PndFE9WJkyK ordHkV3voxT9Q7M4Bn28UJTjwBxcLVM6lDP+5eqNoJCwuQvMRwfsuHoBysHciRoajIy3uOn x5kTEp4/ESd1daJvO3kX1Lps5whX741dgFhpmprWTQ4TM6P7sFR+SrGI3JeeyjzdLtMz5tm Sw4ni9SIoLb1Br2JlMYEQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:pr5xlVTbTMc=:+GCZhwc2vN6rcl3tyWabAy pLi2IWhCnUji0x2fGqrV6I+R0j/5IfmJafRtG9J/Syg5R0b7CfzD/sXYOS2/l1vUCtvmUX8dT 7se5Nl7cdZNIOmswjwIgOa2Jwv3TD4P/qD2vzbY4vrnh6gvCvP37wQPKmYWee6Z/787pdSaKs TXVZg8dbgwyhDjd+koNvXcGK3Pv8gRqjBvyuxQfwuLZfrwldveV3xzjnWgosQOgdZ77cQW7Tr ZVFC1KYNIiYU/EAlnneIVrb7yzrl15M/V2UUVyc+TDp3MHc79dssgIEm6w28pxVfYFTifR22q Fe5qeQpjeeUOLEMVLrhy2KnzwF/tselF36hnSNqXe0UzbqEQe+MH6v3r9ABwx1BjcJOnWbdqK LA8ABb0XMjScPkPqz9thAT1kFAE55i2JB7QPQSOGbdYOb/QVlr9y9uBrBO6hlX/Qwf3eY4dmW Ly6aZVMm2Qh9yVATYm97dpxPypDhSE3Z92mkDIk96DQJwoYK3CA5xOxI/NlOlNVjAAnkjfmC2 uUSzl7U7TJLHZ7hgz6yeMPT1iNCK35BJjfKR0v6FhUSpe/08GsycYdwNVKmyNfIkj4/Rqav84 zOtmikx/C2cLxiHIue9dsTinIIuNobqUOLitKctsf9akcJ6m6E/oxTgDGbAGA72u1ZkaqGlBX 3jkNBDfd0R6/DcqmY0D5aaWzPkgNTBsxlsckycdeukVaYdxv8ITFGcEaEGzUaKgY+GPNFEMQ0 nndhS7swfRirLnLP9bN9CE+DhgufgjZpqvAGpIT5EsGFzxl9sLJbQUfefryyN0nRp0WF1OOqs 2Ab2AGm+PTwBJ0xf5BiJnszZHoZhut8LKch/KaZS+VmsQ0vlYglFW44b1KSoEl+xEGXYKvt Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=217.72.192.73; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 07:58:12 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 Since commit 5a1f49718 the 'olen' variable is not really used. Remove it to fix a warning reported by Clang static code analyzer: CC hw/input/adb-kbd.o hw/input/adb-kbd.c:200:5: warning: Value stored to 'olen' is never read olen =3D 0; ^ ~ Fixes: 5a1f49718 (adb: add support for QKeyCode) Reported-by: Clang Static Analyzer Suggested-by: BALATON Zoltan Acked-by: David Gibson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20200422133152.16770-5-philmd@redhat.com> Signed-off-by: Laurent Vivier --- hw/input/adb-kbd.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/hw/input/adb-kbd.c b/hw/input/adb-kbd.c index 0ba82075897f..a6d5c9b7c9ac 100644 --- a/hw/input/adb-kbd.c +++ b/hw/input/adb-kbd.c @@ -195,9 +195,7 @@ static int adb_kbd_poll(ADBDevice *d, uint8_t *obuf) { KBDState *s =3D ADB_KEYBOARD(d); int keycode; - int olen; =20 - olen =3D 0; if (s->count =3D=3D 0) { return 0; } @@ -216,7 +214,6 @@ static int adb_kbd_poll(ADBDevice *d, uint8_t *obuf) if (keycode =3D=3D 0x7f) { obuf[0] =3D 0x7f; obuf[1] =3D 0x7f; - olen =3D 2; } else { obuf[0] =3D keycode; /* NOTE: the power key key-up is the two byte sequence 0xff 0xff; @@ -224,10 +221,9 @@ static int adb_kbd_poll(ADBDevice *d, uint8_t *obuf) * byte, but choose not to bother. */ obuf[1] =3D 0xff; - olen =3D 2; } =20 - return olen; + return 2; } =20 static int adb_kbd_request(ADBDevice *d, uint8_t *obuf, --=20 2.26.2 From nobody Sat May 18 07:09:01 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1588594663; cv=none; d=zohomail.com; s=zohoarc; b=jFvauFWQvSwxM2QvYX9q8O/Ov+uniXyrVsZaIETYKpS7Tx/YHROB8zyHVgcOqEyBFLHORUpZLwqSd8ozvqa9HehE8xqR71CaxEawTryZeO2qN7dWaIDflXVJwxQJNXER6VWTTIfP5Kqb8puwocj4zNsfvxhKW8OywatshUKSWwk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588594663; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Z8BtmZimzJMDNZmR9u3lBaAHzvUnOlSXfCuWOpH+YZk=; b=CYcgkBP3uIxrPbdZ/Yf9mBp8gl/ReV+6zcbJ9OpTrFkfc1FOLMnKP6uLOschE9/hi4C2QUT2/qmDRFOh8LIFPlea3Af7LQePH8wzyEyyV1OIAji6PNuU4Bif/44o4TuOaVWSEEq2zzq9ohEsBO79Qs4viZcW2AyVk/7tmSMjW2g= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588594663497317.99976648961547; Mon, 4 May 2020 05:17:43 -0700 (PDT) Received: from localhost ([::1]:59530 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVa2X-0003FI-VL for importer@patchew.org; Mon, 04 May 2020 08:17:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52076) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVZju-0003DP-Lf; Mon, 04 May 2020 07:58:26 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:34947) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVZjs-0002JU-Ii; Mon, 04 May 2020 07:58:26 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1M894P-1jS0xl1PVr-005JNp; Mon, 04 May 2020 13:58:18 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 16/20] hw/ide/sii3112: Remove dead assignment Date: Mon, 4 May 2020 13:57:54 +0200 Message-Id: <20200504115758.283914-17-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200504115758.283914-1-laurent@vivier.eu> References: <20200504115758.283914-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:bMYhpdRoGq4TloRGXhT0RRzVkdA2HsVH38gxEEbUu2mBiqfL14C rte2EhtZ3DK3F+uI/Cvm/n41idenNNxJAQnBY5pTs5lpFeMOmG2Fx9D4F3SJCPDUzyV8HLu vcMgs1C9QyjCq/20MaJIBFWuHpnvNeutjXOm1CD4kgLCqIh64wySvIX/h2VmQpA7Yysa2jl BvgeAa7MVvTIllHzAUCOw== X-UI-Out-Filterresults: notjunk:1;V03:K0:s6R3vZ250Cg=:cZEQ0lRSD/yu4gi2y6GAU4 O2NPZy/PsS7BUcdfns+ith+XK5cceEgGhsPyqAQ7nV5xQ3KdoXYAOA6t4p9ikl6pJk0g0WJhW TU2ft8Z0fTgGwCDveJuSsKtWckF5Own9vSds2m+qSV85dg0tRG0GjiGfWqtxJuQN6Vp+cfj+J VKaz3ZzDd2r9Irlrg1PEdghPyEKo/XmlzERnKBrtSl1uo+G7L/a0Y3eabm2zviTs8bKEEWAfd 5EbbjDtUmtnyiOYQYhI+cxwXX/AN2V7EzJqUITiQrW5s6c77Y7RqPa1ivm7GeGSwEKUiYvgiO YD7DDfRxtNQ1zZCVk7+Q+F0RqKkji5PuzDUSdR7aG6+J8tTDuE2hmLusp3iEjgQUF6x9G02ez 3tuNLP8kmzLIsCVFdP/8JmNIzIF5rtfzoJ7md8jzwqbez3ZsnkysONSbI9Yxam//DjPQ+8gs/ DlXsLl/INGbGm6OMfUyjL0EJNX53pLL39Mk0YB3OyvgPNbMyesqUCo2UQED15zmMSOIXixaNZ UFfqVnquYpsf0b99nKQF0AdH8LLOvy9lVYK0euZpvGUREmETKjCuW+58QN0CNDq+XSpQSoGad eFVKOtyEcm1qPxjenWhGY8nOUqlSdGgYJICXL/+xrSUNzD8YQAktCienIKO1oe7kp2Wqqnmvv J2RCZvhlZkB9a85iaWceUhJy+Xl0WpH0/0jNo4tMZxBzvY+fbIw6D9b4sMwUJFQwH/UGxEg2i jWP4s5JN52pqwBgt+ylOUTz8OTRBneMDNRVZor7Zuc5TQiS/pgkDTQE3al4tI4mGCgLw8zI+X rhV+zEdS3poc+zj2Unj8SXTJ/z3O8Rba18aZ57TV/igWJNqVpOSppa06dIYFx5gk+dVoHxA Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.17.10; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 06:04:59 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, John Snow , Michael Tokarev , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 Fix warning reported by Clang static code analyzer: CC hw/ide/sii3112.o hw/ide/sii3112.c:204:9: warning: Value stored to 'val' is never read val =3D 0; ^ ~ Fixes: a9dd6604 Reported-by: Clang Static Analyzer Reviewed-by: BALATON Zoltan Acked-by: John Snow Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20200422133152.16770-6-philmd@redhat.com> Signed-off-by: Laurent Vivier --- hw/ide/sii3112.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/ide/sii3112.c b/hw/ide/sii3112.c index d69079c3d9b7..94d2b57f9535 100644 --- a/hw/ide/sii3112.c +++ b/hw/ide/sii3112.c @@ -42,7 +42,7 @@ static uint64_t sii3112_reg_read(void *opaque, hwaddr add= r, unsigned int size) { SiI3112PCIState *d =3D opaque; - uint64_t val =3D 0; + uint64_t val; =20 switch (addr) { case 0x00: @@ -126,6 +126,7 @@ static uint64_t sii3112_reg_read(void *opaque, hwaddr a= ddr, break; default: val =3D 0; + break; } trace_sii3112_read(size, addr, val); return val; @@ -201,7 +202,7 @@ static void sii3112_reg_write(void *opaque, hwaddr addr, d->regs[1].sien =3D (val >> 16) & 0x3eed; break; default: - val =3D 0; + break; } } =20 --=20 2.26.2 From nobody Sat May 18 07:09:01 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1588594422; cv=none; d=zohomail.com; s=zohoarc; b=hRfViRr6h5XHgByaOvSNFW6ap8wNWTQO8SM6lccEyDRbJ04fSdaBZsCrYm6w92xg+TvX6iK71Q+/BafRO/qh/DTG9/UiulyQm7iB7HNHdNIoZzR/JFDne5OwRKnRVgE/9R1anG/5QN6Q09wgFjZZn/SyUSLFBol+77OisERgYjI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588594422; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8UzWW0ITdJFJzIjtsvAxnQhpjAK9t/0BS0rvJPe/8Ik=; b=Wlh7hx6OWcsTt+WIrbfSjfGdmqo0kxCIpHLDE0v8ZbwiOciJxLVaifVKh9tlyeUaZShtHwpHhtGLDfWZ+G9i2wypHCz9ZKvLzvI/6ZL5T+t9EWbcGtGPY8XyYIngWhxvGtQlFCHZ62Xfbng2Uoq7SiT0n16UcKmvmiLe9lm0sVc= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588594422013290.7436057646245; Mon, 4 May 2020 05:13:42 -0700 (PDT) Received: from localhost ([::1]:48444 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVZye-0006sD-Mg for importer@patchew.org; Mon, 04 May 2020 08:13:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52078) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVZju-0003Dy-Sb; Mon, 04 May 2020 07:58:26 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:49795) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVZjt-0002Kb-TK; Mon, 04 May 2020 07:58:26 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1Mw8cU-1jFHsE3x3s-00s2Wc; Mon, 04 May 2020 13:58:19 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 17/20] hw/isa/i82378: Remove dead assignment Date: Mon, 4 May 2020 13:57:55 +0200 Message-Id: <20200504115758.283914-18-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200504115758.283914-1-laurent@vivier.eu> References: <20200504115758.283914-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:1189xm37UdNK1k0GFY7Kwh9INa2C9dyqIqZiJ5nteJeW9dspCI6 Ug7k66AL0LbDoAPNB6xnInFIcmqEDpBgA/UC7IPzNn/bYYmMk9y3LosMRt0BqLIXj5853wI oqZARO+O+YgaSlAOJx2QNEAQJeysHN/JvTo9v6NJwZSOswaIeqhLPuyofZ3MKdvGGQjnBg9 bkzn49cZCgScE55dOp6BQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:zao/5C13Mrw=:Blt4HTwKetOwahNbNu+5JW T73tXpk52G/jNRHQ4l2zcd5YyEersTe+ifNss8wVOJuHDdK+0mugrjvoQTdS63x0/0rtiAiFf 3fdbiDZHhKtiiDedqcw53DSc2zeU7UNl2jw2Ri6dyCaVe+2xSWzjO/sxB4j7Gb/BLR2eEXbBm fTU6n/rEj1Q90JJukEOJMTE1+yda8Bo99w7wuWAVqpCESo7D1amuZsyg0CnKElRSaxw1ArrK2 RSG3BWkctGcwi+A+a4vMJUUAfRSRMZR+RFcYz5X966eXPArNd+GCuEBZYyQfPpff5g2j36jEd TAENBZXVJfH4kmU0e70gZiL/l6TXzyXCRP6jTdfs3dyzlwR7OPXEGlayaBZPxgvjbbSMpzMvM oZE4qyuAYM72X7nPFdIaz/zN6PdGVzvB3zXlmwA6QUVTS4KSSpWzHU0rVgWc9WnRAR+W5nyGU PLaWnrCkbfBkvjQBlQrjBSY6o1pIe4YG+qiOwczG7HctTGdP5Egnk8ZHbh4vxZ1c0Lbf6adys 79gIK4qzeaaH7bYpPsAqxSKdph4fYPSJ+Wq+HUDJpny+6mMqPNBVfjfPi9hgN7Sj915QOlx/G DMVmbKBAMIF1iPKREKivdrEb8AUc1rHWtcTSnZOH2XynYXmi14zTbBS3KsjJgSw8QmNDlrgG9 CO6a/eYB0zqmcoIS0nw/mX23yz3SuI9gBaPHCOm2LTFniS/6WhhIyrGEjSnrpy8/ZfCY3Erp7 qrS8GUkCNNQ6zZNAufVS0yp/oel2HhO23eEOCDsj7W91LIOOyEhdIe/5s6qA9WEpacKXuK/d3 6zHTqA8aN3jS53lFIVFMDqmTbR/ohuyBNiOsjgXjRP8rAkiC0zTe6xxd1StO12IRifq8/mY Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=217.72.192.73; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 07:58:12 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , Michael Tokarev , Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 Rename the unique variable assigned as 'pit' which better represents what it holds, to fix a warning reported by the Clang static code analyzer: CC hw/isa/i82378.o hw/isa/i82378.c:108:5: warning: Value stored to 'isa' is never read isa =3D isa_create_simple(isabus, "i82374"); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Clang Static Analyzer Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20200422133152.16770-7-philmd@redhat.com> Signed-off-by: Laurent Vivier --- hw/isa/i82378.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/isa/i82378.c b/hw/isa/i82378.c index dcb6b479ea0d..d9e6c7fa0096 100644 --- a/hw/isa/i82378.c +++ b/hw/isa/i82378.c @@ -67,7 +67,7 @@ static void i82378_realize(PCIDevice *pci, Error **errp) I82378State *s =3D I82378(dev); uint8_t *pci_conf; ISABus *isabus; - ISADevice *isa; + ISADevice *pit; =20 pci_conf =3D pci->config; pci_set_word(pci_conf + PCI_COMMAND, @@ -99,13 +99,13 @@ static void i82378_realize(PCIDevice *pci, Error **errp) isa_bus_irqs(isabus, s->i8259); =20 /* 1 82C54 (pit) */ - isa =3D i8254_pit_init(isabus, 0x40, 0, NULL); + pit =3D i8254_pit_init(isabus, 0x40, 0, NULL); =20 /* speaker */ - pcspk_init(isabus, isa); + pcspk_init(isabus, pit); =20 /* 2 82C37 (dma) */ - isa =3D isa_create_simple(isabus, "i82374"); + isa_create_simple(isabus, "i82374"); } =20 static void i82378_init(Object *obj) --=20 2.26.2 From nobody Sat May 18 07:09:01 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1588594346; cv=none; d=zohomail.com; s=zohoarc; b=ap/qDlORey4vSVZKbNT/Poz+WH00+KUgaTfyw4S7K6yI1bt5W4XOqee8siE+7ViV8qzYd7NibNr9JamVt/F6HQ9rBR8euHTObGXY83+VRuWB2HGW7WGHoBKmTYBSHb8R/ziS7ce58e3aj0FQemstyyEF4AZWDknvtoJ7odeb2LU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588594346; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=SJlgqYVtkU+Y7gl70XVolSVeJNhztaz8rd5/INhtkqU=; b=ThJoPk5ZBLIjZN12NOxWeWXbiLAj/xmjPWu2q3mxDd9DvUzIIP6nlNGfGLJRViSNN9bw1T/qmUyXGAoekoynA24KuTXEBC+BpbjySDhR55EzDppH+Po6s1M2ZcBlaT39nJLI55zIgyiJ861n5QnQzwrl0Pj9KuHUf9ZYk+gSNTw= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588594346666879.5118028496411; Mon, 4 May 2020 05:12:26 -0700 (PDT) Received: from localhost ([::1]:45028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVZxR-0005CA-5h for importer@patchew.org; Mon, 04 May 2020 08:12:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52066) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVZjt-0003AL-Hx; Mon, 04 May 2020 07:58:25 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:44793) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVZjs-0002JF-0h; Mon, 04 May 2020 07:58:25 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MXpM2-1jdPLr2KgG-00YAEA; Mon, 04 May 2020 13:58:19 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 18/20] hw/gpio/aspeed_gpio: Remove dead assignment Date: Mon, 4 May 2020 13:57:56 +0200 Message-Id: <20200504115758.283914-19-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200504115758.283914-1-laurent@vivier.eu> References: <20200504115758.283914-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:Epmdrbj84mM4+CNaeDulwlmvqtjjjQC/X1eHvYAmsWRk8j3Fn2h QijUH4N79c1Jg6lWt19bDhVMvk/Fj3FTs9poJ1QXh3aMQ5r0b8lJIHp3QSTozpdbUciXm25 VVPTRMxVD1zVS5dEB+qkxiSoTk1022LNoMuTcce8wtvCp2lK6lglv/R0gGm/hwnzHlhWFh3 CtfAXsijfUc58kuHBdKAA== X-UI-Out-Filterresults: notjunk:1;V03:K0:jrJy+udALk0=:xw/Jpa4PCL6qHBVS5+PejC ndl36lGw0tPEOdos0jaqJC5FVvwaZXiPbauA+5GOOdTK4DP2DPF4aCcuLhP+SrEiJsQorTTru BPCODmZharzbKU/M39ybMnqXQYKDHdOpUNUGhSVV6YROR2pd/Br96I7i3mmCapAfZfVjiaqdQ JRqLLUKZhXdyxVnfebn5TiowuUqNmLs45YZJbUt1b6v/JTnsqhhR0dJWx8VGkfpvBeUch8CiL w7Ngjt4qKnqN+qIpxhqdftoMSwjOhNf5NaPKoGFSinHY4HcT7yJpH5QuCDMZW1q8VcYhHmzbq IIwwMYI081LcnoQUa01yJJusRXpKLnz1H0ng5Azof/+VFXDVckc7zq5G8nC/FaYJRWjjMAAS6 UN+GLv/k8Oc+rhgH/nk4FxR1SobQXkfhxTTfHKHaChYpW2tCL4OtXnwi4dnzS6oBvOVRUmfp7 EnYietJzuUPxV/MAyx18YE5DQ/FfNdmvpl8rCZl5ZlOKKe/v92xAzW+F8m+bQ8MXIY4pFV1b/ t4ooIu4UNCJRq9O/bYS3tC/PbffaJnZELZ1/HsGIPS4Uj/OLl1Bf8reX3O6RS7UUtxjjD5bni MBo2Zc8EqACo7VESU3mnfNMUHedisofGZ4JlKjQAgQyAn5zU1VlWGBY2W8JRradDZWde2rnIY Ly/qsgQBJpnd/+wn7xHh6gtXgziCmuDlUtcBUocEbZ9ZXFqqYCjJWFfLl5ZY9L/D/Yt5P0pcH EjavFRteaS5LJNW/anMoSIvBJMXm2vaLa4MIWAZaP3CV2BtyexkpmWqUZsfiNihemWN5RF089 n9EzzrTncQwheMoOLr2sDrQnxsDPgWFXev6IolOoSwbTdU+WOa5rewlYNjiNzhkVAPigFR+ Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=217.72.192.74; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 07:58:13 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Michael Tokarev , Laurent Vivier , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 Fix warning reported by Clang static code analyzer: hw/gpio/aspeed_gpio.c:717:18: warning: Value stored to 'g_idx' during its= initialization is never read int set_idx, g_idx =3D *group_idx; ^~~~~ ~~~~~~~~~~ Reported-by: Clang Static Analyzer Reviewed-by: C=C3=A9dric Le Goater Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20200422133152.16770-8-philmd@redhat.com> Signed-off-by: Laurent Vivier --- hw/gpio/aspeed_gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/gpio/aspeed_gpio.c b/hw/gpio/aspeed_gpio.c index e52fcfd9a030..4c75b5c80cc9 100644 --- a/hw/gpio/aspeed_gpio.c +++ b/hw/gpio/aspeed_gpio.c @@ -712,7 +712,7 @@ static void aspeed_gpio_write(void *opaque, hwaddr offs= et, uint64_t data, static int get_set_idx(AspeedGPIOState *s, const char *group, int *group_i= dx) { AspeedGPIOClass *agc =3D ASPEED_GPIO_GET_CLASS(s); - int set_idx, g_idx =3D *group_idx; + int set_idx, g_idx; =20 for (set_idx =3D 0; set_idx < agc->nr_gpio_sets; set_idx++) { const GPIOSetProperties *set_props =3D &agc->props[set_idx]; --=20 2.26.2 From nobody Sat May 18 07:09:01 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1588593924; cv=none; d=zohomail.com; s=zohoarc; b=VR/NYoL1OQYFcUkkvQqEA3RX/DVYvbj9Dym8SFvsDAwkC+n/QtMO9wplKFsNnWxtYkGp1R5nnf5zVQGfwzOMGbpMt8xYi5VfmdSdbWa/8Q4cVSJ/B8aM1AzJN69ky6bztsHCEWGOKtA32yQLnfbTVZZxrkuXHbhFHKUVVt2eFpg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588593924; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9Wrf8YGt1lF7RY3wIuKPIO6U48EPSHgpbrb+KblBsl0=; b=Qf5wFbtm/rp7l8dno1445WKEY0jGU16fCD1benB8M2K+CXcmWx9Cz3cY8K9TKn4lh9F0V0OkIvJArUn6UWKFE3pCgKaQjMX69O8fHo9vRtqkQ8byEC8dmelMFTeLrIIRYYrdyB7okXWID8O8WcSJs40OSuvuS1uu8fWqnnzZEiY= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15885939240961005.4502632169568; Mon, 4 May 2020 05:05:24 -0700 (PDT) Received: from localhost ([::1]:50218 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVZqc-0003g8-PP for importer@patchew.org; Mon, 04 May 2020 08:05:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52088) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVZjv-0003Fm-FQ; Mon, 04 May 2020 07:58:27 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:33607) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVZju-0002Kn-IN; Mon, 04 May 2020 07:58:27 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1N0WLC-1jAu9Q0ko0-00wSMw; Mon, 04 May 2020 13:58:20 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 19/20] hw/timer/stm32f2xx_timer: Remove dead assignment Date: Mon, 4 May 2020 13:57:57 +0200 Message-Id: <20200504115758.283914-20-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200504115758.283914-1-laurent@vivier.eu> References: <20200504115758.283914-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:B0v5PS5FzGkJUIZ/DZYt5bnNSFZBdjwZmywtjpJSSg6ugyLkh7H ClGgtdLmYVBhtTW4LcjJr9kXc6bFnCw0S8lx+1qRKd5RlTet7TNzXwXccEWcpm8W0emO5uD f4bYUU3NSQTtmjuLhdVp40W9WutMrbt75D5GvtjJJF4uVUO/pbz/vVQv+QhJ6bcDt0UeTwx ht43JsoamDUTPs+upNTqw== X-UI-Out-Filterresults: notjunk:1;V03:K0:Fk4BJp7nlOQ=:ctjjVVGutJ2OQZh20l2cYq zlRqLqw89D6DS6+DTuEZqiEPaXCLyGi3ZGIXGyBTA9Ww7ap8BZEK8gzZZ9VwmBtZmDSl3YMTa TPb9ggsgFNN35hGMhA5/lYQyzWquZA3CSB7R8v0nmkgKckxoF9vgaB82PEUCH14C1sW/Esvmp 2amY/nJtzegRQNfwIloG6dk+laPTLnsaQFRJdNANh6W4ZRFIfUG5/edflW4XTnbS9dIQhNjxr gCt2ij8LE4/f8963FdaZ4uXHcU2jJaz6t3zDN2sDeIIUI/j3nqsfGXXx0NxIiTTHKiEIBLIMp 2427CI05uKXDBkJCsWITLonHTq/3OsMk7zgfBEduFi1IxrEABvzgrsswoy8inRWTyh/0lgkoV m7LNtke75tMcE4u0MIZw/LXFF2RQ9RjI7MGrEYHIDHae3rluTz8L7X1ve0hZeEjIiBGx4Vp0F Ao23xriicMcmil8ysV3l/QINBYVbzGh1TP6u0B8doC7EMwt93GmNVps8cDJeBqtsZ7SoQcrT0 FfUPtObz1g9a8VgI52q9Jt+0Lov52Th2uN4XqRmuVaJnWWX8H8cbZroMHUBhqkDke0jzK3i2z ll6CWCiL2yuikG7nDJE1yEcldwGkhHUeWHdYMTsdGPPzKH2cYjvcs54LjGHflm9wHLNwcI9uY Ds6sDZKS8UzAZM6hBTnktq9u7jG+dIZ2C7BTZ+VCud9Kp8VeC71qJ2l4/N3hRPRQB38h5TyxM BKb56B0CFIfQ5lA+vvDStcnvbagSsFXWG1seJPwy2ZyOxaeKZUnNZFMxxe0QfdUNCyh9wKB3M H7nMditOoJD2U738LpDq4ifW5Pr92ies7rDxEdL9+2zZuECoeo+WGOYK1rs7EU+yu1k6xv/ Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=217.72.192.74; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 07:58:13 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , Michael Tokarev , Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 Fix warning reported by Clang static code analyzer: CC hw/timer/stm32f2xx_timer.o hw/timer/stm32f2xx_timer.c:225:9: warning: Value stored to 'value' is nev= er read value =3D timer_val; ^ ~~~~~~~~~ Reported-by: Clang Static Analyzer Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20200422133152.16770-9-philmd@redhat.com> Signed-off-by: Laurent Vivier --- hw/timer/stm32f2xx_timer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/timer/stm32f2xx_timer.c b/hw/timer/stm32f2xx_timer.c index 06ec8a02c250..ba8694dcd349 100644 --- a/hw/timer/stm32f2xx_timer.c +++ b/hw/timer/stm32f2xx_timer.c @@ -222,7 +222,6 @@ static void stm32f2xx_timer_write(void *opaque, hwaddr = offset, case TIM_PSC: timer_val =3D stm32f2xx_ns_to_ticks(s, now) - s->tick_offset; s->tim_psc =3D value & 0xFFFF; - value =3D timer_val; break; case TIM_CNT: timer_val =3D value; --=20 2.26.2 From nobody Sat May 18 07:09:01 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1588594859; cv=none; d=zohomail.com; s=zohoarc; b=P4VEsLOzYJarsyFEdT+uQezrtvNsBbEKoLDK7BbzjFm5caIShhQsZngjFVX7b6W6T1Qd3fqfPMYI54uxFOL/FS7EGGhqD0WNc2Z+5ssSaldHeTMyp6d5sdKA+i0naDzuUhMlccG/czlhLaJgE30BbpIejYpEA+ZyEHYbZ9wu9u4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588594859; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=pNwIU/YoLERsclyou3rq/ZZQHq69cFa0aCsDKkAXQms=; b=PuDQEGze7/TVWabkkkAdbjbxP3K6xrRcRyesuI72eznqHW3r5VyNkrVW7dxelwxW4sx1ST7Cbu2xxjL7W1KDvaRJBGLZBMf7S/scy6JD0dBpWzi6AiUyNNrD1kvka5wKiMx7fDztoExG+l+0E6i9b3Aj7DaTYSnKu9LSYjH+VwI= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588594859710641.2928874487724; Mon, 4 May 2020 05:20:59 -0700 (PDT) Received: from localhost ([::1]:38574 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVa5i-0006Jq-IH for importer@patchew.org; Mon, 04 May 2020 08:20:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52094) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVZjv-0003Ge-PV; Mon, 04 May 2020 07:58:34 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:55305) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVZju-0002Kt-PQ; Mon, 04 May 2020 07:58:27 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MoOpq-1ilZoK3HR2-00orfG; Mon, 04 May 2020 13:58:20 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 20/20] hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warning Date: Mon, 4 May 2020 13:57:58 +0200 Message-Id: <20200504115758.283914-21-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200504115758.283914-1-laurent@vivier.eu> References: <20200504115758.283914-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:iqiCL93jf1udn3Aeou0tkXVxhcuNtePCHZfy+QO2oJqpuabBrYX rw5wXhAkgFStJRUuuR04fc3z+bOUkS+TCJxE/4D/0WMGjpZPtpE9HLRprdsTMCAg4/GS1tZ /WVcCeFyTD3hP7tiVHivpUHgq9fpiHgq5U6zG2k8gWRziyg3xU5J4MpqXdM380n6syjbd+a qNpGwycDNFZMOKarFyo2g== X-UI-Out-Filterresults: notjunk:1;V03:K0:gmTiqvLl1/M=:8jDdgjo5b5pCm68z3tmqxX Hb+rgmFCBQm79Xr7JuTU4iVVRGRr14REFHtz8i1ZL6u2Nkx9U47KXt9V3AjMTlqlmeN2y/mYa fDjUkxs1bd14EZTWFf/WdqeiIolemXmJQ9uRBHLy37qFaZnYNC6rvCi7JO6o2XooodANSuvLg LQ6S2Mtlo7/Wa5pvmoGTZ9tb2mLH0R+3vPFgmwQ2e1z+MzT1bOi4nZZpf/jH4k9ODEqHgI5MT WM42nXR6IVJ9h1D3Wx+KHqOPLAVX+7e+0Rol34MTb8z0de6qCEDFM7brGr50//L/F/VSYrhqZ gJVnyAm6z9X87/kV5aeIBK9nL6sxD1Qun75+PcHisU0HVRcfJE08Nm3AB5FTF3CaflIhXAQnN xjNyEfu0AOh9RaezrsTup1ymRh52jRBUp7UuDlVTt9ExGXDvc4WOtzo78yLKuH69UA7/FRmux S3xBQH2gMvjWmwKeS5wjYRfnKIO8Ig7YspTYWjSlQLjk+sj4c4EKyPjySOltVQRNdSVvfrVlK dFYdW877XnHtZ+1R6qZBw8bkh+9bZGi9YM2cm8YJtsPRAiahuGEtI4AnBP/M+rEWRmy6IHtE3 dKGDl5esM6BULTSievMCJ69CQOnkdnhL+waT+Jj4+iJJ1HqSSZBBULWFBlR67x6iPSQks5WEr Pd5WWf/dUdwTW3KtMAm5hJDEMgNEI5Z4CwCMF888n9rkeXojAEI2gNLQO5XJ63rXZEPkxDxrs +4pKtdBYLOjFJWIB9cIPHtatovfREjAgBPhv/0YF5uhR2arMQOce+rVRNDSOyqwqKB6lHqqpz CooFgSP44kTJBGL9fqHWOrCjtQGDZ/ovC5mW/HwgSQtTHM+2/gvnT3P1Ek1u0p2Z+fN28wG Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=217.72.192.74; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 07:58:13 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , Michael Tokarev , Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 pxa2xx_timer_tick4() takes an opaque pointer, then calls pxa2xx_timer_update4(), so the static analyzer can not verify that the 'n < 8': 425 static void pxa2xx_timer_tick4(void *opaque) 426 { 427 PXA2xxTimer4 *t =3D (PXA2xxTimer4 *) opaque; 428 PXA2xxTimerInfo *i =3D (PXA2xxTimerInfo *) t->tm.info; 429 430 pxa2xx_timer_tick(&t->tm); 433 if (t->control & (1 << 6)) 434 pxa2xx_timer_update4(i, qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL)= , t->tm.num - 4); 135 static void pxa2xx_timer_update4(void *opaque, uint64_t now_qemu, int= n) 136 { 137 PXA2xxTimerInfo *s =3D (PXA2xxTimerInfo *) opaque; 140 static const int counters[8] =3D { 0, 0, 0, 0, 4, 4, 6, 6 }; 142 143 if (s->tm4[n].control & (1 << 7)) 144 counter =3D n; 145 else 146 counter =3D counters[n]; Add an assert() to give the static analyzer a hint, this fixes a warning reported by Clang static code analyzer: CC hw/timer/pxa2xx_timer.o hw/timer/pxa2xx_timer.c:146:17: warning: Assigned value is garbage or und= efined counter =3D counters[n]; ^ ~~~~~~~~~~~ Reported-by: Clang Static Analyzer Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20200422133152.16770-10-philmd@redhat.com> Signed-off-by: Laurent Vivier --- hw/timer/pxa2xx_timer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/timer/pxa2xx_timer.c b/hw/timer/pxa2xx_timer.c index cd172cc1e960..944c16588926 100644 --- a/hw/timer/pxa2xx_timer.c +++ b/hw/timer/pxa2xx_timer.c @@ -140,6 +140,7 @@ static void pxa2xx_timer_update4(void *opaque, uint64_t= now_qemu, int n) static const int counters[8] =3D { 0, 0, 0, 0, 4, 4, 6, 6 }; int counter; =20 + assert(n < ARRAY_SIZE(counters)); if (s->tm4[n].control & (1 << 7)) counter =3D n; else --=20 2.26.2