From nobody Sat May 18 12:29:53 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1588582171; cv=none; d=zohomail.com; s=zohoarc; b=FKXT2+AQ056347NljvduRrHk9tjWSaZF578oVfT/C4RxBLVyAloOtplpkSit2+wp0lUXPTP/gNaGd4AMn0R1loQSF7kiFdIk5dpFXh3PgoDIxmVLbYF+/dUICm8UuoSfGrDE6OTN0wB9tw0Kava2lIarVQ7Kjp7jx7jN0AsiCdQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588582171; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=SkzVF0IAQenJ+vuaRxVd2feGaJRdUO/UKBkIdIBtTMo=; b=fLVKbKl8WzQXjuWv3x/lg0sA9n7EmuJ+83Ri1Ak/tPvgHNqDKBFbndYEwvgeCtlcmLZl6LzK+5rfL95O85KhJutsv2YonSwOxbrZhZFOdIYCch4wEDjzVWj0olWuUUQei4v2z8a0F7z8XZ6pJbFGWZHG3WVLkISiPrZUTxQrF2I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588582171583342.3591575970495; Mon, 4 May 2020 01:49:31 -0700 (PDT) Received: from localhost ([::1]:59972 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVWn4-0007JJ-A4 for importer@patchew.org; Mon, 04 May 2020 04:49:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42652) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVWk2-0003sc-DP; Mon, 04 May 2020 04:46:22 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:33379) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVWk0-00057F-W7; Mon, 04 May 2020 04:46:22 -0400 Received: by mail-wr1-x42a.google.com with SMTP id h9so9569838wrt.0; Mon, 04 May 2020 01:46:20 -0700 (PDT) Received: from x1w.redhat.com (26.red-88-21-207.staticip.rima-tde.net. [88.21.207.26]) by smtp.gmail.com with ESMTPSA id w6sm10740621wrt.39.2020.05.04.01.46.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2020 01:46:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SkzVF0IAQenJ+vuaRxVd2feGaJRdUO/UKBkIdIBtTMo=; b=c73G7AIf02xEPxib1pJs4u5FUlo9ab0wnzH783TUYR6omj+qer5h7DRzhPiS7xNIKw Im7+DM3Zv9AJkXLvJjETkQuX4LCfj9uZmD2+T5q8w5Jsc3uUGZzxyp8vMmMkC0h/QroI 6ew83yYKDYqYBh4O5rERY36jLAGiJlsIeXsKq6HgB0U2i2oZVDHPs88cLzaKICLXonv8 TY5dDIDavYUegz1i/IdWQ4uIXeglAfUUp4L9xu5llC+22n28sbuOdVxE2GI7GcVp6PYh +khClOdo55ZtczhuV+McfSyZpVzm68eniJjXMHhJK+ei8bu1NYU3BWhYQgZGPRdNeG+p OU/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=SkzVF0IAQenJ+vuaRxVd2feGaJRdUO/UKBkIdIBtTMo=; b=bgLMf4ijkKkvYb+OUMH0r01V5pmNh6o8fE9cCBT40udpkP4UbgRJ1akErsLOwoYgYI Kj6mHCvMf4AAywai6ucFTQVi1/ZYMBWiKhUCdU9jc/LG/ZEczQDCgFAtG5Xc6rCugsom QuMAzi3LfKHmEjOGzx/rWjW6b7gZHhn5sgi5srrfZzh3edQ2VzNO19eLqdK5lELW6Mt2 dL+7eBjYn63haSKDeBRx9upgbfnj+qLERRaNLsrLF1W3l5WCi7dhzqT10Jvusqms2ix3 1PxxX/lKyKUgTWQhRGM8/wlXPjtxevKov++pgmPIYUEDvkz17XvV0oOsqpSR7aAwlvSh iZDg== X-Gm-Message-State: AGi0PuayfukbrPDFIyURbdLC+1zye/VHZIHWZnuSZ0cK0Z21ev7r8fEu ac3OwuBdRoF+gh4VYMQbOjF/oIJm X-Google-Smtp-Source: APiQypIw4ubh1VWVYRKjwYkeY5N3hwWTvpxXkD+d8A3wLzF3ve8Zuu4Dmn5P+pjEpzIBY/S572nCfg== X-Received: by 2002:adf:e7ca:: with SMTP id e10mr18432009wrn.18.1588581978772; Mon, 04 May 2020 01:46:18 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 1/3] qom/object: Move Object typedef to 'qemu/typedefs.h' Date: Mon, 4 May 2020 10:46:13 +0200 Message-Id: <20200504084615.27642-2-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200504084615.27642-1-f4bug@amsat.org> References: <20200504084615.27642-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x42a.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Eduardo Habkost , qemu-trivial@nongnu.org, Michael Tokarev , Markus Armbruster , Laurent Vivier , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) We use the Object type all over the place. Forward declare it in "qemu/typedefs.h". Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- include/qemu/typedefs.h | 1 + include/qom/object.h | 2 -- include/qom/qom-qobject.h | 2 -- include/sysemu/sysemu.h | 1 - 4 files changed, 1 insertion(+), 5 deletions(-) diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h index 375770a80f..b03ec9f40a 100644 --- a/include/qemu/typedefs.h +++ b/include/qemu/typedefs.h @@ -75,6 +75,7 @@ typedef struct NetFilterState NetFilterState; typedef struct NICInfo NICInfo; typedef struct NodeInfo NodeInfo; typedef struct NumaNodeMem NumaNodeMem; +typedef struct Object Object; typedef struct ObjectClass ObjectClass; typedef struct PCIBridge PCIBridge; typedef struct PCIBus PCIBus; diff --git a/include/qom/object.h b/include/qom/object.h index 784c97c0e1..1edc12e64c 100644 --- a/include/qom/object.h +++ b/include/qom/object.h @@ -20,8 +20,6 @@ struct TypeImpl; typedef struct TypeImpl *Type; =20 -typedef struct Object Object; - typedef struct TypeInfo TypeInfo; =20 typedef struct InterfaceClass InterfaceClass; diff --git a/include/qom/qom-qobject.h b/include/qom/qom-qobject.h index 77cd717e3f..82136e6e80 100644 --- a/include/qom/qom-qobject.h +++ b/include/qom/qom-qobject.h @@ -13,8 +13,6 @@ #ifndef QEMU_QOM_QOBJECT_H #define QEMU_QOM_QOBJECT_H =20 -#include "qom/object.h" - /* * object_property_get_qobject: * @obj: the object diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index ef81302e1a..ca4458e451 100644 --- a/include/sysemu/sysemu.h +++ b/include/sysemu/sysemu.h @@ -5,7 +5,6 @@ #include "qemu/timer.h" #include "qemu/notify.h" #include "qemu/uuid.h" -#include "qom/object.h" =20 /* vl.c */ =20 --=20 2.21.3 From nobody Sat May 18 12:29:53 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1588582250; cv=none; d=zohomail.com; s=zohoarc; b=C2fOd0KPVMiAN58/QowGMYOB5IcVNKxsHejuslzeaZ5HvgiO2gqgPkaaYeI+RK26S+cu5o8LkkRaKthLTnYFMH6MZzNWhScbh9/DjQhj+wHotevdoM6v0tb2FS4gqlF9a2HK00ye5gRDPfGanppqnIi47k2TMYi9oxDZy9wovSE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588582250; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yQVaxRYvRYKfoRoJCtXozicb6p4ygnojFcpJd6zilzU=; b=TILrZ60Ju3GaLQbUbFmcmMufiD886i1IdVS8K7PWJt7L5zLYacj34W6y66squgtGK30h3lBqdW5hl6pJS3DakGKDXiMvE86W85tSPWqdysJAXHMhWzxEUCosm9AKealIfE0KVVU3XtoV6UygMFp2P6L6p4wxHnAsDa8pE5SpuCI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588582250955894.866194226886; Mon, 4 May 2020 01:50:50 -0700 (PDT) Received: from localhost ([::1]:35376 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVWoL-0000Rp-NK for importer@patchew.org; Mon, 04 May 2020 04:50:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42660) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVWk2-0003tG-Q1; Mon, 04 May 2020 04:46:22 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:45796) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVWk1-00059V-NI; Mon, 04 May 2020 04:46:22 -0400 Received: by mail-wr1-x42d.google.com with SMTP id k1so1027359wro.12; Mon, 04 May 2020 01:46:21 -0700 (PDT) Received: from x1w.redhat.com (26.red-88-21-207.staticip.rima-tde.net. [88.21.207.26]) by smtp.gmail.com with ESMTPSA id w6sm10740621wrt.39.2020.05.04.01.46.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2020 01:46:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yQVaxRYvRYKfoRoJCtXozicb6p4ygnojFcpJd6zilzU=; b=AkoRA9MJn/AfYwzLdmr06wHLXPz9SpdPPdOdLYAgnb5WI2mX/+HOAt1HAnrGOMCtDM Wf0lSoj4SEYzYHW1/kgfqF2gG/9ULSELuQQXY4flsQhGgiHXTiwtjIwDE1pAVvYXO6jD SpwlMp9uohSj6gkizRKHCgZDi9HaV8eXQaLeNJsnrnVeF44o1p75KJbUozGNBJKF55xa OfYA5mxdV/qEczgVN32vD4xjtrX+wHDHSroum/L7RCyT6VksPHCFrgtVCyzayE0VQXYq Q/sUaPa//S0Mky/IlyLLGuekc5hUgn+y1LzMRR9XjOVAfU5bGGZcqhptwLvjxAC8ezZq WHyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=yQVaxRYvRYKfoRoJCtXozicb6p4ygnojFcpJd6zilzU=; b=Qr7OZk0xLT4YWYMgFpc1fzObYAUQo8us3LZP6hkQftNWq5IM2vxAEFHIrBsmGM2KK4 haEEogd1EstycB9EqY258Z2+aKzYHu7Ul9/OXmPlPk0pmNE+XbPJdvvNFqGxuK+hQurw vQXn0GXHjyd6hnvPRFFHVlbQn3c17vFkX2y/oQMRfbfQwoavWzrQlrXl63w/lCCixIdV A94Zj11220ecGFkYGxy2CktxnO7/xDnnbzH+Feg0PatESd8ejO7KyXOEgkuJBGWzwx1Y fyiWqgxiG7cHt3yeiVilXpZN99k4myTQztvxH9JPXMNVzNpanfzNRaUe18mHwkCpKAlF sfsw== X-Gm-Message-State: AGi0PuaSJjTm1zhK/gip04V0D3746p3JogJS1VcqWBrzkpEuSiP4+jbw BM9x/ieOc3NZCzJCbh43kJZFX+17 X-Google-Smtp-Source: APiQypIx+HTNBLgl2366kAbs8WSlR1dLjbD4LY/EUpg6Ur8BoQGOpKpVkIHh8YXHVezYy0h1Wi+VmQ== X-Received: by 2002:adf:dfc8:: with SMTP id q8mr813952wrn.325.1588581979953; Mon, 04 May 2020 01:46:19 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 2/3] io/task: Move 'qom/object.h' header to source Date: Mon, 4 May 2020 10:46:14 +0200 Message-Id: <20200504084615.27642-3-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200504084615.27642-1-f4bug@amsat.org> References: <20200504084615.27642-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x42d.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Eduardo Habkost , qemu-trivial@nongnu.org, Michael Tokarev , Markus Armbruster , Laurent Vivier , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) We need "qom/object.h" to call object_ref()/object_unref(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/io/task.h | 2 -- io/task.c | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/io/task.h b/include/io/task.h index 1abbfb8b65..6818dfedd0 100644 --- a/include/io/task.h +++ b/include/io/task.h @@ -21,8 +21,6 @@ #ifndef QIO_TASK_H #define QIO_TASK_H =20 -#include "qom/object.h" - typedef struct QIOTask QIOTask; =20 typedef void (*QIOTaskFunc)(QIOTask *task, diff --git a/io/task.c b/io/task.c index 1ae7b86488..53c0bed686 100644 --- a/io/task.c +++ b/io/task.c @@ -22,6 +22,7 @@ #include "io/task.h" #include "qapi/error.h" #include "qemu/thread.h" +#include "qom/object.h" #include "trace.h" =20 struct QIOTaskThreadData { --=20 2.21.3 From nobody Sat May 18 12:29:53 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1588582078; cv=none; d=zohomail.com; s=zohoarc; b=jUIAt5JsCwjEgEB+RQSrQiZDRJL5JnQtPz3dHgFO+/gaCFkxLzegc1BSH+p//m6BK50VT+W2tR9TWpBFKmVH0ywhebE7GOt1QNV8z1M//U9IjbffVtMCeCn/ON15Suon5C+nlAFe3ZkEyI945ecXvy1J7hWDn9gfw0Zmbiqsyto= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588582078; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=f+EbD9Q86u44mnUNC8LdzOT84sTEw0zjnLN96ls2FY8=; b=hHyMAY0fgCMqn9Tn68ibpYpZTRLtiXYjWOD26254t5pTDx77w9TT3q5l5QWPv85fZxv0AFfgcQArBtk6vb0PNQbp7sLOh3Tc/nofbrzQiimP3zRQrFVIzAWMLtM7UPyXhhRlPPj9ntejomUIz2FH4Svp2swtjB0YIkGxmITjWm0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588582078422332.2440660793028; Mon, 4 May 2020 01:47:58 -0700 (PDT) Received: from localhost ([::1]:55288 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVWlZ-0005Fl-5X for importer@patchew.org; Mon, 04 May 2020 04:47:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42670) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVWk3-0003ui-P2; Mon, 04 May 2020 04:46:23 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:35336) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVWk3-0005A4-3f; Mon, 04 May 2020 04:46:23 -0400 Received: by mail-wr1-x444.google.com with SMTP id x18so19916912wrq.2; Mon, 04 May 2020 01:46:22 -0700 (PDT) Received: from x1w.redhat.com (26.red-88-21-207.staticip.rima-tde.net. [88.21.207.26]) by smtp.gmail.com with ESMTPSA id w6sm10740621wrt.39.2020.05.04.01.46.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2020 01:46:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=f+EbD9Q86u44mnUNC8LdzOT84sTEw0zjnLN96ls2FY8=; b=LMli5Ycftq50qDovpVx2BVYHKwF46lqCoDqY5tfX7XuHCkNIwVjbUHykKpSNh3z0OH pFH897SPxW/L+a5YAO1+Nx5b3xrqXYLWojiOl+/sEGpmvss+Q4z12cJ0f3Rf6G702Nz2 NjVYuhe2PQiqdxNs8pEkDDER4vf/oQYxFsFYAQm0BZxqSvbnVnFGywAGykJChmH+Z90Z mt4dwkopUi+eZG+8P2mPtvcDteS8HnsY+wdHnCBCwlsFpTf+JEkkMx8FpwtTuReKtbet dKfTpQRpDuIHlkb8kx3u2LrUO9SWVZXO0UZrmAxR9hiNWsryKcTmsGrh4SnfVkBble3e iV2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=f+EbD9Q86u44mnUNC8LdzOT84sTEw0zjnLN96ls2FY8=; b=ORCqY42TPQ5TBsHvsd5WMG4sgUZBj94ioQC81xmt7pYNzTGr0GhKVnydWAt8SGgg0L 26HZJ6XHDQnoRdj70Tzi6LO8IFYZFdDlSE+QTzJAkSHkfFZ4DcV1jHFeXH4caiXXnm7j RVg7R+48sdUHORrwe1K9fVc5GSXhMlcEU4V1tUejkm4UAokPI7EC1MgEKRn1qfc/JoY4 RelD77H+QWbRWMSFCifXn+i49kuOzUnRSt9DT7oK3JjVJG4J8A9mweNVj5B18uoP5W8C HJ6SskMUphIR+YM9ZsdQqNJGhcHNPWR1yL9iDmJKOQo/lq5VEll/vSxMULV2U2aHuDTB Tlrg== X-Gm-Message-State: AGi0PuZoUe9o5UCZBntefIqFtt9wZLAzc8bMss4NLBsR8+lg6LuSU6gU FKXxIbR6DR7KBUA6EBCvIrGKnfNr X-Google-Smtp-Source: APiQypL8IYJwhIZ1YGlLBCl4ZFybfnP1SZCSz8tDIjCk975wpi7l83A+O/6xGCkHA0yE/OKhNQ/uhw== X-Received: by 2002:a5d:5651:: with SMTP id j17mr17455133wrw.406.1588581981066; Mon, 04 May 2020 01:46:21 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 3/3] qom/object: Make reparenting error more verbose Date: Mon, 4 May 2020 10:46:15 +0200 Message-Id: <20200504084615.27642-4-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200504084615.27642-1-f4bug@amsat.org> References: <20200504084615.27642-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::444; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x444.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Eduardo Habkost , qemu-trivial@nongnu.org, Michael Tokarev , Markus Armbruster , Laurent Vivier , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Display child and parent names when reparenting occurs. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- qom/object.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/qom/object.c b/qom/object.c index be700e831f..417fd90aa5 100644 --- a/qom/object.c +++ b/qom/object.c @@ -1683,7 +1683,12 @@ void object_property_add_child(Object *obj, const ch= ar *name, ObjectProperty *op; =20 if (child->parent !=3D NULL) { - error_setg(errp, "child object is already parented"); + error_setg(errp, "child object '%s' is already parented (parent: '= %s') " + "can not be children '%s' of '%s'", + object_get_typename(child), + object_get_typename(child->parent), + name, + object_get_typename(obj)); return; } =20 --=20 2.21.3