From nobody Sat May 18 03:46:12 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1588505618; cv=none; d=zohomail.com; s=zohoarc; b=ZlfFpqTu7dqAWl647XXXswm9gatIRHGaSY3PYynOceITwPE9VxmUbSRzGktK+q9hvok/IoTfqsQt0a8H90OCuS2GVVpzddEkgpjUxwG1UzkGvLBsvg4vRXz0JgR+XVQltW+U6/qOXtSGJ+r/a1DFTqq9kt96XDOsa7KhSQkQDCk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588505618; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=WLfI9+SN8h6AKCdaEGa7tKEIhwA7T3hWgI6qxjQ5RDA=; b=PYOvkEbYVgaeFLS50AZAqj33vrGDJxGrkZzYyqoMS7S+avh86/JJU8YD2DnkJmAPoMbu0Qmkb/bASaNtAsnAuySCuMg8NCRFY0ipwIIaJozyyl3u7hCwjrG5ROcJXTKieMYg314jLRT8uDHqAAe2Q+w6p0aKzd/eWilDqZepkYo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588505618950908.7527217366509; Sun, 3 May 2020 04:33:38 -0700 (PDT) Received: from localhost ([::1]:38744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVCsL-0003IK-F2 for importer@patchew.org; Sun, 03 May 2020 07:33:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47012) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVCrH-0001su-BI; Sun, 03 May 2020 07:32:31 -0400 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:54138) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVCrG-0008NQ-Nw; Sun, 03 May 2020 07:32:31 -0400 Received: by mail-wm1-x344.google.com with SMTP id k12so5114526wmj.3; Sun, 03 May 2020 04:32:30 -0700 (PDT) Received: from localhost.localdomain (26.red-88-21-207.staticip.rima-tde.net. [88.21.207.26]) by smtp.gmail.com with ESMTPSA id n9sm13485904wrx.61.2020.05.03.04.32.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 May 2020 04:32:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WLfI9+SN8h6AKCdaEGa7tKEIhwA7T3hWgI6qxjQ5RDA=; b=McQR5EJJhLs6dxRaQZtaEfrlhrcc+HjPo43l9QAVD+sXBhDu3U0/+belCcYvYWh0ny nL65dirh2HbimhNqPp4X8vJeMwInYai+QJwpVPSoVtSBE2l+cLTloxM89GrGCBY/oJEP gr3nKjn2ZhxusgTu3GTUyzQdaP2J3wlbhozXsxSC4sE1mN+xHq/YTqgIax/m0eRtAM5U ciV8365QH6gWJZZAK1OSffLejLjFYkI2H8WQw8cDFMF+RkuOm2sIJ0VdtSi/xTXzp6Tt Y56032eRuYhn1ITTpwPiY0ubl9i5ZsPZYJi0QaMIybmcYeBUR+jv2bdsOnU5vu5KHAec AgPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=WLfI9+SN8h6AKCdaEGa7tKEIhwA7T3hWgI6qxjQ5RDA=; b=UrxLSQAmdFUR9a0OY7Sk58pVXSszRwB94kZblwGCw8w9hhis9zSWqX1MKjnU6X9ejG ZI1358mvfY5I1EgpFQ6akSn1fFxEFB/QKTSoLCpOTueK73symLX1rwxvfIIdJOy1v0o1 cgxFG5ltmtexWj8cfE1zkRnVcDNGxGg71t9y9IgX4irvba3mw71A7DzbhYpvGUVyn682 yg+0rDtAbbAzCXiH+ibHqu4VxUcpdRrTBPpGP5btyDGuJgPeghl4MPFrQP74sdIzW2VM RCph04Rjrf48wn74vlfnaHGM7dArnS2DiTD8Rxaqqg/4WJmRvv9EipdThjC2/DyxSjvv GBTQ== X-Gm-Message-State: AGi0PubL2hQWISwktJ+CnjV3sICAuCvIzVnDdgWnnbOYeP4psz7GX17v 3N8B7G17VIe0yJ/4AiRtEM7p5Hfv X-Google-Smtp-Source: APiQypJLfevv73ldiVHjt+PV/tOH6+rVLBn9XfaUk2FQvemoegC/3Qf15uI6K0ERfn5TcqmC+iJ++g== X-Received: by 2002:a7b:c0c5:: with SMTP id s5mr8933078wmh.134.1588505549067; Sun, 03 May 2020 04:32:29 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH 1/2] audio/mixeng: Fix Clang 'int-conversion' warning Date: Sun, 3 May 2020 13:32:19 +0200 Message-Id: <20200503113220.30808-2-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200503113220.30808-1-f4bug@amsat.org> References: <20200503113220.30808-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::344; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x344.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Riku Voipio , Laurent Vivier , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) When building with Clang 10 on Fedora 32, we get: CC audio/mixeng.o audio/mixeng.c:274:34: error: implicit conversion from 'unsigned int' to = 'float' changes value from 4294967295 to 4294967296 [-Werror,-Wimplicit-int= -float-conversion] static const float float_scale =3D UINT_MAX / 2.f; ^~~~~~~~ ~ /usr/lib64/clang/10.0.0/include/limits.h:56:37: note: expanded from macro= 'UINT_MAX' #define UINT_MAX (__INT_MAX__ *2U +1U) ~~~~~~~~~~~~~~~~~^~~ Fix by using a 64-bit float for the conversion, before casting back to 32-bit float. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- audio/mixeng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/audio/mixeng.c b/audio/mixeng.c index 739a500449..9946bfeaec 100644 --- a/audio/mixeng.c +++ b/audio/mixeng.c @@ -271,7 +271,7 @@ f_sample *mixeng_clip[2][2][2][3] =3D { #define CONV_NATURAL_FLOAT(x) (x) #define CLIP_NATURAL_FLOAT(x) (x) #else -static const float float_scale =3D UINT_MAX / 2.f; +static const float float_scale =3D UINT_MAX / 2.; #define CONV_NATURAL_FLOAT(x) ((x) * float_scale) =20 #ifdef RECIPROCAL --=20 2.21.3 From nobody Sat May 18 03:46:12 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1588505626; cv=none; d=zohomail.com; s=zohoarc; b=C6Rdg2GYiXOJqnTo75t9M9MUA8fTn00+WDvnaRzhpBlZv/SUOazI/MxV5ZvrYfhkzN6SB45WqV2354Wy8g5dMtyWgsASrBuLxnmwVdeVRUZVCJtMZfAIK9AFNFbLHafwqMPZlZo8pQrn7/Y5+QWo6lPpx7yzDRjoPdLTNA//Ab0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588505626; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fkF6VfCkC8dhwiBfLS0TZm2WgnTIh9zitw46wfovxro=; b=bQusAmxdvAxzOou/skce7lAFvStvQ7JcFGKqXswvGfMa0BPLn4AuM+aeTpCaqAeEy96q/X/kBpu3G+S/a/6BCtt7whUlg64XFgplr1CN63wNrH9/mR/wS2sQdPJsn71+wSz3Nj6WiveUHVa1Dp0cEgVXUy4k2CfY6kyTF4wXFC8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588505626057575.8255259307484; Sun, 3 May 2020 04:33:46 -0700 (PDT) Received: from localhost ([::1]:39074 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVCsS-0003Rm-NQ for importer@patchew.org; Sun, 03 May 2020 07:33:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47018) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVCrK-0001z7-7l; Sun, 03 May 2020 07:32:34 -0400 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]:32981) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVCrJ-0008Q2-Hq; Sun, 03 May 2020 07:32:33 -0400 Received: by mail-wm1-x343.google.com with SMTP id v8so13328840wma.0; Sun, 03 May 2020 04:32:32 -0700 (PDT) Received: from localhost.localdomain (26.red-88-21-207.staticip.rima-tde.net. [88.21.207.26]) by smtp.gmail.com with ESMTPSA id n9sm13485904wrx.61.2020.05.03.04.32.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 May 2020 04:32:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fkF6VfCkC8dhwiBfLS0TZm2WgnTIh9zitw46wfovxro=; b=mUaZIIEDAePhgq6/tvBl/eHjQ3qhX21PQAopjxr5no9eeHsiMlAJkQ0xJWLfK0bIy1 jLd39+GHIFRoOjLsCOV4YtmXqALWUZRyOJHOhe8dzdm76EZUm/8H2oKTjsHuGZ/bzo00 yeAaaRHRoatabQDOU72QlcQg0z58alf5azSMVPwkEvSnWeTWkvurxB+8dYCWSW4k6e0j UdIKBG1ElIhFw2Mfrwx42B62QrUaJJM/LDSKf1+0HBN0U6mvdbJghUi8WFrzYI0RrORL 7HBoggktHDiloS03vRgtEhD0NvBhVQEOd5Jmww4pEwjjS03kcDbMAwjMiovSxrMH07hJ 2yHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=fkF6VfCkC8dhwiBfLS0TZm2WgnTIh9zitw46wfovxro=; b=o8n1WPYak8P9icqHcXdIHnJMlmz6zPcYFNP/g5/2URaG7XanOoYrjp0PH6NenvGy1r f5T9plvXe8I5Zh2DTqpx+zmABANIV7KjPbd3yaRcz1IKu+xaPEU9BMQD3u7nP+Bh05l2 ANaXBog8p3PQ7z95is776lQz7zAsq7M/4CoNySMbUnnfzsdDe6KjrfuBOXukVpgq5puI qEOTBGo+p5+esKtcL0RbdWYd2cuRRhiimcjEkceEaN6tLwSRttcbK7j+lP0D3kzD6Rta Ct9hWE+YsqH9nPUfR66xrwCTBJel+0COVCO4e1BaKIXf5DeYctlSPXygGc9F7gPjb1cO lS2A== X-Gm-Message-State: AGi0PubT6TfzB5KFI1EJ9xS8/uz/TTwTstls/rJqp9U9v/bvNXCifqCw z1ZinTZxZwlfS7Yu8sp1uEcjwum9 X-Google-Smtp-Source: APiQypKkpY9uBhhLB96WAnNWqH2t5ZthyVsw+AyDsl1xzDW4IbVXKzzX5jicaFPfGZKdhGHHQ7+zdA== X-Received: by 2002:a1c:f416:: with SMTP id z22mr9056661wma.32.1588505551382; Sun, 03 May 2020 04:32:31 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH 2/2] linux-user/mmap: Fix Clang 'type-limit-compare' warning Date: Sun, 3 May 2020 13:32:20 +0200 Message-Id: <20200503113220.30808-3-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200503113220.30808-1-f4bug@amsat.org> References: <20200503113220.30808-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::343; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x343.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Riku Voipio , Laurent Vivier , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) When building with Clang 10 on Fedora 32, we get: CC linux-user/mmap.o linux-user/mmap.c:720:49: error: result of comparison 'unsigned long' > 1= 8446744073709551615 is always false [-Werror,-Wtautological-type-limit-comp= are] if ((unsigned long)host_addr + new_size > (abi_ulong)-1) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~ Fix by restricting the check for when target sizeof(abi_ulong) is smaller than target sizeof(unsigned long). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- linux-user/mmap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/linux-user/mmap.c b/linux-user/mmap.c index e378033797..b14652d894 100644 --- a/linux-user/mmap.c +++ b/linux-user/mmap.c @@ -714,6 +714,7 @@ abi_long target_mremap(abi_ulong old_addr, abi_ulong ol= d_size, errno =3D ENOMEM; host_addr =3D MAP_FAILED; } +#if TARGET_ABI_BITS < TARGET_LONG_BITS /* Check if address fits target address space */ if ((unsigned long)host_addr + new_size > (abi_ulong)-1) { /* Revert mremap() changes */ @@ -721,6 +722,7 @@ abi_long target_mremap(abi_ulong old_addr, abi_ulong ol= d_size, errno =3D ENOMEM; host_addr =3D MAP_FAILED; } +#endif /* TARGET_ABI_BITS < TARGET_LONG_BITS */ } =20 if (host_addr =3D=3D MAP_FAILED) { --=20 2.21.3