From nobody Tue Feb 10 03:39:56 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1588367696; cv=none; d=zohomail.com; s=zohoarc; b=XpXBTJFYx6gtMBijN6ZRbOqkZrRKoh9UTQOBlVTE7qdKLzr9qviiZoFvT8yBLu/ElgztyzDgu5O5V+PKqqmYB6QUvl408HjfhX7oTf4SHm255W7rbincOaxfUHFBNnqR6R7egzmPB8PYadHGamXBY4oovTBcOgh57v3adklnqVI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588367696; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=T6CcolLGmewGB263Dq5JcXqXdOTfepA8BlCHSWd+1xw=; b=EZhQwLa4ikd+wtME63QOy2VzMlpqzI0I1qU0Bnk8rVLjZWskEVpXsd2WxqR2fQkHkaU5iusVeJXGaYnjW4u4P120tChNfszLSlI3+uVFZiMbV2oovKJaHCISBdladzHHbsNclpmuK/lfvKv8LfAkqvt9CQfRjq+O720WJ6wjn5g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588367696420471.7428243750413; Fri, 1 May 2020 14:14:56 -0700 (PDT) Received: from localhost ([::1]:52422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUczn-00016k-4v for importer@patchew.org; Fri, 01 May 2020 17:14:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUcyp-0008A4-2x for qemu-devel@nongnu.org; Fri, 01 May 2020 17:13:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jUcyo-0005m7-4w for qemu-devel@nongnu.org; Fri, 01 May 2020 17:13:54 -0400 Received: from mail-pj1-x1042.google.com ([2607:f8b0:4864:20::1042]:40582) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jUcyn-0005cq-Mv for qemu-devel@nongnu.org; Fri, 01 May 2020 17:13:53 -0400 Received: by mail-pj1-x1042.google.com with SMTP id fu13so392029pjb.5 for ; Fri, 01 May 2020 14:13:53 -0700 (PDT) Received: from localhost.localdomain (174-21-149-226.tukw.qwest.net. [174.21.149.226]) by smtp.gmail.com with ESMTPSA id g22sm514552pju.21.2020.05.01.14.13.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2020 14:13:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=T6CcolLGmewGB263Dq5JcXqXdOTfepA8BlCHSWd+1xw=; b=xA4F/zyUkQCJ7p3ju3pTIo97fWtVPQbnO6MYUzxklkpnkv3f8FvIPcmKNEVVj/2cUe j95+XYWtl8+3+XYp4DUY6xxjFMRD9KLEgZpdiEeJoiXibyHK4mBlJ0k2NHTVR0csqnAO OJVBOzj/5Li+JZiunFM8GXtebv7Y74rytvljIOOcW3B/I7UnpCx8cVjM729YCrz6XQhx IEtblyyY9N50cPbAgJfrq5lxmg8opzQ8rKODNquhcCLCg+QoF/4msXv8+sCSNkYiGDVY EKW66vqxBpJI2cOjhdQDvPCei5pbYzy45EvwRN3UpmBPWI3oZwk02fuW6v/lgtet1Tin yywg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=T6CcolLGmewGB263Dq5JcXqXdOTfepA8BlCHSWd+1xw=; b=HVxnfgrNRPXMk1JEUdrESadWYoozGaqRSMRwyRPIqHT3a0fulWo4ef+FpPY4caaDyH wyEzFDfjDUvNoyShSdgtTftenz6Cd6qDq35/SXpEhJqDD4SH464JgfDd1+pptNJgW3d8 LQOZTpD+BqZyGD+7iP+sl/7vmKW+vJ6RBQd/C80j1LEGljav3SCNrIqdWF5ewbC+9b1f NhlJ+E+E8uqCSICDDshV4qImEENJKeO39NId90o4WUn7/VEI0py/yabu+5ViWoHa6OQZ Lox5Myf7d25C0bOXlwBk8Wj2JZfyzdOUTHjLQVeoS7nB2UPay3JdSOoHwBojkIMcxKYU qVWQ== X-Gm-Message-State: AGi0PuZKZJW07vO5IZUNpfhb7f3zFVwyGblJRRblb0z3voaB4+2c4NWv JBsOFE4YQSerb3yviGAd+klelartbRk= X-Google-Smtp-Source: APiQypJq6+kYz4zO1NOM2DISz8rNpdjDjCjG24dNBfTwtZAGKDpqwVWJk/ztIm7wMhzyGHD/sE6FQA== X-Received: by 2002:a17:90a:1984:: with SMTP id 4mr1877086pji.36.1588367631967; Fri, 01 May 2020 14:13:51 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 4/6] target/arm: Remove unnecessary range check for VSHL Date: Fri, 1 May 2020 14:13:43 -0700 Message-Id: <20200501211345.30410-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200501211345.30410-1-richard.henderson@linaro.org> References: <20200501211345.30410-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1042; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1042.google.com X-detected-operating-system: by eggs.gnu.org: Error: [-] PROGRAM ABORT : Malformed IPv6 address (bad octet value). Location : parse_addr6(), p0f-client.c:67 X-Received-From: 2607:f8b0:4864:20::1042 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" In 1dc8425e551, while converting to gvec, I added an extra range check against the shift count. This was unnecessary because the encoding of the shift count produces 0 to the element size - 1. Signed-off-by: Richard Henderson --- target/arm/translate.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index f730eb5b75..f082384117 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -6126,16 +6126,8 @@ static int disas_neon_data_insn(DisasContext *s, uin= t32_t insn) gen_gvec_sli(size, rd_ofs, rm_ofs, shift, vec_size, vec_size); } else { /* VSHL */ - /* Shifts larger than the element size are - * architecturally valid and results in zero. - */ - if (shift >=3D 8 << size) { - tcg_gen_gvec_dup_imm(size, rd_ofs, - vec_size, vec_size, 0); - } else { - tcg_gen_gvec_shli(size, rd_ofs, rm_ofs, shift, - vec_size, vec_size); - } + tcg_gen_gvec_shli(size, rd_ofs, rm_ofs, shift, + vec_size, vec_size); } return 0; } --=20 2.20.1