From nobody Tue Feb 10 04:14:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1588235268; cv=none; d=zohomail.com; s=zohoarc; b=hAXAxCT/R9ykyLZzNRDz6WJbBnH7yhYAEnMSL7QTmuFYVWZewWygFod09tpIIr91zfBfm3yg/838mMD806sg65NUovyaB5hQILEiqe2Tn9DtehX8QqxJJLnRcaF3kqmoYn3r/8v2OL4X9gt/Ur94+lmeBOMGCRUiUhJ0/gbkxNA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588235268; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Ha4LSkRs+FV4XQfYz+Fk72LLyMrIOSx/L/VRcKQ8CNA=; b=IXDMoEaWXEI2HY8MqptLvAXrjznecZrTT7llJ5sW+sWg4b0QGjj+ayfAeVRAOuNpDiLLGqmEbEwflmbYm4AUy5WqOfjYdBvc1//P4m80rWFzaD6yomw71ayZ5JfzZ5pKEWU63trg6PmyzJEFQRe5z4d7uu+cUMqYaePgxbo5GJ0= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588235268769912.9502479916871; Thu, 30 Apr 2020 01:27:48 -0700 (PDT) Received: from localhost ([::1]:44550 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jU4Xr-0002Aw-1c for importer@patchew.org; Thu, 30 Apr 2020 04:27:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41292) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jU4Wt-000104-Al for qemu-devel@nongnu.org; Thu, 30 Apr 2020 04:27:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jU4U7-0002EG-MA for qemu-devel@nongnu.org; Thu, 30 Apr 2020 04:26:47 -0400 Received: from mga14.intel.com ([192.55.52.115]:10658) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jU4U7-0002E0-4v for qemu-devel@nongnu.org; Thu, 30 Apr 2020 04:23:55 -0400 Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2020 01:23:53 -0700 Received: from joy-optiplex-7040.sh.intel.com ([10.239.13.16]) by fmsmga004.fm.intel.com with ESMTP; 30 Apr 2020 01:23:50 -0700 IronPort-SDR: mQfk6FIm7S1rFrHx+3Y7yv1J7lCeilJQNrOIRw7yNOqAUk/9xF4zJdgJzKxqPaTVaiy+TLcYoJ N7+63h1de9Kw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False IronPort-SDR: sor0dj/ImWEAu+nCB0L0H3+VmscKb5QjBSTKC71GyDWOCMdrdM0YZSw+DQ83sXrTWRZCdh14L6 604yrLkklAGA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,334,1583222400"; d="scan'208";a="282785028" From: Yan Zhao To: pbonzini@redhat.com, alex.williamson@redhat.com Subject: [PATCH v6 3/3] hw/vfio: let read-only flag take effect for mmap'd regions Date: Thu, 30 Apr 2020 04:13:53 -0400 Message-Id: <20200430081353.31400-1-yan.y.zhao@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200430080744.31232-1-yan.y.zhao@intel.com> References: <20200430080744.31232-1-yan.y.zhao@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=192.55.52.115; envelope-from=yan.y.zhao@intel.com; helo=mga14.intel.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/30 03:10:52 X-ACL-Warn: Detected OS = FreeBSD 9.x or newer [fuzzy] X-Received-From: 192.55.52.115 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yan Zhao , xin.zeng@intel.com, philmd@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" along side setting host page table to be read-only, the memory regions are also required to be read-only, so that when guest writes to the read-only & mmap'd regions, vmexits would happen and region write handlers are called. Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Yan Zhao Signed-off-by: Xin Zeng --- hw/vfio/common.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 2a4fedfeaa..bf510e66c0 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -980,6 +980,10 @@ int vfio_region_mmap(VFIORegion *region) name, region->mmaps[i].size, region->mmaps[i].mmap); g_free(name); + + if (!(region->flags & VFIO_REGION_INFO_FLAG_WRITE)) { + memory_region_set_readonly(®ion->mmaps[i].mem, true); + } memory_region_add_subregion(region->mem, region->mmaps[i].offset, ®ion->mmaps[i].mem); =20 --=20 2.17.1