From nobody Fri Nov 14 15:20:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1588225153; cv=none; d=zohomail.com; s=zohoarc; b=nZ4rjttpM9q8FB+Au8/wsd21EW1/mZdb1TGv7qrSQaGckZjv8LSxdKrslEvHei2VCj5Dm0g4zZpvJzNc/x37FOXCMh5I/ls/DOpDGVHAIyGqclp8DM7buT3CHxbm9BnrTlcNBFGj1L1OawNGUg/gLukB+bava0EHaeoot/O7JhE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588225153; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ocjDn+u5WMI4/nd99OixpijD3tTIFIO6ARnxARf7t0c=; b=aRHJhZ+XB6tgHSR8i2+Iho0z5cNVx0mp3fH4LqOR2uGq0gyaeffov+NauPOPE8eAW2fHLOJfv7wyPNre9M9wChADE/M5SiVSw7QaPc2bGah/vmVnOO0aex+IMkdDLTj3rjDLIJ/cpHk4Hg52PzsQ7uniUFGwUvOtjl2GwtT7uQI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158822515380084.88534496127613; Wed, 29 Apr 2020 22:39:13 -0700 (PDT) Received: from localhost ([::1]:43028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jU1ui-0002ip-Fo for importer@patchew.org; Thu, 30 Apr 2020 01:39:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53376) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jU1n4-00051n-Fv for qemu-devel@nongnu.org; Thu, 30 Apr 2020 01:31:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jU1n0-0002eO-D0 for qemu-devel@nongnu.org; Thu, 30 Apr 2020 01:31:18 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:40838 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jU1my-0002ce-VR for qemu-devel@nongnu.org; Thu, 30 Apr 2020 01:31:13 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-271-hMB5F5LvPpC3RHzKqQ7dCw-1; Thu, 30 Apr 2020 01:31:09 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 02929107ACF2 for ; Thu, 30 Apr 2020 05:31:08 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-113-6.ams2.redhat.com [10.36.113.6]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C648C10023A6; Thu, 30 Apr 2020 05:31:07 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id E6F8711358C3; Thu, 30 Apr 2020 07:31:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588224671; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ocjDn+u5WMI4/nd99OixpijD3tTIFIO6ARnxARf7t0c=; b=X/O9mEY6Ak6qs8MGVp4PKaqn3V0M4HkVtrsqiQ6YGcGH6rZ5blTjrf0I0BByh2Oh/yJLdp pWVjR3bwTAEN0aHNF5MJ0hcwXbQtjjdVayF+6CgMBN4r5bpT+ftGOL433vmPmoTV/TOd7p FmsxFvzmmJqMiAuqjZ/Aig0s+9Ymv8c= X-MC-Unique: hMB5F5LvPpC3RHzKqQ7dCw-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PULL 07/20] qapi: Fix the virtual walk example in visitor.h's big comment Date: Thu, 30 Apr 2020 07:30:51 +0200 Message-Id: <20200430053104.32204-8-armbru@redhat.com> In-Reply-To: <20200430053104.32204-1-armbru@redhat.com> References: <20200430053104.32204-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.120; envelope-from=armbru@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/29 23:34:52 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Call visit_check_list(). Missed in commit a4a1c70dc7 "qapi: Make input visitors detect unvisited list tails". Drop an irrelevant error_propagate() while there. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <20200424084338.26803-3-armbru@redhat.com> --- include/qapi/visitor.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/qapi/visitor.h b/include/qapi/visitor.h index f8a0fc1ea9..7f63e4c381 100644 --- a/include/qapi/visitor.h +++ b/include/qapi/visitor.h @@ -215,6 +215,9 @@ * goto outlist; * } * outlist: + * if (!err) { + * visit_check_list(v, &err); + * } * visit_end_list(v, NULL); * if (!err) { * visit_check_struct(v, &err); @@ -222,7 +225,6 @@ * outobj: * visit_end_struct(v, NULL); * out: - * error_propagate(errp, err); * visit_free(v); * */ --=20 2.21.1