From nobody Sun Feb 8 21:43:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1588225626; cv=none; d=zohomail.com; s=zohoarc; b=bLaimjXNqrL8kHU5FdyE9YdAhJ1knK1jJ/fm8Ak7bmVwdCBZmtBKNRhs1Iu5k/nAIwPrsAvxBzb/syRvXOQiuiYYj06zjlj8cOaaV6I6svum7pcE2WFblEJA/mxYw4Rwzlr+StYG6NMWlodO6EWozjq2JN/ZWTRT0sBFpAbC7uM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588225626; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Ha4LSkRs+FV4XQfYz+Fk72LLyMrIOSx/L/VRcKQ8CNA=; b=UHku4fVH5Pg8DRAXMaU8I3MYHLjQC5x4WqNVSc72RtnKTO8ohHtNphYXyIrhexdZIU+vBNV3IRdGuI4pBwubHWF/KC0XpfKJdKL/pZvjNodMzMsAyZ25Apx6ia3+PFCQTljrss24EKWw2SQZ8kK+uy7tUmYe94aw8L2daSq1gEw= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588225626490343.4794522660874; Wed, 29 Apr 2020 22:47:06 -0700 (PDT) Received: from localhost ([::1]:38780 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jU22L-0005FM-4B for importer@patchew.org; Thu, 30 Apr 2020 01:47:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53618) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jU1pa-0001LI-0J for qemu-devel@nongnu.org; Thu, 30 Apr 2020 01:33:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jU1pZ-0004VS-Jc for qemu-devel@nongnu.org; Thu, 30 Apr 2020 01:33:53 -0400 Received: from mga18.intel.com ([134.134.136.126]:48291) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jU1pZ-0004Of-14 for qemu-devel@nongnu.org; Thu, 30 Apr 2020 01:33:53 -0400 Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2020 22:33:51 -0700 Received: from joy-optiplex-7040.sh.intel.com ([10.239.13.16]) by fmsmga008.fm.intel.com with ESMTP; 29 Apr 2020 22:33:49 -0700 IronPort-SDR: 5ME+KCo09MSl54loFRnToDEZFhmYE+SakJurR7Lpcfq0oHgZ+G4qc84MmzlabsIYA6qcjz3gUf ufsFiHllodoA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False IronPort-SDR: dGqiuojrI12cRxDWZSNbArBBKW0qp3YGxrNao6KDkgH8m+C14xUOUfvU4RpsGiu7Dt7APNH1PI /fa90OfmMdPw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,334,1583222400"; d="scan'208";a="249650098" From: Yan Zhao To: pbonzini@redhat.com, alex.williamson@redhat.com Subject: [PATCH v5 3/3] hw/vfio: let read-only flag take effect for mmap'd regions Date: Thu, 30 Apr 2020 01:24:04 -0400 Message-Id: <20200430052404.29290-1-yan.y.zhao@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200430051558.28991-1-yan.y.zhao@intel.com> References: <20200430051558.28991-1-yan.y.zhao@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=134.134.136.126; envelope-from=yan.y.zhao@intel.com; helo=mga18.intel.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/29 23:42:54 X-ACL-Warn: Detected OS = FreeBSD 9.x or newer [fuzzy] X-Received-From: 134.134.136.126 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yan Zhao , xin.zeng@intel.com, philmd@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" along side setting host page table to be read-only, the memory regions are also required to be read-only, so that when guest writes to the read-only & mmap'd regions, vmexits would happen and region write handlers are called. Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Yan Zhao Signed-off-by: Xin Zeng --- hw/vfio/common.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 2a4fedfeaa..bf510e66c0 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -980,6 +980,10 @@ int vfio_region_mmap(VFIORegion *region) name, region->mmaps[i].size, region->mmaps[i].mmap); g_free(name); + + if (!(region->flags & VFIO_REGION_INFO_FLAG_WRITE)) { + memory_region_set_readonly(®ion->mmaps[i].mem, true); + } memory_region_add_subregion(region->mem, region->mmaps[i].offset, ®ion->mmaps[i].mem); =20 --=20 2.17.1