From nobody Mon Feb 9 13:38:28 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1588161408; cv=none; d=zohomail.com; s=zohoarc; b=RGD8XLqrz+Nzqhzqt2WQmZL9iZQY7wsMluq2RVcSVMNVIs3DoTSXfqUBA8ucYyJiDLlhkJtBBGanxfeNdMhsHKfcsyigV0qKPWqZ3QpvD337gDF0mXxNcZHUl10wrfd2uuRHQA2B5xKNdgNMPin3eCWuy8UlaQ9lZIstCfX6g5U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588161408; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=fOuUDLYZ45AHPnCIWp/al4iAPJBJrcFw0e2TQJnEVQk=; b=XdkzKJBXmCAkRkJilUssxxUKgdrUDMaKjeGxTYK9g8plaRJSk4qyB9A66cYZmtlX+NoN/c5lt8R+yJraevUrA1jLnTUks1IvXzVeR8TWeBsKqrn1sL6+GiAXVmxwXvuGCmPxbM3GDxzA1z51HqY7RWTSziWF6wRWaEBDhY0Y3iM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588161408293316.21955298825947; Wed, 29 Apr 2020 04:56:48 -0700 (PDT) Received: from localhost ([::1]:58754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTlKY-0004fE-US for importer@patchew.org; Wed, 29 Apr 2020 07:56:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50904) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTlGn-0005zd-KW for qemu-devel@nongnu.org; Wed, 29 Apr 2020 07:52:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTlGn-00020U-7B for qemu-devel@nongnu.org; Wed, 29 Apr 2020 07:52:53 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:32746 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jTlGm-00020L-Re for qemu-devel@nongnu.org; Wed, 29 Apr 2020 07:52:52 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-427-XlklErG0NqWY5YyvuKxcZw-1; Wed, 29 Apr 2020 07:52:50 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B04FB107ACCD; Wed, 29 Apr 2020 11:52:49 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-113-193.ams2.redhat.com [10.36.113.193]) by smtp.corp.redhat.com (Postfix) with ESMTP id 44B4E66064; Wed, 29 Apr 2020 11:52:44 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 220C29D9E; Wed, 29 Apr 2020 13:52:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588161172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fOuUDLYZ45AHPnCIWp/al4iAPJBJrcFw0e2TQJnEVQk=; b=UHITsNIphWlVrhj2R9VmPJ9bOrjqiyJubEZCURCNz27HM8+5kZ5TPSJXJx6oNxOGruDvus 3jkFJko67dblVsZe2JxOGIH60srbwVGc7cMx4r0OHDjRXYqP3VRWIQtDuwcrdu3EC+6654 Q81xTCOh4r3R22N7lD918qbpCT1d/SA= X-MC-Unique: XlklErG0NqWY5YyvuKxcZw-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PATCH v2 5/6] ramfb: add sanity checks to ramfb_create_display_surface Date: Wed, 29 Apr 2020 13:52:35 +0200 Message-Id: <20200429115236.28709-6-kraxel@redhat.com> In-Reply-To: <20200429115236.28709-1-kraxel@redhat.com> References: <20200429115236.28709-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.120; envelope-from=kraxel@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/29 01:18:10 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Alex Williamson , lersek@redhat.com, Gerd Hoffmann , hqm03ster@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Gerd Hoffmann Reviewed-by: Laszlo Ersek --- hw/display/ramfb.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/display/ramfb.c b/hw/display/ramfb.c index eb8b4bc49a2f..be884c9ea837 100644 --- a/hw/display/ramfb.c +++ b/hw/display/ramfb.c @@ -15,6 +15,7 @@ #include "qapi/error.h" #include "hw/loader.h" #include "hw/display/ramfb.h" +#include "hw/display/bochs-vbe.h" /* for limits */ #include "ui/console.h" #include "sysemu/reset.h" =20 @@ -49,6 +50,11 @@ static DisplaySurface *ramfb_create_display_surface(int = width, int height, hwaddr size; void *data; =20 + if (width < 16 || width > VBE_DISPI_MAX_XRES || + height < 16 || height > VBE_DISPI_MAX_YRES || + format =3D=3D 0 /* unknown format */) + return NULL; + if (linesize =3D=3D 0) { linesize =3D width * PIXMAN_FORMAT_BPP(format) / 8; } --=20 2.18.2