From nobody Fri Nov 14 12:19:41 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1587998013; cv=none; d=zohomail.com; s=zohoarc; b=lnFIbWu5R4nTQzArmjKqu7qEtIVJuan7cFbckXb0VfXFEUN+suqLNsODfcx4HWKe/Qf/IUGKOlZE8iinGpRyPi6QSsekbIByy5kPbMzBGRSy9usAmF8660OSQpLwOEvEHYIqJD96AppSoOjVeOQnHluCeJFcsz6eHmWpMgom6/k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1587998013; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wF53oQKHsTYpLrSDR4DejZ9174KDt94gCTwACYMoD4Q=; b=Xmd6Eea4khvo2YqS5/uggN3at8XhLGO9AtKSwdDPtMsJ+z75iBj7ivFrqODKw/X3pdrFyLo2e95C/zOo7tPbxi+o0NvC0XebKWCHPZOMkliqbGd3Xcz6kIhwe10B6DFktXRzS/SqZPy0FBp1nzme26aUyXpR1YtCgL/Idy/iJ6g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15879980131590.9760743963206551; Mon, 27 Apr 2020 07:33:33 -0700 (PDT) Received: from localhost ([::1]:48180 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jT4p9-00029Y-RG for importer@patchew.org; Mon, 27 Apr 2020 10:33:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55464) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jT4nr-0000bb-NG for qemu-devel@nongnu.org; Mon, 27 Apr 2020 10:32:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jT4nn-00017R-S3 for qemu-devel@nongnu.org; Mon, 27 Apr 2020 10:32:10 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:34415 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jT4nl-00014Z-VJ for qemu-devel@nongnu.org; Mon, 27 Apr 2020 10:32:06 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-32-hjOcA5zrNPO-cMdOVnHuyw-1; Mon, 27 Apr 2020 10:32:02 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F2F76100A61D; Mon, 27 Apr 2020 14:32:00 +0000 (UTC) Received: from laptop.redhat.com (ovpn-115-95.ams2.redhat.com [10.36.115.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id 719B36062C; Mon, 27 Apr 2020 14:31:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587997924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wF53oQKHsTYpLrSDR4DejZ9174KDt94gCTwACYMoD4Q=; b=Q0n4+uNcILxmUWaDI74RT6JHgj3j3MDQq0VL+/uq2LP16MlIoaTzZ7GIbRNTqzS5qdRR2c GuJPmGxgEX0Kc9UFm9b9Bb/Q8hwniEGmIIK4yXJssergHDVM8Sq0nQDvJ0ehmZBM8i/IaR ruyiJ7vh4CxM1CR4GhNIZ6Typayg0qw= X-MC-Unique: hjOcA5zrNPO-cMdOVnHuyw-1 From: Eric Auger To: eric.auger.pro@gmail.com, eric.auger@redhat.com, stefanb@linux.ibm.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org, cohuck@redhat.com Subject: [PATCH 1/2] tpm: tpm-tis-device: set PPI to false by default Date: Mon, 27 Apr 2020 16:31:44 +0200 Message-Id: <20200427143145.16251-2-eric.auger@redhat.com> In-Reply-To: <20200427143145.16251-1-eric.auger@redhat.com> References: <20200427143145.16251-1-eric.auger@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=eric.auger@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/26 23:32:35 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drjones@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The tpm-tis-device device does not support PPI. Let's change the default value for the corresponding property instead of tricking this latter in the mach-virt machine. Signed-off-by: Eric Auger Reviewed-by: Cornelia Huck Reviewed-by: Peter Maydell Reviewed-by: Stefan Berger --- hw/tpm/tpm_tis_sysbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/tpm/tpm_tis_sysbus.c b/hw/tpm/tpm_tis_sysbus.c index 18c02aed67..eced1fc843 100644 --- a/hw/tpm/tpm_tis_sysbus.c +++ b/hw/tpm/tpm_tis_sysbus.c @@ -91,7 +91,7 @@ static void tpm_tis_sysbus_reset(DeviceState *dev) static Property tpm_tis_sysbus_properties[] =3D { DEFINE_PROP_UINT32("irq", TPMStateSysBus, state.irq_num, TPM_TIS_IRQ), DEFINE_PROP_TPMBE("tpmdev", TPMStateSysBus, state.be_driver), - DEFINE_PROP_BOOL("ppi", TPMStateSysBus, state.ppi_enabled, true), + DEFINE_PROP_BOOL("ppi", TPMStateSysBus, state.ppi_enabled, false), DEFINE_PROP_END_OF_LIST(), }; =20 --=20 2.20.1 From nobody Fri Nov 14 12:19:41 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1587998099; cv=none; d=zohomail.com; s=zohoarc; b=aneOTUCG7GEXrt83Rjo1QOIVY3+P4ogprkKdvpFk0/IY1MIokMh1AjEa/QrbEor2vfS8x4UBLs6moSS41nFuua4Bp2+XlGePuwlLt7adNa+dGj4g56XB6vQsNXXCkZQws/n9N3LXzP2TQhtZ12DWjba43ynxebX/A8FeuEr+YrU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1587998099; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6DSoist89sLde+5SYreI/3BC1hTgpbC4HndD/VV2RXg=; b=RfAhdEz3at4QE3V0Y636qsRQmpPxm433yvMYTyjQ0GCGDwyB7/KUTpgF3rBTfMQB0TQu75pgP5/bK651sH+t3OsDMwuDANpd8vnXFUA6emftHHfAyY4eoYN4e87nfCTiECk1p5E7P3HtXRdn9cs30iZ4ZwcDZqusNrpYTwDUsi4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158799809944850.2380939135727; Mon, 27 Apr 2020 07:34:59 -0700 (PDT) Received: from localhost ([::1]:48272 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jT4qY-0004Vh-20 for importer@patchew.org; Mon, 27 Apr 2020 10:34:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55468) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jT4nr-0000bm-Pl for qemu-devel@nongnu.org; Mon, 27 Apr 2020 10:32:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jT4nr-00018M-AD for qemu-devel@nongnu.org; Mon, 27 Apr 2020 10:32:11 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:37328 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jT4np-000182-Rb for qemu-devel@nongnu.org; Mon, 27 Apr 2020 10:32:10 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-221-oQocEFixNfCA6zbhkX8ufw-1; Mon, 27 Apr 2020 10:32:06 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A72551B18BC2; Mon, 27 Apr 2020 14:32:05 +0000 (UTC) Received: from laptop.redhat.com (ovpn-115-95.ams2.redhat.com [10.36.115.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id BDE0A6062C; Mon, 27 Apr 2020 14:32:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587997929; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6DSoist89sLde+5SYreI/3BC1hTgpbC4HndD/VV2RXg=; b=g/4AdATjFIPEgs1rMT4oYYcCnRRjhPCz9X1JprJXd6Qd7VQWFmLvGKujdhxFVmRLPdwg0Z jSNjgFaxXjMUwHwy49O/8iqEj4jgVekP3KbVC0D+3Naa9xaL7tbMv/Au7mGUAyJ9RRjjPo cGOPp2Qeiumbc5LVMDTYfIXJ7yj2pTE= X-MC-Unique: oQocEFixNfCA6zbhkX8ufw-1 From: Eric Auger To: eric.auger.pro@gmail.com, eric.auger@redhat.com, stefanb@linux.ibm.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org, cohuck@redhat.com Subject: [PATCH 2/2] hw/arm/virt: Remove the compat forcing tpm-tis-device PPI to off Date: Mon, 27 Apr 2020 16:31:45 +0200 Message-Id: <20200427143145.16251-3-eric.auger@redhat.com> In-Reply-To: <20200427143145.16251-1-eric.auger@redhat.com> References: <20200427143145.16251-1-eric.auger@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.120; envelope-from=eric.auger@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/27 02:05:28 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drjones@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Now that the tpm-tis-device device PPI property is off by default, we can remove the compat used for the same goal. Signed-off-by: Eric Auger Reviewed-by: Cornelia Huck Reviewed-by: Peter Maydell Reviewed-by: Stefan Berger --- hw/arm/virt.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 7dc96abf72..2a68306f28 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -2311,11 +2311,6 @@ type_init(machvirt_machine_init); =20 static void virt_machine_5_0_options(MachineClass *mc) { - static GlobalProperty compat[] =3D { - { TYPE_TPM_TIS_SYSBUS, "ppi", "false" }, - }; - - compat_props_add(mc->compat_props, compat, G_N_ELEMENTS(compat)); } DEFINE_VIRT_MACHINE_AS_LATEST(5, 0) =20 --=20 2.20.1