From nobody Sun Feb 8 11:35:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1587993958; cv=none; d=zohomail.com; s=zohoarc; b=dQGFfjvaixKkAxN6aVRukvwZM3rZBGnHWwqdDteidjIUvtsgqTP0MYGE1zmHvmbCi52lDLrbuHgZkONLqsCnmsa+eYJO8ff9oT6kiXIKnfTw0RVC5VDsjnXQTgRyAKE8oOVRTGiP8hup0e/do7aPrEqP5FjV2Oj9ZuSsQviBr7k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1587993958; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=yntwoKjwQcRE9wIsHn1qcGJYKZYmp0BzBHc7v26DwEw=; b=dyKiUu4Le7/LOCxeT9A71Xo3HV3FjAAFWdMo3nNK06H1FPzrGxrbktlcxa6dxcxMCd7seQW4Xz7usLdmsNoxLZGmFP4ZzFkvqajVRd/ied3Fh88AN3bmgcLGYu1+oVcWgvlypHJtOipJzn41BK4RkTmPz9qPwU1CXfKYzRjEnFE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1587993958782202.83715525589048; Mon, 27 Apr 2020 06:25:58 -0700 (PDT) Received: from localhost ([::1]:45276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jT3ll-00052q-EH for importer@patchew.org; Mon, 27 Apr 2020 09:25:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44882) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jT3kZ-0003SI-4Y for qemu-devel@nongnu.org; Mon, 27 Apr 2020 09:24:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jT3kY-0004Pn-LI for qemu-devel@nongnu.org; Mon, 27 Apr 2020 09:24:42 -0400 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]:38080) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jT3kY-0004Pb-8z for qemu-devel@nongnu.org; Mon, 27 Apr 2020 09:24:42 -0400 Received: by mail-pg1-x543.google.com with SMTP id p8so8675982pgi.5 for ; Mon, 27 Apr 2020 06:24:41 -0700 (PDT) Received: from vultr.guest ([149.248.10.52]) by smtp.gmail.com with ESMTPSA id q6sm8378475pfh.193.2020.04.27.06.24.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2020 06:24:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yntwoKjwQcRE9wIsHn1qcGJYKZYmp0BzBHc7v26DwEw=; b=U/HxSKgqfWGvhOBO6lykg2tYmXekyKzJOpJ68FBiccbUOaYffN2zajdqOU0VOs4DHU xdhI2b8DZ36dGLEe2UczE8CmkxDZErT+XEyYZpR+1O941ai59Z838vo1uW1zL4bmfVdv MvJn3KZ9DJoJVe0fbFoHY/dOqAMwOJoRjI3beKFu1BkOpeaaSehb3chqc3XdSOu5ENkw 2+cn4XWMwO6vRaV8sC2WYlDsia5aHF03VMtoJwNL3VOGay0iQMvj0eOoKTarAvBcmeAw 0nRM2qm7CVA+D0dyhDKC0hxsErRauKXeqV7pC4aNF0idGgt5nf9wBH+AA9qDnd4F0x9h 4mNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yntwoKjwQcRE9wIsHn1qcGJYKZYmp0BzBHc7v26DwEw=; b=udSHgWQvD78lyDdBWvXWA/k6q7D9ssbIlp5v3ZMr9if3xQJSoPq4fRcUvbbQI8hSTJ +X2Gk7An9s1Q/PhgSbC5+RXcJa+0A0oPxv6MSVDBPELem+tMkOqNpsd7ik6oUHEAxMYJ BSh04zHLAG1gdL72ZTYvD9Q7cb9zo9e3YnuIYVPcV87GXGCnqn2N7CAiemUFvR98B7gL dZSH3kNo/GwpixJzB3lTPZ184KlpD+iQiEji1w2TcsDEFX5b/++lCn+6A3S36XCcPCR1 ZkDjxAquvFk5JxfMi/Bmh5hwoOVu8Lh8QRrccpM3Z2A8CiYHbvjAY6jAI/3IuIvphMW8 UY/w== X-Gm-Message-State: AGi0PuY63SqhAeKOA1VoxO0ge3vaAHW+7dd5GWsFo4beNqmVZxCUDYaG dbmG5VlLXo/GXXkmdlNDUgA= X-Google-Smtp-Source: APiQypKpDhJbMU7kp2Q5YNdADSSpQaOGfhG9X10yPwQy9VXknpqGAkZ/y33MPI6gmHTilRqL8v+K3g== X-Received: by 2002:a63:4d18:: with SMTP id a24mr21881864pgb.97.1587993880889; Mon, 27 Apr 2020 06:24:40 -0700 (PDT) From: Changbin Du To: Gerd Hoffmann Subject: [PATCH v2] ui/sdl2: fix segment fault caused by null pointer dereference Date: Mon, 27 Apr 2020 21:24:12 +0800 Message-Id: <20200427132412.17909-1-changbin.du@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::543; envelope-from=changbin.du@gmail.com; helo=mail-pg1-x543.google.com X-detected-operating-system: by eggs.gnu.org: Error: [-] PROGRAM ABORT : Malformed IPv6 address (bad octet value). Location : parse_addr6(), p0f-client.c:67 X-Received-From: 2607:f8b0:4864:20::543 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Changbin Du Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) Content-Type: text/plain; charset="utf-8" I found SDL_GetWindowFromID() sometimes return NULL when I start qemu via ssh forwarding even the window has been crated already. I am not sure whether this is a bug of SDL, but we'd better check it carefully. Signed-off-by: Changbin Du --- v2: fix typo. --- ui/sdl2.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/ui/sdl2.c b/ui/sdl2.c index 3c9424eb42..61c7956da3 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -332,6 +332,10 @@ static void handle_keydown(SDL_Event *ev) int gui_key_modifier_pressed =3D get_mod_state(); int gui_keysym =3D 0; =20 + if (!scon) { + return; + } + if (!scon->ignore_hotkeys && gui_key_modifier_pressed && !ev->key.repe= at) { switch (ev->key.keysym.scancode) { case SDL_SCANCODE_2: @@ -412,6 +416,10 @@ static void handle_keyup(SDL_Event *ev) { struct sdl2_console *scon =3D get_scon_from_window(ev->key.windowID); =20 + if (!scon) { + return; + } + scon->ignore_hotkeys =3D false; sdl2_process_key(scon, &ev->key); } @@ -421,6 +429,10 @@ static void handle_textinput(SDL_Event *ev) struct sdl2_console *scon =3D get_scon_from_window(ev->text.windowID); QemuConsole *con =3D scon ? scon->dcl.con : NULL; =20 + if (!con) { + return; + } + if (qemu_console_is_graphic(con)) { return; } --=20 2.25.1