From nobody Fri Nov 14 13:37:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1587756225; cv=none; d=zohomail.com; s=zohoarc; b=jBzmXhmDsGdBjcLdnByJReftLQdlAU/e5xeR0QxI5vNC0p19r8kdn7PckWgJZ4Dk0kWn5nlvka56Jep//YtZXstNroY11F1DGoaL8pDRI4dgxF8rEfYnAocZkQOxaa1Th2L+MBKFDXwNmfyiPWZPiBqL78dtNcapWu7+UNpxBW4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1587756225; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Zz6PIHu4D9IJMAUYz5GlS7tUaH56am6CeocpGy7vUGA=; b=WRUNH+aVXOnJYpvcLBUdUYN7fwSpZx3WPl/W8iLjcGfLvfnS3IbwZu/1hk2iEdU+8ipLUIUKYa6EnDKHGyJm+DyRaghbxtFKSJRKKwZ39kI+ChS1pHUehX+pXKL1Thwu7aB0Q8ib8oIzZykgGJkU4osQ5ZfYTs0OcNQPZ5rahbM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1587756225832387.9864644056021; Fri, 24 Apr 2020 12:23:45 -0700 (PDT) Received: from localhost ([::1]:49864 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jS3vM-0001sz-CD for importer@patchew.org; Fri, 24 Apr 2020 15:23:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52956) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jS3sK-0003PX-7l for qemu-devel@nongnu.org; Fri, 24 Apr 2020 15:20:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jS3sJ-00043L-Oj for qemu-devel@nongnu.org; Fri, 24 Apr 2020 15:20:36 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:58888 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jS3sJ-00041x-8q for qemu-devel@nongnu.org; Fri, 24 Apr 2020 15:20:35 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-470-wQXZRtGYODiiH5cS1TWTug-1; Fri, 24 Apr 2020 15:20:32 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0EDB11005510 for ; Fri, 24 Apr 2020 19:20:32 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-113-6.ams2.redhat.com [10.36.113.6]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BF53A605CF for ; Fri, 24 Apr 2020 19:20:31 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 3776811358C1; Fri, 24 Apr 2020 21:20:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587756034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zz6PIHu4D9IJMAUYz5GlS7tUaH56am6CeocpGy7vUGA=; b=PenBfbKVp8irDfpJLbvIhA1Q1Zfk/p6Scx1HEgDs2YtWbxGjU2zooaC7EU+1nTjXMer4se dwG+wa9pPr7oRJp7WXdXmfRKCDO7Jb/k+SPJDiOy2D1ylunVemIEytAk0QgtO/4h/xb5By OYVHC5hitIW+1WjKSHcP7LDrOrf+6og= X-MC-Unique: wQXZRtGYODiiH5cS1TWTug-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PATCH 05/11] tests/migration: Tighten error checking Date: Fri, 24 Apr 2020 21:20:21 +0200 Message-Id: <20200424192027.11404-6-armbru@redhat.com> In-Reply-To: <20200424192027.11404-1-armbru@redhat.com> References: <20200424192027.11404-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/24 02:57:59 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" migrate_get_socket_address() neglects to check visit_type_SocketAddressList() failure. This smells like a leak, but it actually will crash dereferencing @addrs. Pass &error_abort to remove the code smell. Signed-off-by: Markus Armbruster --- tests/qtest/migration-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index 2568c9529c..dc3490c9fa 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration-test.c @@ -13,6 +13,7 @@ #include "qemu/osdep.h" =20 #include "libqtest.h" +#include "qapi/error.h" #include "qapi/qmp/qdict.h" #include "qemu/module.h" #include "qemu/option.h" @@ -301,7 +302,6 @@ static char *migrate_get_socket_address(QTestState *who= , const char *parameter) { QDict *rsp; char *result; - Error *local_err =3D NULL; SocketAddressList *addrs; Visitor *iv =3D NULL; QObject *object; @@ -310,7 +310,7 @@ static char *migrate_get_socket_address(QTestState *who= , const char *parameter) object =3D qdict_get(rsp, parameter); =20 iv =3D qobject_input_visitor_new(object); - visit_type_SocketAddressList(iv, NULL, &addrs, &local_err); + visit_type_SocketAddressList(iv, NULL, &addrs, &error_abort); visit_free(iv); =20 /* we are only using a single address */ --=20 2.21.1