From nobody Mon Feb 9 01:30:51 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1587718250; cv=none; d=zohomail.com; s=zohoarc; b=JTw5t0cj2R5oB5DFBrBTTzWpdMkNZLY86AALI/WA0cOCtO96yGQyje2BOwZOAiWhVX+KoMNRggdiC1nb3ggA8aA16S8zjV8LXGo/2oou8ClbtlidbGQDIM6790zbkz+wqO9SIF+YZ8YEHdvnwuJhh6vQRezwdR+5CiRVVi5+Ews= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1587718250; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=agw2xR3FoLhsUJSn/He3ew7VPz+p34vBOddxjagzng0=; b=Qeqpc0/w49TNQNZaFmAv7FjOO8oqx+CUPr3dI/S8Zo5hdA7idO++oPEOSLkH+JKFc+Me1oSUjLsK4CToF/V3oKrDcv/LfO/COfGjtTSYNOOv5CobmJ37YtnL7+hvHTvDn0x1dFJjM1SEBUmgz8dhTVpvSsbiMAOnCRgy1WC4Mew= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1587718250969496.309852094867; Fri, 24 Apr 2020 01:50:50 -0700 (PDT) Received: from localhost ([::1]:55338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRu2r-0000Zp-6d for importer@patchew.org; Fri, 24 Apr 2020 04:50:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36704) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRtw2-0005ek-Pf for qemu-devel@nongnu.org; Fri, 24 Apr 2020 04:43:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jRtw0-00025P-SA for qemu-devel@nongnu.org; Fri, 24 Apr 2020 04:43:46 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:52226 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jRtw0-00024L-Dw for qemu-devel@nongnu.org; Fri, 24 Apr 2020 04:43:44 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-340-FOyMccDLOF6fKLNF8HO0oQ-1; Fri, 24 Apr 2020 04:43:41 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A9A0180B70E; Fri, 24 Apr 2020 08:43:40 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-113-6.ams2.redhat.com [10.36.113.6]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5CB0B10016DA; Fri, 24 Apr 2020 08:43:40 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id D52AD11358BE; Fri, 24 Apr 2020 10:43:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587717823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=agw2xR3FoLhsUJSn/He3ew7VPz+p34vBOddxjagzng0=; b=Li3NSF9Gg+lo2wmlCsQeLvv08Khs3/pcSrXdjJJMVTVnmper11iNRnc69Pkedm7nadLWir 8d1cyxzZXf67cBsM6yCZr9tKQstaTMtGO/S8sAlsjQimfduWHTchsfPauGbtuNBusczjMM b2CV6nR8lzyawdMczD/ZkLiWH7kX8hE= X-MC-Unique: FOyMccDLOF6fKLNF8HO0oQ-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PATCH v2 02/15] qapi: Fix the virtual walk example in visitor.h's big comment Date: Fri, 24 Apr 2020 10:43:25 +0200 Message-Id: <20200424084338.26803-3-armbru@redhat.com> In-Reply-To: <20200424084338.26803-1-armbru@redhat.com> References: <20200424084338.26803-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/24 02:57:59 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mdroth@linux.vnet.ibm.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Call visit_check_list(). Missed in commit a4a1c70dc7 "qapi: Make input visitors detect unvisited list tails". Drop an irrelevant error_propagate() while there. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- include/qapi/visitor.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/qapi/visitor.h b/include/qapi/visitor.h index f8a0fc1ea9..7f63e4c381 100644 --- a/include/qapi/visitor.h +++ b/include/qapi/visitor.h @@ -215,6 +215,9 @@ * goto outlist; * } * outlist: + * if (!err) { + * visit_check_list(v, &err); + * } * visit_end_list(v, NULL); * if (!err) { * visit_check_struct(v, &err); @@ -222,7 +225,6 @@ * outobj: * visit_end_struct(v, NULL); * out: - * error_propagate(errp, err); * visit_free(v); * */ --=20 2.21.1