From nobody Sun Feb 8 21:47:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1587658202; cv=none; d=zohomail.com; s=zohoarc; b=WhXPHm+5OoWVDODSW9NIqxKmpsRC5JBG7B2Q1i6H9e+TW7fYnwD8iEMF7Bm+aN/PTiP42MArkJysJQz6H/nagM9E/sip2XzV0ZqcGE9uVEG04ezYkhmZQnhYz48moIzAE6b3IV4PzoHLicV4Yzwhw7IbJDje5UnHacBcQQjMkm8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1587658202; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=82PBqwMiQDZXhV2FxXh59m2D3DaX5boDh8uZPfq8DfY=; b=gIDj//cbbLDMPz0XnF0JHX+btnEkv5a7Tc0Lfd9+3UXCMe4QtgcEdIjWbFvrnL5NlKegjuSnnQC3JThlwNFNqrCLdNvF4UWsaO2l8svQmGiUljxcCEmEz4nfp6qoRAkExAmg0x7V0yfRihT4Vcfpa72X9h++xXpp0ProYjuP8F4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1587658202707228.5979038240281; Thu, 23 Apr 2020 09:10:02 -0700 (PDT) Received: from localhost ([::1]:58258 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jReQL-0004Vz-BJ for importer@patchew.org; Thu, 23 Apr 2020 12:10:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59908) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jReHn-00064X-A7 for qemu-devel@nongnu.org; Thu, 23 Apr 2020 12:01:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jReHT-00026E-Is for qemu-devel@nongnu.org; Thu, 23 Apr 2020 12:01:11 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:27484 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jReHS-000228-1l for qemu-devel@nongnu.org; Thu, 23 Apr 2020 12:00:50 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-77-bMrfp-0gPOqFUQp1yNm6ig-1; Thu, 23 Apr 2020 12:00:39 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 285AB107ACF4; Thu, 23 Apr 2020 16:00:38 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-113-6.ams2.redhat.com [10.36.113.6]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E81685D714; Thu, 23 Apr 2020 16:00:37 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 5A2F811358BE; Thu, 23 Apr 2020 18:00:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587657646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=82PBqwMiQDZXhV2FxXh59m2D3DaX5boDh8uZPfq8DfY=; b=bmqZZvuzVbP+p6aDzNPaWnMnmzU2uKfa49/1DKW1fwfLoEAZjEQuMtTxg630sipC8nwQUy 9FVkbstHLXjPiaALqlnL446+8nPst++rEOHswkhFAjCwfnfoIX6lSAuUrsnOTZAkL/P0lv NWNxPecP3RW9yZ/eMcdbb6CpQyhGlXo= X-MC-Unique: bMrfp-0gPOqFUQp1yNm6ig-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PATCH 02/13] qapi: Fix the virtual walk example in visitor.h's big comment Date: Thu, 23 Apr 2020 18:00:25 +0200 Message-Id: <20200423160036.7048-3-armbru@redhat.com> In-Reply-To: <20200423160036.7048-1-armbru@redhat.com> References: <20200423160036.7048-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.81; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/23 02:14:02 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mdroth@linux.vnet.ibm.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Call visit_check_list(). Missed in commit a4a1c70dc7 "qapi: Make input visitors detect unvisited list tails". Drop an irrelevant error_propagate() while there. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- include/qapi/visitor.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/qapi/visitor.h b/include/qapi/visitor.h index f8a0fc1ea9..7f63e4c381 100644 --- a/include/qapi/visitor.h +++ b/include/qapi/visitor.h @@ -215,6 +215,9 @@ * goto outlist; * } * outlist: + * if (!err) { + * visit_check_list(v, &err); + * } * visit_end_list(v, NULL); * if (!err) { * visit_check_struct(v, &err); @@ -222,7 +225,6 @@ * outobj: * visit_end_struct(v, NULL); * out: - * error_propagate(errp, err); * visit_free(v); * */ --=20 2.21.1