From nobody Fri Dec 19 04:30:54 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1586881903; cv=none; d=zohomail.com; s=zohoarc; b=gvKhIu4TlzKnWjnWgSGCPpHRCwvQf8fIeUSUHwqUGXt5mApCJdmEmBlec6x2AFXvR4XwvFU/lTkEAvto7LWWzHdqai0bCF2nMBBgCRw5YZh/FaKHbH/8YGEqw/JLV+63ybBRe+gEuHC07aOf/MnWTRY7rh1K0LC1eDujyX2cuZw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1586881903; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3GfCTfNzdj9dy1pa2ZHw7P0hlDvMSW+Y7bEI+7tRgbU=; b=gmBF4StXzl8V0PMaJLbaeIlzReODibI5eU3bPHf9b4ovfvBmNqfQk1vXhhwtRd6ttXDFyqsdJrugGeqLA9SxH7f88UyDnAbUrZ4OaoEDAXDjeUrsRUrMoVVwN+JSRcTHqDnXgux37MqMj5C3qnl55SfFl1yTLRkd7tU7MUM9w4M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1586881903427926.1850669212042; Tue, 14 Apr 2020 09:31:43 -0700 (PDT) Received: from localhost ([::1]:34158 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOOTO-0006Zb-6T for importer@patchew.org; Tue, 14 Apr 2020 12:31:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51694) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOOON-0005Dy-Ra for qemu-devel@nongnu.org; Tue, 14 Apr 2020 12:26:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOOOI-0007Cc-0R for qemu-devel@nongnu.org; Tue, 14 Apr 2020 12:26:31 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:40622) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jOOOH-0007CE-QB for qemu-devel@nongnu.org; Tue, 14 Apr 2020 12:26:25 -0400 Received: by mail-wr1-x435.google.com with SMTP id h26so3664328wrb.7 for ; Tue, 14 Apr 2020 09:26:25 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id i129sm20003802wmi.20.2020.04.14.09.26.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 09:26:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=3GfCTfNzdj9dy1pa2ZHw7P0hlDvMSW+Y7bEI+7tRgbU=; b=kbkZnarKZKoMu8TADfKifLPL6IFzKUW2Vod37uexqnAMlU8ITuuq8FiES+0YqvTT3N YNSfVeqKbMZxvbRzjqVK4X155boV+bUY9bkMDG6cOdabxwcfQkYyNhZAVhPF6YgjBJ1K 1XhTVN9kKmmdMvHppYAQKxI+FJHPAQ41grycF7k5s/heYIUlnrOEYtr2U/ADwKji0XRJ EmCqg3Bc8DA8flkqSsP6ZHfmAxtNrQM2EwQ2P+i/hhlrbImEP9qmXK1gfOhPXIZbqdZQ 0usYMWxaO9baTIhpEk9ym8bNWuw5q18TMRcnV/D7XrC4iz+XkSi9DgvY0l4kwofF5iSs i2qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3GfCTfNzdj9dy1pa2ZHw7P0hlDvMSW+Y7bEI+7tRgbU=; b=cMhEaPuFNPTWmGbKb6C166APe3GD93AEeQ0GzfSFVf7U7mqRbd2sW7TYuDWz76o7Od lRSlwUt8Jk41afLDkdfQieneR6+1yzDdhe4J+nlLB+8EfR+AuUCpDR9mlCl7vpcz5W69 dXOuJHnVXzfZM5x3RZMebPXBwcpQCDXzHZwCrEu5qg4L1nh9RuJ2o2lLcZbFchHqL8dY aUq78jt0cyfZI2Af2EtM7uqJ5SfgtqoQzNSXIZk8nEwW6usrULyd4JXzVEVm9yOsgYSq pPeNDiqa9t9dQltQ4jFlMLGrOFVqsWXo5ATm3kkwaOsS2fWGpGupmKvfVvcp2oh32vhz Xqog== X-Gm-Message-State: AGi0PuZRQ883XaUc7Eoc1ZEXhaKY1+KnepdoVQ/XYQHlyPAZdXtx5iIW 7lJ5jis7MS7eMP386kFMj55B+dHZwlUCYw== X-Google-Smtp-Source: APiQypLPPzSwAOrb271XFSh72LaJ+Ur0jJK6t0vtw7ZAC0Y5G4yCVP1Slh9upK9XoKmhkcu48uKUaA== X-Received: by 2002:a5d:5085:: with SMTP id a5mr4866957wrt.394.1586881584533; Tue, 14 Apr 2020 09:26:24 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 08/12] configure: Honour --disable-werror for Sphinx Date: Tue, 14 Apr 2020 17:26:09 +0100 Message-Id: <20200414162613.4479-9-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200414162613.4479-1-peter.maydell@linaro.org> References: <20200414162613.4479-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::435 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) If we are not making warnings fatal for compilation, make them non-fatal when building the Sphinx documentation also. (For instance Sphinx 3.0 warns about some constructs that older versions were happy with, which is a build failure if we use the warnings-as-errors flag.) This provides a workaround at least for LP:1872113. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20200411182934.28678-2-peter.maydell@linaro.org Reviewed-by: Alex Benn=C3=A9e --- configure | 9 ++++++++- Makefile | 2 +- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 233c671aaa9..9b1f5b33e45 100755 --- a/configure +++ b/configure @@ -4928,6 +4928,12 @@ if check_include sys/kcov.h ; then kcov=3Dyes fi =20 +# If we're making warnings fatal, apply this to Sphinx runs as well +sphinx_werror=3D"" +if test "$werror" =3D "yes"; then + sphinx_werror=3D"-W" +fi + # Check we have a new enough version of sphinx-build has_sphinx_build() { # This is a bit awkward but works: create a trivial document and @@ -4936,7 +4942,7 @@ has_sphinx_build() { # sphinx-build doesn't exist at all or if it is too old. mkdir -p "$TMPDIR1/sphinx" touch "$TMPDIR1/sphinx/index.rst" - "$sphinx_build" -c "$source_path/docs" -b html "$TMPDIR1/sphinx" "$TMP= DIR1/sphinx/out" >/dev/null 2>&1 + "$sphinx_build" $sphinx_werror -c "$source_path/docs" -b html "$TMPDIR= 1/sphinx" "$TMPDIR1/sphinx/out" >/dev/null 2>&1 } =20 # Check if tools are available to build documentation. @@ -7631,6 +7637,7 @@ echo "INSTALL_PROG=3D$install -c -m 0755" >> $config_= host_mak echo "INSTALL_LIB=3D$install -c -m 0644" >> $config_host_mak echo "PYTHON=3D$python" >> $config_host_mak echo "SPHINX_BUILD=3D$sphinx_build" >> $config_host_mak +echo "SPHINX_WERROR=3D$sphinx_werror" >> $config_host_mak echo "GENISOIMAGE=3D$genisoimage" >> $config_host_mak echo "CC=3D$cc" >> $config_host_mak if $iasl -h > /dev/null 2>&1; then diff --git a/Makefile b/Makefile index 84ef8816000..8a9113e6663 100644 --- a/Makefile +++ b/Makefile @@ -1076,7 +1076,7 @@ sphinxdocs: $(MANUAL_BUILDDIR)/devel/index.html \ # Note the use of different doctree for each (manual, builder) tuple; # this works around Sphinx not handling parallel invocation on # a single doctree: https://github.com/sphinx-doc/sphinx/issues/2946 -build-manual =3D $(call quiet-command,CONFDIR=3D"$(qemu_confdir)" $(SPHINX= _BUILD) $(if $(V),,-q) -W -b $2 -D version=3D$(VERSION) -D release=3D"$(FUL= L_VERSION)" -d .doctrees/$1-$2 $(SRC_PATH)/docs/$1 $(MANUAL_BUILDDIR)/$1 ,"= SPHINX","$(MANUAL_BUILDDIR)/$1") +build-manual =3D $(call quiet-command,CONFDIR=3D"$(qemu_confdir)" $(SPHINX= _BUILD) $(if $(V),,-q) $(SPHINX_WERROR) -b $2 -D version=3D$(VERSION) -D re= lease=3D"$(FULL_VERSION)" -d .doctrees/$1-$2 $(SRC_PATH)/docs/$1 $(MANUAL_B= UILDDIR)/$1 ,"SPHINX","$(MANUAL_BUILDDIR)/$1") # We assume all RST files in the manual's directory are used in it manual-deps =3D $(wildcard $(SRC_PATH)/docs/$1/*.rst $(SRC_PATH)/docs/$1/*= /*.rst) \ $(SRC_PATH)/docs/defs.rst.inc \ --=20 2.20.1