From nobody Mon Feb 9 18:44:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1586759964; cv=none; d=zohomail.com; s=zohoarc; b=MNKLMqeSOBJWx4Qf9Grjk6is1D0o0jwCjrRfWamgwj8asgyRoJtD/JWO6DNpLvuU1w+rlhukwT+FwY/htMOjXG+uKlC8YKecwekRkylQS8VHOn5lxdQoiifGqs4lfmlLrLrrmHkD4q/Nd9cwZLxj+khISKn4mycrdtiiiniEKQ8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1586759964; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=ZYqxq9KR6NkWfqFxXwOrk0e3evu8rK7aJSoz1YqsRrM=; b=e3IaOa43meZ7VTHHdTt5X8VgICWHNYXPS/jtdwKLMGO0cFWqoOkckaaqKEuZb9AYpF5Xs+y8NRWp/K82fSt2qASjcuZ9eiyrB2QK48HmnHPcXNLdKkXfPRtuvYy2JmGdvQFziTZZkO8u0xbtNTYUqrr0O0cf39fdZZScO9Q8N+E= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1586759964666890.0104391935935; Sun, 12 Apr 2020 23:39:24 -0700 (PDT) Received: from localhost ([::1]:40858 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNskd-00049c-GR for importer@patchew.org; Mon, 13 Apr 2020 02:39:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33120) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNsjr-0003IR-VI for qemu-devel@nongnu.org; Mon, 13 Apr 2020 02:38:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jNsjq-0006gv-5A for qemu-devel@nongnu.org; Mon, 13 Apr 2020 02:38:35 -0400 Received: from mga06.intel.com ([134.134.136.31]:33140) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jNsjo-0006gb-EC for qemu-devel@nongnu.org; Mon, 13 Apr 2020 02:38:33 -0400 Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2020 23:38:30 -0700 Received: from dpdk-zhirun.sh.intel.com ([10.67.119.121]) by fmsmga005.fm.intel.com with ESMTP; 12 Apr 2020 23:38:28 -0700 IronPort-SDR: dVctFnm20N05LAnKRfkIcVak6KWnLKo3h/P/sEwloeSXs8FxUGq8MlpHT2OhEZL/MWqukp8qVc G5LhJv19djmg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False IronPort-SDR: v7W8ERY5H+032SlrriuMM451Js3srNohW6xGJMlTsDrjMZ5mJqCfllAj/R+Or27QyDHfB9nPLM hSWDDawfO5SQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,377,1580803200"; d="scan'208";a="453062288" From: Yan Zhao To: qemu-devel@nongnu.org Subject: [PATCH v3 1/3] memory: drop guest writes to read-only ram device regions Date: Mon, 13 Apr 2020 06:37:13 +0000 Message-Id: <20200413063713.84659-1-yan.y.zhao@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200413063627.84608-1-yan.y.zhao@intel.com> References: <20200413063627.84608-1-yan.y.zhao@intel.com> X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 134.134.136.31 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yan Zhao , Xin Zeng , alex.williamson@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, philmd@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" for ram device regions, drop guest writes if the regions is read-only. Signed-off-by: Yan Zhao Signed-off-by: Xin Zeng --- memory.c | 6 +++++- trace-events | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/memory.c b/memory.c index 601b749906..a380b59980 100644 --- a/memory.c +++ b/memory.c @@ -1312,7 +1312,11 @@ static void memory_region_ram_device_write(void *opa= que, hwaddr addr, { MemoryRegion *mr =3D opaque; =20 - trace_memory_region_ram_device_write(get_cpu_index(), mr, addr, data, = size); + trace_memory_region_ram_device_write(get_cpu_index(), mr, addr, data, + size, mr->readonly); + if (mr->readonly) { + return; + } =20 switch (size) { case 1: diff --git a/trace-events b/trace-events index 42107ebc69..e1de662973 100644 --- a/trace-events +++ b/trace-events @@ -61,7 +61,7 @@ memory_region_ops_write(int cpu_index, void *mr, uint64_t= addr, uint64_t value, memory_region_subpage_read(int cpu_index, void *mr, uint64_t offset, uint6= 4_t value, unsigned size) "cpu %d mr %p offset 0x%"PRIx64" value 0x%"PRIx64= " size %u" memory_region_subpage_write(int cpu_index, void *mr, uint64_t offset, uint= 64_t value, unsigned size) "cpu %d mr %p offset 0x%"PRIx64" value 0x%"PRIx6= 4" size %u" memory_region_ram_device_read(int cpu_index, void *mr, uint64_t addr, uint= 64_t value, unsigned size) "cpu %d mr %p addr 0x%"PRIx64" value 0x%"PRIx64"= size %u" -memory_region_ram_device_write(int cpu_index, void *mr, uint64_t addr, uin= t64_t value, unsigned size) "cpu %d mr %p addr 0x%"PRIx64" value 0x%"PRIx64= " size %u" +memory_region_ram_device_write(int cpu_index, void *mr, uint64_t addr, uin= t64_t value, unsigned size, bool readonly) "cpu %d mr %p addr 0x%"PRIx64" v= alue 0x%"PRIx64" size %u" " is_readonly_region=3D%d" flatview_new(void *view, void *root) "%p (root %p)" flatview_destroy(void *view, void *root) "%p (root %p)" flatview_destroy_rcu(void *view, void *root) "%p (root %p)" --=20 2.17.1