From nobody Wed May 15 14:10:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1586734443; cv=none; d=zohomail.com; s=zohoarc; b=R77WQ2gMIeSNAYfL7NtLlOaOEJDGZnwj+YwVwaWvCvA5GCywrWZQkRiwaIb6wikqY9kMy3oZIfQP8JJaejvkuePIxcgpirocyYywJ3JviQB7mFbiwTjnCjyZNTCsnUN+NOY1NXZsQzEMdBa4YKR/2OnZCLHGPrKkIpfWh9e4RIc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1586734443; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=qiiJ/9LQbNwzVn/oldsWyAe6v31V6qg3EJGBL6aKL1k=; b=DbZlxFkoqR2jaV+aPFnvDS9hf8TC5u3/9w64uTzFWQydCZM4PGArQ29n1Y6iIXIUL+pY+JlLzqqPw9Mx/QEjPyt+bNduN1zGvQZTVMsbVL8KHLmjBiYInpQNWacunYc2xYv5VSvC16NVhfIYqTD9PqPWkRz2K2tzoZg2KQpA5r4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1586734443757705.900522778507; Sun, 12 Apr 2020 16:34:03 -0700 (PDT) Received: from localhost ([::1]:38778 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNm70-0000MK-8k for importer@patchew.org; Sun, 12 Apr 2020 19:34:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55650) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNm6D-0007Z1-23 for qemu-devel@nongnu.org; Sun, 12 Apr 2020 19:33:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jNm6B-0003HJ-Vu for qemu-devel@nongnu.org; Sun, 12 Apr 2020 19:33:12 -0400 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]:36585) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jNm6B-0003H3-Ql for qemu-devel@nongnu.org; Sun, 12 Apr 2020 19:33:11 -0400 Received: by mail-pj1-x1043.google.com with SMTP id nu11so3136871pjb.1 for ; Sun, 12 Apr 2020 16:33:11 -0700 (PDT) Received: from vultr.guest ([149.248.10.52]) by smtp.gmail.com with ESMTPSA id c74sm2122065pfb.67.2020.04.12.16.33.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2020 16:33:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=qiiJ/9LQbNwzVn/oldsWyAe6v31V6qg3EJGBL6aKL1k=; b=Us/qZhLyrxZDqRSMzrmBtnHrCCRtjpL64Z3ElJr3WUJqlI2EWagcziMk3rpLBwukrF ScKPpJFECHPyzmbCjm+DThTE7U+/hImouhEPlPNc/3ubAlD/v2jZS/U9WpmA0bT3QN9U hwzBsTwR+4FkG+eiB8qOCeXTtDo1GMKzyNH10h1OGWzYxmjwZYqH8QpkkXuddJ4WryP6 hM6CfWAlKU28zEPLUHsTago2WsdP5qYq4I8MwoOqdGOfqmdeMf6o7gHFOr11mb8MwU8c CfcFwgx6uAna3qMDso9bC2UUr7yO99dQ6F6nF2Wu5akGls35MlgQ2E/LIDWyyU53AHGb wtGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=qiiJ/9LQbNwzVn/oldsWyAe6v31V6qg3EJGBL6aKL1k=; b=Sr7Sx+FMtcDOKhMBBbkZFkawsxjGqGiqrJm6AfQAtotIseJUlTfpriZZAZ4IHI5RIv Pppun8dCmRbTyTZXDlKVjcpL8ocTMS31MJ2qLMaNjtOGeauKR2R5BeRHZ9WrHF3h81iq yg7FBcqd3eKG+jds1MNVqne2KVkQuxv/pitHNkvmxht7ZJ4d1nq9f55JXhZFjy7gkCxX v2E1vPrR/jKMTw85n58/2pAC/3nsegUj25CQjMIc4VwZo1qDq0oGcrQDODxxr0qcU+Hf 9K3yUyYNhobzrcu+66Lyyryql2wQb7CkUUCKZlKnOSlcIOh1vxJLP/gmxxt4E/zAAu3T Gm+w== X-Gm-Message-State: AGi0PuZkcmaikPrt+KobDYlVpJfpfPzUeTAIZkNIwoc918PrD7JUQyZh BbKFmS/WBufxcOMD7fRj4So= X-Google-Smtp-Source: APiQypLcYBfnl2QvDJgT6Dn1FJwst8Be7kpdSbfTrI9X6hWy3FhuVRWZsn/paC4CSOFQFHbGJ6qsnQ== X-Received: by 2002:a17:90a:d14d:: with SMTP id t13mr425842pjw.175.1586734390860; Sun, 12 Apr 2020 16:33:10 -0700 (PDT) From: Changbin Du To: Paolo Bonzini , Richard Henderson , Eduardo Habkost , Laurent Vivier Subject: [PATCH v2] gdbstub: Fix segment fault for i386 target Date: Mon, 13 Apr 2020 07:32:46 +0800 Message-Id: <20200412233246.4212-1-changbin.du@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::1043 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Changbin Du Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) Content-Type: text/plain; charset="utf-8" With GByteArray, we should pass the object itself but not to plus an offset. gdb log: Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault. __memmove_avx_unaligned_erms () at ../sysdeps/x86_64/multiarch/memmove-vec-= unaligned-erms.S:384 384 ../sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S: No such file = or directory. Fixes: a010bdbe71 ("gdbstub: extend GByteArray to read register helpers") Signed-off-by: Changbin Du Reviewed-by: Laurent Vivier --- v2: remove m68k fix since it's already queued. --- target/i386/gdbstub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/gdbstub.c b/target/i386/gdbstub.c index f3d23b614e..b98a99500a 100644 --- a/target/i386/gdbstub.c +++ b/target/i386/gdbstub.c @@ -106,7 +106,7 @@ int x86_cpu_gdb_read_register(CPUState *cs, GByteArray = *mem_buf, int n) } else if (n >=3D IDX_FP_REGS && n < IDX_FP_REGS + 8) { floatx80 *fp =3D (floatx80 *) &env->fpregs[n - IDX_FP_REGS]; int len =3D gdb_get_reg64(mem_buf, cpu_to_le64(fp->low)); - len +=3D gdb_get_reg16(mem_buf + len, cpu_to_le16(fp->high)); + len +=3D gdb_get_reg16(mem_buf, cpu_to_le16(fp->high)); return len; } else if (n >=3D IDX_XMM_REGS && n < IDX_XMM_REGS + CPU_NB_REGS) { n -=3D IDX_XMM_REGS; --=20 2.25.1