From nobody Sun Feb 8 16:34:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1586688363; cv=none; d=zohomail.com; s=zohoarc; b=ciXmt9OWDZgRCnSl1ufOOF/yrkI9UNOOhLaVBAyvsWMpf9YWwxP8VgKKGCXH1j1M05hTMOclSPalkEabax2tYSwNEwLLelkFOUp94PjPWS0EybkIUv12xQhN9wMhZeIzUnGkm3JWgXPdvoB4lSWyI4Y0cdd5ZH2/YzKbb011eiU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1586688363; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=P/BkFFFE0kL0UxA6yxiSebZm+uJIjXAGvFH5F/PCQ18=; b=aBIEQv4cv/um5fmoW8pYGxJuskJFnE1l0R48qkBn80ZFtuhZk+5R+cx4kedtVz3XIPXx4yi9NTShQEQYkT0rHlBPWCmn9jnrbXt9JSYYca4nbEhI9P+E+GjpG4LM1Mg4dQRKY2b5hJPG2lxJRllxhAY6ljLQxtD5iADpJU8jZtE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1586688363447216.066888117281; Sun, 12 Apr 2020 03:46:03 -0700 (PDT) Received: from localhost ([::1]:60528 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNa7k-0004Su-9P for importer@patchew.org; Sun, 12 Apr 2020 06:46:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46420) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNa6T-0003ou-Kr for qemu-devel@nongnu.org; Sun, 12 Apr 2020 06:44:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jNa6S-0004FZ-Fx for qemu-devel@nongnu.org; Sun, 12 Apr 2020 06:44:41 -0400 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]:42663) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jNa6S-0004F5-8f for qemu-devel@nongnu.org; Sun, 12 Apr 2020 06:44:40 -0400 Received: by mail-pl1-x641.google.com with SMTP id v2so2383291plp.9 for ; Sun, 12 Apr 2020 03:44:39 -0700 (PDT) Received: from vultr.guest ([149.248.10.52]) by smtp.gmail.com with ESMTPSA id 63sm6029985pfe.96.2020.04.12.03.44.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2020 03:44:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=P/BkFFFE0kL0UxA6yxiSebZm+uJIjXAGvFH5F/PCQ18=; b=M1Yif6egcr3WpMikWyBTKh+tvgWEQrmO85kdpwg/GgIBAY8urGz0OZOeZrDSCMMkwm ibArNDAnwRbeTM13Z1m7ptFo74Vod+FQHT67P2r7qikYM2Mx/mBfssIdxJwIRA0gg6hT ZyUXs94wogRI2tcCWt9nT7aWHKd9xM+/M34NOCcBNxRAuVejPGLafb02/Qs8j0nhi5PX kvp/UqboBDlVQ65zXvuH3jpNn/2ted8CqiFUO54Hh3HU54bCdD3XL1/1PIUC1i0CRjDA +hUOtc6DvtI6fwGXhhhBvvPyf5xN1EmtIcKMv5HVHj7SEtCqLtn+SUZ//+3DEAWq2+ad rBKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=P/BkFFFE0kL0UxA6yxiSebZm+uJIjXAGvFH5F/PCQ18=; b=VLnVrDPimVWWbb82sR6OgvpkxrNAzmcZGppQawjmqxfL71SD+/XrmU4TTNAa1Q18vi Xtqzf1bwFz/aXu/JuWWfOfPfg3e8fvpn85VE7mnmZOOcKxthpRs+JU+APT8PotOXrAyy 416TU9VElYBXLWQHOtor4k9Yo/v8ci3jSpo8ezzmo/LzPGslIvlXJxWzM5o6VaGJKFNV Uzu9rg5/mfMrGkFq0DVSm5SHh0sJPTPV8F+0Ib1UkVPk5146i/CmSereH3kj0bnEra4n IoLUV9X/hO0v+AhQbBJRBORtycp95TVZyXh9oVB6e4QZW/CrVXS0n4+kdaGSKllSK/u2 I4MQ== X-Gm-Message-State: AGi0PuY16qmpSPlhURsaxi4NGoQkjcSZPmErRKopEXb/QCLDOFewACCM N59TpJInExTVB6wfWuD021A= X-Google-Smtp-Source: APiQypL+V8lBoSbP/t0iBRywE0BL5tpDIO6Nwi1aGtoSIbu+3cSuXWUNNxDdaj0dFGeBYfK8EHLmaw== X-Received: by 2002:a17:90a:757:: with SMTP id s23mr15556873pje.166.1586688278582; Sun, 12 Apr 2020 03:44:38 -0700 (PDT) From: Changbin Du To: Paolo Bonzini , Richard Henderson , Eduardo Habkost , Laurent Vivier Subject: [PATCH] gdbstub: Fix segment fault for i386 and m68k Date: Sun, 12 Apr 2020 18:44:21 +0800 Message-Id: <20200412104421.77975-1-changbin.du@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::641 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Changbin Du Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) Content-Type: text/plain; charset="utf-8" With GByteArray, we should pass the object itself but not to plus an offset. gdb log: Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault. __memmove_avx_unaligned_erms () at ../sysdeps/x86_64/multiarch/memmove-vec-= unaligned-erms.S:384 384 ../sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S: No such file = or directory. Fixes: a010bdbe71 ("gdbstub: extend GByteArray to read register helpers") Signed-off-by: Changbin Du --- target/i386/gdbstub.c | 2 +- target/m68k/helper.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/target/i386/gdbstub.c b/target/i386/gdbstub.c index f3d23b614e..b98a99500a 100644 --- a/target/i386/gdbstub.c +++ b/target/i386/gdbstub.c @@ -106,7 +106,7 @@ int x86_cpu_gdb_read_register(CPUState *cs, GByteArray = *mem_buf, int n) } else if (n >=3D IDX_FP_REGS && n < IDX_FP_REGS + 8) { floatx80 *fp =3D (floatx80 *) &env->fpregs[n - IDX_FP_REGS]; int len =3D gdb_get_reg64(mem_buf, cpu_to_le64(fp->low)); - len +=3D gdb_get_reg16(mem_buf + len, cpu_to_le16(fp->high)); + len +=3D gdb_get_reg16(mem_buf, cpu_to_le16(fp->high)); return len; } else if (n >=3D IDX_XMM_REGS && n < IDX_XMM_REGS + CPU_NB_REGS) { n -=3D IDX_XMM_REGS; diff --git a/target/m68k/helper.c b/target/m68k/helper.c index 014657c637..cad4083895 100644 --- a/target/m68k/helper.c +++ b/target/m68k/helper.c @@ -109,8 +109,8 @@ static int m68k_fpu_gdb_get_reg(CPUM68KState *env, GByt= eArray *mem_buf, int n) { if (n < 8) { int len =3D gdb_get_reg16(mem_buf, env->fregs[n].l.upper); - len +=3D gdb_get_reg16(mem_buf + len, 0); - len +=3D gdb_get_reg64(mem_buf + len, env->fregs[n].l.lower); + len +=3D gdb_get_reg16(mem_buf, 0); + len +=3D gdb_get_reg64(mem_buf, env->fregs[n].l.lower); return len; } switch (n) { --=20 2.25.1