From nobody Sat Sep 21 00:45:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=mail.ustc.edu.cn ARC-Seal: i=1; a=rsa-sha256; t=1586609298; cv=none; d=zohomail.com; s=zohoarc; b=QcckfWNwnxhzZKgyjPdPocPz6CvttU19c1jWBOqBCPHkxx32TY/OZVwQ1HPdevVmtqeslCwfKn2iloWeS/fPtNFgQT8hKzOGpTVr5L8GT/eY4sCYTRjmwQOTm+tpPNbIldcQgekUUiWqtloTjPK+Nb5IGYAu6IfSrNmzG3hOJ/c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1586609298; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=B3Spx15nOritC6UHHdhFr4XIxOPxo7WLYNHhCujyS5I=; b=K7VO8Yv2WRYuWNQjNrz2FwTkgJ5apA+gB0gnt71aTOTVfkZDWQcNX5Mv9aQPYbAy8hIJCv8n//vYV7ExEgv7DPAgvoRQRGj7SmDZakH3FLXzeS54RtfUvOTrbrwa75WnJK+6U9gyhKAtsY1qME42Jk6NCOTT3ZDKIKW4zyQbEU4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1586609297936273.843011322061; Sat, 11 Apr 2020 05:48:17 -0700 (PDT) Received: from localhost ([::1]:51594 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNFYW-00013u-Pb for importer@patchew.org; Sat, 11 Apr 2020 08:48:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59526) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNFX9-00082p-P2 for qemu-devel@nongnu.org; Sat, 11 Apr 2020 08:46:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jNFX7-0001w8-Uj for qemu-devel@nongnu.org; Sat, 11 Apr 2020 08:46:50 -0400 Received: from email6.ustc.edu.cn ([2001:da8:d800::8]:34065 helo=ustc.edu.cn) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jNFX5-0001qX-Bh for qemu-devel@nongnu.org; Sat, 11 Apr 2020 08:46:49 -0400 Received: from localhost.localdomain (unknown [114.246.35.138]) by newmailweb.ustc.edu.cn (Coremail) with SMTP id LkAmygDXgkwrvJFetTsMAA--.19507S2; Sat, 11 Apr 2020 20:46:35 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ustc.edu.cn; s=dkim; h=Received:From:To:Cc:Subject:Date: Message-Id:MIME-Version:Content-Transfer-Encoding; bh=B3Spx15nOr itC6UHHdhFr4XIxOPxo7WLYNHhCujyS5I=; b=oC86i0we1fB6dRdj8xIC3Og67X RQjdINXU5v+pEQhr0nEu5mqgVKs6GTS382j7Vm1sF6Uu56VlAs21hIAe8LpQEU4v GjqgXCXyLMM2tWAGENqFtdGNaVbs3YQCIfmh+lV6kkUIAqH7eCioq/ZoWw9GnHMw PrgEG+TdI4f5S9VGg= From: lixinyu To: qemu-devel@nongnu.org Cc: aurelien@aurel32.net, arikalo@wavecomp.com, lixinyu Subject: [PATCH] tcg/mips: mips sync* encode error Date: Sat, 11 Apr 2020 20:46:12 +0800 Message-Id: <20200411124612.12560-1-precinct@mail.ustc.edu.cn> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: LkAmygDXgkwrvJFetTsMAA--.19507S2 X-Coremail-Antispam: 1UD129KBjvJXoW7ArWDur47GFW3KFyUCF15urg_yoW8Gr1DpF 1UCr1UKr10gFW5GrnxCr1UXFyxG393JFZ8A3Z2qr98X3Z0qrWqq34rtF40qF4jyrWrJ3yI vrW5Kr1aqa4xAw7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUyv14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s 0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xII jxv20xvE14v26r106r15McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr 1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxAIw28IcxkI7VAKI48J MxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwV AFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv2 0xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4 v20xvaj40_Zr0_Wr1UMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAF wI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7VUbWCJPUUUUU== X-CM-SenderInfo: 5suhuxxqfwqzxdloh3xvwfhvlgxou0/ X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:da8:d800::8 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @mail.ustc.edu.cn) Content-Type: text/plain; charset="utf-8" OPC_SYNC_WMB, OPC_SYNC_MB, OPC_SYNC_ACQUIRE, OPC_SYNC_RELEASE and OPC_SYNC_RMB have wrong encode. According to the mips manual, their encode should be 'OPC_SYNC | 0x?? << 6' rather than 'OPC_SYNC | 0x?? << 5'. Wrong encode can lead illegal instruction errors. These instructions often appear with multi-threaded simulation. Signed-off-by: lixinyu Reviewed-by: Aleksandar Markovic Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- tcg/mips/tcg-target.inc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tcg/mips/tcg-target.inc.c b/tcg/mips/tcg-target.inc.c index 1da663ce84..4d32ebc1df 100644 --- a/tcg/mips/tcg-target.inc.c +++ b/tcg/mips/tcg-target.inc.c @@ -404,11 +404,11 @@ typedef enum { =20 /* MIPS r6 introduced names for weaker variants of SYNC. These are backward compatible to previous architecture revisions. */ - OPC_SYNC_WMB =3D OPC_SYNC | 0x04 << 5, - OPC_SYNC_MB =3D OPC_SYNC | 0x10 << 5, - OPC_SYNC_ACQUIRE =3D OPC_SYNC | 0x11 << 5, - OPC_SYNC_RELEASE =3D OPC_SYNC | 0x12 << 5, - OPC_SYNC_RMB =3D OPC_SYNC | 0x13 << 5, + OPC_SYNC_WMB =3D OPC_SYNC | 0x04 << 6, + OPC_SYNC_MB =3D OPC_SYNC | 0x10 << 6, + OPC_SYNC_ACQUIRE =3D OPC_SYNC | 0x11 << 6, + OPC_SYNC_RELEASE =3D OPC_SYNC | 0x12 << 6, + OPC_SYNC_RMB =3D OPC_SYNC | 0x13 << 6, =20 /* Aliases for convenience. */ ALIAS_PADD =3D sizeof(void *) =3D=3D 4 ? OPC_ADDU : OPC_DADDU, --=20 2.20.1