From nobody Tue Feb 10 03:38:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1586467078; cv=none; d=zohomail.com; s=zohoarc; b=CH+oX46oFTf539M0e06SXz/HOFtRBTn/5XNeH/Ak0YCt2VGtbbYBWmNCfYEE1VPevOP2yFl8i3sI7PQYXzCWGnFnTxekkbBVog+v3n3J8eJY4YPl3GDRsiGIGyofsdWpQkadprXvOR4nWB2yiR0qrAYA5vKZrSON4OL//ca/W+o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1586467078; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3Vwwp+7FgPCuWIPWypnjEryUlzyp/CqPviLpa6fHhzs=; b=J7fnq9JH5x0jnpU5KVKKwQHLo+ZIsnoUEsGJ4vffJ+eeIDCuPlkj/b0iKHqX2zPUsfLwPsip9ldBx91N5BB4P0Z49cN0PS5czpfNgSZajIQ3PaWxjxQR9xJUi+t4m8jsRuD1s4B3qYHoeNXqsIW8zCaNO3z8b0Jlq9RtL67co64= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1586467078778629.1527010125112; Thu, 9 Apr 2020 14:17:58 -0700 (PDT) Received: from localhost ([::1]:55604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jMeYf-0005K4-Ii for importer@patchew.org; Thu, 09 Apr 2020 17:17:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42370) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jMeWV-00028P-Kh for qemu-devel@nongnu.org; Thu, 09 Apr 2020 17:15:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jMeWU-0005m5-H7 for qemu-devel@nongnu.org; Thu, 09 Apr 2020 17:15:43 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:44954) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jMeWU-0005jw-BT for qemu-devel@nongnu.org; Thu, 09 Apr 2020 17:15:42 -0400 Received: by mail-wr1-x42b.google.com with SMTP id c15so13649342wro.11 for ; Thu, 09 Apr 2020 14:15:42 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id 127sm5440743wmd.38.2020.04.09.14.15.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2020 14:15:35 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id C14B21FF96; Thu, 9 Apr 2020 22:15:30 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3Vwwp+7FgPCuWIPWypnjEryUlzyp/CqPviLpa6fHhzs=; b=QLTcE4JhzphXKShNK4RN0Od/VFN09fkzpUqPAb+/skkecwnvkFLqeNWzN+ccJm+722 YBvnCpNbt8NT/baiYiMS2xMmlkbLLAENVQc2DUsJAPcF9q0UeAlos1j9QU9KHGFZ12Mp GP4r3d7ETBDH4TgcqqR2fyIC2OqVaMaVjOfg2RfduY0JLeUcrVtucQoHo0GtE6KuiAnN g7UljjawR0D8vLtThFNraHMNfn1tUuzlwxMhS9rDclGFzjC4WKL/yePErkx1LOxAEmlx 1ehVHPlQn1as3H8OO2kpP/E5Ckh6JDUxghN3lf3xGnMWlDKbrAdSleBJlNDKjYpSPYKV nFFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3Vwwp+7FgPCuWIPWypnjEryUlzyp/CqPviLpa6fHhzs=; b=c84DVYDUROJTmwen+fx2yH9ZYc0vLYtTlaKMDaMVvJ+isqy6xbEm1a93ieEwmXIFE9 dDCOjSs/aNmgaZ5Frd+2SbUn4Ysu/zZymYRMDOKuzvEzd2z3BQdzqDyYHCnAgvUeFlSs BQeWB1WnEpQkmYwelh1yNntE9S18uJ5g9aLrDaronEvqMj8mjEZ/9byYfGXGu8MYoY9P voeyxOx6lmH9rZBxouS7ih9BQAMRWzfgySar8Swiu5Gt4wNB7re7zr4X4tsUfmQIfMDr XmpM9YIpq8iCSpLBMytP9gEeicyk8BUChT82QY5AejVDXLS5bbr1ny5W/0XzgEsGX/Tc ufqQ== X-Gm-Message-State: AGi0PuZmmjHl537XeQ0QWiOicsbCWkNDI56PgE0t73rkgpeGkd0bH1WI QFMqtPwC6wtFv8PhRbzTChnC43DxRc4= X-Google-Smtp-Source: APiQypKZ/EJWB1Q8+JY9/gHifqgKo3+6jEig1OJGDmu/J6tKZAk4HR4KkmJZ644+QMMtaDQtV/QGuw== X-Received: by 2002:a5d:69ce:: with SMTP id s14mr1075308wrw.413.1586466941366; Thu, 09 Apr 2020 14:15:41 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 08/11] target/m68k/helper: Fix m68k_fpu_gdb_get_reg() use of GByteArray Date: Thu, 9 Apr 2020 22:15:26 +0100 Message-Id: <20200409211529.5269-9-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200409211529.5269-1-alex.bennee@linaro.org> References: <20200409211529.5269-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42b X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier , Peter Xu Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Philippe Mathieu-Daud=C3=A9 Since a010bdbe719 the gdbstub API takes a GByteArray*. Unfortunately we forgot to update the gdb_get_reg*() calls. Do it now. Fixes: a010bdbe719 ("extend GByteArray to read register helpers") Reported-by: Peter Xu Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Laurent Vivier Reviewed-by: Peter Xu Signed-off-by: Alex Benn=C3=A9e Message-Id: <20200409172509.4078-1-philmd@redhat.com> Reviewed-by: Richard Henderson --- target/m68k/helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/m68k/helper.c b/target/m68k/helper.c index 014657c6372..cad40838956 100644 --- a/target/m68k/helper.c +++ b/target/m68k/helper.c @@ -109,8 +109,8 @@ static int m68k_fpu_gdb_get_reg(CPUM68KState *env, GByt= eArray *mem_buf, int n) { if (n < 8) { int len =3D gdb_get_reg16(mem_buf, env->fregs[n].l.upper); - len +=3D gdb_get_reg16(mem_buf + len, 0); - len +=3D gdb_get_reg64(mem_buf + len, env->fregs[n].l.lower); + len +=3D gdb_get_reg16(mem_buf, 0); + len +=3D gdb_get_reg64(mem_buf, env->fregs[n].l.lower); return len; } switch (n) { --=20 2.20.1