From nobody Sun May 19 04:05:28 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1586259965; cv=none; d=zohomail.com; s=zohoarc; b=Dt1/w+WoGIjBJln5ERkhJix8tsXX4T6iXxoBzZQdfFMabD3J7kDnoJ4VDTqj2VV7pzoAQRsu8vNsp6Bw+REmqXiHUog49cBsbRSkH8qH48Ik6NqCH06kkMOJzQ8o1NWII8/euB5I0966ntWxSrzb4nFSeNSxl8q+6dV0PO13XFE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1586259965; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=qE8wUZrK/dGQVNk4t1gqwwve6cJyWo1UmICzsJKQkEE=; b=SK9+bqrH53Hqe8QV9vvw8JSTRBOk5zAF8DOe3oTn1Hb7Sk3GI2W6obQs1JP0OPgxvzpynvFvRwliVstGyZ7OtG9E1Van0Tk7LbfwRv/Pdu0tU/wpl7iJ6sryHKwZ0RU1FOXu02QzR1i4QZTQ9L82C0Zkq0xI6T1SYNb50eNbqmY= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1586259965517483.17761126860546; Tue, 7 Apr 2020 04:46:05 -0700 (PDT) Received: from localhost ([::1]:45800 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLmg8-0004AL-7Q for importer@patchew.org; Tue, 07 Apr 2020 07:46:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55272) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLmfB-0003Rp-Bu for qemu-devel@nongnu.org; Tue, 07 Apr 2020 07:45:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jLmf8-0007yp-WB for qemu-devel@nongnu.org; Tue, 07 Apr 2020 07:45:05 -0400 Received: from 6.mo173.mail-out.ovh.net ([46.105.43.93]:42492) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jLmf8-0007wF-Ji for qemu-devel@nongnu.org; Tue, 07 Apr 2020 07:45:02 -0400 Received: from player739.ha.ovh.net (unknown [10.108.35.59]) by mo173.mail-out.ovh.net (Postfix) with ESMTP id 4B8ED136841 for ; Tue, 7 Apr 2020 13:45:00 +0200 (CEST) Received: from kaod.org (82-64-250-170.subs.proxad.net [82.64.250.170]) (Authenticated sender: clg@kaod.org) by player739.ha.ovh.net (Postfix) with ESMTPSA id 56405D2B9B6E; Tue, 7 Apr 2020 11:44:53 +0000 (UTC) From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: "Dr . David Alan Gilbert" Subject: [RFC PATCH] qom: Implement qom-get HMP command Date: Tue, 7 Apr 2020 13:44:49 +0200 Message-Id: <20200407114449.482532-1-clg@kaod.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Ovh-Tracer-Id: 7474568006855920434 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduhedrudehgdeghecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpeevrogurhhitgcunfgvucfiohgrthgvrhcuoegtlhhgsehkrghougdrohhrgheqnecukfhppedtrddtrddtrddtpdekvddrieegrddvhedtrddujedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepphhlrgihvghrjeefledrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdprhgtphhtthhopehqvghmuhdquggvvhgvlhesnhhonhhgnhhurdhorhhg Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 46.105.43.93 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Eduardo Habkost , qemu-devel@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Paolo Bonzini , =?UTF-8?q?Andreas=20F=C3=A4rber?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" Reimplement it based on qmp_qom_get() to avoid converting QObjects back to strings. Inspired-by: Paolo Bonzini Signed-off-by: Andreas F=C3=A4rber Slight fix for bit-rot: Signed-off-by: Dr. David Alan Gilbert [clg: updates for QEMU 5.0 ] Signed-off-by: C=C3=A9dric Le Goater --- I would like to restart the discussion on qom-get command to understand what was the conclusion and see if things have changed since. Thanks, C. include/monitor/hmp.h | 1 + qom/qom-hmp-cmds.c | 23 +++++++++++++++++++++++ hmp-commands.hx | 13 +++++++++++++ 3 files changed, 37 insertions(+) diff --git a/include/monitor/hmp.h b/include/monitor/hmp.h index e33ca5a911a5..c986cfd28bc3 100644 --- a/include/monitor/hmp.h +++ b/include/monitor/hmp.h @@ -96,6 +96,7 @@ void hmp_info_memdev(Monitor *mon, const QDict *qdict); void hmp_info_numa(Monitor *mon, const QDict *qdict); void hmp_info_memory_devices(Monitor *mon, const QDict *qdict); void hmp_qom_list(Monitor *mon, const QDict *qdict); +void hmp_qom_get(Monitor *mon, const QDict *qdict); void hmp_qom_set(Monitor *mon, const QDict *qdict); void hmp_info_qom_tree(Monitor *mon, const QDict *dict); void object_add_completion(ReadLineState *rs, int nb_args, const char *str= ); diff --git a/qom/qom-hmp-cmds.c b/qom/qom-hmp-cmds.c index cd08233a4cfe..b14cf6e785f4 100644 --- a/qom/qom-hmp-cmds.c +++ b/qom/qom-hmp-cmds.c @@ -40,6 +40,29 @@ void hmp_qom_list(Monitor *mon, const QDict *qdict) hmp_handle_error(mon, err); } =20 +void hmp_qom_get(Monitor *mon, const QDict *qdict) +{ + const char *path =3D qdict_get_str(qdict, "path"); + const char *property =3D qdict_get_str(qdict, "property"); + Error *err =3D NULL; + Object *obj; + char *value; + + obj =3D object_resolve_path(path, NULL); + if (obj =3D=3D NULL) { + error_set(&err, ERROR_CLASS_DEVICE_NOT_FOUND, + "Device '%s' not found", path); + hmp_handle_error(mon, err); + return; + } + value =3D object_property_print(obj, property, true, &err); + if (err =3D=3D NULL) { + monitor_printf(mon, "%s\n", value); + g_free(value); + } + hmp_handle_error(mon, err); +} + void hmp_qom_set(Monitor *mon, const QDict *qdict) { const char *path =3D qdict_get_str(qdict, "path"); diff --git a/hmp-commands.hx b/hmp-commands.hx index 7f0f3974ad90..4e39b9caed3e 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1790,6 +1790,19 @@ SRST Print QOM properties of object at location *path* ERST =20 + { + .name =3D "qom-get", + .args_type =3D "path:s,property:s", + .params =3D "path property", + .help =3D "print QOM property", + .cmd =3D hmp_qom_get, + }, + +SRST +``qom-get`` *path* *property* + Print QOM property *property* of object at location *path* +ERST + { .name =3D "qom-set", .args_type =3D "path:s,property:s,value:s", --=20 2.25.1