From nobody Tue Feb 10 03:55:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1586197803; cv=none; d=zohomail.com; s=zohoarc; b=Y8BqUqi/kxrj0QBs1x7EsEMk+NMFHESECf6tLYT1ihEPIj6H+FJIybBo2ioo5Hb31qL2Rv2pXIVMfD18TSO56qIr8tdrgmmaOBPWQxk1TsU8ShLjH1FBzTKFxZ6ckYZ7x457TReYJNrx7HzEHgB3Jhxvnm/t4zR78lk7pkoHjVw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1586197803; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=sdW0l6b6nTSbhLDFO8tdTL2LdtucDsWp9rO++BIIif0=; b=jTBGjtm/BMjacMqRPg8DxoVTDXQMxC6o3uYjAy4pgYmMSLbYBQ2xXQ+WllDdmQq4GDYN+DrhsuK96yBgLHhTDlreF2PETHHqRRRNK2wmkVjIF09WekZfK3u8mRGn7ZLj2sd3v7C+lD/MrUrHJHWDsBs7XLzNDWR7EtCtHn2mKMY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1586197803464160.41307682656134; Mon, 6 Apr 2020 11:30:03 -0700 (PDT) Received: from localhost ([::1]:36750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLWVW-0005GT-5S for importer@patchew.org; Mon, 06 Apr 2020 14:30:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36960) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLVrs-0003HM-9n for qemu-devel@nongnu.org; Mon, 06 Apr 2020 13:49:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jLVrr-0003fU-4I for qemu-devel@nongnu.org; Mon, 06 Apr 2020 13:49:04 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:44221) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jLVrq-0003fD-Re for qemu-devel@nongnu.org; Mon, 06 Apr 2020 13:49:03 -0400 Received: by mail-wr1-x42f.google.com with SMTP id c15so460848wro.11 for ; Mon, 06 Apr 2020 10:49:02 -0700 (PDT) Received: from x1w.redhat.com (116.red-83-42-57.dynamicip.rima-tde.net. [83.42.57.116]) by smtp.gmail.com with ESMTPSA id a67sm364880wmc.30.2020.04.06.10.49.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2020 10:49:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sdW0l6b6nTSbhLDFO8tdTL2LdtucDsWp9rO++BIIif0=; b=mogyeRr9N836X4lTudBjRzbYDylieiCWTT4PZwrosnVp0QYR6naf60R14KOH7YjRQG jHsSPoJkU+Nsehjc/lBEr9ejEw/tgeOgJrpA/kRHzG/B1v7EoDyYZMDgYRGR9GYFd1nr FyJExuWiznvXqpUM0M5Y4bD/952f5WhuoaJHGe78pRIxwjd81C2saw9fHSRlVxaj6aap yjwN20+lg+k4890FtgT09XWfNLj/PAjdUu7oFVKCZs7C8Inqq0EQgAK8I/2T8RDO3cje j/QrhFXNgxox6kBm7rpD9kJaDjXh2WMN2XodGd180sMkypohwIHivQAnZhSqoNoJkyH6 11fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=sdW0l6b6nTSbhLDFO8tdTL2LdtucDsWp9rO++BIIif0=; b=oC3FcXE9ui4k5hy1II/KQs6M4tnAtS11rtevG9GuEpjm3EilGjwrmwjEeiPgnJEWo4 dIQR+BA8TdMtJXOdQ9fTZ1xcRraZfe9s3K2dzT1SqeckbBFqYxJF3wbgMFOMmEkZ5W4O 48LlnFM2/PV8HHXn/eafaWo0x50ouSUjXPGLk1u/+ISfh3HdVZ5TbFRoqnfo5RkwKui+ LZiRTK7hLuZE1sgsRmmFC/U5ci1oq5izJ6RTXXNK5v+xYCQvryg087Tcj3+xmW9RXA7U JX9Td5et/8aREsUq22UsRhvt2PMxKLXSwd5YSLbWN06/4soZdJoKRxxYpCzkuG9RZ4PQ qWkw== X-Gm-Message-State: AGi0PuYRu9lzz1jsri7GlIeQ9Ks4Ltb6lQhVWVj0WjJUH+4gXm7tQUWQ IVP6960iPqC2gUp22lCen77WYMQv80g= X-Google-Smtp-Source: APiQypJIbyrrRC6KE6m4lKvo3p9EHIHQuoG/Y1gMAo1EoD3Tq8hXybPctjRWgRerJxAFPz1xoerXOw== X-Received: by 2002:adf:a347:: with SMTP id d7mr353725wrb.21.1586195341646; Mon, 06 Apr 2020 10:49:01 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Markus Armbruster Subject: [PATCH-for-5.1 v2 50/54] scripts/coccinelle: Find eventually missing error_propagate() calls Date: Mon, 6 Apr 2020 19:47:39 +0200 Message-Id: <20200406174743.16956-51-f4bug@amsat.org> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200406174743.16956-1-f4bug@amsat.org> References: <20200406174743.16956-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42f X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Vladimir Sementsov-Ogievskiy , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) In some places in we put an error into a local Error*, but forget to use it. Add a Coccinelle patch to find such cases and report them. Inspired-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- .../find-missing-error_propagate.cocci | 53 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 54 insertions(+) create mode 100644 scripts/coccinelle/find-missing-error_propagate.cocci diff --git a/scripts/coccinelle/find-missing-error_propagate.cocci b/script= s/coccinelle/find-missing-error_propagate.cocci new file mode 100644 index 0000000000..8b75b37b64 --- /dev/null +++ b/scripts/coccinelle/find-missing-error_propagate.cocci @@ -0,0 +1,53 @@ +// Find places likely missing error-propagation code, but code is too +// complex for automatic transformation, so manual analysis is required. +// +// Copyright: (C) 2020 Philippe Mathieu-Daud=C3=A9 +// This work is licensed under the terms of the GNU GPLv2 or later. +// +// spatch \ +// --macro-file scripts/cocci-macro-file.h --include-headers \ +// --sp-file scripts/coccinelle/find-missing-error_propagate.cocci +// +// Inspired by https://www.mail-archive.com/qemu-devel@nongnu.org/msg69163= 8.html + + +// First match two subsequent calls using local Error* +// in function provided a Error** argument +// +@discard_func_with_errp_argument@ +typedef Error; +Error *local_err; +identifier func, errp, errfunc1, errfunc2; +@@ +void func(..., Error **errp) +{ + <+... + errfunc1(..., &local_err); + ... when !=3D local_err // local_err is not used between the cal= ls + errfunc2(..., &local_err); + ...+> +} + + +// Again, match two subsequent calls using local Error* +// but ignoring within functions provided a Error** argument +// +@manual depends on never discard_func_with_errp_argument@ +Error *local_err; +identifier errfunc1, errfunc2; +position p; +@@ + errfunc1@p(..., &local_err); + ... when !=3D local_err + errfunc2(..., &local_err); + + +// As it is likely too complex to transform, report the hit +// +@script:python@ +f << manual.errfunc1; +p << manual.p; +@@ +print("[[manual check required: " + "error_propagate() might be missing in {}() {}:{}:{}]]".format( + f, p[0].file, p[0].line, p[0].column)) diff --git a/MAINTAINERS b/MAINTAINERS index ae71a0a4b0..29d29461f3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2057,6 +2057,7 @@ F: scripts/coccinelle/add-missing-error_propagate.coc= ci F: scripts/coccinelle/err-bad-newline.cocci F: scripts/coccinelle/error-use-after-free.cocci F: scripts/coccinelle/error_propagate_null.cocci +F: scripts/coccinelle/find-missing-error_propagate.cocci F: scripts/coccinelle/remove_local_err.cocci F: scripts/coccinelle/simplify-init-realize-error_propagate.cocci F: scripts/coccinelle/use-error_abort-in-instance_init.cocci --=20 2.21.1