From nobody Tue Feb 10 20:48:24 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1586196543; cv=none; d=zohomail.com; s=zohoarc; b=Nz0IDqO+BaqlPpWkKeQRrw/ZolsgomAwCT9yfD/pfYJ6GWA6vkrUBiYm0cDJuLxi30oADiQPCO6GKpZtL6hGV94SX518nKga5BKrYNBYFmP6OIB3dbM/u7XpXaKCfTVd3gEgued/W0u6dozHon3INGkFw2TpM2GM1EJ1UkAYJCc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1586196543; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Vz5Q0dw9UVVsHWJSWDpAMdysuLCt157lLdcHJoqyiRY=; b=XVbomKNLZ34D+dLaj7C93ITwPA07sMA/JXgexiLm7tkNHuZ+SUl38wmUJ5pTfh6VPqnpWWLyafvBZsGiuqK+2jreLPeH2zUd8dWghvvRzDhdCqTzUbW1iAjyylQ9B1N9zjr27RmHZB6ipZ1EuKwisEq6k5iAFmcqRLCVrcbSbMw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1586196543415631.9139808492048; Mon, 6 Apr 2020 11:09:03 -0700 (PDT) Received: from localhost ([::1]:36276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLWBB-0005VM-6w for importer@patchew.org; Mon, 06 Apr 2020 14:09:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36837) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLVrh-0002x7-AK for qemu-devel@nongnu.org; Mon, 06 Apr 2020 13:49:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jLVrg-0003Yn-7C for qemu-devel@nongnu.org; Mon, 06 Apr 2020 13:48:53 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:43459) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jLVrg-0003YJ-0s; Mon, 06 Apr 2020 13:48:52 -0400 Received: by mail-wr1-x444.google.com with SMTP id w15so467980wrv.10; Mon, 06 Apr 2020 10:48:51 -0700 (PDT) Received: from x1w.redhat.com (116.red-83-42-57.dynamicip.rima-tde.net. [83.42.57.116]) by smtp.gmail.com with ESMTPSA id a67sm364880wmc.30.2020.04.06.10.48.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2020 10:48:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Vz5Q0dw9UVVsHWJSWDpAMdysuLCt157lLdcHJoqyiRY=; b=DgZX+/ThOXO9FlaiLSsA2n361HyQEVVBt0lsXR4efUjz3HcIebZ5eNHDiu7e78EatS iuxI1rRpIrqddiXsZtUgQ1KohI5XQx7wF+4tp2prFv9PBfXX4uxtJC5/zza13mNPsASd dBlaoLFiDwoBBKEZQl4D/rvDjMOdpJW0P+S6hyfZeFbAeWOMQgfMEaDjvmnpkn1mLiPo P9Y7J14+pwHJIkkkspaQkBRwdw1CE9SPz0f+MaTlP9enWzwjHUkWQxr0p/Urx6wixhdi uXQ0CRuWx45bNj97FbFJA6xFM4q5KEZWEr1E/Kr9ahpxOj11jllNxH/ENCEHGYRs6Lnu iWGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Vz5Q0dw9UVVsHWJSWDpAMdysuLCt157lLdcHJoqyiRY=; b=deeRAvJj0kFS7Lar/XyVCY4e10U2xL7puZgF/tqPEoQmIfOOyiKQCDLU06rPdTysfi H8NKgFZPpHBULkykY8Atk1J6S0r2hTD/g88DAcO4zeaKlgvkYsZH8ElYNNyLI0Gfdr7L uKcgxNmUBxAPGJ2Zyf3/3gOTs1qi7ilxwnOBVn4NkjjWRCyJdsW00EdGXckEniuiKEXo BMnSMoDXfdelnW3gtXfEGt05KfJDr06vqN2uVVBGe6+uigpq2p0XCvC0KsCaPoZzKcwH Y63b7r2rrMf+weTfU1nqqc5yU7IL4vHkl6atbRfmCf/3K3QjQcIj21NO+TBlgm4pUVuB uyZA== X-Gm-Message-State: AGi0PuYEs70MhPjAzGS8YUNqbzI3Cr/z2wYqslerIQG3M+mETocFwz7N pt3w1BgMGAjtBxS2U7xAa+yLe79Hc9o= X-Google-Smtp-Source: APiQypKDdcuC/712qqt9E3in2fE4Fna2G1qgHK2bcaWi+wSy+PQg0cVc21el6h/Qp9vWVISmlQqy2g== X-Received: by 2002:adf:dc92:: with SMTP id r18mr387225wrj.76.1586195330875; Mon, 06 Apr 2020 10:48:50 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Markus Armbruster Subject: [PATCH-for-5.1 v2 45/54] hw/net/xilinx_axienet: Add missing error-propagation code Date: Mon, 6 Apr 2020 19:47:34 +0200 Message-Id: <20200406174743.16956-46-f4bug@amsat.org> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200406174743.16956-1-f4bug@amsat.org> References: <20200406174743.16956-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Vladimir Sementsov-Ogievskiy , Jason Wang , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "open list:Xilinx Zynq" , Alistair Francis , "Edgar E. Iglesias" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Patch created mechanically by running: $ spatch \ --macro-file scripts/cocci-macro-file.h --include-headers \ --sp-file scripts/coccinelle/object_property_missing_error_propagate.co= cci \ --keep-comments --smpl-spacing --dir hw Then review showed this file has a 'xilinx_enet_realize_fail' label that calls error_propagate(). Updated the patch to use the label. Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- v2: New cocci patch generated both transformations (Peter noticed v1 only catched one) --- hw/net/xilinx_axienet.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/net/xilinx_axienet.c b/hw/net/xilinx_axienet.c index 704788811a..db2c675b16 100644 --- a/hw/net/xilinx_axienet.c +++ b/hw/net/xilinx_axienet.c @@ -958,6 +958,9 @@ static void xilinx_enet_realize(DeviceState *dev, Error= **errp) object_property_allow_set_link, OBJ_PROP_LINK_STRONG, &local_err); + if (local_err) { + goto xilinx_enet_realize_fail; + } object_property_add_link(OBJECT(cs), "enet", "xlnx.axi-ethernet", (Object **) &cs->enet, object_property_allow_set_link, @@ -967,6 +970,9 @@ static void xilinx_enet_realize(DeviceState *dev, Error= **errp) goto xilinx_enet_realize_fail; } object_property_set_link(OBJECT(ds), OBJECT(s), "enet", &local_err); + if (local_err) { + goto xilinx_enet_realize_fail; + } object_property_set_link(OBJECT(cs), OBJECT(s), "enet", &local_err); if (local_err) { goto xilinx_enet_realize_fail; --=20 2.21.1