From nobody Tue Feb 10 05:45:55 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1586196449; cv=none; d=zohomail.com; s=zohoarc; b=kGJB+mXUuwvIEY6K6LzKmpUlKfmJmyCSs87T122M841SWFiHWpcLbZGj5hTaKAD1o4tQQrVWNgNsV104OUlx9TJb1eq42lpUaEaBZYHiBYTvD6ILEqwWOz9l0FUvONILvC1tlcjgQ58z0T8qEtEmGEt4fhz2Thht/peofXqgAPM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1586196449; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=pmelmK+74hZzKF1Ju2OEtzPp85pYogzLjVOdCh3WjgU=; b=X/06L6250lOIGQta4rHlTGoUOC3rN2AYHGwH0AFmLi8AjDJW38UXsha+HJB+1JrurVT5X0/VHyqwqiyN2GKUgybcJAridylijDGNuf9zzcUMK+HhVS0qXfyD0ZvNLSe3rZs8VRRbw8L3zmxCN92om8dyWozEijdieT7cnnK/HiQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1586196449088168.13109419160276; Mon, 6 Apr 2020 11:07:29 -0700 (PDT) Received: from localhost ([::1]:36236 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLW9f-0002B0-M6 for importer@patchew.org; Mon, 06 Apr 2020 14:07:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36468) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLVrK-0002Ms-SB for qemu-devel@nongnu.org; Mon, 06 Apr 2020 13:48:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jLVrJ-0003Is-Qo for qemu-devel@nongnu.org; Mon, 06 Apr 2020 13:48:30 -0400 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:55813) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jLVrI-0003Gh-8a; Mon, 06 Apr 2020 13:48:29 -0400 Received: by mail-wm1-x342.google.com with SMTP id e26so277057wmk.5; Mon, 06 Apr 2020 10:48:27 -0700 (PDT) Received: from x1w.redhat.com (116.red-83-42-57.dynamicip.rima-tde.net. [83.42.57.116]) by smtp.gmail.com with ESMTPSA id a67sm364880wmc.30.2020.04.06.10.48.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2020 10:48:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pmelmK+74hZzKF1Ju2OEtzPp85pYogzLjVOdCh3WjgU=; b=jADQD1NQCGgy4v5kf6eilYBewiHygFXg8eZDnUOFmgGaPOJQT4OmKpe3JUAR9x94Kd CKSbRAQea+4v5qTnRL0xOwb+D+XAMmRlAP95nHqpcH399ZVdb395xdlplmyErIY02cbi Qc0rNOpqUet33XO/j0TtbXhIFj+7qBB6nwqYoUpBXbtLGND4HyDU6If30J8H0K/aaYzH jlxuQx1AScuDaSRqisFNimm9eMbzwyhaVP600Tr+ulCnQlaPyMUp3ZONzlmNxpKGnXJL ubko6JEOYsA47FouRu6UgAHr1V88Qp28d3xa//Z29gQqdsL3DaftmBBxM0zCTS4LSy5J kmkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=pmelmK+74hZzKF1Ju2OEtzPp85pYogzLjVOdCh3WjgU=; b=RTFrGGYbgQEGmLpGKMMndJBK4hpWXnvwbihv3+1ATgEAOcAeCHDHK+O9rUa28uSOKG JuZdu5uI5mz13O8MNtgkblp9FC/ZQhduMzekO/Sbc4qkdBUR8g/GGz9Uvf8zM1rnvgRM n8XC7VwWhPvAdWm6E3ItCgv3LcPNFVyfyYNO0Q372W0c2UZ5+oJsDsI9/Kk7xk8UcC1z 7pgWOq8zB+WsWGd+pEWNaLyJdxU40OCDw3wkoImDavlVU/eP3EjRBhrNpznhf1hhEa5G dGPPFKsynahFSpTn7CPvbyUNROudu6E8JPiSH0UgRiss2SW3HNZNgzjbdltx+uMAPAU+ P7IA== X-Gm-Message-State: AGi0PuaCTIy6bZvD7dkwvPR7zyr+MwYGtQhStsZU5Nl7v+e7FYMtUFtw z4QQgkU3+TLXV/Gs05MvA1SZXE7jCvQ= X-Google-Smtp-Source: APiQypJ56Q9Bb/YbAsUf44vQ/MdA+DNYgybbIis+OB4EaivGBK+HVBrfCuQFltZsVaWBww9Iw9eApg== X-Received: by 2002:a1c:e407:: with SMTP id b7mr209077wmh.32.1586195305891; Mon, 06 Apr 2020 10:48:25 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Markus Armbruster Subject: [PATCH-for-5.1 v2 29/54] hw/arm/allwinner-a10: Add missing error-propagation code Date: Mon, 6 Apr 2020 19:47:18 +0200 Message-Id: <20200406174743.16956-30-f4bug@amsat.org> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200406174743.16956-1-f4bug@amsat.org> References: <20200406174743.16956-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::342 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Beniamino Galvani , Peter Maydell , Vladimir Sementsov-Ogievskiy , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "open list:Allwinner-a10" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Patch created mechanically by running: $ spatch \ --macro-file scripts/cocci-macro-file.h --include-headers \ --sp-file scripts/coccinelle/use-error_propagate-in-realize.cocci \ --keep-comments --smpl-spacing --in-place --dir hw Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/allwinner-a10.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/hw/arm/allwinner-a10.c b/hw/arm/allwinner-a10.c index f41395734a..db70aa2b88 100644 --- a/hw/arm/allwinner-a10.c +++ b/hw/arm/allwinner-a10.c @@ -158,14 +158,22 @@ static void aw_a10_realize(DeviceState *dev, Error **= errp) =20 for (i =3D 0; i < AW_A10_NUM_USB; i++) { object_property_set_bool(OBJECT(&s->ehci[i]), true, "realized", - &error_fatal); + &err); + if (err) { + error_propagate(errp, err); + return; + } sysbus_mmio_map(SYS_BUS_DEVICE(&s->ehci[i]), 0, AW_A10_EHCI_BASE + i * 0x8000); sysbus_connect_irq(SYS_BUS_DEVICE(&s->ehci[i]), 0, qdev_get_gpio_in(dev, 39 + i)); =20 object_property_set_bool(OBJECT(&s->ohci[i]), true, "realized", - &error_fatal); + &err); + if (err) { + error_propagate(errp, err); + return; + } sysbus_mmio_map(SYS_BUS_DEVICE(&s->ohci[i]), 0, AW_A10_OHCI_BASE + i * 0x8000); sysbus_connect_irq(SYS_BUS_DEVICE(&s->ohci[i]), 0, @@ -178,7 +186,11 @@ static void aw_a10_realize(DeviceState *dev, Error **e= rrp) sysbus_mmio_map(SYS_BUS_DEVICE(&s->mmc0), 0, AW_A10_MMC0_BASE); sysbus_connect_irq(SYS_BUS_DEVICE(&s->mmc0), 0, qdev_get_gpio_in(dev, = 32)); object_property_add_alias(OBJECT(s), "sd-bus", OBJECT(&s->mmc0), - "sd-bus", &error_abort); + "sd-bus", &err); + if (err) { + error_propagate(errp, err); + return; + } =20 /* RTC */ qdev_init_nofail(DEVICE(&s->rtc)); --=20 2.21.1