From nobody Tue Feb 10 10:07:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1586196287; cv=none; d=zohomail.com; s=zohoarc; b=ehYaPwe6Gh87jK1OGLfP/Y1pKNUqt/Q0/YNaWy8O0CDqMxwryJEoHj8wAzbLna23N1AugdBiFa+0KGCgiHx25u4NfuRkHmtZf3Dt8a0oxSv/qIdTBP5fcdrLy34mzb7GXldO1QJZ63g8LJ+AyWOoEngwsNS9nLdjcbSe15SG5tg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1586196287; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=iPAKPkoi+HJFf28A5mZBn3JxaePmMb+vKpWg/g7b+Dc=; b=BVhvrT0rSSEkh1dFERWMYd1tMPAypgeuf8SoxvuiU45mX8zLv4k2T9wYRqMAgc0m5ymYZlr3gBJu8mC6Zx7QYeFLMW1/VVteq1oehiIvaCLNASkPSPvajzkM9m0jx1b2+FUW8k6dpXKfs7idhHQ8DC75bZ96VPNlvfbU3bEKbDE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1586196287591469.6981189055756; Mon, 6 Apr 2020 11:04:47 -0700 (PDT) Received: from localhost ([::1]:36188 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLW74-0005Lw-By for importer@patchew.org; Mon, 06 Apr 2020 14:04:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36378) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLVrF-0002IU-VO for qemu-devel@nongnu.org; Mon, 06 Apr 2020 13:48:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jLVrE-0003FW-JW for qemu-devel@nongnu.org; Mon, 06 Apr 2020 13:48:25 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:37071) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jLVrE-0003Ch-2u; Mon, 06 Apr 2020 13:48:24 -0400 Received: by mail-wr1-x42b.google.com with SMTP id w10so515426wrm.4; Mon, 06 Apr 2020 10:48:23 -0700 (PDT) Received: from x1w.redhat.com (116.red-83-42-57.dynamicip.rima-tde.net. [83.42.57.116]) by smtp.gmail.com with ESMTPSA id a67sm364880wmc.30.2020.04.06.10.48.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2020 10:48:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iPAKPkoi+HJFf28A5mZBn3JxaePmMb+vKpWg/g7b+Dc=; b=GG0uoRxUc8+VfK7SEVrlqHXsr7G6RT3PJlLFsn6OGv/t2KmIJPUbKP/whI/BTlWqnO 1qxz/Itc2t7BK9pKeOkjDP+OZrLaapNGCwHA2LWy/q7G8PV+V9vh/ic3XmnYhJffKiaT WcrXEmAzgarapZSoF3Hq6rr0y+94bE4CCk0/sQxjYEiEWy2AEC20KzoHLOm7p+O31bW3 gvAf4lEdziS8z4xnndf4riyap4R1nazyl4+x3ZF4swdiH8MEY8J80gN59vaQNPztuqVw b7j+75uDJrOCK+8cc8rgCX/ykrR3zAlhBgnNaxN71zsvGpAZUvWLzDAzvx6Oc8kT4TuH TMCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=iPAKPkoi+HJFf28A5mZBn3JxaePmMb+vKpWg/g7b+Dc=; b=tkk1vMzhnrcwxlc7RqdW4nwmGGl1p0NryRgkJQ1gxTRuuB408VSipDDwM17WeSWqCR by0hR7aDGKBH18bUJNJvE4noeWSRgue2UYgPqNSUul5EtXROEakM1LPBJ3Ipp/DJQGk2 mLHbnbLVhHxb+yFDkGPQea/0jdp/lXNek47CiMTXLmmXpga5Sa+vF3wbIq3eBbJQRLcq 42Ux/IKwedTJ6rdrRiZ6qr5ahE7QYVv08Mmhfmw93Z0Q4hvIOjJA4Fm2KW5LiJPSAyys HEE+tngv7fZNW14DKX0moee/Sg55dEKp7tehHnh9JlUcsVcR7UeM87GrYjS2d7BfsxXd m0vQ== X-Gm-Message-State: AGi0PuaLPg/+gvE1g3wRaaGwMONxLjG2ZRkc0gJZYQyYTgAzVpAodwUm jvwoUBgspUnU0Ki31aCQ+b9RbZT8Q74= X-Google-Smtp-Source: APiQypK7A9mPm3O15qzUuzUEuuvqsU2cICUP2VTTYb9l8/WD5tnJHA2Lz9vO3G/E/yYKIY/ZrZL7Lg== X-Received: by 2002:adf:a347:: with SMTP id d7mr350873wrb.21.1586195302796; Mon, 06 Apr 2020 10:48:22 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Markus Armbruster Subject: [PATCH-for-5.1 v2 27/54] hw/arm/stm32f*05_soc: Add missing error-propagation code Date: Mon, 6 Apr 2020 19:47:16 +0200 Message-Id: <20200406174743.16956-28-f4bug@amsat.org> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200406174743.16956-1-f4bug@amsat.org> References: <20200406174743.16956-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42b X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Vladimir Sementsov-Ogievskiy , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "open list:STM32F205" , Alistair Francis Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Patch created mechanically by running: $ spatch \ --macro-file scripts/cocci-macro-file.h --include-headers \ --sp-file scripts/coccinelle/use-error_propagate-in-realize.cocci \ --keep-comments --smpl-spacing --in-place --dir hw Reviewed-by: Alistair Francis Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/stm32f205_soc.c | 6 +++++- hw/arm/stm32f405_soc.c | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/hw/arm/stm32f205_soc.c b/hw/arm/stm32f205_soc.c index 76b0b0e9be..b1be4fde40 100644 --- a/hw/arm/stm32f205_soc.c +++ b/hw/arm/stm32f205_soc.c @@ -106,7 +106,11 @@ static void stm32f205_soc_realize(DeviceState *dev_soc= , Error **errp) qdev_prop_set_string(armv7m, "cpu-type", s->cpu_type); qdev_prop_set_bit(armv7m, "enable-bitband", true); object_property_set_link(OBJECT(&s->armv7m), OBJECT(get_system_memory(= )), - "memory", &error_abort); + "memory", &err); + if (err) { + error_propagate(errp, err); + return; + } object_property_set_bool(OBJECT(&s->armv7m), true, "realized", &err); if (err !=3D NULL) { error_propagate(errp, err); diff --git a/hw/arm/stm32f405_soc.c b/hw/arm/stm32f405_soc.c index 4f10ce6176..2b8a84a695 100644 --- a/hw/arm/stm32f405_soc.c +++ b/hw/arm/stm32f405_soc.c @@ -121,7 +121,11 @@ static void stm32f405_soc_realize(DeviceState *dev_soc= , Error **errp) qdev_prop_set_string(armv7m, "cpu-type", s->cpu_type); qdev_prop_set_bit(armv7m, "enable-bitband", true); object_property_set_link(OBJECT(&s->armv7m), OBJECT(system_memory), - "memory", &error_abort); + "memory", &err); + if (err) { + error_propagate(errp, err); + return; + } object_property_set_bool(OBJECT(&s->armv7m), true, "realized", &err); if (err !=3D NULL) { error_propagate(errp, err); --=20 2.21.1