From nobody Tue Feb 10 20:06:40 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1586195679; cv=none; d=zohomail.com; s=zohoarc; b=bPC6NCdwC9nJuCl6V0b6TRRekZGCtt4UgD2JWsBivF2ajShXfTVU7vwi3AGgd4jrj3vYhCddTAFHMimR2WYN9gzS0el7OWA3L9Kp0C+cpgzcmVfFRKZ7wF4ovXIdKKmy+AtQcJLW7T635SXOs9d/y7g6L91QyZIMoaRHBCT3lWs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1586195679; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3C5u9DrXZj6rRyHI74cwCLmjedB/NXARv4QiTEDtzdw=; b=gJKfSns31YBYopvDkjJlMsAXtsOjbcEAigLwXiOCSimUFPtCfxSQt8VbDpnNRyeeBxeJBdnfdEOXKb55Z7UMMtBPPikwo1IsA35oAjn+lq2Au5aZaELHGXF0/lNe3VxOkN/7ZJ9FBD6ayadKO0Z2+TqXaXWXflH9pB9YY+NlSIs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1586195679863265.0803430365097; Mon, 6 Apr 2020 10:54:39 -0700 (PDT) Received: from localhost ([::1]:35956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLVxG-0005RG-LA for importer@patchew.org; Mon, 06 Apr 2020 13:54:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35929) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLVqt-0001gR-Vs for qemu-devel@nongnu.org; Mon, 06 Apr 2020 13:48:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jLVqs-0001sc-IB for qemu-devel@nongnu.org; Mon, 06 Apr 2020 13:48:03 -0400 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:37326) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jLVqr-0001ng-Bi; Mon, 06 Apr 2020 13:48:02 -0400 Received: by mail-wr1-x443.google.com with SMTP id w10so513991wrm.4; Mon, 06 Apr 2020 10:48:01 -0700 (PDT) Received: from x1w.redhat.com (116.red-83-42-57.dynamicip.rima-tde.net. [83.42.57.116]) by smtp.gmail.com with ESMTPSA id a67sm364880wmc.30.2020.04.06.10.47.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2020 10:47:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3C5u9DrXZj6rRyHI74cwCLmjedB/NXARv4QiTEDtzdw=; b=BzmpXXpW7EEA5jqIDETxNdtM+2Y/Ra/w9UV/aPg/syX2t5t7NrXFDnQS0d9IgSaWnn vzN4hqnvcKpcdVYe6pxdKHyEJ63mJQtLsDYD2DKwLwiwideF82cL+KDW4TC6Ao2eVhgN aEpBnjBpRsvgvg2UdMMNGw2m16z+jsIaRCSOVmybyourCKbhVcp5YKs1x8NxeMEMaL0I eU3YAktle+U7ghEkm+BDl38xUbxzq74QZ35tN7TmEMz20t27N/X/4EkLduiELZVw2kaw JkZGRmwIiEaIAIyq1b/2VGgGaWSABTCmqFA36hadQjP0xMu3VCt0PgwyVIWEUUxeQdJG s/rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=3C5u9DrXZj6rRyHI74cwCLmjedB/NXARv4QiTEDtzdw=; b=ZrjT8eh/WyIby44lzz0CYpuqsHyWLKsL14/lxeOIlXh21RKggkq2paYBbCwQNRs4lX xMikwGhl8OyUd9mApeU2JJqmJxX7bc5pIF/juxy4PgBnicwy+ROYiCr1AxrX/xRHWYIB Kh93Yn1aGEPVsaoyZZwlk5PdvkI73MotSpyhjogkYsvuaYh38ACy+6YFIs3Z0s+mv5kX zp9VILi2YUHUqTFgtdgNHOyxNRrL3EDZBZ0Sh79tsK71zP6NZ74wcGGf3sqCav4UmkNr WMInmWfMhWsNgWXO1qunCgLz1VLaPVpDws/ATFfrjwdCk3h/wpT80/yLzaKTW6rlneNN l/4A== X-Gm-Message-State: AGi0PuZ2KJwZuWOs6UNN2Ulj1VNOdapBSdKIL198jMbwJKkgRakmO06a FnT3VnNnl2ZqO6B18IDTydEsoYbmbD0= X-Google-Smtp-Source: APiQypIMxwSmnEtOgCvmsz39WSmC/Oia50+cLhNzfAQJwO+V8sHTK+hVoi1jZIeeZ4Iw8sb/42fzoQ== X-Received: by 2002:a5d:5228:: with SMTP id i8mr389256wra.156.1586195280250; Mon, 06 Apr 2020 10:48:00 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Markus Armbruster Subject: [PATCH-for-5.1 v2 10/54] hw/arm/fsl-imx31: Move some code from realize() to init() Date: Mon, 6 Apr 2020 19:46:59 +0200 Message-Id: <20200406174743.16956-11-f4bug@amsat.org> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200406174743.16956-1-f4bug@amsat.org> References: <20200406174743.16956-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::443 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Vladimir Sementsov-Ogievskiy , Peter Chubb , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "open list:i.MX31 kzm" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Coccinelle reported: $ spatch ... --timeout 60 --sp-file \ scripts/coccinelle/simplify-init-realize-error_propagate.cocci HANDLING: hw/arm/fsl-imx31.c >>> possible moves from fsl_imx31_init() to fsl_imx31_realize() in hw/arm= /fsl-imx31.c:68 Move the calls using &error_abort which don't depend of input updated before realize() to init(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/fsl-imx31.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm/fsl-imx31.c b/hw/arm/fsl-imx31.c index 8472d2e911..61287e24f6 100644 --- a/hw/arm/fsl-imx31.c +++ b/hw/arm/fsl-imx31.c @@ -62,6 +62,8 @@ static void fsl_imx31_init(Object *obj) for (i =3D 0; i < FSL_IMX31_NUM_GPIOS; i++) { sysbus_init_child_obj(obj, "gpio[*]", &s->gpio[i], sizeof(s->gpio[= i]), TYPE_IMX_GPIO); + object_property_set_bool(OBJECT(&s->gpio[i]), false, "has-edge-sel= ", + &error_abort); } } =20 @@ -191,8 +193,6 @@ static void fsl_imx31_realize(DeviceState *dev, Error *= *errp) { FSL_IMX31_GPIO3_ADDR, FSL_IMX31_GPIO3_IRQ } }; =20 - object_property_set_bool(OBJECT(&s->gpio[i]), false, "has-edge-sel= ", - &error_abort); object_property_set_bool(OBJECT(&s->gpio[i]), true, "realized", &e= rr); if (err) { error_propagate(errp, err); --=20 2.21.1