From nobody Thu Nov 6 05:10:17 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1585854500; cv=none; d=zohomail.com; s=zohoarc; b=JPawgb023zh6oPwoCQGb1NpnOHkjAbNhQfnf/q0Haujs9YaxfZ39N3woa7O7xqugnt6NkmEkxUBzw7AZmzcQo/+QSWkEuBrB74VIVleUOistQ76SYDv7Jz+0xmker7TJzH4rxNfPJNfltfhyeu2BaaGUj4cVPe2IwLluIA7XKhg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585854500; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=sewDymgizkxqPJPRT3hku2hWbDlQTKfdk8fI/f5dunM=; b=XyNxYsS5NFXv9vXxZeNrCONlbkSHLAy2z7mADpIORreyfBAgJ3F2e/RGI7nX7DoCmd/ssMqMoFBWrJth+MlAkGDlZMUH1wnLJx6xf1DtbwdVWUrYSE3XQwTtDA9ZGrsR1IB4I187rEQfktqCT0xPjoHVWoYruygyFFQtknH0Qks= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585854500480830.6180861552742; Thu, 2 Apr 2020 12:08:20 -0700 (PDT) Received: from localhost ([::1]:46310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jK5CM-0004C4-01 for importer@patchew.org; Thu, 02 Apr 2020 15:08:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33775) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jK5At-0002OV-LF for qemu-devel@nongnu.org; Thu, 02 Apr 2020 15:06:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jK5As-0000Aj-JX for qemu-devel@nongnu.org; Thu, 02 Apr 2020 15:06:47 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:23245 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jK5As-00009B-Fd for qemu-devel@nongnu.org; Thu, 02 Apr 2020 15:06:46 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-157-AXgxyE0QNEOmQC29Dw-v8g-1; Thu, 02 Apr 2020 15:06:43 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 58EC88018A7; Thu, 2 Apr 2020 19:06:42 +0000 (UTC) Received: from virtlab701.virt.lab.eng.bos.redhat.com (virtlab701.virt.lab.eng.bos.redhat.com [10.19.152.228]) by smtp.corp.redhat.com (Postfix) with ESMTP id D746650BEE; Thu, 2 Apr 2020 19:06:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585854405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sewDymgizkxqPJPRT3hku2hWbDlQTKfdk8fI/f5dunM=; b=AArqcsaltbFxIohBCirFam3Ic5sTtkxceDpDK0wyQOlE9ckQ294NY+/qWE9/CP2xf5OkEe XfN1Lz/ZYCSyvIW5WW+WyHhLUEyvG5I8ZLBCuJQ9Cri61qg++LC+jg8LjEm2oXjkX9AiDV wAj40nk45X86TE8VIeoVUudQEa39PXY= X-MC-Unique: AXgxyE0QNEOmQC29Dw-v8g-1 From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PULL 01/15] hw/scsi/vmw_pvscsi: Remove assertion for kick after reset Date: Thu, 2 Apr 2020 15:06:26 -0400 Message-Id: <20200402190640.1693-2-pbonzini@redhat.com> In-Reply-To: <20200402190640.1693-1-pbonzini@redhat.com> References: <20200402190640.1693-1-pbonzini@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Elazar Leibovich , Liran Alon Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Elazar Leibovich When running Ubuntu 3.13.0-65-generic guest, QEMU sometimes crashes during guest ACPI reset. It crashes on assert(s->rings_info_valid) in pvscsi_process_io(). Analyzing the crash revealed that it happens when userspace issues a sync during a reboot syscall. Below are backtraces we gathered from the guests. Guest backtrace when issuing PVSCSI_CMD_ADAPTER_RESET: pci_device_shutdown device_shutdown init_pid_ns init_pid_ns kernel_power_off SYSC_reboot Guest backtrace when issuing PVSCSI_REG_OFFSET_KICK_RW_IO: scsi_done scsi_dispatch_cmd blk_add_timer scsi_request_fn elv_rb_add __blk_run_queue queue_unplugged blk_flush_plug_list blk_finish_plug ext4_writepages set_next_entity do_writepages __filemap_fdatawrite_range filemap_write_and_wait_range ext4_sync_file ext4_sync_file do_fsync sys_fsync Since QEMU pvscsi should imitate VMware pvscsi device emulation, we decided to imitate VMware's behavior in this case. To check VMware behavior, we wrote a kernel module that issues a reset to the pvscsi device and then issues a kick. We ran it on VMware ESXi 6.5 and it seems that it simply ignores the kick. Hence, we decided to ignore the kick as well. Signed-off-by: Elazar Leibovich Signed-off-by: Liran Alon Message-Id: <20200315132634.113632-1-liran.alon@oracle.com> Signed-off-by: Paolo Bonzini --- hw/scsi/vmw_pvscsi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c index c91352cf46..ec5bf9ea34 100644 --- a/hw/scsi/vmw_pvscsi.c +++ b/hw/scsi/vmw_pvscsi.c @@ -719,7 +719,10 @@ pvscsi_process_io(PVSCSIState *s) PVSCSIRingReqDesc descr; hwaddr next_descr_pa; =20 - assert(s->rings_info_valid); + if (!s->rings_info_valid) { + return; + } + while ((next_descr_pa =3D pvscsi_ring_pop_req_descr(&s->rings)) !=3D 0= ) { =20 /* Only read after production index verification */ --=20 2.18.2