From nobody Mon Feb 9 15:08:48 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1585839276; cv=none; d=zohomail.com; s=zohoarc; b=UZyCByvM9YKlCtq37WP2ONcV2zDufWAbq/B+OVIU8LwnGOdOy3yBgdk/2OQtsGwVhp+Dk56sZT5mv1p/AnNc4r3RpI2VVXb29zalO/9Nn+aljRuT/vcIZlO5plziBDjshSgaG74rnkimyFEQuCbHPfBfpOOIzDCjWOr6czGtwtE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585839276; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=S1He/Rpf4JLCiKi93YfAGw3px9JkkCyAWLJbg5rNbYc=; b=Z06XGvkOKDklIILVLQXWsMI1rF/huYuMPiERb6xuAlVlgltUkXLxK/EebZGs+Ha+Add1iUVT0iYiVmq8Ayb5+Es7wXw9pmzzdxcaLnnUp3A3kJBO8Nk5QKUHyRFqDvSW002J2Y3qNFVjLrlf6l5zvmRWUQfZS/9PvkaZ9x4lXyo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585839276556707.8543536112637; Thu, 2 Apr 2020 07:54:36 -0700 (PDT) Received: from localhost ([::1]:41872 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jK1Ep-0004IA-9W for importer@patchew.org; Thu, 02 Apr 2020 10:54:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39774) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jK1DV-0002PB-0g for qemu-devel@nongnu.org; Thu, 02 Apr 2020 10:53:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jK1DS-0000Kj-EB for qemu-devel@nongnu.org; Thu, 02 Apr 2020 10:53:12 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:51573 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jK1DS-0000Jj-1i for qemu-devel@nongnu.org; Thu, 02 Apr 2020 10:53:10 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-410-SGK9YdU5O7C0ZhVWCBXbSg-1; Thu, 02 Apr 2020 10:53:06 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5E94118B9FC7; Thu, 2 Apr 2020 14:53:04 +0000 (UTC) Received: from laptop.redhat.com (ovpn-112-58.ams2.redhat.com [10.36.112.58]) by smtp.corp.redhat.com (Postfix) with ESMTP id 631B65D9CD; Thu, 2 Apr 2020 14:53:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585839189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S1He/Rpf4JLCiKi93YfAGw3px9JkkCyAWLJbg5rNbYc=; b=Z6hqZ5TBbJ4HqMZHf8ESoiluaRqy9F9DJtzz0h+Pkjmh0ftoiSBtndDcxeQgZsEj5EIzcU y05rGrxYLXrwEqMYf9KJ/6UtiQU6cDVQbSboPzZSuJxaM0s5IR8pPMyZ6oTGH27pH4PQ+Q DKCvoo6QVmzCWZXXOCnZViOAKntSmvY= X-MC-Unique: SGK9YdU5O7C0ZhVWCBXbSg-1 From: Eric Auger To: eric.auger.pro@gmail.com, eric.auger@redhat.com, maz@kernel.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, qemu-devel@nongnu.org, qemu-arm@nongnu.org Subject: [kvm-unit-tests PATCH v8 03/13] arm/arm64: gic: Introduce setup_irq() helper Date: Thu, 2 Apr 2020 16:52:17 +0200 Message-Id: <20200402145227.20109-4-eric.auger@redhat.com> In-Reply-To: <20200402145227.20109-1-eric.auger@redhat.com> References: <20200402145227.20109-1-eric.auger@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, drjones@redhat.com, andre.przywara@arm.com, thuth@redhat.com, yuzenghui@huawei.com, alexandru.elisei@arm.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" ipi_enable() code would be reusable for other interrupts than IPI. Let's rename it setup_irq() and pass an interrupt handler pointer. Signed-off-by: Eric Auger --- v4 -> v5: - s/handler_t/irq_handler_t - also add irq_handler_fn in lib/arm/asm/processor.h v2 -> v3: - do not export setup_irq anymore --- arm/gic.c | 19 ++++++------------- lib/arm/asm/processor.h | 2 ++ 2 files changed, 8 insertions(+), 13 deletions(-) diff --git a/arm/gic.c b/arm/gic.c index fcf4c1f..2f904b0 100644 --- a/arm/gic.c +++ b/arm/gic.c @@ -215,20 +215,20 @@ static void ipi_test_smp(void) report_prefix_pop(); } =20 -static void ipi_enable(void) +static void setup_irq(irq_handler_fn handler) { gic_enable_defaults(); #ifdef __arm__ - install_exception_handler(EXCPTN_IRQ, ipi_handler); + install_exception_handler(EXCPTN_IRQ, handler); #else - install_irq_handler(EL1H_IRQ, ipi_handler); + install_irq_handler(EL1H_IRQ, handler); #endif local_irq_enable(); } =20 static void ipi_send(void) { - ipi_enable(); + setup_irq(ipi_handler); wait_on_ready(); ipi_test_self(); ipi_test_smp(); @@ -238,7 +238,7 @@ static void ipi_send(void) =20 static void ipi_recv(void) { - ipi_enable(); + setup_irq(ipi_handler); cpumask_set_cpu(smp_processor_id(), &ready); while (1) wfi(); @@ -295,14 +295,7 @@ static void ipi_clear_active_handler(struct pt_regs *r= egs __unused) static void run_active_clear_test(void) { report_prefix_push("active"); - gic_enable_defaults(); -#ifdef __arm__ - install_exception_handler(EXCPTN_IRQ, ipi_clear_active_handler); -#else - install_irq_handler(EL1H_IRQ, ipi_clear_active_handler); -#endif - local_irq_enable(); - + setup_irq(ipi_clear_active_handler); ipi_test_self(); report_prefix_pop(); } diff --git a/lib/arm/asm/processor.h b/lib/arm/asm/processor.h index 1e1132d..e26ef89 100644 --- a/lib/arm/asm/processor.h +++ b/lib/arm/asm/processor.h @@ -26,7 +26,9 @@ enum vector { EXCPTN_MAX, }; =20 +typedef void (*irq_handler_fn)(struct pt_regs *regs); typedef void (*exception_fn)(struct pt_regs *); + extern void install_exception_handler(enum vector v, exception_fn fn); =20 extern void show_regs(struct pt_regs *regs); --=20 2.20.1