From nobody Fri Nov 14 07:50:36 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1585767903; cv=none; d=zohomail.com; s=zohoarc; b=k+WI1kf39eZ9S5nCaRINCU8ZX198EVngl6o1IyBgfUcmMMiODx42RqQbDbJH1Vr+NNXB9BNKa5y8y1dpN8IckjRYzGZc5zmO9QWUPSioJLLsjd3D/Z1Rpg2w1j1Bz9ypD0KihOjZa07Ift3fEmkMOipTSyrTnWv9AmRsqKs2za0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585767903; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=AntlJWnVYM9oNQFtsfhgE2wkqkON+/plym3jylVzMlY=; b=Wo8mpx+uI2s49PyTk9qBRvCnGzSkDAbC3eE8ZFZF5C3zCAa2AS0GL7zSPPdIropcz2uoSekcPnQIxGqrsg87A9MjgrnqI0HIzUeELceDW04C66BENI2DzgGaTSG4GS+22K+s/bCyyOLNsUoiEpthYZPs5zqa0S/+dLiqn2+cEj4= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585767903625743.8281641200917; Wed, 1 Apr 2020 12:05:03 -0700 (PDT) Received: from localhost ([::1]:36150 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJifd-0004cn-WC for importer@patchew.org; Wed, 01 Apr 2020 15:05:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58566) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJibA-0000T4-Fm for qemu-devel@nongnu.org; Wed, 01 Apr 2020 15:00:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJib9-0002Rm-1K for qemu-devel@nongnu.org; Wed, 01 Apr 2020 15:00:24 -0400 Received: from mailout09.t-online.de ([194.25.134.84]:45750) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jJib8-0002R2-PN for qemu-devel@nongnu.org; Wed, 01 Apr 2020 15:00:22 -0400 Received: from fwd18.aul.t-online.de (fwd18.aul.t-online.de [172.20.26.244]) by mailout09.t-online.de (Postfix) with SMTP id 3CAF942D6891; Wed, 1 Apr 2020 21:00:21 +0200 (CEST) Received: from linpower.localnet (SgGN78ZYghq0L+ncI2t2vYTLp2j7LeBhONEwkPaRSgrPBB+UYmA+s1hGD4VQXnpgD3@[93.236.147.242]) by fwd18.t-online.de with (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384 encrypted) esmtp id 1jJib6-06E4fI0; Wed, 1 Apr 2020 21:00:20 +0200 Received: by linpower.localnet (Postfix, from userid 1000) id 5A5B620062A; Wed, 1 Apr 2020 21:00:17 +0200 (CEST) From: =?UTF-8?q?Volker=20R=C3=BCmelin?= To: Gerd Hoffmann Subject: [PATCH 2/3] dsoundaudio: fix "Could not lock capture buffer" warning Date: Wed, 1 Apr 2020 21:00:16 +0200 Message-Id: <20200401190017.5081-2-vr_qemu@t-online.de> X-Mailer: git-send-email 2.16.4 In-Reply-To: <19cd6a5a-97b7-b684-f026-11d82e34dab9@t-online.de> References: <19cd6a5a-97b7-b684-f026-11d82e34dab9@t-online.de> MIME-Version: 1.0 X-ID: SgGN78ZYghq0L+ncI2t2vYTLp2j7LeBhONEwkPaRSgrPBB+UYmA+s1hGD4VQXnpgD3 X-TOI-MSGID: c567f1f0-1cd0-4719-b0e6-bf99b2daab19 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 194.25.134.84 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU , =?UTF-8?q?Zolt=C3=A1n=20K=C5=91v=C3=A1g=C3=B3?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" IDirectSoundCaptureBuffer_Lock() fails on Windows when called with len =3D 0. Return early from dsound_get_buffer_in() in this case. To reproduce the warning start a linux guest. In the guest start Audacity and you will see a lot of "Could not lock capture buffer" warnings. Signed-off-by: Volker R=C3=BCmelin --- audio/dsoundaudio.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/audio/dsoundaudio.c b/audio/dsoundaudio.c index af70dd128e..ea1595dcd1 100644 --- a/audio/dsoundaudio.c +++ b/audio/dsoundaudio.c @@ -544,6 +544,11 @@ static void *dsound_get_buffer_in(HWVoiceIn *hw, size_= t *size) req_size =3D audio_ring_dist(cpos, hw->pos_emul, hw->size_emul); req_size =3D MIN(req_size, hw->size_emul - hw->pos_emul); =20 + if (req_size =3D=3D 0) { + *size =3D 0; + return NULL; + } + err =3D dsound_lock_in(dscb, &hw->info, hw->pos_emul, req_size, &ret, = NULL, &act_size, NULL, false, ds->s); if (err) { --=20 2.16.4