From nobody Thu May 2 22:26:28 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1585670001; cv=none; d=zohomail.com; s=zohoarc; b=ApeuCsxN32SvV1037DmjVf6QgmAyqBnyJg1bYrCUQcRjqPMgJXOs1/dA2atJ0cBO5bwLe/jP9+8XP2t/7f1wCciRY3+md5euAQ6WhyL54MHqR9WwAuUHJs9dwsdQNiR2L1LRVSdWBUuD9qA31yaleIMZyeau7Y24Gd0DcU8jbhY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585670001; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=fp6o51YOCI0gW9Ryer3bJCxCiqL7ZljVd3anZRqlFTY=; b=Q7z3Hccv+l8fCxvQVGNkk1M+3r5Fb5SAPuXPZsStuVmoJw0DCT5Ed22PWwlQ5CTu89CRTCZgBW/HAalOWiZyEcBGBy0maoaCDTnmlrNXh+qaDZxRkdUVfJsx1PGajmIkqB2oolq2ZLkOJCJRJ4Dkyy8wBYMlTpXAe7z1GtFgOWc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158567000100322.441101320312328; Tue, 31 Mar 2020 08:53:21 -0700 (PDT) Received: from localhost ([::1]:40776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJJCZ-0005wa-QH for importer@patchew.org; Tue, 31 Mar 2020 11:53:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38281) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJJBW-0004rK-En for qemu-devel@nongnu.org; Tue, 31 Mar 2020 11:52:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJJBV-0002F6-A4 for qemu-devel@nongnu.org; Tue, 31 Mar 2020 11:52:14 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:49358 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jJJBV-0002E9-3y for qemu-devel@nongnu.org; Tue, 31 Mar 2020 11:52:13 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-40-quF_b8DGMYe3LJQgmaWfqQ-1; Tue, 31 Mar 2020 11:52:10 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9647713FB; Tue, 31 Mar 2020 15:52:08 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.36.110.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id 54EF75D9C5; Tue, 31 Mar 2020 15:52:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585669931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fp6o51YOCI0gW9Ryer3bJCxCiqL7ZljVd3anZRqlFTY=; b=BVWd24zNsYdFw/C3H8a2n0QAOv2cc03P/I4M/Vie8iv7bWZzmKFI1XxgKjdu4Dgo7QGWV5 o4oXJSIL5H6r7ednM2l7SuCqFfgK/IYBCTQVB5k1F6Ida+gCHmmTI+GK64dkXdclixcDGT UVJpWiXap4kXFgJiYc3VEtUIkIS7QKA= X-MC-Unique: quF_b8DGMYe3LJQgmaWfqQ-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2] configure: warn if not using a separate build directory Date: Tue, 31 Mar 2020 16:51:58 +0100 Message-Id: <20200331155158.381585-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Stefan Hajnoczi , Markus Armbruster , Liviu Ionescu , Paolo Bonzini , =?UTF-8?q?Michal=20Such=C3=A1nek?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Markovic Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Running configure directly from the source directory is a build configuration that will go away in future. It is also not currently covered by any automated testing. Display a deprecation warning if the user attempts to use an in-srcdir build setup, so that they are aware that they're building QEMU in an undesirable manner. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster --- Changed in v2: - Use existing $source_path variable (Eric) - Remove bash-ism in comparison (Eric) - Safe quoting of directory paths (Eric) - Rename variables to reflect that we're applying canonicalization (Eric) configure | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/configure b/configure index e225a1e3ff..5991e0e6e5 100755 --- a/configure +++ b/configure @@ -285,6 +285,16 @@ then error_exit "main directory cannot contain spaces nor colons" fi =20 +canon_build_path=3D$(realpath -- "$PWD") +canon_source_path=3D$(realpath -- "$source_path") + +in_srcdir=3Dno +if [ "$canon_build_path" =3D "$canon_source_path" ] +then + in_srcdir=3Dyes +fi + + # default parameters cpu=3D"" iasl=3D"iasl" @@ -6799,6 +6809,23 @@ if test "$supported_os" =3D "no"; then echo "us upstream at qemu-devel@nongnu.org." fi =20 +if test "$in_srcdir" =3D "yes"; then + echo + echo "WARNING: SUPPORT FOR IN SOURCE DIR BUILDS IS DEPRECATED" + echo + echo "Support for running the 'configure' script directly from the" + echo "source directory is deprecated and will go away in a future" + echo "release. In source dir builds are not covered by automated" + echo "testing and are liable to break without warning. Users are" + echo "strongly recommended to switch to a separate build directory:" + echo + echo " $ mkdir build" + echo " $ cd build" + echo " $ ../configure" + echo " $ make" + echo +fi + config_host_mak=3D"config-host.mak" =20 echo "# Automatically generated by configure - do not modify" >config-all-= disas.mak --=20 2.24.1