From nobody Wed May 1 22:35:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1585651137; cv=none; d=zohomail.com; s=zohoarc; b=Cyg5W4MHBZshUbeDvflnNW191W7qChdG4FVDcVm4KHmI3gg7DWv1SUIrI8nY32hUNJM1J2WTbYYhOoZ7KkqS0Bq9GEXOf0RIRGiF53e4ev6K+1i3NQhN13Uf1DQ7yJ9nHhIOSoYP0Ui2QVe3ym1/lZfnn+dHbCiFGMqDRzdvi5o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585651137; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=/PXJdTRRANQj75wsPD9WT+3tlz+4Azw2OA3jRBkC6l8=; b=KyQ50owD9Cwj/T3wWlPcTmzaGgZCCEq730lZ2YocpCVFnbHTtdknEJLhTWNLqXPdJ4UlkkaxiTy3aO4o2oMsmVfEmQvDV6uDHgoUkDsDLNciup9BaF4bjnMPBmOjdd+VZJUYjtqHVzd8jF7MKlzptbhrWjy2srVUgYpOUFqZydM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158565113794498.84490117836378; Tue, 31 Mar 2020 03:38:57 -0700 (PDT) Received: from localhost ([::1]:35634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJEIK-0006s8-K1 for importer@patchew.org; Tue, 31 Mar 2020 06:38:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50902) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJEHa-0006Q6-KD for qemu-devel@nongnu.org; Tue, 31 Mar 2020 06:38:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJEHZ-0005EA-KI for qemu-devel@nongnu.org; Tue, 31 Mar 2020 06:38:10 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:42039 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jJEHZ-0005Dn-H0 for qemu-devel@nongnu.org; Tue, 31 Mar 2020 06:38:09 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-105-gG-2o7HSM0O9AUg-9mF16g-1; Tue, 31 Mar 2020 06:38:05 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C2E5D8018A1; Tue, 31 Mar 2020 10:38:03 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.36.110.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1CC1396B6C; Tue, 31 Mar 2020 10:37:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585651088; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/PXJdTRRANQj75wsPD9WT+3tlz+4Azw2OA3jRBkC6l8=; b=Gsk0ADN9rC8UcwkGiCozZ/qMAnOpAwbx0abGITCXMMX7+SM9RtaPvJ+T+fQeLV7NUO6n3a 7GSKNt1JUPtGsjXOimgRpBq9TU9J7HpQ5nIA1n9fE8FbTuVLfPBnC3vXigtQpLy6nUQqMW L2blc/4rMBt65BB1nCrqM5xlgvkpizY= X-MC-Unique: gG-2o7HSM0O9AUg-9mF16g-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH] configure: warn if not using a separate build directory Date: Tue, 31 Mar 2020 11:37:58 +0100 Message-Id: <20200331103758.370644-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Liviu Ionescu , Markus Armbruster , Stefan Hajnoczi , Paolo Bonzini , =?UTF-8?q?Michal=20Such=C3=A1nek?= , Aleksandar Markovic Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Running configure directly from the source directory is a build configuration that will go away in future. It is also not currently covered by any automated testing. Display a deprecation warning if the user attempts to use an in-srcdir build setup, so that they are aware that they're building QEMU in an undesirable manner. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 --- configure | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/configure b/configure index e225a1e3ff..1ab7492ab5 100755 --- a/configure +++ b/configure @@ -3,6 +3,19 @@ # qemu configure script (c) 2003 Fabrice Bellard # =20 +BUILDDIR=3D$(pwd) +SRCDIR=3D$(dirname "$0") + +ABS_BUILDDIR=3D$(realpath $BUILDDIR) +ABS_SRCDIR=3D$(realpath $SRCDIR) + +in_srcdir=3Dno +if [ "$ABS_SRCDIR" =3D=3D "$ABS_BUILDDIR" ] +then + in_srcdir=3Dyes +fi + + # Unset some variables known to interfere with behavior of common tools, # just as autoconf does. CLICOLOR_FORCE=3D GREP_OPTIONS=3D @@ -6799,6 +6812,23 @@ if test "$supported_os" =3D "no"; then echo "us upstream at qemu-devel@nongnu.org." fi =20 +if test "$in_srcdir" =3D "yes"; then + echo + echo "WARNING: SUPPORT FOR IN SOURCE DIR BUILDS IS DEPRECATED" + echo + echo "Support for running the 'configure' script directly from the" + echo "source directory is deprecated and will go away in a future" + echo "release. In source dir builds are not covered by automated" + echo "testing and are liable to break without warning. Users are" + echo "strongly recommended to switch to a separate build directory:" + echo + echo " $ mkdir build" + echo " $ cd build" + echo " $ ../configure" + echo " $ make" + echo +fi + config_host_mak=3D"config-host.mak" =20 echo "# Automatically generated by configure - do not modify" >config-all-= disas.mak --=20 2.24.1