From nobody Wed May 8 21:39:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1585582284; cv=none; d=zohomail.com; s=zohoarc; b=QzvqZhNmTACLkAbYJtF2j+gdB8AbHPkO2pIss01IT3BmU/cK98x2fKGyv6BwHLovsR3ZoS6FuOu9gqO2pIetszXTESHHc1oO7bEAy0XeyFjmUvIubuSrib6KiVk54xNER2ghUmP8hhJMUWQUucgomVpK4m1j9PAK8TnkXlIVtGs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585582284; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=wlkjtKPyWMqQrbfa2vdwgZkigUemJrYf+pOUdA57Mms=; b=e7EDqf9Zh12PBcLMcbw0kE41kTR9WMaGw6cdwsRZnbjF+BHIr0u16q6oyVhlqqn69rX3m6nxXSLzhVZInQe2wnWgkWU+1lx2sQtnapfYLmqSLy0OE8ARu/Y8irv0291BpHsDtinVyFrvzBKb2YWNWCCxw4sE/KqLovx4sc00yik= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585582284757296.8706583760096; Mon, 30 Mar 2020 08:31:24 -0700 (PDT) Received: from localhost ([::1]:51366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIwNn-0002vY-4T for importer@patchew.org; Mon, 30 Mar 2020 11:31:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38779) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIwMn-000210-QY for qemu-devel@nongnu.org; Mon, 30 Mar 2020 11:30:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jIwMm-0002Jx-PJ for qemu-devel@nongnu.org; Mon, 30 Mar 2020 11:30:21 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:44204) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jIwMm-0002H0-Gu for qemu-devel@nongnu.org; Mon, 30 Mar 2020 11:30:20 -0400 Received: by mail-wr1-x444.google.com with SMTP id m17so22147924wrw.11 for ; Mon, 30 Mar 2020 08:30:20 -0700 (PDT) Received: from x1w.redhat.com (116.red-83-42-57.dynamicip.rima-tde.net. [83.42.57.116]) by smtp.gmail.com with ESMTPSA id l185sm12185971wml.44.2020.03.30.08.30.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 08:30:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wlkjtKPyWMqQrbfa2vdwgZkigUemJrYf+pOUdA57Mms=; b=F5Yw85YvezFOBGlXOPcLstYiVSY0ywC0+clKJiI1IDmd4azg5CiivOizL9BW2NgcsO YjUAFt7jIEBrs7fYZJNPXsN8QCh5eqz80LObfLY0giNVYcXF9lMykdQMzZD2DtSrsZZW Th+uJmhYSGvWn6njBhG5m8TGVVj6S7cu+YhxtnV7BMGLWwJYpt3l2/QWF11elhGa/Cwr OGF+owRrk8wFgkmFwyCKLH6V/pVzdys6cAj7sE9OxXqHDDuj4wWGkx9IodBCHyuBT9G0 rQXiAqHD2/vKPOotxKvhnCOkQ6EGfb1g4b5UM/VyM+shr44QmASaIlCxQ8KWHJjkkwXq uxRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=wlkjtKPyWMqQrbfa2vdwgZkigUemJrYf+pOUdA57Mms=; b=dnwy+htycOPyCj4AlxO9VqtRnh4BPHRdlgAIWOGviDaMovMN0JmNo3d3bzhrBDDQZT +jRXCsnT+Yr4brKirrLl/T6mfbOQjWOFmBNl2j6p1kpSCfRhP6WtKWUNm461IiQXqcOH Y5d8cAoUeA6jIspHSFH0+Fec1fEIW3gg1uGbYvR4LYzQfQ2RIw27OM+Y57c+cjISAwaG yZpTQZN7dFPiDmYFnXsySTVtpaz3fWnMniwFw5Vcl8aDEKrDmZPzpTLx8MzWRwxG5tNQ 0oihfZDvXwtRA7179kNW5ltMKn47Bb8hxY5dvI9N1EPwMszzp5xcHfPUz1wL2e64Jauv XWow== X-Gm-Message-State: ANhLgQ3C7Pi9A7XnoEezZupDP2TxUJJ1sbmUAmiX1yng877SDm2I126k AbvVi/K7+3A9hvcrO7z9nncFCIoZHiM= X-Google-Smtp-Source: ADFU+vs2RIlyYEqRrY9H6DN7hzGjv+xvOUolEim08yy8K+ZRfnNLLuUV94mQ7+5tMS0PTy+yCJ5pcw== X-Received: by 2002:a05:6000:1251:: with SMTP id j17mr15592161wrx.228.1585582218768; Mon, 30 Mar 2020 08:30:18 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH-for-5.0] gdbstub: Use correct address space with Qqemu.PhyMemMode packet Date: Mon, 30 Mar 2020 17:30:16 +0200 Message-Id: <20200330153016.2959-1-f4bug@amsat.org> X-Mailer: git-send-email 2.21.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" , Peter Maydell , Jon Doron , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Luc Michel Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Since commit 3f940dc98, we added support for vAttach packet to select a particular thread/cpu/core. However when using the GDB physical memory mode, it is not clear which CPU address space is used. Since the CPU address space is stored in CPUState::as, use address_space_rw() instead of cpu_physical_memory_rw(). Fixes: ab4752ec8d9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- gdbstub.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 013fb1ac0f..3baaef50e3 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -69,11 +69,8 @@ static inline int target_memory_rw_debug(CPUState *cpu, = target_ulong addr, =20 #ifndef CONFIG_USER_ONLY if (phy_memory_mode) { - if (is_write) { - cpu_physical_memory_write(addr, buf, len); - } else { - cpu_physical_memory_read(addr, buf, len); - } + address_space_rw(cpu->as, addr, MEMTXATTRS_UNSPECIFIED, + buf, len, is_write); return 0; } #endif --=20 2.21.1