From nobody Sun Feb 8 19:38:13 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1585340467; cv=none; d=zohomail.com; s=zohoarc; b=SIGEAdQfGkzthvbvoafl8X1Vf0RQfCZlJWjtF2c31fX5l3FEjXyYFEKgNzffXrbHDOR3AslZARyuk9FeycxhZAi5SYclX7RmyWReHaxDsoXsw3Vur28bGzJK+rO/04PgaViBX6ISk7NjLwPgtPxNYJM7rpSeL3sdnwa71554sgk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585340467; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Wb57722k04O6Jmrt5TZW6SVzmKByiDi63Qbe3WI68UM=; b=l8j0B094mrmhLKu52iA1raAWarQDdKTZLU9Cr2sCPtaMnSpN98UDsA2hplA/Mnt8ZftfRYlDYUSsCiUg1srpJEoTtSqO2Bw8PctpxJnK3SZ1AdvBQpZb2AUUz4Aum8LHlSpL5/1uVeC+9J7xRmiEyspM/vqvUQLOkJeOaADptpg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585340467327290.4589696806411; Fri, 27 Mar 2020 13:21:07 -0700 (PDT) Received: from localhost ([::1]:46536 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHvTV-0000AL-MC for importer@patchew.org; Fri, 27 Mar 2020 16:21:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57851) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHvO9-0002Ll-78 for qemu-devel@nongnu.org; Fri, 27 Mar 2020 16:15:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jHvO8-0003Bv-3y for qemu-devel@nongnu.org; Fri, 27 Mar 2020 16:15:33 -0400 Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:57040) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jHvO8-0003BI-08 for qemu-devel@nongnu.org; Fri, 27 Mar 2020 16:15:32 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-2-dfFpU7mVNl2109tX3WiM-g-1; Fri, 27 Mar 2020 16:15:29 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7B2CFDB21; Fri, 27 Mar 2020 20:15:27 +0000 (UTC) Received: from probe.redhat.com (ovpn-113-210.rdu2.redhat.com [10.10.113.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id 36E2519C7F; Fri, 27 Mar 2020 20:15:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585340131; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wb57722k04O6Jmrt5TZW6SVzmKByiDi63Qbe3WI68UM=; b=B2Q42VHF5/3GsPKBRdPl7Q/trQsn0CFpSrhStAnC+zZRtkpweiRjVvIkeFGyAQGTip6wcy q+tUU/HhgM44Xw23A+k9Uy5YgvGBy5w/aif5IDDRB+X8scn0NMRto5IDXin7gpFT0BpwXs ZiICdoZ3wO0nk/gNYLiGyHsFaywONns= X-MC-Unique: dfFpU7mVNl2109tX3WiM-g-1 From: John Snow To: Peter Maydell , qemu-devel@nongnu.org Subject: [PULL 4/5] via-ide: use qdev gpio rather than qemu_allocate_irqs() Date: Fri, 27 Mar 2020 16:15:00 -0400 Message-Id: <20200327201501.1417-5-jsnow@redhat.com> In-Reply-To: <20200327201501.1417-1-jsnow@redhat.com> References: <20200327201501.1417-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 63.128.21.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , Mark Cave-Ayland , qemu-block@nongnu.org, Helge Deller , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Aleksandar Rikalo , David Gibson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Artyom Tarasenko , Laurent Vivier , Thomas Huth , Eduardo Habkost , John Snow , Richard Henderson , Kevin Wolf , Max Reitz , qemu-ppc@nongnu.org, Aleksandar Markovic , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Mark Cave-Ayland This prevents the memory from qemu_allocate_irqs() from being leaked which can in some cases be spotted by Coverity (CID 1421984). Signed-off-by: Mark Cave-Ayland Message-id: 20200324210519.2974-3-mark.cave-ayland@ilande.co.uk Signed-off-by: John Snow --- hw/ide/via.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/ide/via.c b/hw/ide/via.c index 2a55b7fbc6..be09912b33 100644 --- a/hw/ide/via.c +++ b/hw/ide/via.c @@ -160,6 +160,7 @@ static void via_ide_reset(DeviceState *dev) static void via_ide_realize(PCIDevice *dev, Error **errp) { PCIIDEState *d =3D PCI_IDE(dev); + DeviceState *ds =3D DEVICE(dev); uint8_t *pci_conf =3D dev->config; int i; =20 @@ -187,9 +188,10 @@ static void via_ide_realize(PCIDevice *dev, Error **er= rp) bmdma_setup_bar(d); pci_register_bar(dev, 4, PCI_BASE_ADDRESS_SPACE_IO, &d->bmdma_bar); =20 + qdev_init_gpio_in(ds, via_ide_set_irq, 2); for (i =3D 0; i < 2; i++) { - ide_bus_new(&d->bus[i], sizeof(d->bus[i]), DEVICE(d), i, 2); - ide_init2(&d->bus[i], qemu_allocate_irq(via_ide_set_irq, d, i)); + ide_bus_new(&d->bus[i], sizeof(d->bus[i]), ds, i, 2); + ide_init2(&d->bus[i], qdev_get_gpio_in(ds, i)); =20 bmdma_init(&d->bus[i], &d->bmdma[i], d); d->bmdma[i].bus =3D &d->bus[i]; --=20 2.21.1