From nobody Sun Feb 8 12:37:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1585340304; cv=none; d=zohomail.com; s=zohoarc; b=crzE3xbVtfvYu3122GWsETyErTbBclxhkh1Tn3637TQs+m126CImugz6fqyz3n98EfHbe9lb2scGLUmkWOe+O1/v23jljtW/DGSTHjR6TyOKWUQ44Uk7Wu9MaeH7HaiuWB2HvitH8VvQumuvFYj0nnpIEHnIg/6X6sEPebCPcD8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585340304; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=YPke/Eo9yLBSwedbOokwjPMQC/LRtOf0e/P1yN/8H/M=; b=AdScUay06rbWdM5VsuHTUX/LjmSHevbjk9Xn6PYTxmWAvmPk/W/v0EYt/kG2F4mZxOGnY3j4TvyAaTYG3YcNEySowYywV0LWhdJES86i/kh7DSo1ogNv9bTj82LeEZ6doE4CMT4wm3EG6kP/JoEJ57zBDjOlu2pXtsvOGZWiLVY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585340304386561.7742539998316; Fri, 27 Mar 2020 13:18:24 -0700 (PDT) Received: from localhost ([::1]:46506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHvQs-0005qY-52 for importer@patchew.org; Fri, 27 Mar 2020 16:18:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57800) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHvO7-0002Gq-0t for qemu-devel@nongnu.org; Fri, 27 Mar 2020 16:15:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jHvO5-000382-Us for qemu-devel@nongnu.org; Fri, 27 Mar 2020 16:15:30 -0400 Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:43449) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jHvO5-00037A-QR for qemu-devel@nongnu.org; Fri, 27 Mar 2020 16:15:29 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-238-JtKweeeHOQC9-lldGvQNjw-1; Fri, 27 Mar 2020 16:15:27 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 124E4107ACC9; Fri, 27 Mar 2020 20:15:25 +0000 (UTC) Received: from probe.redhat.com (ovpn-113-210.rdu2.redhat.com [10.10.113.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5E51619C7F; Fri, 27 Mar 2020 20:15:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585340129; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YPke/Eo9yLBSwedbOokwjPMQC/LRtOf0e/P1yN/8H/M=; b=JoQgRZSpQ8632ilSd3iQaZJ3IJpwQ5ndE3Cke8+cTHFeNPuUGYFh+MPrqQnoStymFU5i97 UdFIR7wQeuaobY7YMUVn5DVOXaZWWpFUzZ+44FP4xPgKWl8DusK77W6EHzffCZ0iEQIRxp mmNS9qEUCUO7GzUa65MxXp3lq15X+fY= X-MC-Unique: JtKweeeHOQC9-lldGvQNjw-1 From: John Snow To: Peter Maydell , qemu-devel@nongnu.org Subject: [PULL 3/5] via-ide: don't use PCI level for legacy IRQs Date: Fri, 27 Mar 2020 16:14:59 -0400 Message-Id: <20200327201501.1417-4-jsnow@redhat.com> In-Reply-To: <20200327201501.1417-1-jsnow@redhat.com> References: <20200327201501.1417-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 63.128.21.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , Mark Cave-Ayland , qemu-block@nongnu.org, Helge Deller , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Aleksandar Rikalo , David Gibson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Artyom Tarasenko , Laurent Vivier , Thomas Huth , Eduardo Habkost , John Snow , Richard Henderson , Kevin Wolf , Max Reitz , qemu-ppc@nongnu.org, Aleksandar Markovic , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Mark Cave-Ayland The PCI level calculation was accidentally left in when rebasing from a previous patchset. Since both IRQs are driven separately, the value being passed into the IRQ handler should be used directly. Signed-off-by: Mark Cave-Ayland Message-id: 20200324210519.2974-2-mark.cave-ayland@ilande.co.uk Signed-off-by: John Snow --- hw/ide/via.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/ide/via.c b/hw/ide/via.c index 8de4945cc1..2a55b7fbc6 100644 --- a/hw/ide/via.c +++ b/hw/ide/via.c @@ -112,7 +112,6 @@ static void via_ide_set_irq(void *opaque, int n, int le= vel) d->config[0x70 + n * 8] &=3D ~0x80; } =20 - level =3D (d->config[0x70] & 0x80) || (d->config[0x78] & 0x80); qemu_set_irq(isa_get_irq(NULL, 14 + n), level); } =20 --=20 2.21.1