From nobody Fri May 3 08:20:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1585294444; cv=none; d=zohomail.com; s=zohoarc; b=DEZWRseE2Hbuh2pJPySNElYCIYemALUd1rioleYHn2Qrx/5W76KzJtiTtittjLPVK7J8MRT/RrzBTPN3GrQjXTcbwC185sBTQSr+e/uGRZ1YxJFN/EOQJ7Rm1dSUKfc0GsgY/DkaiWvILgc7PtevnuLj/5D7Yehf9JytcGbfIDI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585294444; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=1WEXknhFM4m9qux25wruT4CA8BekV8/X5XKSwZW/soY=; b=jxZ0H1Yhxyl0oVloDavawLQw6joMreZzIAFiuLuE63mFygBmZxGQCiwmS3LMczHEbSKBnMK34AshEau6LBdv0EL72PdHlo3GMETLKTgAeif7wajLGYXJdXsm53QogTtUcezde4B7dkKIIW3U7B2XfMDWCo7+gf8kYw/U0w+WA38= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585294442432966.1597660742586; Fri, 27 Mar 2020 00:34:02 -0700 (PDT) Received: from localhost ([::1]:38056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHjVA-0003Nt-U5 for importer@patchew.org; Fri, 27 Mar 2020 03:34:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44655) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHjTx-0002WF-I5 for qemu-devel@nongnu.org; Fri, 27 Mar 2020 03:32:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jHjTt-0005VC-Ml for qemu-devel@nongnu.org; Fri, 27 Mar 2020 03:32:43 -0400 Received: from cmccmta2.chinamobile.com ([221.176.66.80]:11079) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jHjTp-0004Xj-Cb for qemu-devel@nongnu.org; Fri, 27 Mar 2020 03:32:39 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.17]) by rmmx-syy-dmz-app08-12008 (RichMail) with SMTP id 2ee85e7dac01701-d55c3; Fri, 27 Mar 2020 15:32:18 +0800 (CST) Received: from localhost.localdomain (unknown[112.25.154.146]) by rmsmtp-syy-appsvr09-12009 (RichMail) with SMTP id 2ee95e7dabfc32c-971e9; Fri, 27 Mar 2020 15:32:17 +0800 (CST) X-RM-TRANSID: 2ee85e7dac01701-d55c3 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 X-RM-TRANSID: 2ee95e7dabfc32c-971e9 From: Mao Zhongyi To: qemu-devel@nongnu.org Subject: [PATCH] monitor/hmp-cmds: add units for mirate_parameters. Date: Fri, 27 Mar 2020 15:32:10 +0800 Message-Id: <20200327073210.198080-1-maozhongyi@cmss.chinamobile.com> X-Mailer: git-send-email 2.17.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 221.176.66.80 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dgilbert@redhat.com, Mao Zhongyi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When running: (qemu) info migrate_parameters announce-initial: 50 ms announce-max: 550 ms announce-step: 100 ms compress-wait-thread: on ... max-bandwidth: 33554432 bytes/second downtime-limit: 300 milliseconds x-checkpoint-delay: 20000 ... xbzrle-cache-size: 67108864 add units for the parameters 'x-checkpoint-delay' and 'xbzrle-cache-size', it's easier to read. Signed-off-by: Mao Zhongyi --- monitor/hmp-cmds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index 2a900a528a..8d22f96e57 100644 --- a/monitor/hmp-cmds.c +++ b/monitor/hmp-cmds.c @@ -440,7 +440,7 @@ void hmp_info_migrate_parameters(Monitor *mon, const QD= ict *qdict) MigrationParameter_str(MIGRATION_PARAMETER_DOWNTIME_LIMIT), params->downtime_limit); assert(params->has_x_checkpoint_delay); - monitor_printf(mon, "%s: %u\n", + monitor_printf(mon, "%s: %u" " milliseconds\n", MigrationParameter_str(MIGRATION_PARAMETER_X_CHECKPOINT_DELAY), params->x_checkpoint_delay); assert(params->has_block_incremental); @@ -453,7 +453,7 @@ void hmp_info_migrate_parameters(Monitor *mon, const QD= ict *qdict) monitor_printf(mon, "%s: %s\n", MigrationParameter_str(MIGRATION_PARAMETER_MULTIFD_COMPRESSION= ), MultiFDCompression_str(params->multifd_compression)); - monitor_printf(mon, "%s: %" PRIu64 "\n", + monitor_printf(mon, "%s: %" PRIu64 " bytes\n", MigrationParameter_str(MIGRATION_PARAMETER_XBZRLE_CACHE_SIZE), params->xbzrle_cache_size); monitor_printf(mon, "%s: %" PRIu64 "\n", --=20 2.17.1