From nobody Thu May 2 04:54:40 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1585290473; cv=none; d=zohomail.com; s=zohoarc; b=E0PoxciNXBlXW9evmjLsOhBAdQoEhoWURfTzjj9LdjOZM1o2lEWwQ4VO2k5jpbKfRugUjmMAuzhHhw+a2anb8TuEAgLNbtAvtd+FshiqL7+K15NSCEcb6J5aoI4RBZOLQweFpwUVTKyfk28a5bo0BE2h9wRZAoMheBwQjuZjkDo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585290473; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=XCb3Rf1k/5fY9A8vUgQA+sC+25I1K2hGRkMW2DPDBGY=; b=i5jqlkwgb0K3YfA4Jyj2+/CbF9Lfe5+g24BImqLj8AqX3xF2iM5q2f3rmGLD7Dvq8V1exdo2hYsrZ2W2cnNvT0wA3nofp0dU2+Thn2WC+phSjqzFt1V7ATU7Bm8VKgvd+7oQMdb7EmgFdAfFrlfLoB7mfYMx1N17pRj2DPgEB68= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585290472907824.7872005174635; Thu, 26 Mar 2020 23:27:52 -0700 (PDT) Received: from localhost ([::1]:37632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHiT8-0000Eh-8W for importer@patchew.org; Fri, 27 Mar 2020 02:27:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58728) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHiSK-0008C0-Ij for qemu-devel@nongnu.org; Fri, 27 Mar 2020 02:27:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jHiSJ-0003tI-4e for qemu-devel@nongnu.org; Fri, 27 Mar 2020 02:27:00 -0400 Received: from cmccmta1.chinamobile.com ([221.176.66.79]:3973) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jHiSI-0000yd-D2 for qemu-devel@nongnu.org; Fri, 27 Mar 2020 02:26:59 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.5]) by rmmx-syy-dmz-app01-12001 (RichMail) with SMTP id 2ee15e7d9c95898-d3635; Fri, 27 Mar 2020 14:26:29 +0800 (CST) Received: from localhost.localdomain (unknown[112.25.154.146]) by rmsmtp-syy-appsvr03-12003 (RichMail) with SMTP id 2ee35e7d9c9070d-18a74; Fri, 27 Mar 2020 14:26:29 +0800 (CST) X-RM-TRANSID: 2ee15e7d9c95898-d3635 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 X-RM-TRANSID: 2ee35e7d9c9070d-18a74 From: Mao Zhongyi To: qemu-devel@nongnu.org Subject: [PATCH] monitor/hmp-cmds: don't silently output when running 'migrate_set_downtime' fails Date: Fri, 27 Mar 2020 14:26:23 +0800 Message-Id: <20200327062623.191818-1-maozhongyi@cmss.chinamobile.com> X-Mailer: git-send-email 2.17.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 221.176.66.79 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dgilbert@redhat.com, Mao Zhongyi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Although 'migrate_set_downtime' has been deprecated and replaced with 'migrate_set_parameter downtime_limit', it has not been completely eliminated, possibly due to compatibility with older versions. I think as long as this old parameter is running, we should report appropriate message when something goes wrong, not be silent. before: (qemu) migrate_set_downtime -1 (qemu) after: (qemu) migrate_set_downtime -1 Error: Parameter 'downtime_limit' expects an integer in the range of 0 to 2= 000 seconds Signed-off-by: Mao Zhongyi Reviewed-by: Dr. David Alan Gilbert --- monitor/hmp-cmds.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index 9b94e67879..2a900a528a 100644 --- a/monitor/hmp-cmds.c +++ b/monitor/hmp-cmds.c @@ -1181,8 +1181,14 @@ void hmp_migrate_pause(Monitor *mon, const QDict *qd= ict) /* Kept for backwards compatibility */ void hmp_migrate_set_downtime(Monitor *mon, const QDict *qdict) { + Error *err =3D NULL; + double value =3D qdict_get_double(qdict, "value"); - qmp_migrate_set_downtime(value, NULL); + qmp_migrate_set_downtime(value, &err); + + if (err) { + hmp_handle_error(mon, err); + } } =20 void hmp_migrate_set_cache_size(Monitor *mon, const QDict *qdict) --=20 2.17.1