From nobody Mon Feb 9 23:03:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1585164471; cv=none; d=zohomail.com; s=zohoarc; b=htRajIeX+hOWWrxnSgr/ylVaWJX/PgIIwVkqXURo8ArIxbWSBobHliCI8oFwL4+p8zphZ1AjveWX489aUFElfHXVme3FCiQC1mzNbmR02Szy4Km4QD7m7NxyWfi2+m9t7TWNCBPPGdZddqjfaZTXU4WT+iRuA6KNonxAtJAJoPQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585164471; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=FLAg7xZQkFQ92vwN68WYTdAYbQO9ogHsGkYV8gRk1bg=; b=WjLh280ddhpELmE8+uUI/0kMlbIdAYp+7xx7Cy6NQo+pdMuuF/Y4vbuiSCMYqTQk6T3H0Swgl3Sj0/dxzmyzr72l/Ebos6q+NXXjOWLgNwfOffvQCyIjhmS0PvkjDggyEKtfZ57td5Yedh9wIF8OU/WWawA74/V3dWtGK/hVZ10= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585164471327588.8603736221597; Wed, 25 Mar 2020 12:27:51 -0700 (PDT) Received: from localhost ([::1]:42072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHBgs-000474-4Y for importer@patchew.org; Wed, 25 Mar 2020 15:27:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53639) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHBYU-0000eF-4E for qemu-devel@nongnu.org; Wed, 25 Mar 2020 15:19:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jHBYS-00009s-0b for qemu-devel@nongnu.org; Wed, 25 Mar 2020 15:19:09 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]:54113) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jHBYR-00009B-QC; Wed, 25 Mar 2020 15:19:07 -0400 Received: by mail-wm1-x329.google.com with SMTP id b12so3821663wmj.3; Wed, 25 Mar 2020 12:19:07 -0700 (PDT) Received: from localhost.localdomain (37.red-83-52-54.dynamicip.rima-tde.net. [83.52.54.37]) by smtp.gmail.com with ESMTPSA id r17sm6345672wrx.46.2020.03.25.12.19.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2020 12:19:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FLAg7xZQkFQ92vwN68WYTdAYbQO9ogHsGkYV8gRk1bg=; b=aM2i9xGPlxc7eiNKXcKUby7/ZlPXd+ZoPY3tUflSCFFLJjNxH7u/XyAwYjn2/zuLUD 12fiaUWkLFIMzNunmhbWuJjNQDqUXacbAEiOwz7gFocslD+8ACOxJTFu4EcLBBP1Zv2k UJCrRUZS95pqFWH9bnkuf0xZ4d6pugF+IOuJajLtdwSkQFCfUh6YApTPd7SsMAuhcaHX NJKsKBJKyRyl3hVWK8juW/l7Itu0FeesPLePueykBBN6WRhLutNNPh2IR5eusoqjfw3F +pZoInKcPJuHu7Ta7jMn01ezdTHGSJbislTtHSaGDv8ZidIRO+RqCd8dXfjZAMLp8diY Y3uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=FLAg7xZQkFQ92vwN68WYTdAYbQO9ogHsGkYV8gRk1bg=; b=Js+8JV5jFpyru/8YUY9BZs7uz30L+/xCi0FBSUuDwSGe8wtjMxvNMBTwMkSqk6EEN4 6MOtvlVs2sYENU2wZLMFFrv6rC2GnxEAwTDFr+nI3Qs4OTccrK7GgmtpxDF4PZwM758d pxy+VFVbbd039A2bChly2rqZHoVvewLvH9/dNLK2XNqwPpp11OC1RKPAtYWzfeOn4qbG DkwUDOKAWtNdJdRyaIPcXRTITMoj0JKDZfbQb39quA0vq7HHB2AuxP8Cd3MU2iQ1BvpB RUyCzhhuBnU5Qd1hYP40AWKnKw/tQYiR16Suro8QX2LLJP+CSOVZ5YjKzBMhZMLqLESx o+xA== X-Gm-Message-State: ANhLgQ1RO90Y8uUhlRG38R4eo1z2qXtGYGdpck+8EXu3JF/pl/7oVCkG vBmsA3AbeKU6paNCJRS4dGmpcLsbP8c= X-Google-Smtp-Source: ADFU+vsTDouuJFZhsaN9jpTOHaevaZOuYumtfWR76FoMQzD+z65DCgdk07CJDsio8mPDMbGyndXPiw== X-Received: by 2002:a1c:bcc6:: with SMTP id m189mr5049600wmf.48.1585163946428; Wed, 25 Mar 2020 12:19:06 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH-for-5.0 11/12] hw/net/xilinx_axienet: Add missing error-propagation code Date: Wed, 25 Mar 2020 20:18:29 +0100 Message-Id: <20200325191830.16553-12-f4bug@amsat.org> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200325191830.16553-1-f4bug@amsat.org> References: <20200325191830.16553-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::329 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Burton , Sagar Karandikar , "Michael S. Tsirkin" , Jason Wang , Mark Cave-Ayland , Alistair Francis , "Edgar E. Iglesias" , Peter Maydell , Markus Armbruster , Aleksandar Markovic , Palmer Dabbelt , Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , Alistair Francis , qemu-arm@nongnu.org, David Gibson , qemu-riscv@nongnu.org, Bastian Koppelmann , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Andrew Baumann , Jean-Christophe Dubois , qemu-ppc@nongnu.org, Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Running the coccinelle script produced: $ spatch \ --macro-file scripts/cocci-macro-file.h --include-headers \ --sp-file scripts/coccinelle/object_property_missing_error_propagate.co= cci \ --keep-comments --smpl-spacing --dir hw [[manual check required: error_propagate() might be missing in object_pro= perty_set_link() hw/net/xilinx_axienet.c:969:4]] Add the missing error_propagate() after manual review. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- hw/net/xilinx_axienet.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/net/xilinx_axienet.c b/hw/net/xilinx_axienet.c index 704788811a..f11510a71e 100644 --- a/hw/net/xilinx_axienet.c +++ b/hw/net/xilinx_axienet.c @@ -948,39 +948,42 @@ static NetClientInfo net_xilinx_enet_info =3D { static void xilinx_enet_realize(DeviceState *dev, Error **errp) { XilinxAXIEnet *s =3D XILINX_AXI_ENET(dev); XilinxAXIEnetStreamSlave *ds =3D XILINX_AXI_ENET_DATA_STREAM(&s->rx_da= ta_dev); XilinxAXIEnetStreamSlave *cs =3D XILINX_AXI_ENET_CONTROL_STREAM( &s->rx_control= _dev); Error *local_err =3D NULL; =20 object_property_add_link(OBJECT(ds), "enet", "xlnx.axi-ethernet", (Object **) &ds->enet, object_property_allow_set_link, OBJ_PROP_LINK_STRONG, &local_err); object_property_add_link(OBJECT(cs), "enet", "xlnx.axi-ethernet", (Object **) &cs->enet, object_property_allow_set_link, OBJ_PROP_LINK_STRONG, &local_err); if (local_err) { goto xilinx_enet_realize_fail; } object_property_set_link(OBJECT(ds), OBJECT(s), "enet", &local_err); + if (local_err) { + goto xilinx_enet_realize_fail; + } object_property_set_link(OBJECT(cs), OBJECT(s), "enet", &local_err); if (local_err) { goto xilinx_enet_realize_fail; } =20 qemu_macaddr_default_if_unset(&s->conf.macaddr); s->nic =3D qemu_new_nic(&net_xilinx_enet_info, &s->conf, object_get_typename(OBJECT(dev)), dev->id, s); qemu_format_nic_info_str(qemu_get_queue(s->nic), s->conf.macaddr.a); =20 tdk_init(&s->TEMAC.phy); mdio_attach(&s->TEMAC.mdio_bus, &s->TEMAC.phy, s->c_phyaddr); =20 s->TEMAC.parent =3D s; =20 s->rxmem =3D g_malloc(s->c_rxmem); return; --=20 2.21.1