From nobody Mon Feb 9 08:55:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1585142299; cv=none; d=zohomail.com; s=zohoarc; b=PmG+J49ejKPYtkaU/FhZ17hkHs6ltqDJvb6J+xw0VaiPPp5Jebgn5GRE63GZ1u1TL3Dp8dTFEnixP3b4+IfroVtvYW0ks/0DbfyNNaOqMba+k7uGVpnQ8fJszGmlT2J8hmOR2S/uB4rVTpBVUkJ17Bo6PCtkcaxcw1Blqiz7D2Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585142299; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/rpPcwoRo0YJ8IbJdvb/7Apw8Xalqs+hkaNAvH7+1nA=; b=P/m6vUmYfdipO6SM0v7gLTn4gIRrEPK53BzGaH6lwfmsE+c44FpgrNgQ2m86uoTHBLcFIK91jkIVBDXJa7QsknA81jTVlIGXtqUAMF18XHvTYR1TsJVWv6esNLHV/Q+UO+NyIROqO4OSPAqSX0acNYGPMsr18wK7wfTpVQ4i/ZU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585142299588468.929039936452; Wed, 25 Mar 2020 06:18:19 -0700 (PDT) Received: from localhost ([::1]:36118 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jH5vG-0000Cz-LZ for importer@patchew.org; Wed, 25 Mar 2020 09:18:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53072) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jH5ty-0006tN-NF for qemu-devel@nongnu.org; Wed, 25 Mar 2020 09:16:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jH5tx-0006JX-OI for qemu-devel@nongnu.org; Wed, 25 Mar 2020 09:16:58 -0400 Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:44819) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jH5tx-0006Ip-Ki for qemu-devel@nongnu.org; Wed, 25 Mar 2020 09:16:57 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-148-3Kj2nayxPTSeJO_sZf0nmQ-1; Wed, 25 Mar 2020 09:16:54 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1C1EEA1368; Wed, 25 Mar 2020 13:16:53 +0000 (UTC) Received: from dgilbert-t580.localhost (ovpn-114-213.ams2.redhat.com [10.36.114.213]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9E5B85C298; Wed, 25 Mar 2020 13:16:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585142217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/rpPcwoRo0YJ8IbJdvb/7Apw8Xalqs+hkaNAvH7+1nA=; b=MjU/chstvxgu5023JvDAxsF5WMWazLv4fGeMsVFd8npG5Tz2wzIwPvoCq/2prWegOMnFIc ubNkcRe6esp9kU+f2tTjDMGrCd/5011xzFYqJ7z3l7cfPbFmYzfsIsSNYCDKob1YpSzbtD apZjmbhs/r2obs5m6m4CvBMKGgo9DAU= X-MC-Unique: 3Kj2nayxPTSeJO_sZf0nmQ-1 From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, pannengyuan@huawei.com, maozhongyi@cmss.chinamobile.com, vsementsov@virtuozzo.com, imammedo@redhat.com, philmd@redhat.com Subject: [PULL 7/9] migration/colo: fix use after free of local_err Date: Wed, 25 Mar 2020 13:16:30 +0000 Message-Id: <20200325131632.311034-8-dgilbert@redhat.com> In-Reply-To: <20200325131632.311034-1-dgilbert@redhat.com> References: <20200325131632.311034-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 63.128.21.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Vladimir Sementsov-Ogievskiy local_err is used again in secondary_vm_do_failover() after replication_stop_all(), so we must zero it. Otherwise try to set non-NULL local_err will crash. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20200324153630.11882-5-vsementsov@virtuozzo.com> Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Dr. David Alan Gilbert --- migration/colo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/colo.c b/migration/colo.c index 44942c4e23..a54ac84f41 100644 --- a/migration/colo.c +++ b/migration/colo.c @@ -93,6 +93,7 @@ static void secondary_vm_do_failover(void) replication_stop_all(true, &local_err); if (local_err) { error_report_err(local_err); + local_err =3D NULL; } =20 /* Notify all filters of all NIC to do checkpoint */ --=20 2.25.1