From nobody Fri Apr 19 20:27:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1585128234; cv=none; d=zohomail.com; s=zohoarc; b=NbTGcdTfCFIr+6rBzJINbPZlcH+CppLe8gPRyj7I/eTyty0KZFsIs+EyCuOABlD6dG8apaxa8PDtnAmB9JVDUliPiYW0FhztULel/dHzWLkLijZGvEx+9PMDfNP1Hx286cVSYTUhk+5SCj6zE315bqAglVGlIfgu+dvNOLJDiCc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585128234; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=A60kyp92sNOmqrJmzpgRf2grOiLotwVY6oohqMVxFeU=; b=WRbP98CgZlFPPc2qMKVn4UrgXrXVBQIJjnFfRK87VRa+EjIzAroH2QtDbcTTVAMMG0LnWwUZyDFfapem3xpG/Ct6lwRbdADRHnx+YDEvLPM8n+Tnmo+cnXjI3kwZSySIYjdsBDHHwwP+OxkD1IYRm9QYyXnNDxHKIATOmD0acsI= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585128234099484.6323929148199; Wed, 25 Mar 2020 02:23:54 -0700 (PDT) Received: from localhost ([::1]:60874 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jH2GO-0004lS-QM for importer@patchew.org; Wed, 25 Mar 2020 05:23:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52632) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jH2Eo-0003NB-PV for qemu-devel@nongnu.org; Wed, 25 Mar 2020 05:22:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jH2En-0007uo-Lq for qemu-devel@nongnu.org; Wed, 25 Mar 2020 05:22:14 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:58822 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jH2En-0007nk-9g; Wed, 25 Mar 2020 05:22:13 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id D0EA5383E7485E33693D; Wed, 25 Mar 2020 17:22:05 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Wed, 25 Mar 2020 17:21:59 +0800 From: Chen Qun To: , Subject: [PATCH 1/3] gdbstub: prevent uninitialized warning Date: Wed, 25 Mar 2020 17:21:35 +0800 Message-ID: <20200325092137.24020-2-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200325092137.24020-1-kuhn.chenqun@huawei.com> References: <20200325092137.24020-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= , laurent@vivier.eu, Euler Robot , Chen Qun , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" According to the glib function requirements, we need initialise the variable. Otherwise there will be compilation warnings: qemu/gdbstub.c: In function =E2=80=98handle_query_thread_extra=E2=80=99: /usr/include/glib-2.0/glib/glib-autocleanups.h:28:3: warning: =E2=80=98cpu_name=E2=80=99 may be used uninitialized in this function [-Wm= aybe-uninitialized] g_free (*pp); ^~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Miroslav Rezanina =20 --- Cc: "Alex Benn=C3=A9e" Cc: "Philippe Mathieu-Daud=C3=A9" --- gdbstub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 013fb1ac0f..171e150950 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2060,8 +2060,8 @@ static void handle_query_thread_extra(GdbCmdContext *= gdb_ctx, void *user_ctx) /* Print the CPU model and name in multiprocess mode */ ObjectClass *oc =3D object_get_class(OBJECT(cpu)); const char *cpu_model =3D object_class_get_name(oc); - g_autofree char *cpu_name; - cpu_name =3D object_get_canonical_path_component(OBJECT(cpu)); + g_autofree char *cpu_name =3D + object_get_canonical_path_component(OBJECT(cpu)); g_string_printf(rs, "%s %s [%s]", cpu_model, cpu_name, cpu->halted ? "halted " : "running"); } else { --=20 2.23.0 From nobody Fri Apr 19 20:27:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1585128310; cv=none; d=zohomail.com; s=zohoarc; b=La9Jetqu/nbb4LVSptfB/yl3L75HxPN3AVfvl5gt+DNbCG3e1oBWdqApJxVYzFtP3SgkMuBYYsjKEuNCbPpKKbR6TZaMQqaaA+06x97EY57zn44InkDK2QamkXHCHmO2SqXuwz5Khl09xM+j/jASvVo8XvIAvnqhyDt3FmZdxNg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585128310; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ToP6KR/HFnHsIr2jbrDsVXsqpKU8k65hrxNE+r5VrNU=; b=YzKekwDJsO1ZQ5jLzwUupCsOTmgactJg3VgqGoPsrJHc4SOLVmKlC25AmLixc+uZaVx/QKaAaOxTdjXQrfKF+xhEyIRhdpNzj5+NGaml/1j43FtSo/cRBSUNN2gN3pnixXoUrMWaAdrNOKt7O2OnM2FvfhfvRoYh8zL5TTm6ax0= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585128310776245.71340458519182; Wed, 25 Mar 2020 02:25:10 -0700 (PDT) Received: from localhost ([::1]:60896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jH2Hd-0006yR-GT for importer@patchew.org; Wed, 25 Mar 2020 05:25:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52654) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jH2Ep-0003ND-Bk for qemu-devel@nongnu.org; Wed, 25 Mar 2020 05:22:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jH2Eo-0007vk-Dl for qemu-devel@nongnu.org; Wed, 25 Mar 2020 05:22:15 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:58828 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jH2Eo-0007ni-1c; Wed, 25 Mar 2020 05:22:14 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id C909F889F01F33829259; Wed, 25 Mar 2020 17:22:05 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Wed, 25 Mar 2020 17:21:59 +0800 From: Chen Qun To: , Subject: [PATCH 2/3] virtio-crypto: fix 80-char limit violations in virtio_crypto_device_realize() Date: Wed, 25 Mar 2020 17:21:36 +0800 Message-ID: <20200325092137.24020-3-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200325092137.24020-1-kuhn.chenqun@huawei.com> References: <20200325092137.24020-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chen Qun , Euler Robot , zhang.zhanghailiang@huawei.com, laurent@vivier.eu Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Fix: aa8f057e74ae Reported-by: Euler Robot Signed-off-by: Chen Qun --- hw/virtio/virtio-crypto.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-crypto.c b/hw/virtio/virtio-crypto.c index 4c65114de5..eb4a9e4e85 100644 --- a/hw/virtio/virtio-crypto.c +++ b/hw/virtio/virtio-crypto.c @@ -786,7 +786,8 @@ static void virtio_crypto_device_realize(DeviceState *d= ev, Error **errp) error_setg(errp, "'cryptodev' parameter expects a valid object"); return; } else if (cryptodev_backend_is_used(vcrypto->cryptodev)) { - char *path =3D object_get_canonical_path_component(OBJECT(vcrypto-= >conf.cryptodev)); + char *path =3D object_get_canonical_path_component( + OBJECT(vcrypto->conf.cryptodev)); error_setg(errp, "can't use already used cryptodev backend: %s", p= ath); g_free(path); return; --=20 2.23.0 From nobody Fri Apr 19 20:27:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1585128236; cv=none; d=zohomail.com; s=zohoarc; b=e76/WD1+zoL+Hu4MSMaLhYfgN/mjVNubOhSOwm5EWNTeuEWd0IleWfeutvA+3sCAmo8NqVzkoUqGwkOQvGmoFYe6OqYeoe74EfsBYKwSqZ40K2ZZoY37sRh/6RD7eq1fK/jN+oMWC7rx3JN1LnjJ2L3opkYIOcr6Fm/1DuFR3oo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585128236; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=cRB9h5DPX7NKOvUH1hTB3IxVjkrLLLh3q6QFa+oBaws=; b=Nco95khERfR+C3410H4G0kLRAyOReUvKN2Py+TBvUo4gJ5F12+mB9aN/dafs3TZnv0hG+JNPzPodOPdGNbmSss2MsqHWZSKbNNEyBs0ViXv/xf8pe+V3jibcJxeVzKcmXKPHaEYgKH+o3oZVYR+OyCZhQYc83iMifJTbclghvxo= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585128236812752.00679069181; Wed, 25 Mar 2020 02:23:56 -0700 (PDT) Received: from localhost ([::1]:60876 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jH2GR-0004ml-Hc for importer@patchew.org; Wed, 25 Mar 2020 05:23:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52651) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jH2Ep-0003NC-A4 for qemu-devel@nongnu.org; Wed, 25 Mar 2020 05:22:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jH2Eo-0007ve-Cn for qemu-devel@nongnu.org; Wed, 25 Mar 2020 05:22:15 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:58820 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jH2Eo-0007nh-1R; Wed, 25 Mar 2020 05:22:14 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id CCE4039DC149207BF30C; Wed, 25 Mar 2020 17:22:05 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Wed, 25 Mar 2020 17:22:00 +0800 From: Chen Qun To: , Subject: [PATCH 3/3] crypto: Redundant type conversion for AES_KEY pointer Date: Wed, 25 Mar 2020 17:21:37 +0800 Message-ID: <20200325092137.24020-4-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200325092137.24020-1-kuhn.chenqun@huawei.com> References: <20200325092137.24020-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chen Qun , Euler Robot , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , zhang.zhanghailiang@huawei.com, laurent@vivier.eu Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Fix: eaec903c5b8 Reported-by: Euler Robot Signed-off-by: Chen Qun Acked-by: Daniel P. Berrang=C3=A9 Reviewed-by: Laurent Vivier --- Cc: "Daniel P. Berrang=C3=A9" --- crypto/cipher-builtin.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/crypto/cipher-builtin.c b/crypto/cipher-builtin.c index bf8413e71a..99d6280a16 100644 --- a/crypto/cipher-builtin.c +++ b/crypto/cipher-builtin.c @@ -133,8 +133,7 @@ static void qcrypto_cipher_aes_xts_encrypt(const void *= ctx, { const QCryptoCipherBuiltinAESContext *aesctx =3D ctx; =20 - qcrypto_cipher_aes_ecb_encrypt((AES_KEY *)&aesctx->enc, - src, dst, length); + qcrypto_cipher_aes_ecb_encrypt(&aesctx->enc, src, dst, length); } =20 =20 @@ -145,8 +144,7 @@ static void qcrypto_cipher_aes_xts_decrypt(const void *= ctx, { const QCryptoCipherBuiltinAESContext *aesctx =3D ctx; =20 - qcrypto_cipher_aes_ecb_decrypt((AES_KEY *)&aesctx->dec, - src, dst, length); + qcrypto_cipher_aes_ecb_decrypt(&aesctx->dec, src, dst, length); } =20 =20 --=20 2.23.0