From nobody Thu Apr 18 23:57:50 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1585105267; cv=none; d=zohomail.com; s=zohoarc; b=LnHw83VVRgwRs6VFLBRmevhpDPy9VqvUYrO0Xqhrfjch1VT8S4zXjHSqVJAu8s3JU9nyZTiI29Nc8JIpqIMZakucEpU092jm3hddOi3YQ0JudzYx7v1J3+iO2T38wN8fhhlQ6sHVngr8tUCAaO+zK0e4soR6kVrK8zSkeRrmEtc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585105267; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=YRrr/LMCbmi2kMsuMcszrPKchqMJETsyAOWQrA8K6+8=; b=Sj2en7ihIjdniIGOx+BZI+9OakGXcYDWHdWK2eOc6tMuab6vvqFsUupPV+e/FTtPdlidDp3xAB+FnFeXvkTbW1VM205QAHyqLpUKS0mCykfTeTBFSpCC1+jA14zp7JJxWxeLqly57/pPLYdky7Ho/NnGHCCbffO+EklvCeWj0mA= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585105267245998.7388065288776; Tue, 24 Mar 2020 20:01:07 -0700 (PDT) Received: from localhost ([::1]:58542 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGwHx-0002pG-V0 for importer@patchew.org; Tue, 24 Mar 2020 23:01:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45446) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGwGd-00013w-PJ for qemu-devel@nongnu.org; Tue, 24 Mar 2020 22:59:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGwGc-0004zJ-Km for qemu-devel@nongnu.org; Tue, 24 Mar 2020 22:59:43 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:3213 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jGwGc-0004x2-92; Tue, 24 Mar 2020 22:59:42 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 9D30A52F1980FDBAAC69; Wed, 25 Mar 2020 10:59:37 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.487.0; Wed, 25 Mar 2020 10:59:27 +0800 From: Chen Qun To: , Subject: [PATCH v5 1/3] scsi/esp-pci: add g_assert() for fix clang analyzer warning in esp_pci_io_write() Date: Wed, 25 Mar 2020 10:59:17 +0800 Message-ID: <20200325025919.21316-2-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200325025919.21316-1-kuhn.chenqun@huawei.com> References: <20200325025919.21316-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.190 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, laurent@vivier.eu, Paolo Bonzini , Euler Robot , Chen Qun , philmd@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: hw/scsi/esp-pci.c:198:9: warning: Value stored to 'size' is never read size =3D 4; ^ ~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Laurent Vivier --- Cc: Paolo Bonzini Cc:Fam Zheng v1->v2: keep ' size =3D 4' and add 'g_assert(size >=3D 4)' after if() statement. (Base on Laurent's comments) --- hw/scsi/esp-pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c index d5a1f9e017..497a8d5901 100644 --- a/hw/scsi/esp-pci.c +++ b/hw/scsi/esp-pci.c @@ -197,6 +197,7 @@ static void esp_pci_io_write(void *opaque, hwaddr addr, addr &=3D ~3; size =3D 4; } + g_assert(size >=3D 4); =20 if (addr < 0x40) { /* SCSI core reg */ --=20 2.23.0 From nobody Thu Apr 18 23:57:50 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1585105265; cv=none; d=zohomail.com; s=zohoarc; b=fPtSFwM+elEMnehDeDaqvNxKz/Oy/uDxKXByc9Ejq6yQRKNnShheHCQHGRNu1mG5zDdtzt1kVdHNCSChFFuhPhmmBwOgFf8PcmVQamVZrWVnb/YT5tGrLX6YYhIMNjf3nbdB7VuIu4LSObuzPrGdHWDEN1CElZbUZxPfl1+E0OY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585105265; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=uFRqSnzX88yT2TCsjZCC7RBf9weosXbGE8R/eH71i4w=; b=Axa/x4M+qx9hxTwxz7nd1kmAlkihteeVM7mrW+k51hl5gmDoujc1UQj/iDBibKKVCZlwnyNpUTVgeE18+O3Y6iOIaMvBFDq5pxA1jSz6zusRXhCCpHRS1EudhjS6cMONxzRsLcNsLXO17cGIVGH6Enth1q6CGhTVWuU7d5/72Bg= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585105265650167.07068814259287; Tue, 24 Mar 2020 20:01:05 -0700 (PDT) Received: from localhost ([::1]:58536 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGwHv-0002lK-QS for importer@patchew.org; Tue, 24 Mar 2020 23:01:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45447) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGwGd-00013x-Q3 for qemu-devel@nongnu.org; Tue, 24 Mar 2020 22:59:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGwGc-0004zP-Kk for qemu-devel@nongnu.org; Tue, 24 Mar 2020 22:59:43 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:3212 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jGwGc-0004x1-9F; Tue, 24 Mar 2020 22:59:42 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id A1D3C60B2E7D08106BF8; Wed, 25 Mar 2020 10:59:37 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.487.0; Wed, 25 Mar 2020 10:59:28 +0800 From: Chen Qun To: , Subject: [PATCH v5 2/3] display/blizzard: use extract16() for fix clang analyzer warning in blizzard_draw_line16_32() Date: Wed, 25 Mar 2020 10:59:18 +0800 Message-ID: <20200325025919.21316-3-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200325025919.21316-1-kuhn.chenqun@huawei.com> References: <20200325025919.21316-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.190 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , zhang.zhanghailiang@huawei.com, philmd@redhat.com, laurent@vivier.eu, Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: hw/display/blizzard.c:940:9: warning: Value stored to 'data' is never read data >>=3D 5; ^ ~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Laurent Vivier --- Cc: Andrzej Zaborowski Cc: Peter Maydell v1->v2: Use extract16() function instead of bit operation(Base on Laurent's= comments). --- hw/display/blizzard.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/display/blizzard.c b/hw/display/blizzard.c index 359e399c2a..105241577d 100644 --- a/hw/display/blizzard.c +++ b/hw/display/blizzard.c @@ -19,6 +19,7 @@ */ =20 #include "qemu/osdep.h" +#include "qemu/bitops.h" #include "ui/console.h" #include "hw/display/blizzard.h" #include "ui/pixel_ops.h" @@ -932,12 +933,9 @@ static void blizzard_draw_line16_32(uint32_t *dest, const uint16_t *end =3D (const void *) src + width; while (src < end) { data =3D *src ++; - b =3D (data & 0x1f) << 3; - data >>=3D 5; - g =3D (data & 0x3f) << 2; - data >>=3D 6; - r =3D (data & 0x1f) << 3; - data >>=3D 5; + b =3D extract16(data, 0, 5) << 3; + g =3D extract16(data, 5, 6) << 2; + r =3D extract16(data, 11, 5) << 3; *dest++ =3D rgb_to_pixel32(r, g, b); } } --=20 2.23.0 From nobody Thu Apr 18 23:57:50 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1585105267; cv=none; d=zohomail.com; s=zohoarc; b=VK0U4BXm0LU/9RwlHfbv2iChAGm5YhElc4QoBg4qSAqcMOHs5vSOdG7aofvIGLmxRZ0oUWK4+2fahKjFIoj9FRco67lU/9p2QRSo8Jzfvcp46XiH4EvS0qrcVgtwuNpEZzljcypBB8rw1jc+ge8CvLFZ8nSCzNTc0j//byChS3g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585105267; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=iNVRgYWjHw/cU7xzbTCrx0FhhihGeV2P25OB0oXhFCA=; b=BAOJieieeMt4Htu5uWDQANVKi//gmH3Wz8I6sRUg6imvbSD0nVng/EX4b9mS1nCqnEHrq6NBD2a1g6fEGif2caz24I9zGJbBWU/y99L8m+3A1thA/8aLxuuNI8jCz+iiX13XY3Iz2IrXRQH3EHl7blAlizlP3gVae/lgBt85LSg= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585105267619498.50775947327804; Tue, 24 Mar 2020 20:01:07 -0700 (PDT) Received: from localhost ([::1]:58540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGwHy-0002o2-A8 for importer@patchew.org; Tue, 24 Mar 2020 23:01:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45448) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGwGd-00013y-Ph for qemu-devel@nongnu.org; Tue, 24 Mar 2020 22:59:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGwGc-0004zR-Kk for qemu-devel@nongnu.org; Tue, 24 Mar 2020 22:59:43 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:3725 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jGwGc-0004x0-90; Tue, 24 Mar 2020 22:59:42 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id CD1F3D59120C6882B2BE; Wed, 25 Mar 2020 10:59:37 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.487.0; Wed, 25 Mar 2020 10:59:28 +0800 From: Chen Qun To: , Subject: [PATCH v5 3/3] timer/exynos4210_mct: Remove redundant statement in exynos4210_mct_write() Date: Wed, 25 Mar 2020 10:59:19 +0800 Message-ID: <20200325025919.21316-4-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200325025919.21316-1-kuhn.chenqun@huawei.com> References: <20200325025919.21316-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.191 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , zhang.zhanghailiang@huawei.com, Igor Mitsyanko , laurent@vivier.eu, Euler Robot , Chen Qun , philmd@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: hw/timer/exynos4210_mct.c:1370:9: warning: Value stored to 'index' is never= read index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/timer/exynos4210_mct.c:1399:9: warning: Value stored to 'index' is never= read index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/timer/exynos4210_mct.c:1441:9: warning: Value stored to 'index' is never= read index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Laurent Vivier Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- Cc: Igor Mitsyanko Cc: Peter Maydell --- hw/timer/exynos4210_mct.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hw/timer/exynos4210_mct.c b/hw/timer/exynos4210_mct.c index 944120aea5..570cf7075b 100644 --- a/hw/timer/exynos4210_mct.c +++ b/hw/timer/exynos4210_mct.c @@ -1367,7 +1367,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr= offset, =20 case L0_TCNTB: case L1_TCNTB: lt_i =3D GET_L_TIMER_IDX(offset); - index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); =20 /* * TCNTB is updated to internal register only after CNT expired. @@ -1396,7 +1395,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr= offset, =20 case L0_ICNTB: case L1_ICNTB: lt_i =3D GET_L_TIMER_IDX(offset); - index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); =20 s->l_timer[lt_i].reg.wstat |=3D L_WSTAT_ICNTB_WRITE; s->l_timer[lt_i].reg.cnt[L_REG_CNT_ICNTB] =3D value & @@ -1438,8 +1436,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr= offset, =20 case L0_FRCNTB: case L1_FRCNTB: lt_i =3D GET_L_TIMER_IDX(offset); - index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); - DPRINTF("local timer[%d] FRCNTB write %llx\n", lt_i, value); =20 s->l_timer[lt_i].reg.wstat |=3D L_WSTAT_FRCCNTB_WRITE; --=20 2.23.0