From nobody Thu Apr 25 20:09:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=virtuozzo.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585064278826548.3632565893715; Tue, 24 Mar 2020 08:37:58 -0700 (PDT) Received: from localhost ([::1]:50926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGlcq-0002Ol-UI for importer@patchew.org; Tue, 24 Mar 2020 11:37:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39544) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGlbm-0000aL-V7 for qemu-devel@nongnu.org; Tue, 24 Mar 2020 11:36:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGlbl-0005df-Mt for qemu-devel@nongnu.org; Tue, 24 Mar 2020 11:36:50 -0400 Received: from mail-eopbgr70133.outbound.protection.outlook.com ([40.107.7.133]:6087 helo=EUR04-HE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jGlbl-0005br-FF; Tue, 24 Mar 2020 11:36:49 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (10.141.175.15) by AM7PR08MB5336.eurprd08.prod.outlook.com (10.141.172.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.20; Tue, 24 Mar 2020 15:36:47 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::9057:6f5a:378c:7533]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::9057:6f5a:378c:7533%6]) with mapi id 15.20.2835.021; Tue, 24 Mar 2020 15:36:47 +0000 Received: from kvm.sw.ru (185.215.60.15) by HE1PR0401CA0062.eurprd04.prod.outlook.com (2603:10a6:3:19::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.20 via Frontend Transport; Tue, 24 Mar 2020 15:36:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VfWpc9v03hoa6XscRgPV21VkpsaTgP1EwxHB5kez1544Vt132GYq+IzZAj0+WHYBRjhLvyuIf0lAZsrvMTVxzSqSdyiS1JfqCxsig451u0kldWaiQOjG9d+H5ZXYbMBeJ91oI+/sU5ltOxV9+TY6dYPxiv4j9RvdGXgVAbKg2zZXQYyEHxP7r6Z/3l7G3pDuh6IbnkeZxxOpzd4O4uSMGkilwHCh06tQwbV1YN9akhfqGs2U0fuGL3GkL3pnBvxp58Ag7Fw9IgpWtjnZkkSf9JPL8jcvKjghmFnmMaKj5z16kQcCetW/ql4fuG8o+8Lu++LYetI+nP5j2oFhJ8AgBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uvVI1rv2dAOmET5uFzSQbNMMIFXMCPCpWSFvcQJ9m3I=; b=hSQhLjbXZVUDeK27tbBi0ecd9QBd430S+eWFO/NM0DJyJzXLdNjGIp2EYzciuBlqw21Hg5e5eRFt/MuEYwwfQY4pjVHWX+dR57yQ06AOF25D4mdENYgk/tMVGjBcPEAHz80eEPSM4xkDxt9GLEq5ybARBXU3xDMlhQ3nr+uk/iVKCx3PvghI2QeVy8UwMnNlrZDBZn4UqnaHfQqCiAhMbEDjktQOttcJ/4IXbFQBcrOemLN3RUYSpQeObPe1vxYKjkKAfRAioKhITMOxKqejrgO2zVa+cchO1XYQX+WKfTG+eX4EHcxIzYKXteFxBsgRwO2+kI7j6PI0U56DuALGJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uvVI1rv2dAOmET5uFzSQbNMMIFXMCPCpWSFvcQJ9m3I=; b=tX/IFbQRAwr+nv6pz14+aRnmblW2Cgs9NvITJ9UoWkY9YDbeKwBIaIJPaQ2XXv5KK6PQqvoTlEjQL1iH5zaoQWeGr7XFIUo0z2nnbJ0nua8KqBEECCW/Mh4dRowuu9trtuK4SyiMiycPC5gdokewKqbnvjf4u2crwIeXNSblIZs= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=vsementsov@virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Subject: [PATCH 1/6] scripts/coccinelle: add error-use-after-free.cocci Date: Tue, 24 Mar 2020 18:36:25 +0300 Message-ID: <20200324153630.11882-2-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20200324153630.11882-1-vsementsov@virtuozzo.com> References: <20200324153630.11882-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: HE1PR0401CA0062.eurprd04.prod.outlook.com (2603:10a6:3:19::30) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Mailer: git-send-email 2.21.0 X-Originating-IP: [185.215.60.15] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 84905608-077e-4b1b-b16b-08d7d0092a14 X-MS-TrafficTypeDiagnostic: AM7PR08MB5336: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-Forefront-PRVS: 03524FBD26 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4636009)(346002)(136003)(366004)(376002)(39850400004)(396003)(66946007)(81166006)(66556008)(5660300002)(4326008)(66476007)(2906002)(81156014)(8676002)(16526019)(6666004)(107886003)(26005)(8936002)(186003)(316002)(6512007)(6486002)(52116002)(36756003)(6506007)(1076003)(478600001)(956004)(86362001)(6916009)(2616005)(7416002)(2004002); DIR:OUT; SFP:1102; SCL:1; SRVR:AM7PR08MB5336; H:AM7PR08MB5494.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (protection.outlook.com: virtuozzo.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5KwKB8WffMk9yRqThFpY0PXLvgc20iw669PxuNihAHW6TOWpHookRfXpUGx2lNo5b8CEyUliZy8MI4TjEMGWHob36kGCg/RkCy1zcPk7fDAWyUV1ReYIXPipWrvuv7dSGUGwihBYr9MkXMCYGYn78X2cIrePViwJuS3ealH36Uzl0URqDxs19iiLEPfqLcb0m0TAjiz7fZjmwgISCCaf9jHOIn98sRrsKtv6bGd6YZfvMavgLuwE7xED0TNoxfCe5dDVu4eKN3r9f2yxZkVHzPzWcR/vjwDWdjYEC8/++s50w1hg7+ZgbDeclAHnvE7/jhYhNpUDIvl3wAihXFX6RwIexLkdWIUX80ImOD2/pXzQeOl9MYidhfkqQuIoY9Sh1Y019iueFoaIIl/0YcCACf9cJLQQRIv2z7kMWA6f0Aj1F8ZtZRHP2/j1L6A2HgpA1jliO/ArELimhgnuHlyVvGLThpGF7kBPhGpwSp2OspGyFx6qd4fV2SIpgBuwLo+IXENH69JNUvfV685400oyrMk08d608X2RKL0gu/nBLYD6Igw7tBAhkPNuN6qkkic4 X-MS-Exchange-AntiSpam-MessageData: M0z1/QwuOUdHIMYjWrFHktcDk6LbQzt7q3grBwk5ElFp5zF3HcEfBMf6cx1JQphLRDsLV3DGrgPMMxPIPKIFYCBmvy7ikR8uui081sEA5Q42LMJX8KDu//gSBaCgihBIZORp4sqfASp2NI8SUcg5Fg== X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84905608-077e-4b1b-b16b-08d7d0092a14 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2020 15:36:47.7388 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uU8Xg36GcbHqwnfzQh6F3Ap4X2p1s4jMlfcZ0/nWDRk7zJnmJC892Nj/KU1ZJ+mogyMW1cPF6GIS/0va6TDc9ANOy24bhNUtt+EOptczdrY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5336 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 40.107.7.133 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, zhang.zhanghailiang@huawei.com, qemu-block@nongnu.org, quintela@redhat.com, armbru@redhat.com, dgilbert@redhat.com, mreitz@redhat.com, den@openvz.org, marcandre.lureau@redhat.com, jsnow@redhat.com, mdroth@linux.vnet.ibm.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Computed bodyhash is different from the expected one) Content-Type: text/plain; charset="utf-8" Add script to find and fix trivial use-after-free of Error objects. How to use: spatch --sp-file scripts/coccinelle/auto-propagated-errp.cocci \ --macro-file scripts/cocci-macro-file.h --in-place \ --no-show-diff ( FILES... | --use-gitgrep . ) Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Markus Armbruster Reviewed-by: Richard Henderson --- scripts/coccinelle/error-use-after-free.cocci | 52 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 53 insertions(+) create mode 100644 scripts/coccinelle/error-use-after-free.cocci diff --git a/scripts/coccinelle/error-use-after-free.cocci b/scripts/coccin= elle/error-use-after-free.cocci new file mode 100644 index 0000000000..7cfa42355b --- /dev/null +++ b/scripts/coccinelle/error-use-after-free.cocci @@ -0,0 +1,52 @@ +// Find and fix trivial use-after-free of Error objects +// +// Copyright (c) 2020 Virtuozzo International GmbH. +// +// This program is free software; you can redistribute it and/or +// modify it under the terms of the GNU General Public License as +// published by the Free Software Foundation; either version 2 of the +// License, or (at your option) any later version. +// +// This program is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. +// +// You should have received a copy of the GNU General Public License +// along with this program. If not, see +// . +// +// How to use: +// spatch --sp-file scripts/coccinelle/auto-propagated-errp.cocci \ +// --macro-file scripts/cocci-macro-file.h --in-place \ +// --no-show-diff ( FILES... | --use-gitgrep . ) + +@ exists@ +identifier fn, fn2; +expression err; +@@ + + fn(...) + { + <... +( + error_free(err); ++ err =3D NULL; +| + error_report_err(err); ++ err =3D NULL; +| + error_reportf_err(err, ...); ++ err =3D NULL; +| + warn_report_err(err); ++ err =3D NULL; +| + warn_reportf_err(err, ...); ++ err =3D NULL; +) + ... when !=3D err =3D NULL + when !=3D exit(...) + fn2(..., err, ...) + ...> + } diff --git a/MAINTAINERS b/MAINTAINERS index b5c86ec494..ba97cc43fc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2037,6 +2037,7 @@ F: include/qemu/error-report.h F: qapi/error.json F: util/error.c F: util/qemu-error.c +F: scripts/coccinelle/*err*.cocci =20 GDB stub M: Alex Benn=C3=A9e --=20 2.21.0 From nobody Thu Apr 25 20:09:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=virtuozzo.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585064282083352.8918216978666; Tue, 24 Mar 2020 08:38:02 -0700 (PDT) Received: from localhost ([::1]:50928 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGlcs-0002Os-VF for importer@patchew.org; Tue, 24 Mar 2020 11:37:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39548) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGlbn-0000aN-7X for qemu-devel@nongnu.org; Tue, 24 Mar 2020 11:36:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGlbm-0005eC-8L for qemu-devel@nongnu.org; Tue, 24 Mar 2020 11:36:51 -0400 Received: from mail-eopbgr70133.outbound.protection.outlook.com ([40.107.7.133]:6087 helo=EUR04-HE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jGlbm-0005br-0h; Tue, 24 Mar 2020 11:36:50 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (10.141.175.15) by AM7PR08MB5336.eurprd08.prod.outlook.com (10.141.172.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.20; Tue, 24 Mar 2020 15:36:49 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::9057:6f5a:378c:7533]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::9057:6f5a:378c:7533%6]) with mapi id 15.20.2835.021; Tue, 24 Mar 2020 15:36:49 +0000 Received: from kvm.sw.ru (185.215.60.15) by HE1PR0401CA0062.eurprd04.prod.outlook.com (2603:10a6:3:19::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.20 via Frontend Transport; Tue, 24 Mar 2020 15:36:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DQL6I26j9PYQeJBn07pnY5rzVclfxl0GKtYgZAlv5hDKB2w3aP8/GmqYyqfVgzoCe9QxztYfxDLe00kTyQduPsYSDWO+7Stjjt2a1Iu8I8KgY8L5M8eQ5dr7GmWc71qNLETVSuIH1Z62dhsuuPrHRL7M4gWYJY/vCMEAydu1rUkHoCbQhJ0C0fgsuEwjI3eXoxYxsXi3QhXeRIZxQnonkfsCOSSII1ZRbYJ+3oxkZQie3qQbjXNDd6RYD+lx0OHsmiZRV2xQSKz2+b4wvq/kR3gjOkXiOB4jTWZwWB4UyXBJlXxS79zvvexNnnaUunFRNsv1/+fE8ClHDAMeCaNBgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cYBMXaxkWtGuXY3v1HX6eWulhTKmq4Xs2iCFQb0SZAI=; b=XqW0A69t+bxdy3cSKJHMjF1wajmRaBgG40i3EjP+NwTZ4ldD2Whp7grlp99EntOZmGWZTh16Wx8RVZIpZ5q3fg8P1Y5vJ2uMrteYUihXF5x5w7rOpWcav9G4ofxtfw8cWd0BR4a4NOj9elm+fXyAzT2akDrjjdi6efo3Jliv392eeFLZpKMDcvuVubutCSJ/M2hW64TZVKV5Dw602JIWkQ8YduiOzFWNQ1CkCA/7u1o3d/BvTfc/3RtZpN0wu6lZJ4i3/KtHwCjgWqWRk1zfAAiffaxuO8aiWhujFUAEBosd4E2tDW+Y8I87b9UdvhmwuUqjRCmkdZCU7tYck79z/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cYBMXaxkWtGuXY3v1HX6eWulhTKmq4Xs2iCFQb0SZAI=; b=r0Iri2LaO+DPXmzc7se+Gwwfw4f5vKCR7CGLjeEUY+5x8iqBAYxBWMY25QaJBLMkSkLflGvwkZNEtg1L8+GGqCYzVaSbjDn/waj1qv0uCC/OkzWmQngFsE1HUhFuDVC7VSw44hYmWtAZJqXZBU/qrx59xg6OfLeLVQ/W6hw8dgo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=vsementsov@virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Subject: [PATCH 2/6] block/mirror: fix use after free of local_err Date: Tue, 24 Mar 2020 18:36:26 +0300 Message-ID: <20200324153630.11882-3-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20200324153630.11882-1-vsementsov@virtuozzo.com> References: <20200324153630.11882-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: HE1PR0401CA0062.eurprd04.prod.outlook.com (2603:10a6:3:19::30) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Mailer: git-send-email 2.21.0 X-Originating-IP: [185.215.60.15] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 39839de3-f2a9-4685-5a37-08d7d0092aeb X-MS-TrafficTypeDiagnostic: AM7PR08MB5336: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2276; X-Forefront-PRVS: 03524FBD26 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4636009)(346002)(136003)(366004)(376002)(39850400004)(396003)(66946007)(81166006)(66556008)(5660300002)(4326008)(66476007)(2906002)(81156014)(8676002)(16526019)(6666004)(4744005)(107886003)(26005)(8936002)(186003)(316002)(6512007)(6486002)(52116002)(36756003)(6506007)(1076003)(478600001)(956004)(86362001)(6916009)(2616005)(7416002); DIR:OUT; SFP:1102; SCL:1; SRVR:AM7PR08MB5336; H:AM7PR08MB5494.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (protection.outlook.com: virtuozzo.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bEFh0Go9C/6nWS+sLxJP5kFP+XQRqZCHX1aS9ZRy2HeiZbOWOY4kp/I6fNd7DxQz665qYV7kZJZ0mpAHRbX5PIOA8KuCbslkHkzVrGWb/yl9T4oHsc1RY1PDVYIiqVn+btUhB1g+x5BaRf0qc8IIlQwet69ugs3UY7F9Ci8t6lDxi6nibrzSMx9QaoNCIrdnLMkV4AIXy1K32GBFSmegPcpRHFJP3MA9JwTyoXGS0h3B1uqZHzsjHoG/LSGo0NE3dDjPyXNgjRbc1P0Gz5M2cquMdNS62l8vY3tGGnskPN/xc7RLRWzeHkYQGSNfPZzcKu8UtLhtJqlixktbNPIoLhtd/Ny0nEdmXJvfigZk9R9nmKhCLXB8Pj9akQVa0hJtvIhXWA0BuVZDYZ86ZyO1FDbVQ/BLJyViNycDn/EM5krzIwfniwTBanNFgZhmE5rJ X-MS-Exchange-AntiSpam-MessageData: 9tNFkZWk5kOEwExTyGZJSKoadqLDIOWbYo3Xz9XZ1tAy/zDcVJxNbBjJfK7k56SNFrNMN/HRQ5JsVHx5PIDhpFlPQg5pBkxpf2HLkPv1mKv2c2RUXI6/cVgYAvRm1HDx7Y3/JhWOhq5F4B+qZHwJmQ== X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39839de3-f2a9-4685-5a37-08d7d0092aeb X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2020 15:36:49.1774 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iIkppl9WQPdVUe16gyvIU/cGnW4LMOdw/UeJhzYRayhAFQi+ZRXlZfrJY8cPt3jaX6sFfTTJI+HjC2qPhL/guzv2SQ+hknwCed5uZjahdRA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5336 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 40.107.7.133 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, zhang.zhanghailiang@huawei.com, qemu-block@nongnu.org, quintela@redhat.com, armbru@redhat.com, dgilbert@redhat.com, mreitz@redhat.com, den@openvz.org, marcandre.lureau@redhat.com, jsnow@redhat.com, mdroth@linux.vnet.ibm.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Computed bodyhash is different from the expected one) Content-Type: text/plain; charset="utf-8" local_err is used again in mirror_exit_common() after bdrv_set_backing_hd(), so we must zero it. Otherwise try to set non-NULL local_err will crash. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: John Snow Reviewed-by: Richard Henderson --- block/mirror.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/mirror.c b/block/mirror.c index 447051dbc6..6203e5946e 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -678,6 +678,7 @@ static int mirror_exit_common(Job *job) bdrv_set_backing_hd(target_bs, backing, &local_err); if (local_err) { error_report_err(local_err); + local_err =3D NULL; ret =3D -EPERM; } } --=20 2.21.0 From nobody Thu Apr 25 20:09:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=virtuozzo.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585064370392452.88182719441636; Tue, 24 Mar 2020 08:39:30 -0700 (PDT) Received: from localhost ([::1]:50966 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGleL-0006ML-1X for importer@patchew.org; Tue, 24 Mar 2020 11:39:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39597) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGlbp-0000al-VY for qemu-devel@nongnu.org; Tue, 24 Mar 2020 11:36:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGlbo-0005hO-V2 for qemu-devel@nongnu.org; Tue, 24 Mar 2020 11:36:53 -0400 Received: from mail-eopbgr70132.outbound.protection.outlook.com ([40.107.7.132]:20336 helo=EUR04-HE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jGlbo-0005fj-NH; Tue, 24 Mar 2020 11:36:52 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (10.141.175.15) by AM7PR08MB5336.eurprd08.prod.outlook.com (10.141.172.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.20; Tue, 24 Mar 2020 15:36:50 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::9057:6f5a:378c:7533]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::9057:6f5a:378c:7533%6]) with mapi id 15.20.2835.021; Tue, 24 Mar 2020 15:36:50 +0000 Received: from kvm.sw.ru (185.215.60.15) by HE1PR0401CA0062.eurprd04.prod.outlook.com (2603:10a6:3:19::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.20 via Frontend Transport; Tue, 24 Mar 2020 15:36:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SSeEyjfOgejIpQOiQPregCNT6mxJXeM5yjmjJghP8dl/OcpakGc4yzr6KKrWkWZAw19NXdg28TCnzF0bGfAmcwxzehYA6o06g1JITkXgOrQpmUDnlrqdYiBMUGG776lw2qIn63+d9BmEb7ZD/kjBJzfHNFUu0KEhLYPK65S7i2sKho38bqNE5DRaLbKnasEbjX+IN7/ySPTgX7wMKWhHk9LAkfMMQsoz/gvuBEo0nCddfVk/kfnAfuknd+7nGYwwotSbsHIVrimAeOPg/8RWN4dbvWvAq55Qe6p9zseKspekymBCZmUPBn18ZbUhXkQsEX5BQ4SBGa6Qez0Ut0IHIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SSNK1zzcI2VQA2U36YyqYry2DuMuGlpopiutGskWWrY=; b=Fhz1LLG3Phy0967Beieu/cIBvNq6FjZQm0MC5k91pvs3yhgqW0eDF/U3UlwZHGSb5+Dvu4OCXOYXkwRKs1flkG9VwfGyDm5YFN3FCczappChccj7P3kczJUodn5WnXoMzRHjpz8P4KZOJsR6IPZC5ygRHMT9To+8FRjAlEQFMWhZeVEAiyneMhfPKW4+qprSJVZfIz/CPwF1fuJvg/7zQKxAnAOAL0pexiYfg1RESflod1FltcXuLTP9sgdRh+RBhY5kVrNDCuFFC+WHUrPeW3XjLh/tBGJYsDCRCSxQVt6rPzFy1+eJkLFpp7ciGecHxxQ1SFQN49bdiKeM/tbedA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SSNK1zzcI2VQA2U36YyqYry2DuMuGlpopiutGskWWrY=; b=IQelt1ZX+d6zG64F9eSDREr94mLcqq/hI9uUmm/fmGmPFUB1RigQp/idvWldXD14F3x7zc8xP7PwIlV/1xmGJgit70+o1cgauOVP20Dz7gb6C1ET7OMATMfnYw/kypZxl45Lv3lIvAKCL6n6HuRcdy2mwOhRICKV78CvFQ2XthE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=vsementsov@virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Subject: [PATCH 3/6] dump/win_dump: fix use after free of err Date: Tue, 24 Mar 2020 18:36:27 +0300 Message-ID: <20200324153630.11882-4-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20200324153630.11882-1-vsementsov@virtuozzo.com> References: <20200324153630.11882-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: HE1PR0401CA0062.eurprd04.prod.outlook.com (2603:10a6:3:19::30) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Mailer: git-send-email 2.21.0 X-Originating-IP: [185.215.60.15] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6813d97e-3600-45b5-4ddc-08d7d0092bc9 X-MS-TrafficTypeDiagnostic: AM7PR08MB5336: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2733; X-Forefront-PRVS: 03524FBD26 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4636009)(346002)(136003)(366004)(376002)(39850400004)(396003)(66946007)(81166006)(66556008)(5660300002)(4326008)(66476007)(2906002)(81156014)(8676002)(16526019)(6666004)(4744005)(107886003)(26005)(8936002)(186003)(316002)(6512007)(6486002)(52116002)(36756003)(6506007)(1076003)(478600001)(956004)(86362001)(6916009)(2616005)(7416002); DIR:OUT; SFP:1102; SCL:1; SRVR:AM7PR08MB5336; H:AM7PR08MB5494.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (protection.outlook.com: virtuozzo.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zRqdxtmOQOHWrbq+UsYbXKDl128xShdi3LQDh+NH5MAQGLTKVKRM5gUwGEyDwXSU8H99cJnVq8o17bAFrMDw8/XghOgR1sr+hbeMJTD92d3xfmLjj6n/hDEeG2bNPOJyx3cjJPArYguloQZ3n08u09TZI6VlC2qgnL04zz+zpl1CDsen/gZ0ZsMqsYzyAnbCosAHMHeX4MOUOId3t/YQvRQc4TaHkke9yrVc2E5QtPwlXS0vbUtonNLHWe57EJ9xGQQ6prviDLVHHFWTFSVNqxldsZwcKTD8qLLXfF/JlcyKp1yqhKhsLho2OTpm5qfOsvlVAmxu4ZOZRiFu3ck45QImddTqtZEFqagm5TiihqL02USDE97LqqYlBs17jll1y35lA4de55lEEPA9TnvzkseMO+Knp1F5O6dsJdCqqocR48QPK1dwxNm7nPco4pB5 X-MS-Exchange-AntiSpam-MessageData: KFpwuVJkhpcGNvGWTdolQaAeVDiCngBNdezh1WUu1++igtdFlh6SWyBVKzBJch6SBTpr4lgNXk5Oce+Q/jrF9wyhnnU1/4BXBhfcnCz0+9ajBbdQv5vK9SU+4PDu8FFUY2F79wyUuFkl7P3r1EW4Hg== X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6813d97e-3600-45b5-4ddc-08d7d0092bc9 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2020 15:36:50.5912 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tTtOlsA3XuTUZVpKJ35ILkfMnA+yj4/akgQCfDLMfdS3aPa6vJ5o6voSEi2EEGN5Yz4rK64VoQN8NcyrhGRz6cH4CrCTwQFtn+L7712z6IA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5336 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 40.107.7.132 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, zhang.zhanghailiang@huawei.com, qemu-block@nongnu.org, quintela@redhat.com, armbru@redhat.com, dgilbert@redhat.com, mreitz@redhat.com, den@openvz.org, marcandre.lureau@redhat.com, jsnow@redhat.com, mdroth@linux.vnet.ibm.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Computed bodyhash is different from the expected one) Content-Type: text/plain; charset="utf-8" It's possible that we'll try to set err twice (or more). It's bad, it will crash. Instead, use warn_report(). Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Markus Armbruster Reviewed-by: Richard Henderson --- dump/win_dump.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/dump/win_dump.c b/dump/win_dump.c index eda2a48974..652c7bad99 100644 --- a/dump/win_dump.c +++ b/dump/win_dump.c @@ -304,13 +304,11 @@ static void restore_context(WinDumpHeader64 *h, struct saved_context *saved_ctx) { int i; - Error *err =3D NULL; =20 for (i =3D 0; i < h->NumberProcessors; i++) { if (cpu_memory_rw_debug(first_cpu, saved_ctx[i].addr, (uint8_t *)&saved_ctx[i].ctx, sizeof(WinContext), 1)) { - error_setg(&err, "win-dump: failed to restore CPU #%d context"= , i); - warn_report_err(err); + warn_report("win-dump: failed to restore CPU #%d context", i); } } } --=20 2.21.0 From nobody Thu Apr 25 20:09:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=virtuozzo.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585064451242814.8704958191421; Tue, 24 Mar 2020 08:40:51 -0700 (PDT) Received: from localhost ([::1]:50992 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGlfe-0008BL-1m for importer@patchew.org; Tue, 24 Mar 2020 11:40:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39606) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGlbq-0000bW-Fp for qemu-devel@nongnu.org; Tue, 24 Mar 2020 11:36:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGlbp-0005ht-GT for qemu-devel@nongnu.org; Tue, 24 Mar 2020 11:36:54 -0400 Received: from mail-eopbgr70132.outbound.protection.outlook.com ([40.107.7.132]:20336 helo=EUR04-HE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jGlbp-0005fj-8y; Tue, 24 Mar 2020 11:36:53 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (10.141.175.15) by AM7PR08MB5336.eurprd08.prod.outlook.com (10.141.172.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.20; Tue, 24 Mar 2020 15:36:52 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::9057:6f5a:378c:7533]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::9057:6f5a:378c:7533%6]) with mapi id 15.20.2835.021; Tue, 24 Mar 2020 15:36:52 +0000 Received: from kvm.sw.ru (185.215.60.15) by HE1PR0401CA0062.eurprd04.prod.outlook.com (2603:10a6:3:19::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.20 via Frontend Transport; Tue, 24 Mar 2020 15:36:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AlwvjhpSs7bvGbHVUpc/V5OY4+FOCh/H3eU/1KmXuswciLED80QLty/JJxklysbSTrGZsMFNBw5r6qGvtm8RebYAEj0+wai7nXH7HkbAL6Vg1S7Ab4zeld+PlKY5RsDhPJUJhqPEeHC/kzoYHzVHB7uFJI5wpzxVbUbdceRsOEfSjBUzQyfIHk8u1TFsQ8orO6GcCwLWFBKStZ6TAO+WGv5P4vpFGcuSPUwc12EXlACnM73hrqtz6gWIdpHhtFvWr0bTXsbC+3o78Mbfxm4LFgce0/ozQEKlbL1IVFlS7qKqJpMS7YRH9+p9FQDac2offQTNeQtS4YCm8YiQCzPJXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0SlD7INHF2fuHGL8EHihFCP40LyPoL2LWIw1mPvnZH8=; b=G166tZNyo59PJImbcNdVsImwUQ8Xq7dkcmMq5nq+B7s+uTZzsqyfn02iJEEAGUGf4PHmcBlC3bHyeFYFtyAD7dPZFELoGIX2m6rom4l+QS1qxDjL2+Zp1yE7SGqE0oK6DP+fzdnTY4TOcw3She76VNABOdQSiVVXsPcy37IB7p0gy3MBQukMIVLbgI666YJtPBNXEYFj88taxdiWBaknWa05eRs5dmTCpNqceZcKlbPq4D3aVvDhvPcKOF6BH6Tv1dd68+FD5gj9YamsUac7CFp205+tJmIefkVVyuFXSfcBiUWB+OfKDFPqOPIM4wSiRdWivJnablYOwiML+hndNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0SlD7INHF2fuHGL8EHihFCP40LyPoL2LWIw1mPvnZH8=; b=Kmv9aW5foC/h8USrzcmykfcaUicvPRCvY0HZuI20ZQE2/o9wdcXKtZWlJHtYFdaH74dFgVu9uJHWBjpCGDV0UmE+2VPCgG5fv9Ggy6YEcbjLPxy8bNGNE/Ug0vEZ7oMM/GrjU7rDvNnhL4vYTln0+t1a86uh5ABQzqlnl5gU8Gk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=vsementsov@virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Subject: [PATCH 4/6] migration/colo: fix use after free of local_err Date: Tue, 24 Mar 2020 18:36:28 +0300 Message-ID: <20200324153630.11882-5-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20200324153630.11882-1-vsementsov@virtuozzo.com> References: <20200324153630.11882-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: HE1PR0401CA0062.eurprd04.prod.outlook.com (2603:10a6:3:19::30) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Mailer: git-send-email 2.21.0 X-Originating-IP: [185.215.60.15] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c8eb99ad-7b27-4d2b-dca2-08d7d0092c9b X-MS-TrafficTypeDiagnostic: AM7PR08MB5336: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2887; X-Forefront-PRVS: 03524FBD26 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4636009)(346002)(136003)(366004)(376002)(39850400004)(396003)(66946007)(81166006)(66556008)(5660300002)(4326008)(66476007)(2906002)(81156014)(8676002)(16526019)(6666004)(4744005)(107886003)(26005)(8936002)(186003)(316002)(6512007)(6486002)(52116002)(36756003)(6506007)(1076003)(478600001)(956004)(86362001)(6916009)(2616005)(7416002); DIR:OUT; SFP:1102; SCL:1; SRVR:AM7PR08MB5336; H:AM7PR08MB5494.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (protection.outlook.com: virtuozzo.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hjt+QYJ4UwAEK/A/2dLyRY+ohKfA0mt4c5BkSF+jnB6sxMarSZ4dND5wVT0KXM2ms/CK6+e74Z4tFn0MC3vtnheZtS3972A9crRy7bjq+P1m6QVFIGbnukDu32ZUZkeCxqYpooGjZn6IWV3Z28yuUK0/csgLPae8Mu1RWF/xV8y3KjNeqXCbNtS8wcx83KGpD+cCbRD/6a4P6C/jwA/2SwBa6Hru1urzd8Qw5pE9KgaoTRjrIX2JFxCrXQZpmRnF1pd0PA1gL/EJB1bB0qmwUAVKWQZ7FhkKAOrtq2kMlHQw/rGMXGaicEHChBM0e5a3oCcUTPf4TQXgIQvMdyMZLW6fuilLDH5kWhznMb/1ROYOO7apwqPrY1NFhGFllJU8HC0ipLddCcTxUGcYXJSZqkiK8BhlJ3/EtzNRbkt57ltiQB3iwoufiHeAPbd0Htun X-MS-Exchange-AntiSpam-MessageData: ub9PlDHY0UkzBL8IODtRG0406M4elNTof15X39qUbHJtt28WhQgSjXmYgJ1GLI3tBTiLIDctiUIzfHcIUPnWUgWcmAjfmmtkQU+S9HYn5q58i3en+wYcJ3MAy0NM1QvMp2o4w4ct4JX3Jkz3U8ULKw== X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: c8eb99ad-7b27-4d2b-dca2-08d7d0092c9b X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2020 15:36:51.9821 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XfrdLEUkI038cWm+sR01ow03c9D4KB+DoU5qZ3ETpiyjVbZNhWHvRq6SX1w9X/f+Bb3glGWmArfosfXeMYgldecU0n1zBopOJBARAnb6WUk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5336 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 40.107.7.132 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, zhang.zhanghailiang@huawei.com, qemu-block@nongnu.org, quintela@redhat.com, armbru@redhat.com, dgilbert@redhat.com, mreitz@redhat.com, den@openvz.org, marcandre.lureau@redhat.com, jsnow@redhat.com, mdroth@linux.vnet.ibm.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Computed bodyhash is different from the expected one) Content-Type: text/plain; charset="utf-8" local_err is used again in secondary_vm_do_failover() after replication_stop_all(), so we must zero it. Otherwise try to set non-NULL local_err will crash. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Richard Henderson --- migration/colo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/colo.c b/migration/colo.c index 44942c4e23..a54ac84f41 100644 --- a/migration/colo.c +++ b/migration/colo.c @@ -93,6 +93,7 @@ static void secondary_vm_do_failover(void) replication_stop_all(true, &local_err); if (local_err) { error_report_err(local_err); + local_err =3D NULL; } =20 /* Notify all filters of all NIC to do checkpoint */ --=20 2.21.0 From nobody Thu Apr 25 20:09:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=virtuozzo.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585064287079981.8176811801513; Tue, 24 Mar 2020 08:38:07 -0700 (PDT) Received: from localhost ([::1]:50932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGlcz-0002eI-Ir for importer@patchew.org; Tue, 24 Mar 2020 11:38:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39642) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGlbs-0000gj-Ok for qemu-devel@nongnu.org; Tue, 24 Mar 2020 11:36:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGlbr-0005ju-N8 for qemu-devel@nongnu.org; Tue, 24 Mar 2020 11:36:56 -0400 Received: from mail-eopbgr70127.outbound.protection.outlook.com ([40.107.7.127]:12801 helo=EUR04-HE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jGlbr-0005iH-EF; Tue, 24 Mar 2020 11:36:55 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (10.141.175.15) by AM7PR08MB5336.eurprd08.prod.outlook.com (10.141.172.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.20; Tue, 24 Mar 2020 15:36:53 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::9057:6f5a:378c:7533]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::9057:6f5a:378c:7533%6]) with mapi id 15.20.2835.021; Tue, 24 Mar 2020 15:36:53 +0000 Received: from kvm.sw.ru (185.215.60.15) by HE1PR0401CA0062.eurprd04.prod.outlook.com (2603:10a6:3:19::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.20 via Frontend Transport; Tue, 24 Mar 2020 15:36:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LSrOqIv1oGbOPcFrvs4XvVPodGl6NElHkPe+Nwo/GMqE9mdnToY3lnLWlvnEnykjSzP/adl+PhvMF3aGRkgnWfdYEbE+IpNma9Drc1BBfe3F/oy8GTVHif0h1HdyoWvmYVu33o8845KFt5Sc6LpmNFjp8LxfKBwD802I6vzIfOO7xKskumMIx6YVPNI+nvirM/HJs0uG7SwutK3eQQ/IHcgyJ7/iIkwPGWoZuQpoR89doC84J9EPIfsbP/6waJnvoUfCeUqYlNxITTbqt6FcWt0RMzDljFqQ6yz0gsKLwFgxstBSriYSwHvTXx4S1Gjn5U5OjphHFpgN8ZRv4jprOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VQ9ykL5Eu6wTJhnMicriYMBQcLEOE7O58yzOYjdgtcg=; b=hzWraIgEQPib/49zXLMe6JmJJ1koXpkeeNEI7XW12UFmPM7BkjedEuUvTEq7SBZo4ApHXwL8TUKvCoS/TxhdngGt3oSP0VhtJMvL8cONFWS2xUWAPCvOVo2Kt90w7bvVr3WLBUOmDU/73vlCEZNgMaO2CG7cD69iIZ8fgj2DcDBPLP2Rqwb4qz7NtkG98xar7lmrbR+S/YttAmm1GEyvJpC95GquJS6CdJ29y5WP2Lh4gL/E9c4K58sdN+NTWgea49UQXCF/lpSgmxQIZJPF5jwN0RdbzMNGBEXdBew0d+y0jKr8ilqH90+25t1G2O3rp6xTol6iQMmA/4JdR2iFhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VQ9ykL5Eu6wTJhnMicriYMBQcLEOE7O58yzOYjdgtcg=; b=SUYIsadopzIjvszyULbjlolp7fXqEJyhekPzV02GWQnHSR/OA+7gk0jnqCigO9CDWGQdYCfIGSXzJ5rFkdyXgiEHVSV3BnGifi4aTsITwK1IbdpcV4n9OHxyYEzUTgVpseM9y+q9V0O0aPXHCYxst4gsp0eaozu6sF3XzoEOT4c= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=vsementsov@virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Subject: [PATCH 5/6] migration/ram: fix use after free of local_err Date: Tue, 24 Mar 2020 18:36:29 +0300 Message-ID: <20200324153630.11882-6-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20200324153630.11882-1-vsementsov@virtuozzo.com> References: <20200324153630.11882-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: HE1PR0401CA0062.eurprd04.prod.outlook.com (2603:10a6:3:19::30) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Mailer: git-send-email 2.21.0 X-Originating-IP: [185.215.60.15] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7339a7e0-51f2-488f-e38a-08d7d0092d73 X-MS-TrafficTypeDiagnostic: AM7PR08MB5336: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3044; X-Forefront-PRVS: 03524FBD26 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4636009)(346002)(136003)(366004)(376002)(39850400004)(396003)(66946007)(81166006)(66556008)(5660300002)(4326008)(66476007)(2906002)(81156014)(8676002)(16526019)(6666004)(4744005)(107886003)(26005)(8936002)(186003)(316002)(6512007)(6486002)(52116002)(36756003)(6506007)(1076003)(478600001)(956004)(86362001)(6916009)(2616005)(7416002); DIR:OUT; SFP:1102; SCL:1; SRVR:AM7PR08MB5336; H:AM7PR08MB5494.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (protection.outlook.com: virtuozzo.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P1mweofcacsc9D7xAbokXlu1rA6cRzzPT+oOHgtklNquPfMKTUG9lIa4CI37Wyq90sCkfPQaj00eLZmyHMT2rxjOUWnh+WREHivFpXuNCW86b4oukD8mpz2QrQywsYp/Dni1G28o2RQz47akHlHJ2F2f61HnZUZIW4yKStZ9bfv1TX9zrQmC9sHzBkeVq8CJwrTwchYjk0DKWtvr9XxxHiGUVr3FO308Y2FG6soHxbPntVa5ROrlmrvxZ3m08ZjhTDxc+HIYWXV0ypAdu5XkNTTFVGPOjfsn2ozMiZwyTo9heNeDe7gB7GdkME3SWQ6p2J8JrBQI3Uxf8eZXuytFZ+Tb/019p3aFEMfaTLL/duwOn8wA1iODRemKLoOzju0AlpSeDurtUvFeYhOtrmx4sr35t+iBxQdrUPwSHnH5P/eS6qzMd1FFZmr3zVbGjO+C X-MS-Exchange-AntiSpam-MessageData: AefSAE1gSJrMC7KREGGRmXwhITCTfCbS1dZhRmgjXHWxShsZ98LgbvyJSRGzFeVHnq6ErYjUv0y6RWEIkXgevi2SfT5aTBUZo1B4jq+NaHnBuSnojvdPN7fXilgvLvmeqXBNvQ/nRi7Upe7u2vwlUg== X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7339a7e0-51f2-488f-e38a-08d7d0092d73 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2020 15:36:53.4128 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nctyixmrp8tDQ34MoPMq6Dz+KI5kPueYNOeBhgalBm9W1+Lex2DjDTT4oaDjiTL8Tzdd5UdppdVX3nZZGKwRZZST1Bhs5arQ3gvkP6wyXRI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5336 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 40.107.7.127 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, zhang.zhanghailiang@huawei.com, qemu-block@nongnu.org, quintela@redhat.com, armbru@redhat.com, dgilbert@redhat.com, mreitz@redhat.com, den@openvz.org, marcandre.lureau@redhat.com, jsnow@redhat.com, mdroth@linux.vnet.ibm.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Computed bodyhash is different from the expected one) Content-Type: text/plain; charset="utf-8" local_err is used again in migration_bitmap_sync_precopy() after precopy_notify(), so we must zero it. Otherwise try to set non-NULL local_err will crash. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Richard Henderson --- migration/ram.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/ram.c b/migration/ram.c index c12cfdbe26..04f13feb2e 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -980,6 +980,7 @@ static void migration_bitmap_sync_precopy(RAMState *rs) */ if (precopy_notify(PRECOPY_NOTIFY_BEFORE_BITMAP_SYNC, &local_err)) { error_report_err(local_err); + local_err =3D NULL; } =20 migration_bitmap_sync(rs); --=20 2.21.0 From nobody Thu Apr 25 20:09:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=virtuozzo.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585064370968860.1144910597354; Tue, 24 Mar 2020 08:39:30 -0700 (PDT) Received: from localhost ([::1]:50968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGleL-0006NH-Ix for importer@patchew.org; Tue, 24 Mar 2020 11:39:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39653) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGlbt-0000iJ-DD for qemu-devel@nongnu.org; Tue, 24 Mar 2020 11:36:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGlbs-0005kV-9b for qemu-devel@nongnu.org; Tue, 24 Mar 2020 11:36:57 -0400 Received: from mail-eopbgr70127.outbound.protection.outlook.com ([40.107.7.127]:12801 helo=EUR04-HE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jGlbs-0005iH-1N; Tue, 24 Mar 2020 11:36:56 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (10.141.175.15) by AM7PR08MB5336.eurprd08.prod.outlook.com (10.141.172.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.20; Tue, 24 Mar 2020 15:36:54 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::9057:6f5a:378c:7533]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::9057:6f5a:378c:7533%6]) with mapi id 15.20.2835.021; Tue, 24 Mar 2020 15:36:54 +0000 Received: from kvm.sw.ru (185.215.60.15) by HE1PR0401CA0062.eurprd04.prod.outlook.com (2603:10a6:3:19::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.20 via Frontend Transport; Tue, 24 Mar 2020 15:36:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IRB4VdmEGTfK/BfLIap+H8n9e8lnkg3TcvusOHLF91WigOIRQdb/X42oEXYVuwxzTFmVgC2Aiab/s+FHe5Q0AyvlU4285JaRnmdoRMd9d/3RHzgetuk7PIZaJYDQkSZ/Z5xKCcVx/zeivkVRYNDLD7qeadcE6MFGhjI0NXLThbJ/eRo8gMGKagZlkvDC4HPneE3TOVgAdR7xyw0zmLCuY05gBrQ02jp4mLg0BEzE/mm8yKMK+Wc29kkk6DjXzfx0b3EtX3GzqOPm0rt/nLHc8FrCV4R7WHdJkIEz089g+lh3Mca7ZDVEgIy/cmOCLNbhnRcmnh4HrXR+6DotGOFTuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IC8lq9+Zh1HMxH0rGLH6/fnwLrDvmfThUJgMeq3kQCE=; b=UzpFPuwRh0Mb9BmORfv61edYYYkS9j3fnR4FSiXC7Clwx5u0ClC6VqDILpkSLlhteHKoX6qkpiecu11NUQQaqV9hMjSympjpi714DKFa82tPanTXrIFO38jXE4j1OWbPgLO6Yzp8xtL2h7hR82y5M8nxoiYuhaY+MsJu+HlB3owmVA52HgMZ4M/MfSHBf6IDHJIVth0JbX+qJr+35aVE364nXUhXow/kwqgq+r3gLqKty8SqST6UE1wnTqyy5iT37foNFBcBtOHk1EO7/De8+0o/aoVIa3A9MBjTo5oGrgThMOieX4NfcDhCYmvQ6dE6JIA4ZsjT1BepHKjnklL3Vw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IC8lq9+Zh1HMxH0rGLH6/fnwLrDvmfThUJgMeq3kQCE=; b=pBVPGYzwZAN1PG/X45AGVjBzWDRv/44LKI+mhQ0IB83R6m3oJj8TFI6rplBHE9z/Mo1V+I+2tHGn7KLjS1S6d4SW2PWmSKbklMhUDVUaa3tuejFejS7Pe2dJ3oesW/OW7AZU6798GSU8WoYEiElPuMESfEBtDpJt+g10pSwp7M0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=vsementsov@virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Subject: [PATCH 6/6] qga/commands-posix: fix use after free of local_err Date: Tue, 24 Mar 2020 18:36:30 +0300 Message-ID: <20200324153630.11882-7-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20200324153630.11882-1-vsementsov@virtuozzo.com> References: <20200324153630.11882-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: HE1PR0401CA0062.eurprd04.prod.outlook.com (2603:10a6:3:19::30) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Mailer: git-send-email 2.21.0 X-Originating-IP: [185.215.60.15] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cc7acb14-ef0d-4a2b-d3c8-08d7d0092e4c X-MS-TrafficTypeDiagnostic: AM7PR08MB5336: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4941; X-Forefront-PRVS: 03524FBD26 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4636009)(346002)(136003)(366004)(376002)(39850400004)(396003)(66946007)(81166006)(66556008)(5660300002)(4326008)(66476007)(2906002)(81156014)(8676002)(16526019)(6666004)(107886003)(26005)(8936002)(186003)(316002)(6512007)(6486002)(52116002)(36756003)(6506007)(1076003)(478600001)(956004)(86362001)(6916009)(2616005)(7416002); DIR:OUT; SFP:1102; SCL:1; SRVR:AM7PR08MB5336; H:AM7PR08MB5494.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (protection.outlook.com: virtuozzo.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TzNDLaf+HH/XQjurnk+jQ6qBqzIZgSxcPGk6kasakbI4X2a20cZSaGmELLV8QJMlOcy/E1qsspC8EnnKOlC5eNFsdL1+DnPLNprB/P5v1mxreiSL9mKzCUJhW6Er8qIbOYMEHd1osB8HXX1Tlav1b7xf4lGydngRZkp/XKvalO+gJrbHghU9SJK8fTy+lfgn73OWFQOSEiWcaXSLnuLZmSlcfmL1QGvKuNSz/KlrjahERyQ3EYOnTy4jDgZ7IyEoa+n5d6QGWFCYdDN9XdahhB8Fq+BEdy3ex6QlaOIcbVgc2NJWMzvcubssz/ibTPqBDKrlFhGra6hvnDZWTtI3yKMb4ozA2IaZWAk5yCXBx+ek12aVwItwaA76hlQ43JxwG466SvPqh+gh126WgTfQhwX0NvF5HY4yVx+warqE/0LSclV6322/pN2I25q+6Brg X-MS-Exchange-AntiSpam-MessageData: bpkTu95P2ruhXb1d4THnE8u10/Te9ROwGP2vgpye5/bSrH11KPTaIPmRAixN8MUcOvaU3w7S2MZDtv0AjvmXUU95Q85fwplJWx0TPnCkYcCabCNncPR17iwlENsupNL2pZncmQY/T3ds0c/A/OPmuQ== X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc7acb14-ef0d-4a2b-d3c8-08d7d0092e4c X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2020 15:36:54.8335 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tPku4VizcRNx5F8/HBl415g5XNfVsoY9GWQcM/fXSGdjW590gMEmYgbZXpzmG9k8vvrIWDW/Cst8B8v+BIPFl7JnmemEpGRnOodBhfhrb/I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5336 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 40.107.7.127 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, zhang.zhanghailiang@huawei.com, qemu-block@nongnu.org, quintela@redhat.com, armbru@redhat.com, dgilbert@redhat.com, mreitz@redhat.com, den@openvz.org, marcandre.lureau@redhat.com, jsnow@redhat.com, mdroth@linux.vnet.ibm.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Computed bodyhash is different from the expected one) Content-Type: text/plain; charset="utf-8" local_err is used several times in guest_suspend(). Setting non-NULL local_err will crash, so let's zero it after freeing. Also fix possible leak of local_err in final if(). Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Richard Henderson --- qga/commands-posix.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 93474ff770..cc69b82704 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -1773,6 +1773,7 @@ static void guest_suspend(SuspendMode mode, Error **e= rrp) } =20 error_free(local_err); + local_err =3D NULL; =20 if (pmutils_supports_mode(mode, &local_err)) { mode_supported =3D true; @@ -1784,6 +1785,7 @@ static void guest_suspend(SuspendMode mode, Error **e= rrp) } =20 error_free(local_err); + local_err =3D NULL; =20 if (linux_sys_state_supports_mode(mode, &local_err)) { mode_supported =3D true; @@ -1791,6 +1793,7 @@ static void guest_suspend(SuspendMode mode, Error **e= rrp) } =20 if (!mode_supported) { + error_free(local_err); error_setg(errp, "the requested suspend mode is not supported by the gue= st"); } else { --=20 2.21.0