From nobody Mon Feb 9 14:37:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1585052555; cv=none; d=zohomail.com; s=zohoarc; b=bBvn/yA++WAnlBmmpqp3yX0fy8NiNhDdOSAjId8FwQe0xTZPMnY7SB/CQsyc9o6CpcOLaflNkOF/Uk2CuB7OayB2s3jsUsSCodx4YLv4nnK+ev3YnPI22Yw15SElrRE0IxajhFFfOvTviqqU9d0mYKnenn7oo3hCT3pH0oxjWKY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585052555; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=sdgB1cGP4lrDOWYdtizKh5IPnMWCdKyq0DPNZtkoOt0=; b=inhUylfduqfU4G7JIIY6vwpJSNj4h4Nl805pMhArKfCd+edOemBUWEB5TmG4NNYm72zf0ETF37vb6shYpPjyGM88saewWFUMoVAkTplEO6KXwS5/pv/taNuhmu8n4Kh197OdoANsBkNjKk0BiT2uYNeTYgGqftTZ9mR7qG6+rGc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585052555045493.2922611098122; Tue, 24 Mar 2020 05:22:35 -0700 (PDT) Received: from localhost ([::1]:47896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGiZl-0005kO-QZ for importer@patchew.org; Tue, 24 Mar 2020 08:22:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41255) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGiYQ-0004Ji-KE for qemu-devel@nongnu.org; Tue, 24 Mar 2020 08:21:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGiYO-0007xZ-GC for qemu-devel@nongnu.org; Tue, 24 Mar 2020 08:21:09 -0400 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]:24789) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jGiYN-0007xO-P0 for qemu-devel@nongnu.org; Tue, 24 Mar 2020 08:21:07 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-89-Ai3zRmdWM1WtxMhj3HlVuw-1; Tue, 24 Mar 2020 08:21:05 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5B3B78017CC; Tue, 24 Mar 2020 12:21:04 +0000 (UTC) Received: from localhost (ovpn-114-213.ams2.redhat.com [10.36.114.213]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6059C60BF3; Tue, 24 Mar 2020 12:21:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585052467; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sdgB1cGP4lrDOWYdtizKh5IPnMWCdKyq0DPNZtkoOt0=; b=FtagiRGUJzFvLRDtCU+6WX1tGqUfEruSDBJ8m0iGNLRaGTpbpXzSN3mm7hnaDK8sstNjO0 Pj9cycn5TlYYGPjjz8uxPpP6qgBiMNHoFw9PJS5xwqaOLKNkNkxtBXEJz9FFZIxgWpkrnJ N6pn4J7XZp8ouiicE/c2Dghrb8iuUBY= X-MC-Unique: Ai3zRmdWM1WtxMhj3HlVuw-1 From: Max Reitz To: qemu-block@nongnu.org Subject: [PULL 5/6] iotests: Fix cleanup path in some tests Date: Tue, 24 Mar 2020 13:20:43 +0100 Message-Id: <20200324122044.1131326-6-mreitz@redhat.com> In-Reply-To: <20200324122044.1131326-1-mreitz@redhat.com> References: <20200324122044.1131326-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 216.205.24.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Some iotests leave behind some external data file when run for qcow2 with -o data_file. Fix that. Signed-off-by: Max Reitz Message-Id: <20200224171631.384314-1-mreitz@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Max Reitz --- tests/qemu-iotests/085 | 1 + tests/qemu-iotests/087 | 6 ++++++ tests/qemu-iotests/279 | 2 +- 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/085 b/tests/qemu-iotests/085 index 46981dbb64..dd3c993a2d 100755 --- a/tests/qemu-iotests/085 +++ b/tests/qemu-iotests/085 @@ -39,6 +39,7 @@ SNAPSHOTS=3D10 _cleanup() { _cleanup_qemu + _cleanup_test_img for i in $(seq 1 ${SNAPSHOTS}) do _rm_test_img "${TEST_DIR}/${i}-${snapshot_virt0}" diff --git a/tests/qemu-iotests/087 b/tests/qemu-iotests/087 index d6c8613419..bdfdad3454 100755 --- a/tests/qemu-iotests/087 +++ b/tests/qemu-iotests/087 @@ -26,6 +26,12 @@ echo "QA output created by $seq" =20 status=3D1 # failure is the default! =20 +_cleanup() +{ + _cleanup_test_img +} +trap "_cleanup; exit \$status" 0 1 2 3 15 + # get standard environment, filters and checks . ./common.rc . ./common.filter diff --git a/tests/qemu-iotests/279 b/tests/qemu-iotests/279 index 30d29b1cb2..75a4747e6b 100755 --- a/tests/qemu-iotests/279 +++ b/tests/qemu-iotests/279 @@ -26,7 +26,7 @@ status=3D1 # failure is the default! _cleanup() { _cleanup_test_img - rm -f "$TEST_IMG.mid" + _rm_test_img "$TEST_IMG.mid" } trap "_cleanup; exit \$status" 0 1 2 3 15 =20 --=20 2.25.1