From nobody Mon Feb 9 16:02:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1585052621; cv=none; d=zohomail.com; s=zohoarc; b=CYz2AROoSrKSSXHz1Z2vMVcHR5YN+r06rGyPIueyGDywSEVKUCd5xebyeazb1A9ZmKp4AvkO2yKBdCLhTzSzPY8hJM8pCYCKk5y7AI11UZVug6hGg4VZI6I9/y+VF8Gs7LiWX9C3w5xx4WkmY9QH4awIr20Ax4+T+8+B8mBDCgI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585052621; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NnS7vaFSkjphTxcTGdbglpjhLyF05h3cx+k7Q4E8TXg=; b=UMbvGbVX5qOm7mUpCwaGnT0WbBFPv/70t8NimujU5U0RoSzp4Dzt6PnpKaNfvbUrlCdbfVJOOcxeY7gqZvXWlmo9y99ODxCICKA6E5P31KXbxpYUkzFFuT4i9Kd790Ni5o6GeDFfB1qo9e32pBfhoSMuoR2bv9FvOtTNvvvghSY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585052621332561.3457967522385; Tue, 24 Mar 2020 05:23:41 -0700 (PDT) Received: from localhost ([::1]:47922 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGiap-0007bB-UB for importer@patchew.org; Tue, 24 Mar 2020 08:23:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41158) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGiYE-00042f-JI for qemu-devel@nongnu.org; Tue, 24 Mar 2020 08:20:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGiYD-0007sp-I2 for qemu-devel@nongnu.org; Tue, 24 Mar 2020 08:20:58 -0400 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]:37883) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jGiYD-0007sY-E8 for qemu-devel@nongnu.org; Tue, 24 Mar 2020 08:20:57 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-69-RO_T6sxhMCOuPw_wKTjobQ-1; Tue, 24 Mar 2020 08:20:54 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A9658800D50; Tue, 24 Mar 2020 12:20:53 +0000 (UTC) Received: from localhost (ovpn-114-213.ams2.redhat.com [10.36.114.213]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1DEDF9497D; Tue, 24 Mar 2020 12:20:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585052457; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NnS7vaFSkjphTxcTGdbglpjhLyF05h3cx+k7Q4E8TXg=; b=IqKVZidsgeo7Yo6lpopiXp8807FV0sdybsaVDRMyKBda9y7E1lY+zQz0Rt7hKBVd6fgJRQ 3AVf8Z1bjikOL5kZtOpx02QWEBhPSHvlp2leBljJISQO4xfsxBHvMdAzObwZMDrkMBNPDA U2QMAPW/YabIMZPfCLBS5czRBuDNP/0= X-MC-Unique: RO_T6sxhMCOuPw_wKTjobQ-1 From: Max Reitz To: qemu-block@nongnu.org Subject: [PULL 2/6] block: Assert BlockDriver::format_name is not NULL Date: Tue, 24 Mar 2020 13:20:40 +0100 Message-Id: <20200324122044.1131326-3-mreitz@redhat.com> In-Reply-To: <20200324122044.1131326-1-mreitz@redhat.com> References: <20200324122044.1131326-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 216.205.24.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Philippe Mathieu-Daud=C3=A9 bdrv_do_find_format() calls strcmp() using BlockDriver::format_name as argument, which must not be NULL. Assert this field is not null when we register a block driver in bdrv_register(). Reported-by: Mansour Ahmadi Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20200318222235.23856-1-philmd@redhat.com> Reviewed-by: Alberto Garcia Signed-off-by: Max Reitz --- block.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block.c b/block.c index a2542c977b..6b984dc883 100644 --- a/block.c +++ b/block.c @@ -363,6 +363,7 @@ char *bdrv_get_full_backing_filename(BlockDriverState *= bs, Error **errp) =20 void bdrv_register(BlockDriver *bdrv) { + assert(bdrv->format_name); QLIST_INSERT_HEAD(&bdrv_drivers, bdrv, list); } =20 --=20 2.25.1