From nobody Mon Feb 9 08:57:15 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1585052546; cv=none; d=zohomail.com; s=zohoarc; b=UXnY6981LjGcF6daympxvUE0CIYlSTagKHvhRthn4FAmBYU9zJE9NIYUC+myuTiCsd8nXMJpIUnQM8OI4X2FSVakPNR81O+x0nN2+woOC6LiYF4rGsVQTgah5+RG99d+Y+bqDflgnemJ/gwk1i5UzzVSq+XKrIMqOU4hEFxP21E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585052546; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=1PALZhzTZ/yxc7gxpribSfGldl+SWaMPLuS4AF6PbTk=; b=jaerBh6FjBE3R8U007gz75ZqSqeGdiFI0RPiDFIe1WakiAZBeplr89FpymAOxC9yBQujOge3fGYlaZuALVSkoiETaxTNdufHC4DAnCx/3EfWRh9fiXzPaCs7tNar7IJlkFnGC7JhbI0Rb3HEKijPAmQweI28houYOC1dPDPDRNM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585052546020600.6446142832392; Tue, 24 Mar 2020 05:22:26 -0700 (PDT) Received: from localhost ([::1]:47894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGiZc-0005Pl-Ff for importer@patchew.org; Tue, 24 Mar 2020 08:22:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41128) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGiYD-00041O-CV for qemu-devel@nongnu.org; Tue, 24 Mar 2020 08:20:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGiYC-0007sA-DX for qemu-devel@nongnu.org; Tue, 24 Mar 2020 08:20:57 -0400 Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:20244) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jGiYC-0007rp-A9 for qemu-devel@nongnu.org; Tue, 24 Mar 2020 08:20:56 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-260-P_V8a761MNqStQBwKa3pdw-1; Tue, 24 Mar 2020 08:20:51 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 98CBE801E67; Tue, 24 Mar 2020 12:20:50 +0000 (UTC) Received: from localhost (ovpn-114-213.ams2.redhat.com [10.36.114.213]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 338395D9E5; Tue, 24 Mar 2020 12:20:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585052455; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1PALZhzTZ/yxc7gxpribSfGldl+SWaMPLuS4AF6PbTk=; b=FwvSB2F8kfZ9dbTdtzBk3UZWykVivy4JdJWxLq8YvKq7gArdUjKRVU88czynXF6yMGZXaI FfaV1Qp23sVRtQHqhPAgLYK5M5Uvuo9l5M7rBhFBbryy81gWQx6eHRYlbZs92crnlKHvef CTQddVQ3Y73MBy6DZYcUJ3WcWdW1EII= X-MC-Unique: P_V8a761MNqStQBwKa3pdw-1 From: Max Reitz To: qemu-block@nongnu.org Subject: [PULL 1/6] block: Avoid memleak on qcow2 image info failure Date: Tue, 24 Mar 2020 13:20:39 +0100 Message-Id: <20200324122044.1131326-2-mreitz@redhat.com> In-Reply-To: <20200324122044.1131326-1-mreitz@redhat.com> References: <20200324122044.1131326-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 63.128.21.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Eric Blake If we fail to get bitmap info, we must not leak the encryption info. Fixes: b8968c875f403 Fixes: Coverity CID 1421894 Signed-off-by: Eric Blake Message-Id: <20200320183620.1112123-1-eblake@redhat.com> Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Andrey Shinkevich Tested-by: Andrey Shinkevich Signed-off-by: Max Reitz --- block/qcow2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qcow2.c b/block/qcow2.c index d44b45633d..e08917ed84 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -4811,6 +4811,7 @@ static ImageInfoSpecific *qcow2_get_specific_info(Blo= ckDriverState *bs, if (local_err) { error_propagate(errp, local_err); qapi_free_ImageInfoSpecific(spec_info); + qapi_free_QCryptoBlockInfo(encrypt_info); return NULL; } *spec_info->u.qcow2.data =3D (ImageInfoSpecificQCow2){ --=20 2.25.1