From nobody Thu Dec 18 22:24:06 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1584985314; cv=none; d=zohomail.com; s=zohoarc; b=TWVRdL/Ml6pwmehIQ7ATY2c2VIbaTZNauOUtEpoOyVW4XALYmyEiVEOvjhUH9w4QVXhmZwtqoyOHIHFYB8HRdCYuVSSGaY5/awKgC041MgAgn2WGCrv4jyyB4RXM9yP1e7MeDvsZWy/bRAIxZurCQXbw/g3jRci9Ivcg9EtQn4M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584985314; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Bajoz+UVKNChgk5fuej6bzALgtOzMFKSB1SLz/XHXRk=; b=W3qx0pJah6fo9bRKBR9iLg/KkXMg3HiF+cMbow71jMa+e1FvX57m3bhRbWLUfsEXiMLUacBIpM630DNkpnSsqQFvLoNyWwW9wlQoLhVVdDaAoO03MhS8Hw3ehDb55WWPH8zVP93BZZRUu/5UxL83rH9cP1Ktk8i/G24SBv1pcqA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584985314359825.202846640517; Mon, 23 Mar 2020 10:41:54 -0700 (PDT) Received: from localhost ([::1]:37622 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGR5E-00061N-MD for importer@patchew.org; Mon, 23 Mar 2020 13:41:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52220) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGR3h-0004OG-Hw for qemu-devel@nongnu.org; Mon, 23 Mar 2020 13:40:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGR3g-0003hZ-If for qemu-devel@nongnu.org; Mon, 23 Mar 2020 13:40:17 -0400 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:39659) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jGR3g-0003g3-5v for qemu-devel@nongnu.org; Mon, 23 Mar 2020 13:40:16 -0400 Received: by mail-wr1-x441.google.com with SMTP id p10so5764031wrt.6 for ; Mon, 23 Mar 2020 10:40:15 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id o9sm25145282wrw.20.2020.03.23.10.40.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2020 10:40:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=Bajoz+UVKNChgk5fuej6bzALgtOzMFKSB1SLz/XHXRk=; b=VeQEvntktYkrFhTTinhzDdlSffzgyQJcqnsTTuyZyemL9UGRjlxdJincdEA5cSuYec Txvs51POF+yI0Pbi+MC9ov1W4VSpu9zFj7PRCZEeToZjZXldz7vqJldGgBuIDOuwlftx jGXIzxrOHwd3ohksrxFm7rnva+BcluBQIwbMqWM+vhLS24ZaTQ9MZQwLZm4OeDWhbSBt azwDrZm8ibQZeYFZdK86y26+EOuYZ8GBj9slLafFXj4D5nTcPy7cUi1CocPP+RRXNumM U+PxFpZ2HPaS68kTywFsagD+HgBUT67TBi3lVWgX9V4RjZkcVyS2nAOQ09pk+uZ+2sAH dVOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Bajoz+UVKNChgk5fuej6bzALgtOzMFKSB1SLz/XHXRk=; b=R2nNumqp+86y2RoIMM0kRONevzPDqV2nLeQ9G+NZXnJi9MjVVDt0+bmuag34sEoyF/ YwuOmphVWehPgnNEabTL5mtEUopQ1Vqy1+9MJKHDwLVl9C+AA9jJ8T/WQhGH/3oZwM2B mYSCpGUrF5uiwHDnjKfklKmpAvOQ0q2sLIA11Qzo48ZzEnHYJFYfqHoY2pZn/4hRmTI7 XkLsZO//L2Q+mVnL/uvmSy2O1AJoTuZ2FA4ZMHu8SLjGWzdRPlq1Qn5hxTAcEo2EcGV6 ecQrraiyQaerZ8EadZm6D1wJiMiKubRebWpXDRgc0kO9pW1z1wF0gvJaO287agnxsOQb 5qsw== X-Gm-Message-State: ANhLgQ13Qc89MG/ZW8BRb0znZmjzpgYZ80NTdfINg4uAZZzP+WwgVJac rvWw3Av+ASHkj90yQHnUnWiVrVYgsj/86A== X-Google-Smtp-Source: ADFU+vsabAUZ/Hx2f2uURgCoAc8fPBPFO5E1BBweePnyxqncscz7rDhNZa61qi5MPILHBaAC3sfuZw== X-Received: by 2002:adf:efc9:: with SMTP id i9mr10965935wrp.23.1584985214122; Mon, 23 Mar 2020 10:40:14 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 4/5] target/arm: Assert immh != 0 in disas_simd_shift_imm Date: Mon, 23 Mar 2020 17:40:05 +0000 Message-Id: <20200323174006.8468-5-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200323174006.8468-1-peter.maydell@linaro.org> References: <20200323174006.8468-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) From: Richard Henderson Coverity raised a shed-load of errors cascading from inferring that clz32(immh) might yield 32, from immh might be 0. While immh cannot be 0 from encoding, it is not obvious even to a human how we've checked that: via the filtering provided by data_proc_simd[]. Reported-by: Coverity (CID 1421923, and more) Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-id: 20200320160622.8040-3-richard.henderson@linaro.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- target/arm/translate-a64.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 8fffb52203d..032478614c4 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -10405,6 +10405,9 @@ static void disas_simd_shift_imm(DisasContext *s, u= int32_t insn) bool is_u =3D extract32(insn, 29, 1); bool is_q =3D extract32(insn, 30, 1); =20 + /* data_proc_simd[] has sent immh =3D=3D 0 to disas_simd_mod_imm. */ + assert(immh !=3D 0); + switch (opcode) { case 0x08: /* SRI */ if (!is_u) { --=20 2.20.1