From nobody Thu May 2 20:48:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1584933357; cv=none; d=zohomail.com; s=zohoarc; b=iTC+eDXEAbO1GKxWn6FIwVm5UUnWQcEgcbtynHWgdZmOLPEl6U0KRX2HShK+Bt1homAhKKj8JmTeyAUQS6WOs7xb2SwJvFBCpdRDRfWESNGukqeL4jwdWbAiadR8idosqIojwxstBZnIw4I1r2HB+wiqMv2TkL45oV3vIajRUyQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584933357; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ZRLWWKGgW5NB/UTLg//sF4BQJY4Fzokk6Eo1iBJEfXs=; b=n3KluPnd7/XzmnNnoEzkcwxip7F4In/DfzQDO7EtK52Rl/LZ/ob961wIjIR+94gJbGC8DkSbO7SEvyiWc0A9ZXvFKjdItGxJvOyorRRm/wTfvVjLDslPoicJBY3qZQrTGwaDOvJLR04ZQt+wZHn3c6D0rytBqjOkJ5ot5mSn7Yo= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584933357295828.0790142339629; Sun, 22 Mar 2020 20:15:57 -0700 (PDT) Received: from localhost ([::1]:56714 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGDZE-0007GU-3o for importer@patchew.org; Sun, 22 Mar 2020 23:15:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51043) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGDY4-0005ig-NZ for qemu-devel@nongnu.org; Sun, 22 Mar 2020 23:14:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGDY2-0003fh-UV for qemu-devel@nongnu.org; Sun, 22 Mar 2020 23:14:44 -0400 Received: from mga07.intel.com ([134.134.136.100]:56656) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jGDY2-0003fE-NI for qemu-devel@nongnu.org; Sun, 22 Mar 2020 23:14:42 -0400 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2020 20:14:40 -0700 Received: from lxy-clx-4s.sh.intel.com ([10.239.43.161]) by FMSMGA003.fm.intel.com with ESMTP; 22 Mar 2020 20:14:38 -0700 IronPort-SDR: Ncbn1yt/iQBxyi9L+fxe3BA9BoAjhfupK0uUdLWGwbZ4XEK1c67+OCAvXRygfLyEDVj3u/+j+P Co/ZF/1BCSEA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False IronPort-SDR: pRX5EL3s7jKlUC0DyiWxWVCif4V9kHdzoAikBRqVPuPVWdDrntlbDIQIGRJvr185g3LRvS86fT K8iiw9uLqCUQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,294,1580803200"; d="scan'208";a="292453683" From: Xiaoyao Li To: Paolo Bonzini , Marcelo Tosatti , Richard Henderson , Eduardo Habkost Subject: [PATCH 1/3] target/i386: Rename CORE_CAPABILITY to CORE_CAPABILITIES Date: Mon, 23 Mar 2020 10:56:56 +0800 Message-Id: <20200323025658.4540-2-xiaoyao.li@intel.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200323025658.4540-1-xiaoyao.li@intel.com> References: <20200323025658.4540-1-xiaoyao.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 134.134.136.100 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Xiaoyao Li , qemu-devel@nongnu.org, kvm@vger.kernel.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Intel SDM updates the name of MSR CORE_CAPABILITY to CORE_CAPABILITIES, so updating it QEMU. Signed-off-by: Xiaoyao Li --- target/i386/cpu.c | 12 ++++++------ target/i386/cpu.h | 6 +++--- target/i386/kvm.c | 6 +++--- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 34b511f078e5..1de7f3cd533e 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -1216,7 +1216,7 @@ static FeatureWordInfo feature_word_info[FEATURE_WORD= S] =3D { .index =3D MSR_IA32_ARCH_CAPABILITIES, }, }, - [FEAT_CORE_CAPABILITY] =3D { + [FEAT_CORE_CAPABILITIES] =3D { .type =3D MSR_FEATURE_WORD, .feat_names =3D { NULL, NULL, NULL, NULL, @@ -1229,7 +1229,7 @@ static FeatureWordInfo feature_word_info[FEATURE_WORD= S] =3D { NULL, NULL, NULL, NULL, }, .msr =3D { - .index =3D MSR_IA32_CORE_CAPABILITY, + .index =3D MSR_IA32_CORE_CAPABILITIES, }, }, =20 @@ -1406,8 +1406,8 @@ static FeatureDep feature_dependencies[] =3D { .to =3D { FEAT_ARCH_CAPABILITIES, ~0ull }, }, { - .from =3D { FEAT_7_0_EDX, CPUID_7_0_EDX_CORE_CAPABILIT= Y }, - .to =3D { FEAT_CORE_CAPABILITY, ~0ull }, + .from =3D { FEAT_7_0_EDX, CPUID_7_0_EDX_CORE_CAPABILIT= IES }, + .to =3D { FEAT_CORE_CAPABILITIES, ~0ull }, }, { .from =3D { FEAT_1_ECX, CPUID_EXT_VMX }, @@ -3709,8 +3709,8 @@ static X86CPUDefinition builtin_x86_defs[] =3D { .features[FEAT_7_0_EDX] =3D CPUID_7_0_EDX_SPEC_CTRL | CPUID_7_0_EDX_ARCH_CAPABILITIES | CPUID_7_0_EDX_SPEC_CTRL_SSBD= | - CPUID_7_0_EDX_CORE_CAPABILITY, - .features[FEAT_CORE_CAPABILITY] =3D + CPUID_7_0_EDX_CORE_CAPABILITIES, + .features[FEAT_CORE_CAPABILITIES] =3D MSR_CORE_CAP_SPLIT_LOCK_DETECT, /* * Missing: XSAVES (not supported by some Linux versions, diff --git a/target/i386/cpu.h b/target/i386/cpu.h index 60d797d5941f..f6c54412ba5e 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -349,7 +349,7 @@ typedef enum X86Seg { #define MSR_VIRT_SSBD 0xc001011f #define MSR_IA32_PRED_CMD 0x49 #define MSR_IA32_UCODE_REV 0x8b -#define MSR_IA32_CORE_CAPABILITY 0xcf +#define MSR_IA32_CORE_CAPABILITIES 0xcf =20 #define MSR_IA32_ARCH_CAPABILITIES 0x10a #define ARCH_CAP_TSX_CTRL_MSR (1<<7) @@ -526,7 +526,7 @@ typedef enum FeatureWord { FEAT_XSAVE_COMP_LO, /* CPUID[EAX=3D0xd,ECX=3D0].EAX */ FEAT_XSAVE_COMP_HI, /* CPUID[EAX=3D0xd,ECX=3D0].EDX */ FEAT_ARCH_CAPABILITIES, - FEAT_CORE_CAPABILITY, + FEAT_CORE_CAPABILITIES, FEAT_VMX_PROCBASED_CTLS, FEAT_VMX_SECONDARY_CTLS, FEAT_VMX_PINBASED_CTLS, @@ -777,7 +777,7 @@ typedef uint64_t FeatureWordArray[FEATURE_WORDS]; /* Arch Capabilities */ #define CPUID_7_0_EDX_ARCH_CAPABILITIES (1U << 29) /* Core Capability */ -#define CPUID_7_0_EDX_CORE_CAPABILITY (1U << 30) +#define CPUID_7_0_EDX_CORE_CAPABILITIES (1U << 30) /* Speculative Store Bypass Disable */ #define CPUID_7_0_EDX_SPEC_CTRL_SSBD (1U << 31) =20 diff --git a/target/i386/kvm.c b/target/i386/kvm.c index 69eb43d796e6..6888cb7caeae 100644 --- a/target/i386/kvm.c +++ b/target/i386/kvm.c @@ -2051,7 +2051,7 @@ static int kvm_get_supported_msrs(KVMState *s) case MSR_IA32_ARCH_CAPABILITIES: has_msr_arch_capabs =3D true; break; - case MSR_IA32_CORE_CAPABILITY: + case MSR_IA32_CORE_CAPABILITIES: has_msr_core_capabs =3D true; break; case MSR_IA32_VMX_VMFUNC: @@ -2696,8 +2696,8 @@ static void kvm_init_msrs(X86CPU *cpu) } =20 if (has_msr_core_capabs) { - kvm_msr_entry_add(cpu, MSR_IA32_CORE_CAPABILITY, - env->features[FEAT_CORE_CAPABILITY]); + kvm_msr_entry_add(cpu, MSR_IA32_CORE_CAPABILITIES, + env->features[FEAT_CORE_CAPABILITIES]); } =20 if (has_msr_ucode_rev) { --=20 2.20.1 From nobody Thu May 2 20:48:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1584933417; cv=none; d=zohomail.com; s=zohoarc; b=jd8BudSYivWC7c1ptueGnBlCTsRxZuttuRyK4VnZwMgVa0dE3tHuKBc0QbwOcwPpsJX2lEeZeR0sbbQUDEaJaty466oj9iAOsgHctpuBczwqw7H3h9g12II/G/89U/0hrA6oPjynf1ISgslA22zORraSzEka0N5ApiaAvvZxKdY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584933417; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=pJ3GoyjcqKxWasKniGVSL64CcbWlMzx+/XcH3ZpZzmE=; b=KDvjESXDbjCNaHmkeIYby4QzQRmrpZhpgyMAUFTPp5gNTdYFm9m8JXnUbaMuGweX0zW5QK8Nl+WvKd4RIAeB6yTxmVT5p8nkdx/SZxDRNBnSg4NTwJec25KYaOnFeYPBbvpZnU3qUu1dfDM473rtXwCSclnH5JvvGMK1e//IVVs= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158493341797492.17814121012054; Sun, 22 Mar 2020 20:16:57 -0700 (PDT) Received: from localhost ([::1]:56736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGDaC-0000aq-QR for importer@patchew.org; Sun, 22 Mar 2020 23:16:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51059) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGDY5-0005ih-IK for qemu-devel@nongnu.org; Sun, 22 Mar 2020 23:14:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGDY4-0003gC-90 for qemu-devel@nongnu.org; Sun, 22 Mar 2020 23:14:45 -0400 Received: from mga07.intel.com ([134.134.136.100]:56660) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jGDY3-0003fq-UT for qemu-devel@nongnu.org; Sun, 22 Mar 2020 23:14:44 -0400 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2020 20:14:42 -0700 Received: from lxy-clx-4s.sh.intel.com ([10.239.43.161]) by FMSMGA003.fm.intel.com with ESMTP; 22 Mar 2020 20:14:40 -0700 IronPort-SDR: 8xGx7k2Ccaj7baqWqXbHRmzmnf3/2x1kgF6QWfU4WHxLaJiStsYBLXHaTbzWr3r14tXJOmgcL6 yMFF8T9L0fKg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False IronPort-SDR: Gg+QmSZ8XLK3JGiAcInv8v2C/jGZtEXMFOu8gL1rc12E5hYuMeikfstiUIPjnpYrAk6dz6rqwo ULjSfFlndTVg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,294,1580803200"; d="scan'208";a="292453684" From: Xiaoyao Li To: Paolo Bonzini , Marcelo Tosatti , Richard Henderson , Eduardo Habkost Subject: [PATCH 2/3] target/i386: Add support for TEST_CTRL MSR Date: Mon, 23 Mar 2020 10:56:57 +0800 Message-Id: <20200323025658.4540-3-xiaoyao.li@intel.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200323025658.4540-1-xiaoyao.li@intel.com> References: <20200323025658.4540-1-xiaoyao.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 134.134.136.100 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Xiaoyao Li , qemu-devel@nongnu.org, kvm@vger.kernel.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Xiaoyao Li MSR_TEST_CTRL is needed and accessed by feature split lock detection. Signed-off-by: Xiaoyao Li --- target/i386/cpu.h | 2 ++ target/i386/kvm.c | 13 +++++++++++++ target/i386/machine.c | 20 ++++++++++++++++++++ 3 files changed, 35 insertions(+) diff --git a/target/i386/cpu.h b/target/i386/cpu.h index f6c54412ba5e..177732ad19da 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -343,6 +343,7 @@ typedef enum X86Seg { #define MSR_IA32_APICBASE_ENABLE (1<<11) #define MSR_IA32_APICBASE_EXTD (1 << 10) #define MSR_IA32_APICBASE_BASE (0xfffffU<<12) +#define MSR_TEST_CTRL 0x33 #define MSR_IA32_FEATURE_CONTROL 0x0000003a #define MSR_TSC_ADJUST 0x0000003b #define MSR_IA32_SPEC_CTRL 0x48 @@ -1466,6 +1467,7 @@ typedef struct CPUX86State { =20 uint64_t spec_ctrl; uint64_t virt_ssbd; + uint64_t msr_test_ctrl; =20 /* End of state preserved by INIT (dummy marker). */ struct {} end_init_save; diff --git a/target/i386/kvm.c b/target/i386/kvm.c index 6888cb7caeae..411402aa29fa 100644 --- a/target/i386/kvm.c +++ b/target/i386/kvm.c @@ -101,6 +101,7 @@ static bool has_msr_umwait; static bool has_msr_spec_ctrl; static bool has_msr_tsx_ctrl; static bool has_msr_virt_ssbd; +static bool has_msr_test_ctrl; static bool has_msr_smi_count; static bool has_msr_arch_capabs; static bool has_msr_core_capabs; @@ -2048,6 +2049,9 @@ static int kvm_get_supported_msrs(KVMState *s) case MSR_VIRT_SSBD: has_msr_virt_ssbd =3D true; break; + case MSR_TEST_CTRL: + has_msr_test_ctrl =3D true; + break; case MSR_IA32_ARCH_CAPABILITIES: has_msr_arch_capabs =3D true; break; @@ -2766,6 +2770,9 @@ static int kvm_put_msrs(X86CPU *cpu, int level) if (has_msr_virt_ssbd) { kvm_msr_entry_add(cpu, MSR_VIRT_SSBD, env->virt_ssbd); } + if (has_msr_test_ctrl) { + kvm_msr_entry_add(cpu, MSR_TEST_CTRL, env->msr_test_ctrl); + } =20 #ifdef TARGET_X86_64 if (lm_capable_kernel) { @@ -3154,6 +3161,9 @@ static int kvm_get_msrs(X86CPU *cpu) if (has_msr_virt_ssbd) { kvm_msr_entry_add(cpu, MSR_VIRT_SSBD, 0); } + if (has_msr_test_ctrl) { + kvm_msr_entry_add(cpu, MSR_TEST_CTRL, 0); + } if (!env->tsc_valid) { kvm_msr_entry_add(cpu, MSR_IA32_TSC, 0); env->tsc_valid =3D !runstate_is_running(); @@ -3549,6 +3559,9 @@ static int kvm_get_msrs(X86CPU *cpu) case MSR_VIRT_SSBD: env->virt_ssbd =3D msrs[i].data; break; + case MSR_TEST_CTRL: + env->msr_test_ctrl =3D msrs[i].data; + break; case MSR_IA32_RTIT_CTL: env->msr_rtit_ctrl =3D msrs[i].data; break; diff --git a/target/i386/machine.c b/target/i386/machine.c index 0c96531a56f0..a23c6687d5ba 100644 --- a/target/i386/machine.c +++ b/target/i386/machine.c @@ -1252,6 +1252,25 @@ static const VMStateDescription vmstate_msr_virt_ssb= d =3D { } }; =20 +static bool msr_test_ctrl_needed(void *opaque) +{ + X86CPU *cpu =3D opaque; + CPUX86State *env =3D &cpu->env; + + return env->msr_test_ctrl !=3D 0; +} + +static const VMStateDescription vmstate_msr_test_ctrl =3D { + .name =3D "cpu/msr_test_ctrl", + .version_id =3D 1, + .minimum_version_id =3D 1, + .needed =3D msr_test_ctrl_needed, + .fields =3D (VMStateField[]){ + VMSTATE_UINT64(env.msr_test_ctrl, X86CPU), + VMSTATE_END_OF_LIST() + } +}; + static bool svm_npt_needed(void *opaque) { X86CPU *cpu =3D opaque; @@ -1439,6 +1458,7 @@ VMStateDescription vmstate_x86_cpu =3D { &vmstate_mcg_ext_ctl, &vmstate_msr_intel_pt, &vmstate_msr_virt_ssbd, + &vmstate_msr_test_ctrl, &vmstate_svm_npt, #ifndef TARGET_X86_64 &vmstate_efer32, --=20 2.20.1 From nobody Thu May 2 20:48:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1584933358; cv=none; d=zohomail.com; s=zohoarc; b=IF2fQL9k29uRtsNQVyuB3w18Jr28ILCdVlCfzLWPr22eTyArfsqrpG4zk0UgiQHjSuBzqgJQIXm25bI7p9dfsIIV2dm1+LJVwUa3l1cwTmQAcYqg20vgA0Bu3F/CamWzgRrYTTAimbGMGikVOA8Y7VasIk8MdDF0oQlgN2V403Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584933358; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=rHDBPGM0BR7hCuRtFt/xoNMbu4ISo5WuTwwF7ynz5O0=; b=g7sDiv7TUTxRJ5H6eaN/J0Htm0/EO2Sfa209yi6CT3+Lk5eXIS838fDg4pY0S9PrfHBZYH2DhRirUtmWu48EgsvZ4G6viMOPw+egKlQL8D/I27MiuWeFgnkszv7hA25yM7wPaiP3sb33lgtxkmLl81q9uo8t+aORVEJDAzDPFIk= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584933358505704.7318744317232; Sun, 22 Mar 2020 20:15:58 -0700 (PDT) Received: from localhost ([::1]:56716 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGDZE-0007IE-TF for importer@patchew.org; Sun, 22 Mar 2020 23:15:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51072) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGDY6-0005is-KP for qemu-devel@nongnu.org; Sun, 22 Mar 2020 23:14:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGDY5-0003gl-Mj for qemu-devel@nongnu.org; Sun, 22 Mar 2020 23:14:46 -0400 Received: from mga07.intel.com ([134.134.136.100]:56665) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jGDY5-0003gP-EI for qemu-devel@nongnu.org; Sun, 22 Mar 2020 23:14:45 -0400 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2020 20:14:44 -0700 Received: from lxy-clx-4s.sh.intel.com ([10.239.43.161]) by FMSMGA003.fm.intel.com with ESMTP; 22 Mar 2020 20:14:42 -0700 IronPort-SDR: natrt4NfZs8pxDFTMfJO9EcDUKWQRNGlNYOyEUh26X79FbMzvJubwR4SLT5V+vO5s74Pro4ugo UFay3WEqGD6g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False IronPort-SDR: uYur9/pt0qTm1pCiSl2Gb8z6WaZ27QWwAxqe0ET2NSe31lYk6CKbczLb2jDBKy4p6igdDvkzTZ 9acOqk7HrLcA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,294,1580803200"; d="scan'208";a="292453701" From: Xiaoyao Li To: Paolo Bonzini , Marcelo Tosatti , Richard Henderson , Eduardo Habkost Subject: [PATCH 3/3] target/i386: Tell why guest exits to user space due to #AC Date: Mon, 23 Mar 2020 10:56:58 +0800 Message-Id: <20200323025658.4540-4-xiaoyao.li@intel.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200323025658.4540-1-xiaoyao.li@intel.com> References: <20200323025658.4540-1-xiaoyao.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 134.134.136.100 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Xiaoyao Li , qemu-devel@nongnu.org, kvm@vger.kernel.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Tell why guest exits from kvm to user space due to #AC, so user knows what happened. Signed-off-by: Xiaoyao Li --- target/i386/kvm.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/target/i386/kvm.c b/target/i386/kvm.c index 411402aa29fa..36bc1485d478 100644 --- a/target/i386/kvm.c +++ b/target/i386/kvm.c @@ -4464,8 +4464,15 @@ int kvm_arch_handle_exit(CPUState *cs, struct kvm_ru= n *run) ret =3D -1; break; case KVM_EXIT_EXCEPTION: - fprintf(stderr, "KVM: exception %d exit (error code 0x%x)\n", - run->ex.exception, run->ex.error_code); + if (run->ex.exception =3D=3D AC_VECTOR) { + fprintf(stderr, "Guest encounters an #AC due to split lock. Be= cause " + "guest doesn't expect this split lock #AC (it doesn't = set " + "msr_test_ctrl.split_lock_detect) and host sets " + "split_lock_detect=3Dfatal, guest has to be killed.\n"= ); + } else { + fprintf(stderr, "KVM: exception %d exit (error code 0x%x)\n", + run->ex.exception, run->ex.error_code); + } ret =3D -1; break; case KVM_EXIT_DEBUG: --=20 2.20.1