From nobody Mon Feb 9 11:29:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1584802067; cv=none; d=zohomail.com; s=zohoarc; b=AklmXibTxrZcR3aL14scxShvqCTxVD+nEzxwh5C56H1OnW8/PODj67FFKQgRoXVfNnmePm70AI7vqV8XK5dVDyTEi++pZs12dNSHDxLNuSIk6ZLGGuKcl63nSvYXRX7q6BH4CU8jZ+OXrg/QcK2SrLh299XsYZ+ub4wfcP/Qaew= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584802067; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=aNR2u2S6oJHTNfAafS+3cPQs0kK7tiu5/JdDcxGLqd4=; b=Y6Aj0dWEzMsehEJv93M1jwihmTJcmTIBKlcknOP/ou6y1bYHslDcQU6YbQW6m1Qn+5iZdAU7ivkki+FyWfc8wkXytDHvVxfYDTTZ29pfKxGTIuzTpnt86MB4yiRaX8l+jgOe8jgE2PaxjLNcIbHc0QP13Yp9PSZz7B26e7Z0+cs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584802067077924.263446118191; Sat, 21 Mar 2020 07:47:47 -0700 (PDT) Received: from localhost ([::1]:37704 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFfPd-0005X3-Ra for importer@patchew.org; Sat, 21 Mar 2020 10:47:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59957) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFfK0-0005Yu-LQ for qemu-devel@nongnu.org; Sat, 21 Mar 2020 10:41:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFfJz-0007Zl-Kc for qemu-devel@nongnu.org; Sat, 21 Mar 2020 10:41:56 -0400 Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:25476) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jFfJz-0007ZL-GC for qemu-devel@nongnu.org; Sat, 21 Mar 2020 10:41:55 -0400 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-416-1mltPEi_MDKPWsG2tQ7e-w-1; Sat, 21 Mar 2020 10:41:53 -0400 Received: by mail-wr1-f70.google.com with SMTP id b11so4354747wru.21 for ; Sat, 21 Mar 2020 07:41:53 -0700 (PDT) Received: from localhost.localdomain (37.red-83-52-54.dynamicip.rima-tde.net. [83.52.54.37]) by smtp.gmail.com with ESMTPSA id l83sm12694424wmf.43.2020.03.21.07.41.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2020 07:41:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584801715; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aNR2u2S6oJHTNfAafS+3cPQs0kK7tiu5/JdDcxGLqd4=; b=J23Jpr+i+XZcnmyU70T26P+itVo75sFH0xtJPsj4P8ByWDSLHDix84VL5/eUCHN0XpT/1D Vnl/Q3mumgh+tYO6R/8c//nxTrfsJAUpNP+C60SFRW6P4drUhzs9oyNiQCNnZdyVUgTqZ2 2ZX88+sguFVbZp6qleecm9jqSdtXQ/c= X-MC-Unique: 1mltPEi_MDKPWsG2tQ7e-w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=10vzrd1KB4hBe4ZZMwH09166mQI1VXUjkd4JvuSfJzs=; b=TGFgkEK+TcwdN96KXqKFwH/aOvkcscxu+SFIXNHfdRudWMkIQPtYgZAvAAd9pCm+Zx Ab/i5ne9PR2mTlD1fgbl1x4MnqmonALAV7dHM+DW9+jBRAJ723ipaaQ2ywAcgvLbjeqX oEO8nmPBDGWUtkK5NdlbWkwFrAsZI+JbEZqkYYCVmzrxhPqlZ4a22R4aJEI9Wh5XBdws GDZo3VpYJYyXK169zEKuvoEMW3UuZcqxDgwDMN+1T7Ee9EN9O7i7ab/VV2/Mk17Mr2Xf X1dx7Og0jNvWLCd9+aUe6yPr4mXSYd7jEep2V5zRLV6meaqrfmDv/tTrhNw4A7JVhS5H Lyxw== X-Gm-Message-State: ANhLgQ0uVe85fhdrTWCRkbQUnt4pN3tXU57su8TEXBzUDy6Z/huj90wg Ygql+f7+4auXorKcJkQxg2MokcfubZQC5fg9CEWMRjKGdSBEd2Y23BYM+y96cBz79FvMvLqurCh 8PP3TCt4hKFUtxXU= X-Received: by 2002:adf:a490:: with SMTP id g16mr17744341wrb.42.1584801712171; Sat, 21 Mar 2020 07:41:52 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvcdshd1gb0Sq4YqL62+G+0WKhBXbND0XSvaVf2BglTV01faEbdjx+USFWF7c7rg/A6yGHbRQ== X-Received: by 2002:adf:a490:: with SMTP id g16mr17744313wrb.42.1584801711853; Sat, 21 Mar 2020 07:41:51 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH-for-5.0 v2 06/11] hw/isa/i82378: Remove dead assignment Date: Sat, 21 Mar 2020 15:41:05 +0100 Message-Id: <20200321144110.5010-7-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200321144110.5010-1-philmd@redhat.com> References: <20200321144110.5010-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 63.128.21.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , "Michael S. Tsirkin" , Mark Cave-Ayland , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Markus Armbruster , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Joel Stanley , Michael Tokarev , Alistair Francis , qemu-arm@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , John Snow , David Gibson , Kevin Wolf , Andrew Jeffery , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier , Max Reitz , Igor Mitsyanko , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Rename the unique variable assigned as 'pit' which better represents what it holds, to fix a warning reported by the Clang static code analyzer: CC hw/isa/i82378.o hw/isa/i82378.c:108:5: warning: Value stored to 'isa' is never read isa =3D isa_create_simple(isabus, "i82374"); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- hw/isa/i82378.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/isa/i82378.c b/hw/isa/i82378.c index dcb6b479ea..d9e6c7fa00 100644 --- a/hw/isa/i82378.c +++ b/hw/isa/i82378.c @@ -67,7 +67,7 @@ static void i82378_realize(PCIDevice *pci, Error **errp) I82378State *s =3D I82378(dev); uint8_t *pci_conf; ISABus *isabus; - ISADevice *isa; + ISADevice *pit; =20 pci_conf =3D pci->config; pci_set_word(pci_conf + PCI_COMMAND, @@ -99,13 +99,13 @@ static void i82378_realize(PCIDevice *pci, Error **errp) isa_bus_irqs(isabus, s->i8259); =20 /* 1 82C54 (pit) */ - isa =3D i8254_pit_init(isabus, 0x40, 0, NULL); + pit =3D i8254_pit_init(isabus, 0x40, 0, NULL); =20 /* speaker */ - pcspk_init(isabus, isa); + pcspk_init(isabus, pit); =20 /* 2 82C37 (dma) */ - isa =3D isa_create_simple(isabus, "i82374"); + isa_create_simple(isabus, "i82374"); } =20 static void i82378_init(Object *obj) --=20 2.21.1